Speed up mobile app warm start by another ~75% - #12555

Merged
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement
Jul 17, 2025
Merged

Speed up mobile app warm start by another ~75%#12555
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement

Conversation

@DejayJD

@DejayJDDejayJD commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

  • This hook was the only thing triggering rerenders on App.tsx on warm start (lock/unlock screen).
  • I realized that this foreground hook doesnt even change anything in the render so there's no reason for it to be causing any renders at all.
  • Moving the hook out to its own component which means App.tsx doesnt ever rerender now.

Now the app warm start looks sooooo nice
image

(most expensive commit being 10ms is well within the 16.6ms range to stay at 60fps ❤️ )

  • Also added a markdown file to keep a log of performance improvements as we go

How Has This Been Tested?

ios:prod

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de45a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJDDejayJD changed the title Speed up app warm start by another ~75%Speed up mobile app warm start by another ~75%Jul 17, 2025

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow killer

</ErrorBoundary>
</PortalProvider>
</GestureHandlerRootView>
<PortalProvider>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming we want to drop the GestureHandlerRootView?

@DejayJD
DejayJD enabled auto-merge (squash) July 17, 2025 22:49
@DejayJD
DejayJD disabled auto-merge July 17, 2025 22:56
@DejayJD
DejayJD merged commit 1a752dd into mainJul 17, 2025
4 of 6 checks passed
@DejayJD
DejayJD deleted the jd/app-warm-start-improvement branch July 17, 2025 22:56
audius-infra pushed a commit that referenced this pull request Jul 19, 2025
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Speed up mobile app warm start by another ~75% - #12555

Merged
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement
Jul 17, 2025
Merged

Speed up mobile app warm start by another ~75%#12555
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement

Conversation

@DejayJD

@DejayJDDejayJD commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

  • This hook was the only thing triggering rerenders on App.tsx on warm start (lock/unlock screen).
  • I realized that this foreground hook doesnt even change anything in the render so there's no reason for it to be causing any renders at all.
  • Moving the hook out to its own component which means App.tsx doesnt ever rerender now.

Now the app warm start looks sooooo nice
image

(most expensive commit being 10ms is well within the 16.6ms range to stay at 60fps ❤️ )

  • Also added a markdown file to keep a log of performance improvements as we go

How Has This Been Tested?

ios:prod

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de45a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJDDejayJD changed the title Speed up app warm start by another ~75%Speed up mobile app warm start by another ~75%Jul 17, 2025

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow killer

</ErrorBoundary>
</PortalProvider>
</GestureHandlerRootView>
<PortalProvider>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming we want to drop the GestureHandlerRootView?

@DejayJD
DejayJD enabled auto-merge (squash) July 17, 2025 22:49
@DejayJD
DejayJD disabled auto-merge July 17, 2025 22:56
@DejayJD
DejayJD merged commit 1a752dd into mainJul 17, 2025
4 of 6 checks passed
@DejayJD
DejayJD deleted the jd/app-warm-start-improvement branch July 17, 2025 22:56
audius-infra pushed a commit that referenced this pull request Jul 19, 2025
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Speed up mobile app warm start by another ~75% - #12555

Merged
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement
Jul 17, 2025
Merged

Speed up mobile app warm start by another ~75%#12555
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement

Conversation

@DejayJD

@DejayJDDejayJD commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

  • This hook was the only thing triggering rerenders on App.tsx on warm start (lock/unlock screen).
  • I realized that this foreground hook doesnt even change anything in the render so there's no reason for it to be causing any renders at all.
  • Moving the hook out to its own component which means App.tsx doesnt ever rerender now.

Now the app warm start looks sooooo nice
image

(most expensive commit being 10ms is well within the 16.6ms range to stay at 60fps ❤️ )

  • Also added a markdown file to keep a log of performance improvements as we go

How Has This Been Tested?

ios:prod

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de45a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJDDejayJD changed the title Speed up app warm start by another ~75%Speed up mobile app warm start by another ~75%Jul 17, 2025

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow killer

</ErrorBoundary>
</PortalProvider>
</GestureHandlerRootView>
<PortalProvider>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming we want to drop the GestureHandlerRootView?

@DejayJD
DejayJD enabled auto-merge (squash) July 17, 2025 22:49
@DejayJD
DejayJD disabled auto-merge July 17, 2025 22:56
@DejayJD
DejayJD merged commit 1a752dd into mainJul 17, 2025
4 of 6 checks passed
@DejayJD
DejayJD deleted the jd/app-warm-start-improvement branch July 17, 2025 22:56
audius-infra pushed a commit that referenced this pull request Jul 19, 2025
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Speed up mobile app warm start by another ~75% - #12555

Merged
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement
Jul 17, 2025
Merged

Speed up mobile app warm start by another ~75%#12555
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement

Conversation

@DejayJD

@DejayJDDejayJD commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

  • This hook was the only thing triggering rerenders on App.tsx on warm start (lock/unlock screen).
  • I realized that this foreground hook doesnt even change anything in the render so there's no reason for it to be causing any renders at all.
  • Moving the hook out to its own component which means App.tsx doesnt ever rerender now.

Now the app warm start looks sooooo nice
image

(most expensive commit being 10ms is well within the 16.6ms range to stay at 60fps ❤️ )

  • Also added a markdown file to keep a log of performance improvements as we go

How Has This Been Tested?

ios:prod

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de45a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJDDejayJD changed the title Speed up app warm start by another ~75%Speed up mobile app warm start by another ~75%Jul 17, 2025

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow killer

</ErrorBoundary>
</PortalProvider>
</GestureHandlerRootView>
<PortalProvider>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming we want to drop the GestureHandlerRootView?

@DejayJD
DejayJD enabled auto-merge (squash) July 17, 2025 22:49
@DejayJD
DejayJD disabled auto-merge July 17, 2025 22:56
@DejayJD
DejayJD merged commit 1a752dd into mainJul 17, 2025
4 of 6 checks passed
@DejayJD
DejayJD deleted the jd/app-warm-start-improvement branch July 17, 2025 22:56
audius-infra pushed a commit that referenced this pull request Jul 19, 2025
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Speed up mobile app warm start by another ~75% - #12555

Merged
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement
Jul 17, 2025
Merged

Speed up mobile app warm start by another ~75%#12555
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement

Conversation

@DejayJD

@DejayJDDejayJD commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

  • This hook was the only thing triggering rerenders on App.tsx on warm start (lock/unlock screen).
  • I realized that this foreground hook doesnt even change anything in the render so there's no reason for it to be causing any renders at all.
  • Moving the hook out to its own component which means App.tsx doesnt ever rerender now.

Now the app warm start looks sooooo nice
image

(most expensive commit being 10ms is well within the 16.6ms range to stay at 60fps ❤️ )

  • Also added a markdown file to keep a log of performance improvements as we go

How Has This Been Tested?

ios:prod

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de45a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJDDejayJD changed the title Speed up app warm start by another ~75%Speed up mobile app warm start by another ~75%Jul 17, 2025

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow killer

</ErrorBoundary>
</PortalProvider>
</GestureHandlerRootView>
<PortalProvider>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming we want to drop the GestureHandlerRootView?

@DejayJD
DejayJD enabled auto-merge (squash) July 17, 2025 22:49
@DejayJD
DejayJD disabled auto-merge July 17, 2025 22:56
@DejayJD
DejayJD merged commit 1a752dd into mainJul 17, 2025
4 of 6 checks passed
@DejayJD
DejayJD deleted the jd/app-warm-start-improvement branch July 17, 2025 22:56
audius-infra pushed a commit that referenced this pull request Jul 19, 2025
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Speed up mobile app warm start by another ~75% - #12555

Merged
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement
Jul 17, 2025
Merged

Speed up mobile app warm start by another ~75%#12555
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement

Conversation

@DejayJD

@DejayJDDejayJD commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

  • This hook was the only thing triggering rerenders on App.tsx on warm start (lock/unlock screen).
  • I realized that this foreground hook doesnt even change anything in the render so there's no reason for it to be causing any renders at all.
  • Moving the hook out to its own component which means App.tsx doesnt ever rerender now.

Now the app warm start looks sooooo nice
image

(most expensive commit being 10ms is well within the 16.6ms range to stay at 60fps ❤️ )

  • Also added a markdown file to keep a log of performance improvements as we go

How Has This Been Tested?

ios:prod

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de45a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJDDejayJD changed the title Speed up app warm start by another ~75%Speed up mobile app warm start by another ~75%Jul 17, 2025

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow killer

</ErrorBoundary>
</PortalProvider>
</GestureHandlerRootView>
<PortalProvider>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming we want to drop the GestureHandlerRootView?

@DejayJD
DejayJD enabled auto-merge (squash) July 17, 2025 22:49
@DejayJD
DejayJD disabled auto-merge July 17, 2025 22:56
@DejayJD
DejayJD merged commit 1a752dd into mainJul 17, 2025
4 of 6 checks passed
@DejayJD
DejayJD deleted the jd/app-warm-start-improvement branch July 17, 2025 22:56
audius-infra pushed a commit that referenced this pull request Jul 19, 2025
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Speed up mobile app warm start by another ~75% - #12555

Merged
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement
Jul 17, 2025
Merged

Speed up mobile app warm start by another ~75%#12555
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement

Conversation

@DejayJD

@DejayJDDejayJD commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

  • This hook was the only thing triggering rerenders on App.tsx on warm start (lock/unlock screen).
  • I realized that this foreground hook doesnt even change anything in the render so there's no reason for it to be causing any renders at all.
  • Moving the hook out to its own component which means App.tsx doesnt ever rerender now.

Now the app warm start looks sooooo nice
image

(most expensive commit being 10ms is well within the 16.6ms range to stay at 60fps ❤️ )

  • Also added a markdown file to keep a log of performance improvements as we go

How Has This Been Tested?

ios:prod

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de45a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJDDejayJD changed the title Speed up app warm start by another ~75%Speed up mobile app warm start by another ~75%Jul 17, 2025

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow killer

</ErrorBoundary>
</PortalProvider>
</GestureHandlerRootView>
<PortalProvider>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming we want to drop the GestureHandlerRootView?

@DejayJD
DejayJD enabled auto-merge (squash) July 17, 2025 22:49
@DejayJD
DejayJD disabled auto-merge July 17, 2025 22:56
@DejayJD
DejayJD merged commit 1a752dd into mainJul 17, 2025
4 of 6 checks passed
@DejayJD
DejayJD deleted the jd/app-warm-start-improvement branch July 17, 2025 22:56
audius-infra pushed a commit that referenced this pull request Jul 19, 2025
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Speed up mobile app warm start by another ~75% - #12555

Merged
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement
Jul 17, 2025
Merged

Speed up mobile app warm start by another ~75%#12555
DejayJD merged 3 commits into
mainfrom
jd/app-warm-start-improvement

Conversation

@DejayJD

@DejayJDDejayJD commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

  • This hook was the only thing triggering rerenders on App.tsx on warm start (lock/unlock screen).
  • I realized that this foreground hook doesnt even change anything in the render so there's no reason for it to be causing any renders at all.
  • Moving the hook out to its own component which means App.tsx doesnt ever rerender now.

Now the app warm start looks sooooo nice
image

(most expensive commit being 10ms is well within the 16.6ms range to stay at 60fps ❤️ )

  • Also added a markdown file to keep a log of performance improvements as we go

How Has This Been Tested?

ios:prod

@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: de45a62

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJDDejayJD changed the title Speed up app warm start by another ~75%Speed up mobile app warm start by another ~75%Jul 17, 2025

@dylanjeffersdylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow killer

</ErrorBoundary>
</PortalProvider>
</GestureHandlerRootView>
<PortalProvider>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirming we want to drop the GestureHandlerRootView?

@DejayJD
DejayJD enabled auto-merge (squash) July 17, 2025 22:49
@DejayJD
DejayJD disabled auto-merge July 17, 2025 22:56
@DejayJD
DejayJD merged commit 1a752dd into mainJul 17, 2025
4 of 6 checks passed
@DejayJD
DejayJD deleted the jd/app-warm-start-improvement branch July 17, 2025 22:56
audius-infra pushed a commit that referenced this pull request Jul 19, 2025
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DejayJD@dylanjeffers