Fix class file version detection by jpbempel · Pull Request #8057 · DataDog/dd-trace-java

jpbempel · 2024-12-05T10:23:19Z

What Does This Do

we are forcing 1.8 class file version when it's below, but we are checking against the full version while we need to check against the major version only

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Squash your commits prior merging or merge using GitHub's Squash and merge
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

we are forcing 1.8 class file version when it's below, but we are checking against the full version while we need to check against the major version only

pr-commenter · 2024-12-05T10:42:41Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1733394738	1733395122
end_time	2024-12-05T10:33:35	2024-12-05T10:39:59
git_branch	master	jpbempel/old-classfile-1.1
git_commit_sha	`5b58772`	`fdca440`
start_time	2024-12-05T10:32:19	2024-12-05T10:38:42

See matching parameters

	Baseline	Candidate
ci_job_id	727834534	727834534
ci_pipeline_id	50383235	50383235
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1733394147	1733394147

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 9 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	better [-501.730µs; -328.571µs] or [-4.735%; -3.101%]	better [-507.953µs; -323.483µs] or [-4.718%; -3.004%]	better [-506.980µs; -285.253µs] or [-4.668%; -2.627%]	better [-593.477µs; -183.321µs] or [-5.304%; -1.638%]	better [+1.697op/s; +4.448op/s] or [+1.841%; +4.826%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-30.683µs; +80.864µs] or [-11.463%; +30.211%]	unstable [-38.228µs; +95.831µs] or [-12.406%; +31.099%]	unstable [-48.116µs; +118.454µs] or [-14.942%; +36.784%]	unstable [-394.408µs; +1207.319µs] or [-65.687%; +201.076%]	same
scenario:basic	unstable [-11.291µs; +18.083µs] or [-4.007%; +6.417%]	unstable [-14.136µs; +34.395µs] or [-4.554%; +11.080%]	unstable [-16.784µs; +47.078µs] or [-5.247%; +14.718%]	unstable [-299.593µs; +895.691µs] or [-54.534%; +163.040%]	unstable [-184.458op/s; +184.458op/s] or [-7.378%; +7.378%]

Request duration reports for reports

gantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (308.149 µs) : 283, 333
. : milestone, 308,
basic (310.439 µs) : 302, 319
. : milestone, 310,
loop (10.767 ms) : 10653, 10881
. : milestone, 10767,
section candidate
noprobe (336.95 µs) : 250, 424
. : milestone, 337,
basic (320.568 µs) : 288, 353
. : milestone, 321,
loop (10.351 ms) : 10310, 10392
. : milestone, 10351,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	308.149 µs [282.858 µs, 333.439 µs]
basic	310.439 µs [301.605 µs, 319.272 µs]
loop	10.767 ms [10.653 ms, 10.881 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	336.95 µs [250.233 µs, 423.667 µs]
basic	320.568 µs [288.227 µs, 352.909 µs]
loop	10.351 ms [10.31 ms, 10.392 ms]

pr-commenter · 2024-12-05T11:05:19Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/old-classfile-1.1
git_commit_date	1733317832	1733394147
git_commit_sha	`5b58772`	`fdca440`
release_version	1.44.0-SNAPSHOT~5b587720dd	1.44.0-SNAPSHOT~fdca4401fd

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733396575	1733396575
ci_job_id	727834528	727834528
ci_pipeline_id	50383235	50383235
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~fdca4401fd, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1090641
Total [baseline] (8.622 s) : 0, 8622426
Agent [candidate] (1.095 s) : 0, 1094613
Total [candidate] (8.692 s) : 0, 8692293
section iast
Agent [baseline] (1.218 s) : 0, 1218319
Total [baseline] (9.238 s) : 0, 9237853
Agent [candidate] (1.221 s) : 0, 1221197
Total [candidate] (9.189 s) : 0, 9188596
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.232 s) : 0, 1231795
Total [baseline] (9.239 s) : 0, 9238931
Agent [candidate] (1.22 s) : 0, 1220068
Total [candidate] (9.153 s) : 0, 9152870
section iast_TELEMETRY_OFF
Agent [baseline] (1.218 s) : 0, 1217649
Total [baseline] (9.192 s) : 0, 9192392
Agent [candidate] (1.214 s) : 0, 1213990
Total [candidate] (9.155 s) : 0, 9155111

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.091 s	-
Agent	iast	1.218 s	127.678 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.232 s	141.153 ms (12.9%)
Agent	iast_TELEMETRY_OFF	1.218 s	127.008 ms (11.6%)
Total	tracing	8.622 s	-
Total	iast	9.238 s	615.427 ms (7.1%)
Total	iast_HARDCODED_SECRET_DISABLED	9.239 s	616.505 ms (7.2%)
Total	iast_TELEMETRY_OFF	9.192 s	569.966 ms (6.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	iast	1.221 s	126.585 ms (11.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.22 s	125.456 ms (11.5%)
Agent	iast_TELEMETRY_OFF	1.214 s	119.377 ms (10.9%)
Total	tracing	8.692 s	-
Total	iast	9.189 s	496.302 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.153 s	460.577 ms (5.3%)
Total	iast_TELEMETRY_OFF	9.155 s	462.817 ms (5.3%)

gantt
title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~fdca4401fd, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.307 ms) : 0, 693307
BytebuddyAgent [candidate] (695.217 ms) : 0, 695217
GlobalTracer [baseline] (315.687 ms) : 0, 315687
GlobalTracer [candidate] (318.614 ms) : 0, 318614
AppSec [baseline] (54.433 ms) : 0, 54433
AppSec [candidate] (54.943 ms) : 0, 54943
Remote Config [baseline] (676.096 µs) : 0, 676
Remote Config [candidate] (683.678 µs) : 0, 684
Telemetry [baseline] (12.874 ms) : 0, 12874
Telemetry [candidate] (11.457 ms) : 0, 11457
section iast
BytebuddyAgent [baseline] (810.637 ms) : 0, 810637
BytebuddyAgent [candidate] (814.261 ms) : 0, 814261
GlobalTracer [baseline] (306.237 ms) : 0, 306237
GlobalTracer [candidate] (305.677 ms) : 0, 305677
AppSec [baseline] (57.479 ms) : 0, 57479
AppSec [candidate] (57.394 ms) : 0, 57394
IAST [baseline] (21.976 ms) : 0, 21976
IAST [candidate] (21.877 ms) : 0, 21877
Remote Config [baseline] (633.552 µs) : 0, 634
Remote Config [candidate] (637.408 µs) : 0, 637
Telemetry [baseline] (7.65 ms) : 0, 7650
Telemetry [candidate] (7.566 ms) : 0, 7566
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (822.835 ms) : 0, 822835
BytebuddyAgent [candidate] (812.673 ms) : 0, 812673
GlobalTracer [baseline] (306.694 ms) : 0, 306694
GlobalTracer [candidate] (305.981 ms) : 0, 305981
AppSec [baseline] (58.393 ms) : 0, 58393
AppSec [candidate] (56.645 ms) : 0, 56645
IAST [baseline] (21.538 ms) : 0, 21538
IAST [candidate] (22.787 ms) : 0, 22787
Remote Config [baseline] (667.973 µs) : 0, 668
Remote Config [candidate] (648.548 µs) : 0, 649
Telemetry [baseline] (7.73 ms) : 0, 7730
Telemetry [candidate] (7.594 ms) : 0, 7594
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (810.662 ms) : 0, 810662
BytebuddyAgent [candidate] (808.743 ms) : 0, 808743
GlobalTracer [baseline] (306.817 ms) : 0, 306817
GlobalTracer [candidate] (305.319 ms) : 0, 305319
AppSec [baseline] (57.942 ms) : 0, 57942
AppSec [candidate] (57.877 ms) : 0, 57877
IAST [baseline] (20.397 ms) : 0, 20397
IAST [candidate] (20.291 ms) : 0, 20291
Remote Config [baseline] (620.377 µs) : 0, 620
Remote Config [candidate] (617.524 µs) : 0, 618
Telemetry [baseline] (7.441 ms) : 0, 7441
Telemetry [candidate] (7.406 ms) : 0, 7406

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~fdca4401fd, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1095880
Total [baseline] (10.42 s) : 0, 10420426
Agent [candidate] (1.091 s) : 0, 1091063
Total [candidate] (10.456 s) : 0, 10456395
section appsec
Agent [baseline] (1.222 s) : 0, 1221793
Total [baseline] (10.671 s) : 0, 10671091
Agent [candidate] (1.227 s) : 0, 1226563
Total [candidate] (10.7 s) : 0, 10699792
section iast
Agent [baseline] (1.218 s) : 0, 1218199
Total [baseline] (10.901 s) : 0, 10901076
Agent [candidate] (1.217 s) : 0, 1217489
Total [candidate] (10.944 s) : 0, 10943635
section profiling
Agent [baseline] (1.325 s) : 0, 1324850
Total [baseline] (10.763 s) : 0, 10763498
Agent [candidate] (1.313 s) : 0, 1313135
Total [candidate] (10.764 s) : 0, 10764316

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.096 s	-
Agent	appsec	1.222 s	125.912 ms (11.5%)
Agent	iast	1.218 s	122.319 ms (11.2%)
Agent	profiling	1.325 s	228.969 ms (20.9%)
Total	tracing	10.42 s	-
Total	appsec	10.671 s	250.665 ms (2.4%)
Total	iast	10.901 s	480.651 ms (4.6%)
Total	profiling	10.763 s	343.072 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.091 s	-
Agent	appsec	1.227 s	135.501 ms (12.4%)
Agent	iast	1.217 s	126.427 ms (11.6%)
Agent	profiling	1.313 s	222.072 ms (20.4%)
Total	tracing	10.456 s	-
Total	appsec	10.7 s	243.397 ms (2.3%)
Total	iast	10.944 s	487.24 ms (4.7%)
Total	profiling	10.764 s	307.921 ms (2.9%)

gantt
title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~fdca4401fd, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (698.075 ms) : 0, 698075
BytebuddyAgent [candidate] (694.951 ms) : 0, 694951
GlobalTracer [baseline] (317.897 ms) : 0, 317897
GlobalTracer [candidate] (316.598 ms) : 0, 316598
AppSec [baseline] (54.885 ms) : 0, 54885
AppSec [candidate] (54.441 ms) : 0, 54441
Remote Config [baseline] (683.122 µs) : 0, 683
Remote Config [candidate] (673.769 µs) : 0, 674
Telemetry [baseline] (10.543 ms) : 0, 10543
Telemetry [candidate] (10.644 ms) : 0, 10644
section appsec
BytebuddyAgent [baseline] (710.147 ms) : 0, 710147
BytebuddyAgent [candidate] (712.911 ms) : 0, 712911
GlobalTracer [baseline] (313.128 ms) : 0, 313128
GlobalTracer [candidate] (314.241 ms) : 0, 314241
AppSec [baseline] (166.31 ms) : 0, 166310
AppSec [candidate] (167.341 ms) : 0, 167341
Remote Config [baseline] (1.34 ms) : 0, 1340
Remote Config [candidate] (998.463 µs) : 0, 998
Telemetry [baseline] (7.759 ms) : 0, 7759
Telemetry [candidate] (7.818 ms) : 0, 7818
IAST [baseline] (18.865 ms) : 0, 18865
IAST [candidate] (19.045 ms) : 0, 19045
section iast
BytebuddyAgent [baseline] (812.584 ms) : 0, 812584
BytebuddyAgent [candidate] (812.024 ms) : 0, 812024
GlobalTracer [baseline] (305.686 ms) : 0, 305686
GlobalTracer [candidate] (304.814 ms) : 0, 304814
AppSec [baseline] (57.402 ms) : 0, 57402
AppSec [candidate] (56.159 ms) : 0, 56159
Remote Config [baseline] (630.306 µs) : 0, 630
Remote Config [candidate] (644.029 µs) : 0, 644
Telemetry [baseline] (7.518 ms) : 0, 7518
Telemetry [candidate] (7.505 ms) : 0, 7505
IAST [baseline] (20.694 ms) : 0, 20694
IAST [candidate] (22.647 ms) : 0, 22647
section profiling
ProfilingAgent [baseline] (93.226 ms) : 0, 93226
ProfilingAgent [candidate] (93.68 ms) : 0, 93680
BytebuddyAgent [baseline] (695.607 ms) : 0, 695607
BytebuddyAgent [candidate] (687.28 ms) : 0, 687280
GlobalTracer [baseline] (434.847 ms) : 0, 434847
GlobalTracer [candidate] (431.332 ms) : 0, 431332
AppSec [baseline] (53.42 ms) : 0, 53420
AppSec [candidate] (53.466 ms) : 0, 53466
Remote Config [baseline] (665.208 µs) : 0, 665
Remote Config [candidate] (689.238 µs) : 0, 689
Telemetry [baseline] (7.705 ms) : 0, 7705
Telemetry [candidate] (7.769 ms) : 0, 7769
Profiling [baseline] (93.249 ms) : 0, 93249
Profiling [candidate] (93.704 ms) : 0, 93704

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-05T10:33:09	2024-12-05T10:40:09
git_branch	master	jpbempel/old-classfile-1.1
git_commit_date	1733317832	1733394147
git_commit_sha	`5b58772`	`fdca440`
release_version	1.44.0-SNAPSHOT~5b587720dd	1.44.0-SNAPSHOT~fdca4401fd
start_time	2024-12-05T10:32:55	2024-12-05T10:39:55

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1733395562	1733395562
ci_job_id	727834529	727834529
ci_pipeline_id	50383235	50383235
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~fdca4401fd, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section baseline
no_agent (372.839 µs) : 353, 393
. : milestone, 373,
iast (493.302 µs) : 471, 515
. : milestone, 493,
iast_FULL (652.87 µs) : 631, 674
. : milestone, 653,
iast_GLOBAL (532.942 µs) : 510, 556
. : milestone, 533,
iast_HARDCODED_SECRET_DISABLED (494.602 µs) : 473, 516
. : milestone, 495,
iast_INACTIVE (451.049 µs) : 430, 473
. : milestone, 451,
iast_TELEMETRY_OFF (483.674 µs) : 462, 505
. : milestone, 484,
tracing (453.231 µs) : 432, 475
. : milestone, 453,
section candidate
no_agent (370.771 µs) : 351, 391
. : milestone, 371,
iast (497.796 µs) : 477, 519
. : milestone, 498,
iast_FULL (649.197 µs) : 628, 671
. : milestone, 649,
iast_GLOBAL (522.467 µs) : 500, 545
. : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (495.998 µs) : 475, 517
. : milestone, 496,
iast_INACTIVE (456.256 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (487.704 µs) : 466, 510
. : milestone, 488,
tracing (453.17 µs) : 432, 474
. : milestone, 453,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.839 µs [352.923 µs, 392.755 µs]	-
iast	493.302 µs [471.419 µs, 515.185 µs]	120.463 µs (32.3%)
iast_FULL	652.87 µs [631.252 µs, 674.489 µs]	280.031 µs (75.1%)
iast_GLOBAL	532.942 µs [510.014 µs, 555.87 µs]	160.102 µs (42.9%)
iast_HARDCODED_SECRET_DISABLED	494.602 µs [473.31 µs, 515.894 µs]	121.763 µs (32.7%)
iast_INACTIVE	451.049 µs [429.56 µs, 472.537 µs]	78.21 µs (21.0%)
iast_TELEMETRY_OFF	483.674 µs [462.036 µs, 505.312 µs]	110.835 µs (29.7%)
tracing	453.231 µs [431.706 µs, 474.755 µs]	80.391 µs (21.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.771 µs [350.998 µs, 390.544 µs]	-
iast	497.796 µs [476.562 µs, 519.03 µs]	127.025 µs (34.3%)
iast_FULL	649.197 µs [627.757 µs, 670.637 µs]	278.426 µs (75.1%)
iast_GLOBAL	522.467 µs [500.087 µs, 544.847 µs]	151.696 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED	495.998 µs [474.685 µs, 517.311 µs]	125.227 µs (33.8%)
iast_INACTIVE	456.256 µs [435.39 µs, 477.121 µs]	85.485 µs (23.1%)
iast_TELEMETRY_OFF	487.704 µs [465.601 µs, 509.807 µs]	116.933 µs (31.5%)
tracing	453.17 µs [431.929 µs, 474.412 µs]	82.399 µs (22.2%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~fdca4401fd, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1370
. : milestone, 1350,
appsec (1.76 ms) : 1736, 1785
. : milestone, 1760,
appsec_no_iast (1.751 ms) : 1727, 1775
. : milestone, 1751,
iast (1.494 ms) : 1471, 1516
. : milestone, 1494,
profiling (1.535 ms) : 1511, 1560
. : milestone, 1535,
tracing (1.48 ms) : 1456, 1505
. : milestone, 1480,
section candidate
no_agent (1.349 ms) : 1329, 1368
. : milestone, 1349,
appsec (1.76 ms) : 1735, 1784
. : milestone, 1760,
appsec_no_iast (1.753 ms) : 1728, 1778
. : milestone, 1753,
iast (1.5 ms) : 1477, 1523
. : milestone, 1500,
profiling (1.523 ms) : 1499, 1546
. : milestone, 1523,
tracing (1.48 ms) : 1455, 1504
. : milestone, 1480,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.33 ms, 1.37 ms]	-
appsec	1.76 ms [1.736 ms, 1.785 ms]	410.66 µs (30.4%)
appsec_no_iast	1.751 ms [1.727 ms, 1.775 ms]	401.316 µs (29.7%)
iast	1.494 ms [1.471 ms, 1.516 ms]	143.804 µs (10.7%)
profiling	1.535 ms [1.511 ms, 1.56 ms]	185.677 µs (13.8%)
tracing	1.48 ms [1.456 ms, 1.505 ms]	130.488 µs (9.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.349 ms [1.329 ms, 1.368 ms]	-
appsec	1.76 ms [1.735 ms, 1.784 ms]	411.153 µs (30.5%)
appsec_no_iast	1.753 ms [1.728 ms, 1.778 ms]	404.036 µs (30.0%)
iast	1.5 ms [1.477 ms, 1.523 ms]	151.41 µs (11.2%)
profiling	1.523 ms [1.499 ms, 1.546 ms]	174.051 µs (12.9%)
tracing	1.48 ms [1.455 ms, 1.504 ms]	131.024 µs (9.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/old-classfile-1.1
git_commit_date	1733317832	1733394147
git_commit_sha	`5b58772`	`fdca440`
release_version	1.44.0-SNAPSHOT~5b587720dd	1.44.0-SNAPSHOT~fdca4401fd

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1733396142	1733396142
ci_job_id	727834530	727834530
ci_pipeline_id	50383235	50383235
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~fdca4401fd, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.36 ms) : 2319, 2402
. : milestone, 2360,
iast (2.101 ms) : 2049, 2154
. : milestone, 2101,
iast_GLOBAL (2.141 ms) : 2088, 2194
. : milestone, 2141,
profiling (1.984 ms) : 1940, 2027
. : milestone, 1984,
tracing (1.934 ms) : 1894, 1974
. : milestone, 1934,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.36 ms) : 2318, 2402
. : milestone, 2360,
iast (2.104 ms) : 2051, 2157
. : milestone, 2104,
iast_GLOBAL (2.15 ms) : 2096, 2203
. : milestone, 2150,
profiling (1.974 ms) : 1931, 2017
. : milestone, 1974,
tracing (1.943 ms) : 1903, 1984
. : milestone, 1943,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.475 ms [1.464 ms, 1.487 ms]	-
appsec	2.36 ms [2.319 ms, 2.402 ms]	884.781 µs (60.0%)
iast	2.101 ms [2.049 ms, 2.154 ms]	625.88 µs (42.4%)
iast_GLOBAL	2.141 ms [2.088 ms, 2.194 ms]	665.606 µs (45.1%)
profiling	1.984 ms [1.94 ms, 2.027 ms]	508.234 µs (34.4%)
tracing	1.934 ms [1.894 ms, 1.974 ms]	458.216 µs (31.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	2.36 ms [2.318 ms, 2.402 ms]	887.403 µs (60.3%)
iast	2.104 ms [2.051 ms, 2.157 ms]	631.322 µs (42.9%)
iast_GLOBAL	2.15 ms [2.096 ms, 2.203 ms]	677.145 µs (46.0%)
profiling	1.974 ms [1.931 ms, 2.017 ms]	501.575 µs (34.1%)
tracing	1.943 ms [1.903 ms, 1.984 ms]	470.844 µs (32.0%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~fdca4401fd, baseline=1.44.0-SNAPSHOT~5b587720dd
dateFormat X
axisFormat %s
section baseline
no_agent (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
appsec (15.098 s) : 15098000, 15098000
. : milestone, 15098000,
iast (18.968 s) : 18968000, 18968000
. : milestone, 18968000,
iast_GLOBAL (17.944 s) : 17944000, 17944000
. : milestone, 17944000,
profiling (15.222 s) : 15222000, 15222000
. : milestone, 15222000,
tracing (14.778 s) : 14778000, 14778000
. : milestone, 14778000,
section candidate
no_agent (15.233 s) : 15233000, 15233000
. : milestone, 15233000,
appsec (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
iast (18.576 s) : 18576000, 18576000
. : milestone, 18576000,
iast_GLOBAL (17.776 s) : 17776000, 17776000
. : milestone, 17776000,
profiling (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
tracing (14.979 s) : 14979000, 14979000
. : milestone, 14979000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.023 s [15.023 s, 15.023 s]	-
appsec	15.098 s [15.098 s, 15.098 s]	75.0 ms (0.5%)
iast	18.968 s [18.968 s, 18.968 s]	3.945 s (26.3%)
iast_GLOBAL	17.944 s [17.944 s, 17.944 s]	2.921 s (19.4%)
profiling	15.222 s [15.222 s, 15.222 s]	199.0 ms (1.3%)
tracing	14.778 s [14.778 s, 14.778 s]	-245.0 ms (-1.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.233 s [15.233 s, 15.233 s]	-
appsec	14.908 s [14.908 s, 14.908 s]	-325.0 ms (-2.1%)
iast	18.576 s [18.576 s, 18.576 s]	3.343 s (21.9%)
iast_GLOBAL	17.776 s [17.776 s, 17.776 s]	2.543 s (16.7%)
profiling	14.946 s [14.946 s, 14.946 s]	-287.0 ms (-1.9%)
tracing	14.979 s [14.979 s, 14.979 s]	-254.0 ms (-1.7%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.50.0` -> `2.50.1` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.59.0` -> `2.59.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.45.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.45.0): 1.45.0 ##### Breaking changes > \[!WARNING]\ > Support for custom scope manager using OpenTelemetry tracer artifact (`dd-trace-ot`) is dropped. > Tracing with OpenTracing API and custom scope manager will continue to work on 1.44.x releases. ##### Components ##### Application Security Management (IAST) - ✨ Add propagation to URI#toURL method ([#8146](DataDog/dd-trace-java#8146) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Increase IAST propagation to StringBuilder setLength ([#8119](DataDog/dd-trace-java#8119) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuffer append ([#8082](DataDog/dd-trace-java#8082) - [@Mariovido](https://github.com/Mariovido)) - ✨ Handle IAST security controls custom validation and sanitization methods ([#7997](DataDog/dd-trace-java#7997) - [@jandro996](https://github.com/jandro996)) ##### Application Security Management (WAF) - ✨ Update user lifecycle tracking to V3 ([#8108](DataDog/dd-trace-java#8108) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Exploit prevention for Shell Injection / Command Injection ([#7615](DataDog/dd-trace-java#7615) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 💡 Support instrumentation of repackaged libraries ([#8153](DataDog/dd-trace-java#8153) - [@mcculls](https://github.com/mcculls)) - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### Database Monitoring - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Dynamic Instrumentation - 🐛 make local var hoisting disabled by default ([#8158](DataDog/dd-trace-java#8158) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix var hoisting issue when no previous store ([#8122](DataDog/dd-trace-java#8122) - [@jpbempel](https://github.com/jpbempel)) - ✨ Only decorate spans without code origin information ([#8105](DataDog/dd-trace-java#8105) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix suspend Kotlin methods instrumentation ([#8080](DataDog/dd-trace-java#8080) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix class file version detection ([#8057](DataDog/dd-trace-java#8057) - [@jpbempel](https://github.com/jpbempel)) ##### GraalVM native-image - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### ML Observability (LLMObs) - ✨🧪 Add LLMObs configuration ([#8076](DataDog/dd-trace-java#8076) - [@gary-huang](https://github.com/gary-huang)) ##### Metrics - Bump integrations-core submodule to 7.60.0 ([#8098](DataDog/dd-trace-java#8098) - [@mcculls](https://github.com/mcculls)) - Upgrade to java-dogstatsd-client v4.4.3 ([#8096](DataDog/dd-trace-java#8096) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - ⚠️🧹 Remove custom scope manager support ([#8164](DataDog/dd-trace-java#8164) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Telemetry - ✨ Retry telemetry requests if CI Visibility is enabled ([#8147](DataDog/dd-trace-java#8147) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add configurable Dependency service resolution period ([#8079](DataDog/dd-trace-java#8079) - [@jandro996](https://github.com/jandro996)) ##### Testing - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### Tracer core - ✨ Defer remote components to avoid OkHttp class-loading side-effects ([#8131](DataDog/dd-trace-java#8131) - [@mcculls](https://github.com/mcculls)) - ✨ Improve Context API null handling and Javadoc ([#8129](DataDog/dd-trace-java#8129) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🐛⚡ Avoid performing blocking I/O operation on application thread ([#8120](DataDog/dd-trace-java#8120) - [@mcculls](https://github.com/mcculls)) - 💡 Introduce a shared context component, independent of tracing ([#8117](DataDog/dd-trace-java#8117) - [@mcculls](https://github.com/mcculls)) - ✨ Improves ServiceNameCollector ([#8109](DataDog/dd-trace-java#8109) - [@amarziali](https://github.com/amarziali)) - Upgrade to ASM 9.7.1 (adds new constant for Java 24) ([#8097](DataDog/dd-trace-java#8097) - [@mcculls](https://github.com/mcculls)) - 🐛 Dynamically evaluate service name for message consumers ([#8088](DataDog/dd-trace-java#8088) - [@amarziali](https://github.com/amarziali)) ##### Serverless - 🐛 Add avoid double instrumenting lambda non-streaming handlers. ([#8073](DataDog/dd-trace-java#8073) - [@purple4reina](https://github.com/purple4reina)) ##### Instrumentations ##### AWS SDK instrumentation - 💡 Instrument EMR's relocated AWS SDK ([#8157](DataDog/dd-trace-java#8157) - [@mcculls](https://github.com/mcculls)) ##### Eclipse Vert.x instrumentation - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### JDBC instrumentation - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Jetty instrumentation - 🐛 Ensure jetty 12 has servlet.path starting with / ([#8093](DataDog/dd-trace-java#8093) - [@github-actions](https://github.com/github-actions)\[bot]) ##### JMS instrumentation - 🧹 Re-use `javax` JMS module for `jakarta` namespace ([#8155](DataDog/dd-trace-java#8155) - [@mcculls](https://github.com/mcculls)) - 🧹 Group `javax.jms` instrumentations under a single module ([#8154](DataDog/dd-trace-java#8154) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛 Reactor: early propagate span in context when subscribing ([#8166](DataDog/dd-trace-java#8166) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: ba2355aa4e2e39ab1fee27319cc4176238efd90b

Fix class file version detection
fdca440
we are forcing 1.8 class file version when it's below, but we are checking against the full version while we need to check against the major version only

jpbempel added type: bug fix Bug fix comp: debugger Dynamic Instrumentation labels Dec 5, 2024

jpbempel requested a review from a team as a code owner December 5, 2024 10:23

jpbempel requested review from shatzi and removed request for a teamDecember 5, 2024 10:23

evanchooly approved these changes Dec 16, 2024
View reviewed changes

jpbempel merged commit 59a70e1 into masterDec 16, 2024

jpbempel deleted the jpbempel/old-classfile-1.1 branch December 16, 2024 20:40

github-actionsBot added this to the 1.45.0 milestone Dec 16, 2024

Navigation Menu

Uh oh!

Fix class file version detection - #8057

Fix class file version detection#8057
jpbempel merged 1 commit into
masterfrom
jpbempel/old-classfile-1.1

jpbempel commented Dec 5, 2024

Uh oh!

pr-commenterBot commented Dec 5, 2024•
edited
Loading

Uh oh!

pr-commenterBot commented Dec 5, 2024•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jpbempel commented Dec 5, 2024

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Dec 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Debugger benchmarks

Parameters

Summary

Uh oh!

pr-commenterBot commented Dec 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pr-commenterBot commented Dec 5, 2024•
edited
Loading

pr-commenterBot commented Dec 5, 2024•
edited
Loading