Upgrade to java-dogstatsd-client v4.4.3 by mcculls · Pull Request #8096 · DataDog/dd-trace-java

mcculls · 2024-12-16T23:02:53Z

Motivation

[BUGFIX] Fix sampling and visibility issues with new direct client.
- See direct: fix sampling and visibility issues with new direct client java-dogstatsd-client#249

Additional Notes

The following changes are also included, but have no effect because of the way we configure java-dogstatsd-client

[BUGFIX] Use correct buffer size for unix sockets when using address builder method.
- See AMLII-2058 Use correct buffer size for unix sockets java-dogstatsd-client#256
[BUGFIX] Restore public constructor for NoOpStatsDClient.
- See AMLII-1813 Remove non-public constructor java-dogstatsd-client#247

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-12-16T23:42:20Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/dogstatsd-4.4.3
git_commit_date	1734386576	1734389426
git_commit_sha	`721af2f`	`6d35dc2`
release_version	1.45.0-SNAPSHOT~721af2f5a5	1.45.0-SNAPSHOT~6d35dc2dfb

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734392497	1734392497
ci_job_id	741453795	741453795
ci_pipeline_id	51278280	51278280
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088577
Total [baseline] (10.392 s) : 0, 10392225
Agent [candidate] (1.092 s) : 0, 1091659
Total [candidate] (10.384 s) : 0, 10383924
section appsec
Agent [baseline] (1.225 s) : 0, 1224731
Total [baseline] (10.652 s) : 0, 10651877
Agent [candidate] (1.234 s) : 0, 1233624
Total [candidate] (10.679 s) : 0, 10679418
section iast
Agent [baseline] (1.22 s) : 0, 1220009
Total [baseline] (10.947 s) : 0, 10946640
Agent [candidate] (1.222 s) : 0, 1221792
Total [candidate] (10.996 s) : 0, 10996471
section profiling
Agent [baseline] (1.312 s) : 0, 1312477
Total [baseline] (10.746 s) : 0, 10745663
Agent [candidate] (1.33 s) : 0, 1329537
Total [candidate] (10.889 s) : 0, 10889486

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	appsec	1.225 s	136.154 ms (12.5%)
Agent	iast	1.22 s	131.432 ms (12.1%)
Agent	profiling	1.312 s	223.899 ms (20.6%)
Total	tracing	10.392 s	-
Total	appsec	10.652 s	259.653 ms (2.5%)
Total	iast	10.947 s	554.415 ms (5.3%)
Total	profiling	10.746 s	353.438 ms (3.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.092 s	-
Agent	appsec	1.234 s	141.965 ms (13.0%)
Agent	iast	1.222 s	130.133 ms (11.9%)
Agent	profiling	1.33 s	237.878 ms (21.8%)
Total	tracing	10.384 s	-
Total	appsec	10.679 s	295.494 ms (2.8%)
Total	iast	10.996 s	612.547 ms (5.9%)
Total	profiling	10.889 s	505.562 ms (4.9%)

gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.742 ms) : 0, 693742
BytebuddyAgent [candidate] (694.44 ms) : 0, 694440
GlobalTracer [baseline] (316.29 ms) : 0, 316290
GlobalTracer [candidate] (316.491 ms) : 0, 316491
AppSec [baseline] (54.339 ms) : 0, 54339
AppSec [candidate] (54.941 ms) : 0, 54941
Remote Config [baseline] (671.115 µs) : 0, 671
Remote Config [candidate] (691.583 µs) : 0, 692
Telemetry [baseline] (9.861 ms) : 0, 9861
Telemetry [candidate] (11.382 ms) : 0, 11382
section appsec
BytebuddyAgent [baseline] (712.513 ms) : 0, 712513
BytebuddyAgent [candidate] (717.225 ms) : 0, 717225
GlobalTracer [baseline] (313.746 ms) : 0, 313746
GlobalTracer [candidate] (315.841 ms) : 0, 315841
AppSec [baseline] (166.169 ms) : 0, 166169
AppSec [candidate] (168.142 ms) : 0, 168142
Remote Config [baseline] (628.909 µs) : 0, 629
Remote Config [candidate] (638.069 µs) : 0, 638
Telemetry [baseline] (7.413 ms) : 0, 7413
Telemetry [candidate] (8.488 ms) : 0, 8488
IAST [baseline] (21.137 ms) : 0, 21137
IAST [candidate] (19.053 ms) : 0, 19053
section iast
BytebuddyAgent [baseline] (812.95 ms) : 0, 812950
BytebuddyAgent [candidate] (814.197 ms) : 0, 814197
GlobalTracer [baseline] (306.285 ms) : 0, 306285
GlobalTracer [candidate] (306.549 ms) : 0, 306549
AppSec [baseline] (57.202 ms) : 0, 57202
AppSec [candidate] (58.004 ms) : 0, 58004
Remote Config [baseline] (610.374 µs) : 0, 610
Remote Config [candidate] (644.966 µs) : 0, 645
Telemetry [baseline] (7.498 ms) : 0, 7498
Telemetry [candidate] (7.471 ms) : 0, 7471
IAST [baseline] (21.727 ms) : 0, 21727
IAST [candidate] (21.19 ms) : 0, 21190
section profiling
ProfilingAgent [baseline] (93.096 ms) : 0, 93096
ProfilingAgent [candidate] (94.669 ms) : 0, 94669
BytebuddyAgent [baseline] (687.069 ms) : 0, 687069
BytebuddyAgent [candidate] (698.134 ms) : 0, 698134
GlobalTracer [baseline] (431.292 ms) : 0, 431292
GlobalTracer [candidate] (434.425 ms) : 0, 434425
AppSec [baseline] (53.501 ms) : 0, 53501
AppSec [candidate] (53.837 ms) : 0, 53837
Remote Config [baseline] (664.117 µs) : 0, 664
Remote Config [candidate] (680.78 µs) : 0, 681
Telemetry [baseline] (7.712 ms) : 0, 7712
Telemetry [candidate] (7.828 ms) : 0, 7828
Profiling [baseline] (93.12 ms) : 0, 93120
Profiling [candidate] (94.695 ms) : 0, 94695

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1103177
Total [baseline] (8.66 s) : 0, 8659940
Agent [candidate] (1.092 s) : 0, 1091604
Total [candidate] (8.598 s) : 0, 8598036
section iast
Agent [baseline] (1.221 s) : 0, 1221250
Total [baseline] (9.193 s) : 0, 9192616
Agent [candidate] (1.231 s) : 0, 1230977
Total [candidate] (9.192 s) : 0, 9192119
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.22 s) : 0, 1219624
Total [baseline] (9.131 s) : 0, 9131235
Agent [candidate] (1.23 s) : 0, 1230492
Total [candidate] (9.184 s) : 0, 9184232
section iast_TELEMETRY_OFF
Agent [baseline] (1.23 s) : 0, 1229973
Total [baseline] (9.224 s) : 0, 9224130
Agent [candidate] (1.223 s) : 0, 1223491
Total [candidate] (9.129 s) : 0, 9129067

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.103 s	-
Agent	iast	1.221 s	118.074 ms (10.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.22 s	116.447 ms (10.6%)
Agent	iast_TELEMETRY_OFF	1.23 s	126.797 ms (11.5%)
Total	tracing	8.66 s	-
Total	iast	9.193 s	532.676 ms (6.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.131 s	471.295 ms (5.4%)
Total	iast_TELEMETRY_OFF	9.224 s	564.19 ms (6.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.092 s	-
Agent	iast	1.231 s	139.373 ms (12.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.23 s	138.888 ms (12.7%)
Agent	iast_TELEMETRY_OFF	1.223 s	131.887 ms (12.1%)
Total	tracing	8.598 s	-
Total	iast	9.192 s	594.082 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.184 s	586.196 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.129 s	531.031 ms (6.2%)

gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (701.473 ms) : 0, 701473
BytebuddyAgent [candidate] (696.241 ms) : 0, 696241
GlobalTracer [baseline] (318.838 ms) : 0, 318838
GlobalTracer [candidate] (316.864 ms) : 0, 316864
AppSec [baseline] (54.978 ms) : 0, 54978
AppSec [candidate] (54.746 ms) : 0, 54746
Remote Config [baseline] (684.254 µs) : 0, 684
Remote Config [candidate] (679.957 µs) : 0, 680
Telemetry [baseline] (13.358 ms) : 0, 13358
Telemetry [candidate] (9.308 ms) : 0, 9308
section iast
BytebuddyAgent [baseline] (813.452 ms) : 0, 813452
BytebuddyAgent [candidate] (824.605 ms) : 0, 824605
GlobalTracer [baseline] (306.681 ms) : 0, 306681
GlobalTracer [candidate] (305.834 ms) : 0, 305834
AppSec [baseline] (57.316 ms) : 0, 57316
AppSec [candidate] (57.709 ms) : 0, 57709
IAST [baseline] (22.002 ms) : 0, 22002
IAST [candidate] (20.842 ms) : 0, 20842
Remote Config [baseline] (615.136 µs) : 0, 615
Remote Config [candidate] (615.086 µs) : 0, 615
Telemetry [baseline] (7.483 ms) : 0, 7483
Telemetry [candidate] (7.44 ms) : 0, 7440
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (812.872 ms) : 0, 812872
BytebuddyAgent [candidate] (820.17 ms) : 0, 820170
GlobalTracer [baseline] (305.652 ms) : 0, 305652
GlobalTracer [candidate] (308.586 ms) : 0, 308586
AppSec [baseline] (57.403 ms) : 0, 57403
AppSec [candidate] (57.635 ms) : 0, 57635
IAST [baseline] (21.864 ms) : 0, 21864
IAST [candidate] (22.114 ms) : 0, 22114
Remote Config [baseline] (617.14 µs) : 0, 617
Remote Config [candidate] (618.672 µs) : 0, 619
Telemetry [baseline] (7.487 ms) : 0, 7487
Telemetry [candidate] (7.503 ms) : 0, 7503
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (820.88 ms) : 0, 820880
BytebuddyAgent [candidate] (815.546 ms) : 0, 815546
GlobalTracer [baseline] (307.897 ms) : 0, 307897
GlobalTracer [candidate] (306.959 ms) : 0, 306959
AppSec [baseline] (58.302 ms) : 0, 58302
AppSec [candidate] (57.425 ms) : 0, 57425
IAST [baseline] (20.876 ms) : 0, 20876
IAST [candidate] (21.69 ms) : 0, 21690
Remote Config [baseline] (633.033 µs) : 0, 633
Remote Config [candidate] (620.896 µs) : 0, 621
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (7.404 ms) : 0, 7404

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-16T23:11:49	2024-12-16T23:18:50
git_branch	master	mcculls/dogstatsd-4.4.3
git_commit_date	1734386576	1734389426
git_commit_sha	`721af2f`	`6d35dc2`
release_version	1.45.0-SNAPSHOT~721af2f5a5	1.45.0-SNAPSHOT~6d35dc2dfb
start_time	2024-12-16T23:11:36	2024-12-16T23:18:36

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734391486	1734391486
ci_job_id	741453796	741453796
ci_pipeline_id	51278280	51278280
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (382.106 µs) : 362, 402
. : milestone, 382,
iast (498.151 µs) : 477, 520
. : milestone, 498,
iast_FULL (658.175 µs) : 637, 680
. : milestone, 658,
iast_GLOBAL (521.61 µs) : 500, 543
. : milestone, 522,
iast_HARDCODED_SECRET_DISABLED (500.051 µs) : 479, 521
. : milestone, 500,
iast_INACTIVE (457.024 µs) : 436, 478
. : milestone, 457,
iast_TELEMETRY_OFF (481.461 µs) : 460, 503
. : milestone, 481,
tracing (463.975 µs) : 443, 485
. : milestone, 464,
section candidate
no_agent (381.654 µs) : 362, 402
. : milestone, 382,
iast (497.819 µs) : 476, 520
. : milestone, 498,
iast_FULL (663.887 µs) : 642, 685
. : milestone, 664,
iast_GLOBAL (527.008 µs) : 505, 549
. : milestone, 527,
iast_HARDCODED_SECRET_DISABLED (499.204 µs) : 478, 521
. : milestone, 499,
iast_INACTIVE (458.305 µs) : 438, 479
. : milestone, 458,
iast_TELEMETRY_OFF (487.583 µs) : 466, 509
. : milestone, 488,
tracing (456.193 µs) : 435, 477
. : milestone, 456,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	382.106 µs [361.854 µs, 402.358 µs]	-
iast	498.151 µs [476.685 µs, 519.618 µs]	116.045 µs (30.4%)
iast_FULL	658.175 µs [636.833 µs, 679.518 µs]	276.069 µs (72.2%)
iast_GLOBAL	521.61 µs [499.743 µs, 543.478 µs]	139.504 µs (36.5%)
iast_HARDCODED_SECRET_DISABLED	500.051 µs [478.813 µs, 521.289 µs]	117.945 µs (30.9%)
iast_INACTIVE	457.024 µs [436.085 µs, 477.962 µs]	74.917 µs (19.6%)
iast_TELEMETRY_OFF	481.461 µs [460.179 µs, 502.743 µs]	99.355 µs (26.0%)
tracing	463.975 µs [442.839 µs, 485.111 µs]	81.869 µs (21.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.654 µs [361.646 µs, 401.662 µs]	-
iast	497.819 µs [476.056 µs, 519.582 µs]	116.165 µs (30.4%)
iast_FULL	663.887 µs [642.325 µs, 685.449 µs]	282.233 µs (74.0%)
iast_GLOBAL	527.008 µs [504.666 µs, 549.349 µs]	145.354 µs (38.1%)
iast_HARDCODED_SECRET_DISABLED	499.204 µs [477.888 µs, 520.521 µs]	117.55 µs (30.8%)
iast_INACTIVE	458.305 µs [437.716 µs, 478.894 µs]	76.651 µs (20.1%)
iast_TELEMETRY_OFF	487.583 µs [466.13 µs, 509.036 µs]	105.929 µs (27.8%)
tracing	456.193 µs [434.894 µs, 477.492 µs]	74.539 µs (19.5%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.352 ms) : 1332, 1372
. : milestone, 1352,
appsec (1.772 ms) : 1749, 1796
. : milestone, 1772,
appsec_no_iast (1.783 ms) : 1759, 1808
. : milestone, 1783,
iast (1.506 ms) : 1483, 1529
. : milestone, 1506,
profiling (1.509 ms) : 1486, 1531
. : milestone, 1509,
tracing (1.503 ms) : 1479, 1528
. : milestone, 1503,
section candidate
no_agent (1.391 ms) : 1371, 1411
. : milestone, 1391,
appsec (1.769 ms) : 1745, 1793
. : milestone, 1769,
appsec_no_iast (1.778 ms) : 1753, 1803
. : milestone, 1778,
iast (1.506 ms) : 1483, 1529
. : milestone, 1506,
profiling (1.521 ms) : 1498, 1544
. : milestone, 1521,
tracing (1.485 ms) : 1459, 1510
. : milestone, 1485,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.352 ms [1.332 ms, 1.372 ms]	-
appsec	1.772 ms [1.749 ms, 1.796 ms]	420.237 µs (31.1%)
appsec_no_iast	1.783 ms [1.759 ms, 1.808 ms]	431.37 µs (31.9%)
iast	1.506 ms [1.483 ms, 1.529 ms]	153.904 µs (11.4%)
profiling	1.509 ms [1.486 ms, 1.531 ms]	156.663 µs (11.6%)
tracing	1.503 ms [1.479 ms, 1.528 ms]	151.449 µs (11.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.391 ms [1.371 ms, 1.411 ms]	-
appsec	1.769 ms [1.745 ms, 1.793 ms]	378.707 µs (27.2%)
appsec_no_iast	1.778 ms [1.753 ms, 1.803 ms]	387.042 µs (27.8%)
iast	1.506 ms [1.483 ms, 1.529 ms]	115.262 µs (8.3%)
profiling	1.521 ms [1.498 ms, 1.544 ms]	130.328 µs (9.4%)
tracing	1.485 ms [1.459 ms, 1.51 ms]	93.869 µs (6.7%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/dogstatsd-4.4.3
git_commit_date	1734386576	1734389426
git_commit_sha	`721af2f`	`6d35dc2`
release_version	1.45.0-SNAPSHOT~721af2f5a5	1.45.0-SNAPSHOT~6d35dc2dfb

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1734392100	1734392100
ci_job_id	741453797	741453797
ci_pipeline_id	51278280	51278280
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.341 ms) : 2300, 2382
. : milestone, 2341,
iast (2.092 ms) : 2039, 2145
. : milestone, 2092,
iast_GLOBAL (2.133 ms) : 2079, 2186
. : milestone, 2133,
profiling (1.965 ms) : 1922, 2008
. : milestone, 1965,
tracing (1.928 ms) : 1888, 1969
. : milestone, 1928,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.349 ms) : 2307, 2391
. : milestone, 2349,
iast (2.095 ms) : 2042, 2148
. : milestone, 2095,
iast_GLOBAL (2.142 ms) : 2088, 2195
. : milestone, 2142,
profiling (1.962 ms) : 1918, 2005
. : milestone, 1962,
tracing (1.931 ms) : 1890, 1972
. : milestone, 1931,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.467 ms [1.456 ms, 1.479 ms]	-
appsec	2.341 ms [2.3 ms, 2.382 ms]	873.602 µs (59.5%)
iast	2.092 ms [2.039 ms, 2.145 ms]	624.578 µs (42.6%)
iast_GLOBAL	2.133 ms [2.079 ms, 2.186 ms]	665.104 µs (45.3%)
profiling	1.965 ms [1.922 ms, 2.008 ms]	497.539 µs (33.9%)
tracing	1.928 ms [1.888 ms, 1.969 ms]	460.892 µs (31.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	2.349 ms [2.307 ms, 2.391 ms]	876.345 µs (59.5%)
iast	2.095 ms [2.042 ms, 2.148 ms]	622.608 µs (42.3%)
iast_GLOBAL	2.142 ms [2.088 ms, 2.195 ms]	669.178 µs (45.4%)
profiling	1.962 ms [1.918 ms, 2.005 ms]	489.163 µs (33.2%)
tracing	1.931 ms [1.89 ms, 1.972 ms]	458.442 µs (31.1%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~6d35dc2dfb, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
appsec (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
iast (18.584 s) : 18584000, 18584000
. : milestone, 18584000,
iast_GLOBAL (17.753 s) : 17753000, 17753000
. : milestone, 17753000,
profiling (14.839 s) : 14839000, 14839000
. : milestone, 14839000,
tracing (15.157 s) : 15157000, 15157000
. : milestone, 15157000,
section candidate
no_agent (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
appsec (15.155 s) : 15155000, 15155000
. : milestone, 15155000,
iast (19.035 s) : 19035000, 19035000
. : milestone, 19035000,
iast_GLOBAL (17.749 s) : 17749000, 17749000
. : milestone, 17749000,
profiling (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
tracing (15.028 s) : 15028000, 15028000
. : milestone, 15028000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.848 s [14.848 s, 14.848 s]	-
appsec	14.896 s [14.896 s, 14.896 s]	48.0 ms (0.3%)
iast	18.584 s [18.584 s, 18.584 s]	3.736 s (25.2%)
iast_GLOBAL	17.753 s [17.753 s, 17.753 s]	2.905 s (19.6%)
profiling	14.839 s [14.839 s, 14.839 s]	-9.0 ms (-0.1%)
tracing	15.157 s [15.157 s, 15.157 s]	309.0 ms (2.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.914 s [14.914 s, 14.914 s]	-
appsec	15.155 s [15.155 s, 15.155 s]	241.0 ms (1.6%)
iast	19.035 s [19.035 s, 19.035 s]	4.121 s (27.6%)
iast_GLOBAL	17.749 s [17.749 s, 17.749 s]	2.835 s (19.0%)
profiling	15.204 s [15.204 s, 15.204 s]	290.0 ms (1.9%)
tracing	15.028 s [15.028 s, 15.028 s]	114.0 ms (0.8%)

github-actions · 2024-12-17T11:20:40Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.50.0` -> `2.50.1` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.59.0` -> `2.59.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.45.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.45.0): 1.45.0 ##### Breaking changes > \[!WARNING]\ > Support for custom scope manager using OpenTelemetry tracer artifact (`dd-trace-ot`) is dropped. > Tracing with OpenTracing API and custom scope manager will continue to work on 1.44.x releases. ##### Components ##### Application Security Management (IAST) - ✨ Add propagation to URI#toURL method ([#8146](DataDog/dd-trace-java#8146) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Increase IAST propagation to StringBuilder setLength ([#8119](DataDog/dd-trace-java#8119) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuffer append ([#8082](DataDog/dd-trace-java#8082) - [@Mariovido](https://github.com/Mariovido)) - ✨ Handle IAST security controls custom validation and sanitization methods ([#7997](DataDog/dd-trace-java#7997) - [@jandro996](https://github.com/jandro996)) ##### Application Security Management (WAF) - ✨ Update user lifecycle tracking to V3 ([#8108](DataDog/dd-trace-java#8108) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Exploit prevention for Shell Injection / Command Injection ([#7615](DataDog/dd-trace-java#7615) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 💡 Support instrumentation of repackaged libraries ([#8153](DataDog/dd-trace-java#8153) - [@mcculls](https://github.com/mcculls)) - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### Database Monitoring - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Dynamic Instrumentation - 🐛 make local var hoisting disabled by default ([#8158](DataDog/dd-trace-java#8158) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix var hoisting issue when no previous store ([#8122](DataDog/dd-trace-java#8122) - [@jpbempel](https://github.com/jpbempel)) - ✨ Only decorate spans without code origin information ([#8105](DataDog/dd-trace-java#8105) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix suspend Kotlin methods instrumentation ([#8080](DataDog/dd-trace-java#8080) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix class file version detection ([#8057](DataDog/dd-trace-java#8057) - [@jpbempel](https://github.com/jpbempel)) ##### GraalVM native-image - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### ML Observability (LLMObs) - ✨🧪 Add LLMObs configuration ([#8076](DataDog/dd-trace-java#8076) - [@gary-huang](https://github.com/gary-huang)) ##### Metrics - Bump integrations-core submodule to 7.60.0 ([#8098](DataDog/dd-trace-java#8098) - [@mcculls](https://github.com/mcculls)) - Upgrade to java-dogstatsd-client v4.4.3 ([#8096](DataDog/dd-trace-java#8096) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - ⚠️🧹 Remove custom scope manager support ([#8164](DataDog/dd-trace-java#8164) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Telemetry - ✨ Retry telemetry requests if CI Visibility is enabled ([#8147](DataDog/dd-trace-java#8147) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add configurable Dependency service resolution period ([#8079](DataDog/dd-trace-java#8079) - [@jandro996](https://github.com/jandro996)) ##### Testing - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### Tracer core - ✨ Defer remote components to avoid OkHttp class-loading side-effects ([#8131](DataDog/dd-trace-java#8131) - [@mcculls](https://github.com/mcculls)) - ✨ Improve Context API null handling and Javadoc ([#8129](DataDog/dd-trace-java#8129) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🐛⚡ Avoid performing blocking I/O operation on application thread ([#8120](DataDog/dd-trace-java#8120) - [@mcculls](https://github.com/mcculls)) - 💡 Introduce a shared context component, independent of tracing ([#8117](DataDog/dd-trace-java#8117) - [@mcculls](https://github.com/mcculls)) - ✨ Improves ServiceNameCollector ([#8109](DataDog/dd-trace-java#8109) - [@amarziali](https://github.com/amarziali)) - Upgrade to ASM 9.7.1 (adds new constant for Java 24) ([#8097](DataDog/dd-trace-java#8097) - [@mcculls](https://github.com/mcculls)) - 🐛 Dynamically evaluate service name for message consumers ([#8088](DataDog/dd-trace-java#8088) - [@amarziali](https://github.com/amarziali)) ##### Serverless - 🐛 Add avoid double instrumenting lambda non-streaming handlers. ([#8073](DataDog/dd-trace-java#8073) - [@purple4reina](https://github.com/purple4reina)) ##### Instrumentations ##### AWS SDK instrumentation - 💡 Instrument EMR's relocated AWS SDK ([#8157](DataDog/dd-trace-java#8157) - [@mcculls](https://github.com/mcculls)) ##### Eclipse Vert.x instrumentation - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### JDBC instrumentation - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Jetty instrumentation - 🐛 Ensure jetty 12 has servlet.path starting with / ([#8093](DataDog/dd-trace-java#8093) - [@github-actions](https://github.com/github-actions)\[bot]) ##### JMS instrumentation - 🧹 Re-use `javax` JMS module for `jakarta` namespace ([#8155](DataDog/dd-trace-java#8155) - [@mcculls](https://github.com/mcculls)) - 🧹 Group `javax.jms` instrumentations under a single module ([#8154](DataDog/dd-trace-java#8154) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛 Reactor: early propagate span in context when subscribing ([#8166](DataDog/dd-trace-java#8166) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: ba2355aa4e2e39ab1fee27319cc4176238efd90b

Upgrade to java-dogstatsd-client v4.4.3
6d35dc2

mcculls added tag: dependencies Dependencies related changes comp: metrics Metrics labels Dec 16, 2024

mcculls marked this pull request as ready for review December 17, 2024 11:20

mcculls requested a review from a team as a code owner December 17, 2024 11:20

mcculls requested a review from nayeem-kamal December 17, 2024 11:20

amarziali approved these changes Dec 17, 2024
View reviewed changes

mcculls merged commit 44d088e into masterDec 17, 2024

mcculls deleted the mcculls/dogstatsd-4.4.3 branch December 17, 2024 12:13

github-actionsBot added this to the 1.45.0 milestone Dec 17, 2024

Navigation Menu

Uh oh!

Upgrade to java-dogstatsd-client v4.4.3 - #8096

Upgrade to java-dogstatsd-client v4.4.3#8096
mcculls merged 1 commit into
masterfrom
mcculls/dogstatsd-4.4.3

mcculls commented Dec 16, 2024•
edited
Loading

Uh oh!

pr-commenterBot commented Dec 16, 2024

Uh oh!

github-actionsBot commented Dec 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mcculls commented Dec 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenterBot commented Dec 16, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actionsBot commented Dec 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mcculls commented Dec 16, 2024•
edited
Loading