Upgrade to ASM 9.7.1 (adds new constant for Java 24) by mcculls · Pull Request #8097 · DataDog/dd-trace-java

mcculls · 2024-12-16T23:35:44Z

Motivation

https://asm.ow2.io/versions.html

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-12-17T00:19:24Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/asm-9.7.1
git_commit_date	1734386576	1734392324
git_commit_sha	`721af2f`	`4643d0c`
release_version	1.45.0-SNAPSHOT~721af2f5a5	1.45.0-SNAPSHOT~4643d0ce58

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734394867	1734394867
ci_job_id	741481122	741481122
ci_pipeline_id	51280355	51280355
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~4643d0ce58, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.095 s) : 0, 1095038
Total [baseline] (10.396 s) : 0, 10396450
Agent [candidate] (1.097 s) : 0, 1096870
Total [candidate] (10.456 s) : 0, 10455797
section appsec
Agent [baseline] (1.229 s) : 0, 1229388
Total [baseline] (10.715 s) : 0, 10714684
Agent [candidate] (1.226 s) : 0, 1225639
Total [candidate] (10.7 s) : 0, 10699737
section iast
Agent [baseline] (1.217 s) : 0, 1217130
Total [baseline] (10.96 s) : 0, 10960114
Agent [candidate] (1.217 s) : 0, 1217143
Total [candidate] (10.943 s) : 0, 10942983
section profiling
Agent [baseline] (1.314 s) : 0, 1314038
Total [baseline] (10.782 s) : 0, 10782472
Agent [candidate] (1.328 s) : 0, 1327641
Total [candidate] (10.88 s) : 0, 10880000

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.095 s	-
Agent	appsec	1.229 s	134.35 ms (12.3%)
Agent	iast	1.217 s	122.092 ms (11.1%)
Agent	profiling	1.314 s	219.001 ms (20.0%)
Total	tracing	10.396 s	-
Total	appsec	10.715 s	318.234 ms (3.1%)
Total	iast	10.96 s	563.664 ms (5.4%)
Total	profiling	10.782 s	386.022 ms (3.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.097 s	-
Agent	appsec	1.226 s	128.768 ms (11.7%)
Agent	iast	1.217 s	120.273 ms (11.0%)
Agent	profiling	1.328 s	230.771 ms (21.0%)
Total	tracing	10.456 s	-
Total	appsec	10.7 s	243.94 ms (2.3%)
Total	iast	10.943 s	487.186 ms (4.7%)
Total	profiling	10.88 s	424.203 ms (4.1%)

gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~4643d0ce58, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (697.958 ms) : 0, 697958
BytebuddyAgent [candidate] (699.164 ms) : 0, 699164
GlobalTracer [baseline] (317.743 ms) : 0, 317743
GlobalTracer [candidate] (318.639 ms) : 0, 318639
AppSec [baseline] (54.905 ms) : 0, 54905
AppSec [candidate] (54.766 ms) : 0, 54766
Remote Config [baseline] (693.55 µs) : 0, 694
Remote Config [candidate] (678.678 µs) : 0, 679
Telemetry [baseline] (9.96 ms) : 0, 9960
Telemetry [candidate] (9.825 ms) : 0, 9825
section appsec
BytebuddyAgent [baseline] (714.492 ms) : 0, 714492
BytebuddyAgent [candidate] (711.699 ms) : 0, 711699
GlobalTracer [baseline] (315.243 ms) : 0, 315243
GlobalTracer [candidate] (314.339 ms) : 0, 314339
AppSec [baseline] (167.14 ms) : 0, 167140
AppSec [candidate] (167.326 ms) : 0, 167326
Remote Config [baseline] (638.804 µs) : 0, 639
Remote Config [candidate] (651.297 µs) : 0, 651
Telemetry [baseline] (7.775 ms) : 0, 7775
Telemetry [candidate] (8.485 ms) : 0, 8485
IAST [baseline] (20.746 ms) : 0, 20746
IAST [candidate] (18.861 ms) : 0, 18861
section iast
BytebuddyAgent [baseline] (811.742 ms) : 0, 811742
BytebuddyAgent [candidate] (810.713 ms) : 0, 810713
GlobalTracer [baseline] (305.448 ms) : 0, 305448
GlobalTracer [candidate] (305.664 ms) : 0, 305664
AppSec [baseline] (57.496 ms) : 0, 57496
AppSec [candidate] (57.141 ms) : 0, 57141
Remote Config [baseline] (604.848 µs) : 0, 605
Remote Config [candidate] (620.185 µs) : 0, 620
Telemetry [baseline] (7.389 ms) : 0, 7389
Telemetry [candidate] (7.425 ms) : 0, 7425
IAST [baseline] (20.737 ms) : 0, 20737
IAST [candidate] (21.856 ms) : 0, 21856
section profiling
BytebuddyAgent [baseline] (688.506 ms) : 0, 688506
BytebuddyAgent [candidate] (697.578 ms) : 0, 697578
GlobalTracer [baseline] (430.828 ms) : 0, 430828
GlobalTracer [candidate] (434.296 ms) : 0, 434296
AppSec [baseline] (53.47 ms) : 0, 53470
AppSec [candidate] (53.733 ms) : 0, 53733
Remote Config [baseline] (660.121 µs) : 0, 660
Remote Config [candidate] (685.262 µs) : 0, 685
Telemetry [baseline] (7.677 ms) : 0, 7677
Telemetry [candidate] (7.731 ms) : 0, 7731
ProfilingAgent [baseline] (93.747 ms) : 0, 93747
ProfilingAgent [candidate] (93.999 ms) : 0, 93999
Profiling [baseline] (93.771 ms) : 0, 93771
Profiling [candidate] (94.024 ms) : 0, 94024

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~4643d0ce58, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1093714
Total [baseline] (8.626 s) : 0, 8625922
Agent [candidate] (1.091 s) : 0, 1090959
Total [candidate] (8.643 s) : 0, 8642952
section iast
Agent [baseline] (1.226 s) : 0, 1226008
Total [baseline] (9.182 s) : 0, 9182208
Agent [candidate] (1.219 s) : 0, 1218727
Total [candidate] (9.227 s) : 0, 9226913
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.228 s) : 0, 1227881
Total [baseline] (9.212 s) : 0, 9212269
Agent [candidate] (1.222 s) : 0, 1221656
Total [candidate] (9.161 s) : 0, 9161202
section iast_TELEMETRY_OFF
Agent [baseline] (1.222 s) : 0, 1222063
Total [baseline] (9.177 s) : 0, 9177336
Agent [candidate] (1.215 s) : 0, 1215315
Total [candidate] (9.15 s) : 0, 9150483

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.094 s	-
Agent	iast	1.226 s	132.294 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.228 s	134.166 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.222 s	128.349 ms (11.7%)
Total	tracing	8.626 s	-
Total	iast	9.182 s	556.286 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.212 s	586.347 ms (6.8%)
Total	iast_TELEMETRY_OFF	9.177 s	551.414 ms (6.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.091 s	-
Agent	iast	1.219 s	127.768 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.222 s	130.697 ms (12.0%)
Agent	iast_TELEMETRY_OFF	1.215 s	124.356 ms (11.4%)
Total	tracing	8.643 s	-
Total	iast	9.227 s	583.961 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.161 s	518.25 ms (6.0%)
Total	iast_TELEMETRY_OFF	9.15 s	507.531 ms (5.9%)

gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~4643d0ce58, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (696.686 ms) : 0, 696686
BytebuddyAgent [candidate] (694.876 ms) : 0, 694876
GlobalTracer [baseline] (317.214 ms) : 0, 317214
GlobalTracer [candidate] (316.684 ms) : 0, 316684
AppSec [baseline] (54.746 ms) : 0, 54746
AppSec [candidate] (54.35 ms) : 0, 54350
Remote Config [baseline] (684.359 µs) : 0, 684
Remote Config [candidate] (679.891 µs) : 0, 680
Telemetry [baseline] (10.639 ms) : 0, 10639
Telemetry [candidate] (10.628 ms) : 0, 10628
section iast
BytebuddyAgent [baseline] (817.36 ms) : 0, 817360
BytebuddyAgent [candidate] (812.111 ms) : 0, 812111
GlobalTracer [baseline] (307.53 ms) : 0, 307530
GlobalTracer [candidate] (305.873 ms) : 0, 305873
AppSec [baseline] (56.605 ms) : 0, 56605
AppSec [candidate] (56.328 ms) : 0, 56328
IAST [baseline] (22.62 ms) : 0, 22620
IAST [candidate] (22.599 ms) : 0, 22599
Remote Config [baseline] (621.328 µs) : 0, 621
Remote Config [candidate] (617.346 µs) : 0, 617
Telemetry [baseline] (7.464 ms) : 0, 7464
Telemetry [candidate] (7.435 ms) : 0, 7435
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (818.321 ms) : 0, 818321
BytebuddyAgent [candidate] (813.412 ms) : 0, 813412
GlobalTracer [baseline] (307.638 ms) : 0, 307638
GlobalTracer [candidate] (306.132 ms) : 0, 306132
AppSec [baseline] (58.54 ms) : 0, 58540
AppSec [candidate] (57.965 ms) : 0, 57965
IAST [baseline] (21.366 ms) : 0, 21366
IAST [candidate] (22.239 ms) : 0, 22239
Remote Config [baseline] (624.974 µs) : 0, 625
Remote Config [candidate] (615.473 µs) : 0, 615
Telemetry [baseline] (7.542 ms) : 0, 7542
Telemetry [candidate] (7.52 ms) : 0, 7520
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (815.821 ms) : 0, 815821
BytebuddyAgent [candidate] (809.552 ms) : 0, 809552
GlobalTracer [baseline] (305.494 ms) : 0, 305494
GlobalTracer [candidate] (305.434 ms) : 0, 305434
AppSec [baseline] (56.657 ms) : 0, 56657
AppSec [candidate] (57.266 ms) : 0, 57266
IAST [baseline] (22.333 ms) : 0, 22333
IAST [candidate] (21.383 ms) : 0, 21383
Remote Config [baseline] (626.917 µs) : 0, 627
Remote Config [candidate] (625.731 µs) : 0, 626
Telemetry [baseline] (7.325 ms) : 0, 7325
Telemetry [candidate] (7.314 ms) : 0, 7314

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-16T23:51:13	2024-12-16T23:58:10
git_branch	master	mcculls/asm-9.7.1
git_commit_date	1734386576	1734392324
git_commit_sha	`721af2f`	`4643d0c`
release_version	1.45.0-SNAPSHOT~721af2f5a5	1.45.0-SNAPSHOT~4643d0ce58
start_time	2024-12-16T23:51:00	2024-12-16T23:57:56

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734393841	1734393841
ci_job_id	741481123	741481123
ci_pipeline_id	51280355	51280355
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~4643d0ce58, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (371.441 µs) : 351, 392
. : milestone, 371,
iast (487.679 µs) : 466, 509
. : milestone, 488,
iast_FULL (644.226 µs) : 623, 666
. : milestone, 644,
iast_GLOBAL (518.155 µs) : 496, 540
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (487.212 µs) : 466, 509
. : milestone, 487,
iast_INACTIVE (445.967 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (484.595 µs) : 463, 506
. : milestone, 485,
tracing (447.317 µs) : 426, 468
. : milestone, 447,
section candidate
no_agent (377.642 µs) : 356, 399
. : milestone, 378,
iast (497.541 µs) : 476, 519
. : milestone, 498,
iast_FULL (641.165 µs) : 620, 663
. : milestone, 641,
iast_GLOBAL (525.523 µs) : 502, 549
. : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (487.754 µs) : 466, 509
. : milestone, 488,
iast_INACTIVE (449.929 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (471.976 µs) : 451, 493
. : milestone, 472,
tracing (445.084 µs) : 425, 465
. : milestone, 445,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	371.441 µs [351.127 µs, 391.756 µs]	-
iast	487.679 µs [466.194 µs, 509.164 µs]	116.238 µs (31.3%)
iast_FULL	644.226 µs [622.798 µs, 665.654 µs]	272.784 µs (73.4%)
iast_GLOBAL	518.155 µs [495.813 µs, 540.497 µs]	146.714 µs (39.5%)
iast_HARDCODED_SECRET_DISABLED	487.212 µs [465.562 µs, 508.862 µs]	115.77 µs (31.2%)
iast_INACTIVE	445.967 µs [425.184 µs, 466.751 µs]	74.526 µs (20.1%)
iast_TELEMETRY_OFF	484.595 µs [462.791 µs, 506.399 µs]	113.153 µs (30.5%)
tracing	447.317 µs [426.34 µs, 468.294 µs]	75.875 µs (20.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.642 µs [356.267 µs, 399.016 µs]	-
iast	497.541 µs [475.844 µs, 519.237 µs]	119.899 µs (31.7%)
iast_FULL	641.165 µs [619.679 µs, 662.652 µs]	263.524 µs (69.8%)
iast_GLOBAL	525.523 µs [502.321 µs, 548.725 µs]	147.882 µs (39.2%)
iast_HARDCODED_SECRET_DISABLED	487.754 µs [466.152 µs, 509.356 µs]	110.112 µs (29.2%)
iast_INACTIVE	449.929 µs [428.534 µs, 471.323 µs]	72.287 µs (19.1%)
iast_TELEMETRY_OFF	471.976 µs [450.636 µs, 493.317 µs]	94.335 µs (25.0%)
tracing	445.084 µs [424.699 µs, 465.47 µs]	67.443 µs (17.9%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~4643d0ce58, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1368
. : milestone, 1349,
appsec (1.743 ms) : 1719, 1766
. : milestone, 1743,
appsec_no_iast (1.755 ms) : 1730, 1779
. : milestone, 1755,
iast (1.476 ms) : 1453, 1499
. : milestone, 1476,
profiling (1.495 ms) : 1471, 1519
. : milestone, 1495,
tracing (1.494 ms) : 1470, 1518
. : milestone, 1494,
section candidate
no_agent (1.35 ms) : 1330, 1369
. : milestone, 1350,
appsec (1.74 ms) : 1714, 1765
. : milestone, 1740,
appsec_no_iast (1.761 ms) : 1737, 1786
. : milestone, 1761,
iast (1.487 ms) : 1465, 1509
. : milestone, 1487,
profiling (1.479 ms) : 1455, 1502
. : milestone, 1479,
tracing (1.484 ms) : 1458, 1509
. : milestone, 1484,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.349 ms [1.329 ms, 1.368 ms]	-
appsec	1.743 ms [1.719 ms, 1.766 ms]	393.926 µs (29.2%)
appsec_no_iast	1.755 ms [1.73 ms, 1.779 ms]	405.688 µs (30.1%)
iast	1.476 ms [1.453 ms, 1.499 ms]	127.11 µs (9.4%)
profiling	1.495 ms [1.471 ms, 1.519 ms]	146.104 µs (10.8%)
tracing	1.494 ms [1.47 ms, 1.518 ms]	144.764 µs (10.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.33 ms, 1.369 ms]	-
appsec	1.74 ms [1.714 ms, 1.765 ms]	389.789 µs (28.9%)
appsec_no_iast	1.761 ms [1.737 ms, 1.786 ms]	411.411 µs (30.5%)
iast	1.487 ms [1.465 ms, 1.509 ms]	137.012 µs (10.2%)
profiling	1.479 ms [1.455 ms, 1.502 ms]	129.072 µs (9.6%)
tracing	1.484 ms [1.458 ms, 1.509 ms]	133.773 µs (9.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/asm-9.7.1
git_commit_date	1734386576	1734392324
git_commit_sha	`721af2f`	`4643d0c`
release_version	1.45.0-SNAPSHOT~721af2f5a5	1.45.0-SNAPSHOT~4643d0ce58

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1734394384	1734394384
ci_job_id	741481124	741481124
ci_pipeline_id	51280355	51280355
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~4643d0ce58, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (15.623 s) : 15623000, 15623000
. : milestone, 15623000,
appsec (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
iast (18.461 s) : 18461000, 18461000
. : milestone, 18461000,
iast_GLOBAL (17.633 s) : 17633000, 17633000
. : milestone, 17633000,
profiling (15.425 s) : 15425000, 15425000
. : milestone, 15425000,
tracing (14.976 s) : 14976000, 14976000
. : milestone, 14976000,
section candidate
no_agent (15.508 s) : 15508000, 15508000
. : milestone, 15508000,
appsec (15.045 s) : 15045000, 15045000
. : milestone, 15045000,
iast (18.796 s) : 18796000, 18796000
. : milestone, 18796000,
iast_GLOBAL (17.899 s) : 17899000, 17899000
. : milestone, 17899000,
profiling (15.459 s) : 15459000, 15459000
. : milestone, 15459000,
tracing (14.976 s) : 14976000, 14976000
. : milestone, 14976000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.623 s [15.623 s, 15.623 s]	-
appsec	14.854 s [14.854 s, 14.854 s]	-769.0 ms (-4.9%)
iast	18.461 s [18.461 s, 18.461 s]	2.838 s (18.2%)
iast_GLOBAL	17.633 s [17.633 s, 17.633 s]	2.01 s (12.9%)
profiling	15.425 s [15.425 s, 15.425 s]	-198.0 ms (-1.3%)
tracing	14.976 s [14.976 s, 14.976 s]	-647.0 ms (-4.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.508 s [15.508 s, 15.508 s]	-
appsec	15.045 s [15.045 s, 15.045 s]	-463.0 ms (-3.0%)
iast	18.796 s [18.796 s, 18.796 s]	3.288 s (21.2%)
iast_GLOBAL	17.899 s [17.899 s, 17.899 s]	2.391 s (15.4%)
profiling	15.459 s [15.459 s, 15.459 s]	-49.0 ms (-0.3%)
tracing	14.976 s [14.976 s, 14.976 s]	-532.0 ms (-3.4%)

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~4643d0ce58, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
. : milestone, 1461,
appsec (2.339 ms) : 2297, 2380
. : milestone, 2339,
iast (2.073 ms) : 2021, 2126
. : milestone, 2073,
iast_GLOBAL (2.118 ms) : 2065, 2171
. : milestone, 2118,
profiling (1.956 ms) : 1914, 1999
. : milestone, 1956,
tracing (1.923 ms) : 1883, 1963
. : milestone, 1923,
section candidate
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.343 ms) : 2301, 2385
. : milestone, 2343,
iast (2.085 ms) : 2032, 2138
. : milestone, 2085,
iast_GLOBAL (2.128 ms) : 2075, 2181
. : milestone, 2128,
profiling (1.951 ms) : 1909, 1993
. : milestone, 1951,
tracing (1.927 ms) : 1887, 1968
. : milestone, 1927,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.461 ms [1.45 ms, 1.473 ms]	-
appsec	2.339 ms [2.297 ms, 2.38 ms]	877.315 µs (60.0%)
iast	2.073 ms [2.021 ms, 2.126 ms]	611.745 µs (41.9%)
iast_GLOBAL	2.118 ms [2.065 ms, 2.171 ms]	656.374 µs (44.9%)
profiling	1.956 ms [1.914 ms, 1.999 ms]	494.987 µs (33.9%)
tracing	1.923 ms [1.883 ms, 1.963 ms]	461.539 µs (31.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.466 ms [1.455 ms, 1.478 ms]	-
appsec	2.343 ms [2.301 ms, 2.385 ms]	877.011 µs (59.8%)
iast	2.085 ms [2.032 ms, 2.138 ms]	618.486 µs (42.2%)
iast_GLOBAL	2.128 ms [2.075 ms, 2.181 ms]	661.49 µs (45.1%)
profiling	1.951 ms [1.909 ms, 1.993 ms]	484.809 µs (33.1%)
tracing	1.927 ms [1.887 ms, 1.968 ms]	460.977 µs (31.4%)

github-actions · 2024-12-17T11:20:46Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.50.0` -> `2.50.1` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.59.0` -> `2.59.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.45.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.45.0): 1.45.0 ##### Breaking changes > \[!WARNING]\ > Support for custom scope manager using OpenTelemetry tracer artifact (`dd-trace-ot`) is dropped. > Tracing with OpenTracing API and custom scope manager will continue to work on 1.44.x releases. ##### Components ##### Application Security Management (IAST) - ✨ Add propagation to URI#toURL method ([#8146](DataDog/dd-trace-java#8146) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Increase IAST propagation to StringBuilder setLength ([#8119](DataDog/dd-trace-java#8119) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuffer append ([#8082](DataDog/dd-trace-java#8082) - [@Mariovido](https://github.com/Mariovido)) - ✨ Handle IAST security controls custom validation and sanitization methods ([#7997](DataDog/dd-trace-java#7997) - [@jandro996](https://github.com/jandro996)) ##### Application Security Management (WAF) - ✨ Update user lifecycle tracking to V3 ([#8108](DataDog/dd-trace-java#8108) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Exploit prevention for Shell Injection / Command Injection ([#7615](DataDog/dd-trace-java#7615) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 💡 Support instrumentation of repackaged libraries ([#8153](DataDog/dd-trace-java#8153) - [@mcculls](https://github.com/mcculls)) - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### Database Monitoring - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Dynamic Instrumentation - 🐛 make local var hoisting disabled by default ([#8158](DataDog/dd-trace-java#8158) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix var hoisting issue when no previous store ([#8122](DataDog/dd-trace-java#8122) - [@jpbempel](https://github.com/jpbempel)) - ✨ Only decorate spans without code origin information ([#8105](DataDog/dd-trace-java#8105) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix suspend Kotlin methods instrumentation ([#8080](DataDog/dd-trace-java#8080) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix class file version detection ([#8057](DataDog/dd-trace-java#8057) - [@jpbempel](https://github.com/jpbempel)) ##### GraalVM native-image - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### ML Observability (LLMObs) - ✨🧪 Add LLMObs configuration ([#8076](DataDog/dd-trace-java#8076) - [@gary-huang](https://github.com/gary-huang)) ##### Metrics - Bump integrations-core submodule to 7.60.0 ([#8098](DataDog/dd-trace-java#8098) - [@mcculls](https://github.com/mcculls)) - Upgrade to java-dogstatsd-client v4.4.3 ([#8096](DataDog/dd-trace-java#8096) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - ⚠️🧹 Remove custom scope manager support ([#8164](DataDog/dd-trace-java#8164) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Telemetry - ✨ Retry telemetry requests if CI Visibility is enabled ([#8147](DataDog/dd-trace-java#8147) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add configurable Dependency service resolution period ([#8079](DataDog/dd-trace-java#8079) - [@jandro996](https://github.com/jandro996)) ##### Testing - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### Tracer core - ✨ Defer remote components to avoid OkHttp class-loading side-effects ([#8131](DataDog/dd-trace-java#8131) - [@mcculls](https://github.com/mcculls)) - ✨ Improve Context API null handling and Javadoc ([#8129](DataDog/dd-trace-java#8129) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🐛⚡ Avoid performing blocking I/O operation on application thread ([#8120](DataDog/dd-trace-java#8120) - [@mcculls](https://github.com/mcculls)) - 💡 Introduce a shared context component, independent of tracing ([#8117](DataDog/dd-trace-java#8117) - [@mcculls](https://github.com/mcculls)) - ✨ Improves ServiceNameCollector ([#8109](DataDog/dd-trace-java#8109) - [@amarziali](https://github.com/amarziali)) - Upgrade to ASM 9.7.1 (adds new constant for Java 24) ([#8097](DataDog/dd-trace-java#8097) - [@mcculls](https://github.com/mcculls)) - 🐛 Dynamically evaluate service name for message consumers ([#8088](DataDog/dd-trace-java#8088) - [@amarziali](https://github.com/amarziali)) ##### Serverless - 🐛 Add avoid double instrumenting lambda non-streaming handlers. ([#8073](DataDog/dd-trace-java#8073) - [@purple4reina](https://github.com/purple4reina)) ##### Instrumentations ##### AWS SDK instrumentation - 💡 Instrument EMR's relocated AWS SDK ([#8157](DataDog/dd-trace-java#8157) - [@mcculls](https://github.com/mcculls)) ##### Eclipse Vert.x instrumentation - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### JDBC instrumentation - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Jetty instrumentation - 🐛 Ensure jetty 12 has servlet.path starting with / ([#8093](DataDog/dd-trace-java#8093) - [@github-actions](https://github.com/github-actions)\[bot]) ##### JMS instrumentation - 🧹 Re-use `javax` JMS module for `jakarta` namespace ([#8155](DataDog/dd-trace-java#8155) - [@mcculls](https://github.com/mcculls)) - 🧹 Group `javax.jms` instrumentations under a single module ([#8154](DataDog/dd-trace-java#8154) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛 Reactor: early propagate span in context when subscribing ([#8166](DataDog/dd-trace-java#8166) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: ba2355aa4e2e39ab1fee27319cc4176238efd90b

mcculls added comp: core Tracer core tag: dependencies Dependencies related changes labels Dec 16, 2024

Upgrade to ASM 9.7.1 (adds new constant for Java 24)
4643d0c

mcculls force-pushed the mcculls/asm-9.7.1 branch from 93f1106 to 4643d0cCompare December 16, 2024 23:38

mcculls marked this pull request as ready for review December 17, 2024 11:20

mcculls requested a review from a team as a code owner December 17, 2024 11:20

mcculls requested a review from smola December 17, 2024 11:20

amarziali approved these changes Dec 17, 2024
View reviewed changes

mcculls merged commit ea44523 into masterDec 17, 2024

mcculls deleted the mcculls/asm-9.7.1 branch December 17, 2024 12:13

github-actionsBot added this to the 1.45.0 milestone Dec 17, 2024

Navigation Menu

Uh oh!

Upgrade to ASM 9.7.1 (adds new constant for Java 24) - #8097

Upgrade to ASM 9.7.1 (adds new constant for Java 24)#8097
mcculls merged 1 commit into
masterfrom
mcculls/asm-9.7.1

mcculls commented Dec 16, 2024

Uh oh!

pr-commenterBot commented Dec 17, 2024•
edited
Loading

Uh oh!

github-actionsBot commented Dec 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

mcculls commented Dec 16, 2024

Motivation

Contributor Checklist

Uh oh!

pr-commenterBot commented Dec 17, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actionsBot commented Dec 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pr-commenterBot commented Dec 17, 2024•
edited
Loading