Ensure jetty 12 has servlet.path starting with / by github-actions[bot] · Pull Request #8093 · DataDog/dd-trace-java

github-actions · 2024-12-15T04:18:47Z

This PR updates the Gradle dependencies. ⚠️ Don't forget to squash commits before merging. ⚠️

Update PR title if a code change is needed to support one of those new dependencies

pr-commenter · 2024-12-15T04:48:53Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ci/update-gradle-dependencies-20241215
git_commit_date	1734386576	1734435432
git_commit_sha	`721af2f`	1569c69d4c
release_version	1.45.0-SNAPSHOT~721af2f5a5	1.45.0-SNAPSHOT~1569c69d4c

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734437757	1734437757
ci_job_id	741896643	741896643
ci_pipeline_id	51311714	51311714
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for petclinic

gantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~1569c69d4c, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1092127
Total [baseline] (10.43 s) : 0, 10430084
Agent [candidate] (1.093 s) : 0, 1093020
Total [candidate] (10.408 s) : 0, 10407757
section appsec
Agent [baseline] (1.226 s) : 0, 1225676
Total [baseline] (10.666 s) : 0, 10665839
Agent [candidate] (1.231 s) : 0, 1230668
Total [candidate] (10.667 s) : 0, 10667392
section iast
Agent [baseline] (1.221 s) : 0, 1221315
Total [baseline] (10.964 s) : 0, 10964257
Agent [candidate] (1.221 s) : 0, 1221142
Total [candidate] (10.875 s) : 0, 10875215
section profiling
Agent [baseline] (1.317 s) : 0, 1317327
Total [baseline] (10.865 s) : 0, 10865147
Agent [candidate] (1.329 s) : 0, 1329220
Total [candidate] (10.832 s) : 0, 10831927

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.092 s	-
Agent	appsec	1.226 s	133.549 ms (12.2%)
Agent	iast	1.221 s	129.188 ms (11.8%)
Agent	profiling	1.317 s	225.199 ms (20.6%)
Total	tracing	10.43 s	-
Total	appsec	10.666 s	235.754 ms (2.3%)
Total	iast	10.964 s	534.173 ms (5.1%)
Total	profiling	10.865 s	435.063 ms (4.2%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.093 s	-
Agent	appsec	1.231 s	137.649 ms (12.6%)
Agent	iast	1.221 s	128.122 ms (11.7%)
Agent	profiling	1.329 s	236.201 ms (21.6%)
Total	tracing	10.408 s	-
Total	appsec	10.667 s	259.635 ms (2.5%)
Total	iast	10.875 s	467.458 ms (4.5%)
Total	profiling	10.832 s	424.17 ms (4.1%)

gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~1569c69d4c, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.364 ms) : 0, 695364
BytebuddyAgent [candidate] (695.847 ms) : 0, 695847
GlobalTracer [baseline] (316.682 ms) : 0, 316682
GlobalTracer [candidate] (317.286 ms) : 0, 317286
AppSec [baseline] (54.428 ms) : 0, 54428
AppSec [candidate] (54.15 ms) : 0, 54150
Remote Config [baseline] (679.797 µs) : 0, 680
Remote Config [candidate] (677.572 µs) : 0, 678
Telemetry [baseline] (11.287 ms) : 0, 11287
Telemetry [candidate] (11.321 ms) : 0, 11321
section appsec
BytebuddyAgent [baseline] (712.402 ms) : 0, 712402
BytebuddyAgent [candidate] (716.229 ms) : 0, 716229
GlobalTracer [baseline] (313.777 ms) : 0, 313777
GlobalTracer [candidate] (315.081 ms) : 0, 315081
AppSec [baseline] (167.726 ms) : 0, 167726
AppSec [candidate] (167.977 ms) : 0, 167977
Remote Config [baseline] (631.835 µs) : 0, 632
Remote Config [candidate] (640.148 µs) : 0, 640
Telemetry [baseline] (7.439 ms) : 0, 7439
Telemetry [candidate] (7.435 ms) : 0, 7435
IAST [baseline] (19.995 ms) : 0, 19995
IAST [candidate] (19.012 ms) : 0, 19012
section iast
BytebuddyAgent [baseline] (814.299 ms) : 0, 814299
BytebuddyAgent [candidate] (813.951 ms) : 0, 813951
GlobalTracer [baseline] (306.343 ms) : 0, 306343
GlobalTracer [candidate] (306.089 ms) : 0, 306089
AppSec [baseline] (57.228 ms) : 0, 57228
AppSec [candidate] (57.808 ms) : 0, 57808
Remote Config [baseline] (604.723 µs) : 0, 605
Remote Config [candidate] (635.634 µs) : 0, 636
Telemetry [baseline] (7.39 ms) : 0, 7390
Telemetry [candidate] (7.501 ms) : 0, 7501
IAST [baseline] (21.704 ms) : 0, 21704
IAST [candidate] (21.363 ms) : 0, 21363
section profiling
ProfilingAgent [baseline] (94.078 ms) : 0, 94078
ProfilingAgent [candidate] (93.598 ms) : 0, 93598
BytebuddyAgent [baseline] (689.169 ms) : 0, 689169
BytebuddyAgent [candidate] (698.65 ms) : 0, 698650
GlobalTracer [baseline] (432.9 ms) : 0, 432900
GlobalTracer [candidate] (435.02 ms) : 0, 435020
AppSec [baseline] (53.592 ms) : 0, 53592
AppSec [candidate] (53.8 ms) : 0, 53800
Remote Config [baseline] (684.382 µs) : 0, 684
Remote Config [candidate] (677.341 µs) : 0, 677
Telemetry [baseline] (7.73 ms) : 0, 7730
Telemetry [candidate] (7.749 ms) : 0, 7749
Profiling [baseline] (94.103 ms) : 0, 94103
Profiling [candidate] (93.622 ms) : 0, 93622

Startup time reports for insecure-bank

gantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~1569c69d4c, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092828
Total [baseline] (8.64 s) : 0, 8640195
Agent [candidate] (1.088 s) : 0, 1088328
Total [candidate] (8.608 s) : 0, 8608093
section iast
Agent [baseline] (1.228 s) : 0, 1228127
Total [baseline] (9.188 s) : 0, 9188432
Agent [candidate] (1.238 s) : 0, 1238043
Total [candidate] (9.272 s) : 0, 9271908
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.222 s) : 0, 1221614
Total [baseline] (9.151 s) : 0, 9150714
Agent [candidate] (1.224 s) : 0, 1224033
Total [candidate] (9.169 s) : 0, 9168664
section iast_TELEMETRY_OFF
Agent [baseline] (1.218 s) : 0, 1218474
Total [baseline] (9.192 s) : 0, 9192109
Agent [candidate] (1.224 s) : 0, 1223985
Total [candidate] (9.177 s) : 0, 9176666

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.093 s	-
Agent	iast	1.228 s	135.299 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.222 s	128.785 ms (11.8%)
Agent	iast_TELEMETRY_OFF	1.218 s	125.645 ms (11.5%)
Total	tracing	8.64 s	-
Total	iast	9.188 s	548.238 ms (6.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.151 s	510.519 ms (5.9%)
Total	iast_TELEMETRY_OFF	9.192 s	551.915 ms (6.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.088 s	-
Agent	iast	1.238 s	149.716 ms (13.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.224 s	135.705 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.224 s	135.658 ms (12.5%)
Total	tracing	8.608 s	-
Total	iast	9.272 s	663.815 ms (7.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.169 s	560.57 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.177 s	568.573 ms (6.6%)

gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~1569c69d4c, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (695.965 ms) : 0, 695965
BytebuddyAgent [candidate] (693.561 ms) : 0, 693561
GlobalTracer [baseline] (316.638 ms) : 0, 316638
GlobalTracer [candidate] (315.945 ms) : 0, 315945
AppSec [baseline] (54.589 ms) : 0, 54589
AppSec [candidate] (54.556 ms) : 0, 54556
Remote Config [baseline] (683.017 µs) : 0, 683
Remote Config [candidate] (673.402 µs) : 0, 673
Telemetry [baseline] (11.242 ms) : 0, 11242
Telemetry [candidate] (9.927 ms) : 0, 9927
section iast
BytebuddyAgent [baseline] (819.756 ms) : 0, 819756
BytebuddyAgent [candidate] (825.074 ms) : 0, 825074
GlobalTracer [baseline] (307.306 ms) : 0, 307306
GlobalTracer [candidate] (311.375 ms) : 0, 311375
AppSec [baseline] (56.635 ms) : 0, 56635
AppSec [candidate] (57.454 ms) : 0, 57454
Remote Config [baseline] (613.224 µs) : 0, 613
Remote Config [candidate] (616.612 µs) : 0, 617
Telemetry [baseline] (7.434 ms) : 0, 7434
Telemetry [candidate] (7.485 ms) : 0, 7485
IAST [baseline] (22.606 ms) : 0, 22606
IAST [candidate] (22.122 ms) : 0, 22122
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (814.175 ms) : 0, 814175
BytebuddyAgent [candidate] (815.75 ms) : 0, 815750
GlobalTracer [baseline] (306.31 ms) : 0, 306310
GlobalTracer [candidate] (307.003 ms) : 0, 307003
AppSec [baseline] (56.638 ms) : 0, 56638
AppSec [candidate] (58.157 ms) : 0, 58157
Remote Config [baseline] (599.48 µs) : 0, 599
Remote Config [candidate] (624.268 µs) : 0, 624
Telemetry [baseline] (7.445 ms) : 0, 7445
Telemetry [candidate] (7.431 ms) : 0, 7431
IAST [baseline] (22.713 ms) : 0, 22713
IAST [candidate] (21.28 ms) : 0, 21280
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (812.281 ms) : 0, 812281
BytebuddyAgent [candidate] (816.265 ms) : 0, 816265
GlobalTracer [baseline] (305.801 ms) : 0, 305801
GlobalTracer [candidate] (307.051 ms) : 0, 307051
AppSec [baseline] (57.931 ms) : 0, 57931
AppSec [candidate] (57.567 ms) : 0, 57567
Remote Config [baseline] (622.474 µs) : 0, 622
Remote Config [candidate] (617.776 µs) : 0, 618
Telemetry [baseline] (7.403 ms) : 0, 7403
Telemetry [candidate] (7.279 ms) : 0, 7279
IAST [baseline] (20.685 ms) : 0, 20685
IAST [candidate] (21.388 ms) : 0, 21388

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-12-17T11:48:12	2024-12-17T11:55:10
git_branch	master	ci/update-gradle-dependencies-20241215
git_commit_date	1734386576	1734435432
git_commit_sha	`721af2f`	1569c69d4c
release_version	1.45.0-SNAPSHOT~721af2f5a5	1.45.0-SNAPSHOT~1569c69d4c
start_time	2024-12-17T11:47:58	2024-12-17T11:54:56

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1734436862	1734436862
ci_job_id	741896644	741896644
ci_pipeline_id	51311714	51311714
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~1569c69d4c, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (373.12 µs) : 353, 393
. : milestone, 373,
iast (492.308 µs) : 471, 514
. : milestone, 492,
iast_FULL (646.279 µs) : 625, 668
. : milestone, 646,
iast_GLOBAL (517.502 µs) : 496, 539
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (494.516 µs) : 472, 517
. : milestone, 495,
iast_INACTIVE (454.412 µs) : 433, 476
. : milestone, 454,
iast_TELEMETRY_OFF (482.521 µs) : 461, 504
. : milestone, 483,
tracing (448.905 µs) : 428, 470
. : milestone, 449,
section candidate
no_agent (370.403 µs) : 350, 391
. : milestone, 370,
iast (488.132 µs) : 466, 510
. : milestone, 488,
iast_FULL (649.008 µs) : 627, 671
. : milestone, 649,
iast_GLOBAL (512.96 µs) : 492, 534
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (493.336 µs) : 471, 515
. : milestone, 493,
iast_INACTIVE (448.851 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (472.561 µs) : 451, 494
. : milestone, 473,
tracing (447.243 µs) : 426, 468
. : milestone, 447,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	373.12 µs [352.868 µs, 393.372 µs]	-
iast	492.308 µs [470.579 µs, 514.036 µs]	119.187 µs (31.9%)
iast_FULL	646.279 µs [624.953 µs, 667.606 µs]	273.159 µs (73.2%)
iast_GLOBAL	517.502 µs [495.569 µs, 539.436 µs]	144.382 µs (38.7%)
iast_HARDCODED_SECRET_DISABLED	494.516 µs [472.305 µs, 516.728 µs]	121.396 µs (32.5%)
iast_INACTIVE	454.412 µs [433.1 µs, 475.724 µs]	81.292 µs (21.8%)
iast_TELEMETRY_OFF	482.521 µs [460.645 µs, 504.397 µs]	109.4 µs (29.3%)
tracing	448.905 µs [427.509 µs, 470.301 µs]	75.785 µs (20.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.403 µs [349.967 µs, 390.839 µs]	-
iast	488.132 µs [466.367 µs, 509.897 µs]	117.729 µs (31.8%)
iast_FULL	649.008 µs [627.248 µs, 670.767 µs]	278.605 µs (75.2%)
iast_GLOBAL	512.96 µs [491.533 µs, 534.387 µs]	142.557 µs (38.5%)
iast_HARDCODED_SECRET_DISABLED	493.336 µs [471.371 µs, 515.3 µs]	122.933 µs (33.2%)
iast_INACTIVE	448.851 µs [427.884 µs, 469.819 µs]	78.449 µs (21.2%)
iast_TELEMETRY_OFF	472.561 µs [451.425 µs, 493.697 µs]	102.158 µs (27.6%)
tracing	447.243 µs [426.113 µs, 468.373 µs]	76.84 µs (20.7%)

Request duration reports for petclinic

gantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~1569c69d4c, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1374
. : milestone, 1354,
appsec (1.746 ms) : 1723, 1770
. : milestone, 1746,
appsec_no_iast (1.735 ms) : 1710, 1760
. : milestone, 1735,
iast (1.487 ms) : 1465, 1510
. : milestone, 1487,
profiling (1.504 ms) : 1481, 1527
. : milestone, 1504,
tracing (1.493 ms) : 1468, 1518
. : milestone, 1493,
section candidate
no_agent (1.346 ms) : 1327, 1366
. : milestone, 1346,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.764 ms) : 1740, 1789
. : milestone, 1764,
iast (1.494 ms) : 1471, 1516
. : milestone, 1494,
profiling (1.533 ms) : 1507, 1558
. : milestone, 1533,
tracing (1.487 ms) : 1463, 1512
. : milestone, 1487,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.354 ms [1.335 ms, 1.374 ms]	-
appsec	1.746 ms [1.723 ms, 1.77 ms]	391.928 µs (28.9%)
appsec_no_iast	1.735 ms [1.71 ms, 1.76 ms]	380.347 µs (28.1%)
iast	1.487 ms [1.465 ms, 1.51 ms]	133.037 µs (9.8%)
profiling	1.504 ms [1.481 ms, 1.527 ms]	149.636 µs (11.0%)
tracing	1.493 ms [1.468 ms, 1.518 ms]	138.214 µs (10.2%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.346 ms [1.327 ms, 1.366 ms]	-
appsec	1.739 ms [1.715 ms, 1.763 ms]	392.377 µs (29.1%)
appsec_no_iast	1.764 ms [1.74 ms, 1.789 ms]	418.054 µs (31.0%)
iast	1.494 ms [1.471 ms, 1.516 ms]	147.364 µs (10.9%)
profiling	1.533 ms [1.507 ms, 1.558 ms]	186.239 µs (13.8%)
tracing	1.487 ms [1.463 ms, 1.512 ms]	140.757 µs (10.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ci/update-gradle-dependencies-20241215
git_commit_date	1734386576	1734435432
git_commit_sha	`721af2f`	1569c69d4c
release_version	1.45.0-SNAPSHOT~721af2f5a5	1.45.0-SNAPSHOT~1569c69d4c

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1734437253	1734437253
ci_job_id	741896645	741896645
ci_pipeline_id	51311714	51311714
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~1569c69d4c, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.355 ms) : 2313, 2396
. : milestone, 2355,
iast (2.086 ms) : 2034, 2139
. : milestone, 2086,
iast_GLOBAL (2.132 ms) : 2079, 2185
. : milestone, 2132,
profiling (1.962 ms) : 1919, 2005
. : milestone, 1962,
tracing (1.931 ms) : 1891, 1972
. : milestone, 1931,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (2.353 ms) : 2312, 2395
. : milestone, 2353,
iast (2.084 ms) : 2031, 2137
. : milestone, 2084,
iast_GLOBAL (2.142 ms) : 2088, 2196
. : milestone, 2142,
profiling (1.956 ms) : 1914, 1998
. : milestone, 1956,
tracing (1.932 ms) : 1891, 1972
. : milestone, 1932,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.481 ms]	-
appsec	2.355 ms [2.313 ms, 2.396 ms]	885.266 µs (60.3%)
iast	2.086 ms [2.034 ms, 2.139 ms]	616.924 µs (42.0%)
iast_GLOBAL	2.132 ms [2.079 ms, 2.185 ms]	662.992 µs (45.1%)
profiling	1.962 ms [1.919 ms, 2.005 ms]	492.632 µs (33.5%)
tracing	1.931 ms [1.891 ms, 1.972 ms]	461.935 µs (31.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	2.353 ms [2.312 ms, 2.395 ms]	877.416 µs (59.5%)
iast	2.084 ms [2.031 ms, 2.137 ms]	607.996 µs (41.2%)
iast_GLOBAL	2.142 ms [2.088 ms, 2.196 ms]	666.256 µs (45.1%)
profiling	1.956 ms [1.914 ms, 1.998 ms]	480.205 µs (32.5%)
tracing	1.932 ms [1.891 ms, 1.972 ms]	455.629 µs (30.9%)

Execution time for biojava

gantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~1569c69d4c, baseline=1.45.0-SNAPSHOT~721af2f5a5
dateFormat X
axisFormat %s
section baseline
no_agent (15.381 s) : 15381000, 15381000
. : milestone, 15381000,
appsec (15.047 s) : 15047000, 15047000
. : milestone, 15047000,
iast (18.951 s) : 18951000, 18951000
. : milestone, 18951000,
iast_GLOBAL (18.298 s) : 18298000, 18298000
. : milestone, 18298000,
profiling (14.74 s) : 14740000, 14740000
. : milestone, 14740000,
tracing (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
section candidate
no_agent (15.155 s) : 15155000, 15155000
. : milestone, 15155000,
appsec (15.183 s) : 15183000, 15183000
. : milestone, 15183000,
iast (19.034 s) : 19034000, 19034000
. : milestone, 19034000,
iast_GLOBAL (18.038 s) : 18038000, 18038000
. : milestone, 18038000,
profiling (14.915 s) : 14915000, 14915000
. : milestone, 14915000,
tracing (14.835 s) : 14835000, 14835000
. : milestone, 14835000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.381 s [15.381 s, 15.381 s]	-
appsec	15.047 s [15.047 s, 15.047 s]	-334.0 ms (-2.2%)
iast	18.951 s [18.951 s, 18.951 s]	3.57 s (23.2%)
iast_GLOBAL	18.298 s [18.298 s, 18.298 s]	2.917 s (19.0%)
profiling	14.74 s [14.74 s, 14.74 s]	-641.0 ms (-4.2%)
tracing	14.863 s [14.863 s, 14.863 s]	-518.0 ms (-3.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.155 s [15.155 s, 15.155 s]	-
appsec	15.183 s [15.183 s, 15.183 s]	28.0 ms (0.2%)
iast	19.034 s [19.034 s, 19.034 s]	3.879 s (25.6%)
iast_GLOBAL	18.038 s [18.038 s, 18.038 s]	2.883 s (19.0%)
profiling	14.915 s [14.915 s, 14.915 s]	-240.0 ms (-1.6%)
tracing	14.835 s [14.835 s, 14.835 s]	-320.0 ms (-2.1%)

pr-commenter · 2024-12-15T04:57:09Z

Kafka / producer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ci/update-gradle-dependencies-20241215
git_commit_date	1734447587	1734447939
git_commit_sha	`4e958f3`	`702ac0e`

See matching parameters

	Baseline	Candidate
ci_job_date	1734449011	1734449011
ci_job_id	742192622	742192622
ci_pipeline_id	51330358	51330358
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce	same

pr-commenter · 2024-12-15T05:09:41Z

Kafka / consumer-benchmark

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	ci/update-gradle-dependencies-20241215
git_commit_date	1734122972	1734435432
git_commit_sha	`efe39cc`	1569c69d4c6f75c8d1283dc53cd1d5240b160c4b

See matching parameters

	Baseline	Candidate
ci_job_date	1734436548	1734436548
ci_job_id	741896648	741896648
ci_pipeline_id	51311714	51311714
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion	11.0.25	11.0.25
jmhVersion	1.36	1.36
jvm	/usr/lib/jvm/java-11-openjdk-amd64/bin/java	/usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant	-Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName	OpenJDK 64-Bit Server VM	OpenJDK 64-Bit Server VM
vmVersion	11.0.25+9-post-Ubuntu-1ubuntu122.04	11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results

scenario	Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume	same

PerfectSlayer

Thank for the fixes!

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.50.0` -> `2.50.1` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.49.0` -> `2.49.1` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.59.0` -> `2.59.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.44.1` -> `1.45.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.47` -> `2.29.48` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.45.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.45.0): 1.45.0 ##### Breaking changes > \[!WARNING]\ > Support for custom scope manager using OpenTelemetry tracer artifact (`dd-trace-ot`) is dropped. > Tracing with OpenTracing API and custom scope manager will continue to work on 1.44.x releases. ##### Components ##### Application Security Management (IAST) - ✨ Add propagation to URI#toURL method ([#8146](DataDog/dd-trace-java#8146) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Increase IAST propagation to StringBuilder setLength ([#8119](DataDog/dd-trace-java#8119) - [@Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuffer append ([#8082](DataDog/dd-trace-java#8082) - [@Mariovido](https://github.com/Mariovido)) - ✨ Handle IAST security controls custom validation and sanitization methods ([#7997](DataDog/dd-trace-java#7997) - [@jandro996](https://github.com/jandro996)) ##### Application Security Management (WAF) - ✨ Update user lifecycle tracking to V3 ([#8108](DataDog/dd-trace-java#8108) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Exploit prevention for Shell Injection / Command Injection ([#7615](DataDog/dd-trace-java#7615) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 💡 Support instrumentation of repackaged libraries ([#8153](DataDog/dd-trace-java#8153) - [@mcculls](https://github.com/mcculls)) - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### Database Monitoring - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Dynamic Instrumentation - 🐛 make local var hoisting disabled by default ([#8158](DataDog/dd-trace-java#8158) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix var hoisting issue when no previous store ([#8122](DataDog/dd-trace-java#8122) - [@jpbempel](https://github.com/jpbempel)) - ✨ Only decorate spans without code origin information ([#8105](DataDog/dd-trace-java#8105) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix suspend Kotlin methods instrumentation ([#8080](DataDog/dd-trace-java#8080) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix class file version detection ([#8057](DataDog/dd-trace-java#8057) - [@jpbempel](https://github.com/jpbempel)) ##### GraalVM native-image - ✨ Configure native image build setting for JDK-22 based GraalVM ([#8092](DataDog/dd-trace-java#8092) - [@MattAlp](https://github.com/MattAlp)) ##### ML Observability (LLMObs) - ✨🧪 Add LLMObs configuration ([#8076](DataDog/dd-trace-java#8076) - [@gary-huang](https://github.com/gary-huang)) ##### Metrics - Bump integrations-core submodule to 7.60.0 ([#8098](DataDog/dd-trace-java#8098) - [@mcculls](https://github.com/mcculls)) - Upgrade to java-dogstatsd-client v4.4.3 ([#8096](DataDog/dd-trace-java#8096) - [@mcculls](https://github.com/mcculls)) ##### OpenTracing - ⚠️🧹 Remove custom scope manager support ([#8164](DataDog/dd-trace-java#8164) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Telemetry - ✨ Retry telemetry requests if CI Visibility is enabled ([#8147](DataDog/dd-trace-java#8147) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add configurable Dependency service resolution period ([#8079](DataDog/dd-trace-java#8079) - [@jandro996](https://github.com/jandro996)) ##### Testing - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### Tracer core - ✨ Defer remote components to avoid OkHttp class-loading side-effects ([#8131](DataDog/dd-trace-java#8131) - [@mcculls](https://github.com/mcculls)) - ✨ Improve Context API null handling and Javadoc ([#8129](DataDog/dd-trace-java#8129) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🐛⚡ Avoid performing blocking I/O operation on application thread ([#8120](DataDog/dd-trace-java#8120) - [@mcculls](https://github.com/mcculls)) - 💡 Introduce a shared context component, independent of tracing ([#8117](DataDog/dd-trace-java#8117) - [@mcculls](https://github.com/mcculls)) - ✨ Improves ServiceNameCollector ([#8109](DataDog/dd-trace-java#8109) - [@amarziali](https://github.com/amarziali)) - Upgrade to ASM 9.7.1 (adds new constant for Java 24) ([#8097](DataDog/dd-trace-java#8097) - [@mcculls](https://github.com/mcculls)) - 🐛 Dynamically evaluate service name for message consumers ([#8088](DataDog/dd-trace-java#8088) - [@amarziali](https://github.com/amarziali)) ##### Serverless - 🐛 Add avoid double instrumenting lambda non-streaming handlers. ([#8073](DataDog/dd-trace-java#8073) - [@purple4reina](https://github.com/purple4reina)) ##### Instrumentations ##### AWS SDK instrumentation - 💡 Instrument EMR's relocated AWS SDK ([#8157](DataDog/dd-trace-java#8157) - [@mcculls](https://github.com/mcculls)) ##### Eclipse Vert.x instrumentation - 🐛 Remove restriction to not run vertx4 latest tests on java 17 ([#8133](DataDog/dd-trace-java#8133) - [@vandonr](https://github.com/vandonr)) ##### JDBC instrumentation - ✨ Add full APM/DBM mode for Oracle ([#8090](DataDog/dd-trace-java#8090) - [@nenadnoveljic](https://github.com/nenadnoveljic)) ##### Jetty instrumentation - 🐛 Ensure jetty 12 has servlet.path starting with / ([#8093](DataDog/dd-trace-java#8093) - [@github-actions](https://github.com/github-actions)\[bot]) ##### JMS instrumentation - 🧹 Re-use `javax` JMS module for `jakarta` namespace ([#8155](DataDog/dd-trace-java#8155) - [@mcculls](https://github.com/mcculls)) - 🧹 Group `javax.jms` instrumentations under a single module ([#8154](DataDog/dd-trace-java#8154) - [@mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛 Reactor: early propagate span in context when subscribing ([#8166](DataDog/dd-trace-java#8166) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: ba2355aa4e2e39ab1fee27319cc4176238efd90b

github-actionsBot requested a review from a team as a code owner December 15, 2024 04:18

github-actionsBot added the tag: no release notes Changes to exclude from release notes label Dec 15, 2024

github-actionsBot requested a review from a team as a code owner December 15, 2024 04:18

github-actionsBot added the tag: dependencies Dependencies related changes label Dec 15, 2024

github-actionsBot requested a review from a team as a code owner December 15, 2024 04:18

github-actionsBot requested review from ValentinZakharov and manuel-alvarez-alvarez December 15, 2024 04:18

amarziali force-pushed the ci/update-gradle-dependencies-20241215 branch from 97c256f to 883f492Compare December 17, 2024 08:19

amarziali changed the title ~~Update Gradle dependencies~~Ensure jetty 12 has servlet.path starting with /Dec 17, 2024

amarziali added type: bug fix Bug fix inst: jetty Jetty instrumentation and removed tag: no release notes Changes to exclude from release notes labels Dec 17, 2024

amarziali force-pushed the ci/update-gradle-dependencies-20241215 branch 2 times, most recently from 1cbd1cf to 1569c69Compare December 17, 2024 11:37

github-actionsBotand others added 8 commits December 17, 2024 16:05

chore: Update Gradle dependencies
94bdefb

chore: Update Gradle dependencies
1da798c

chore: Update Gradle dependencies
50bddd0

chore: Update Gradle dependencies
5c6f87c

baseline latest cxf to java 17
320c9f9

Ensure servlet.path starts with /
689d2ea

fix min java version property
7bd51cc

reformat
702ac0e

amarziali force-pushed the ci/update-gradle-dependencies-20241215 branch from 1569c69 to 702ac0eCompare December 17, 2024 15:06

PerfectSlayer approved these changes Dec 17, 2024
View reviewed changes

amarziali enabled auto-merge (squash) December 17, 2024 15:32

amarziali merged commit 772d178 into masterDec 17, 2024

amarziali deleted the ci/update-gradle-dependencies-20241215 branch December 17, 2024 15:44

github-actionsBot added this to the 1.45.0 milestone Dec 17, 2024

Navigation Menu

Uh oh!

Ensure jetty 12 has servlet.path starting with / - #8093

Ensure jetty 12 has servlet.path starting with /#8093
amarziali merged 8 commits into
masterfrom
ci/update-gradle-dependencies-20241215

github-actionsBot commented Dec 15, 2024•
edited by amarziali
Loading

Uh oh!

pr-commenterBot commented Dec 15, 2024•
edited
Loading

Uh oh!

pr-commenterBot commented Dec 15, 2024•
edited
Loading

Uh oh!

pr-commenterBot commented Dec 15, 2024•
edited
Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

github-actionsBot commented Dec 15, 2024• edited by amarziali Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenterBot commented Dec 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

pr-commenterBot commented Dec 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kafka / producer-benchmark

Parameters

Summary

Uh oh!

pr-commenterBot commented Dec 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kafka / consumer-benchmark

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actionsBot commented Dec 15, 2024•
edited by amarziali
Loading

pr-commenterBot commented Dec 15, 2024•
edited
Loading

pr-commenterBot commented Dec 15, 2024•
edited
Loading

pr-commenterBot commented Dec 15, 2024•
edited
Loading