Matthew's autonomous - #75
Merged
Merged
Conversation
… and improved commands on path planner
ProfessorAtomicManiac
left a comment
Contributor
Author
There was a problem hiding this comment.
For the paths that are not auto-ruiners:
- You should be able to simultaneously move the arm + drive the robot to speed up the paths. The arm won't actually move that much since its only moving to the subwoofer position, so it shouldn't throw off driving.
- Since the intake command only stops once it detects a note, if you never pick up a note the entire auto would stop. Currently, you follow the path and in parallel run the intake command. If you want the intake command to stop running after the path is done, you could use a
Deadline Groupso the intake command stops when the path is done.
Contributor
Author
|
Also, its good to keep the other paths that only do one note, two note, etc. If we're with 254, we don't wanna run into them during auto |
Member
|
Once PR #68 gets merged, you should merge from master. That should fix the branch-out-of-date and (hopefully) the build failure. |
ProfessorAtomicManiac
left a comment
Contributor
Author
There was a problem hiding this comment.
I approve this PR. I cannot actually approve this since I'm the author, so someone else please do that for me.
Contributor
Author
|
oh wait i can override branch protections haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoting Matthew