refactor(core): thin leftover production/compatibility bridges - #705
Merged
Merged
Conversation
Delete zero-importer runCore* helpers from update-compatibility and inline the pass-through uninstall-compatibility wrapper into the uninstall command. Document KEEP rationale on retained production/compatibility facades required for frozen CLI contracts (no SDK expansion, no P3 upgrade rewrite).
Drswith
marked this pull request as ready for review
September 6, 2026 11:32
Drswith
deleted the
cursor/thin-production-compatibility-bridges-332b
branch
September 6, 2026 11:32
14 tasks
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-1.12 P2 cleanup: import-graph evaluation of leftover
src/services/*-productionandsrc/core/*-compatibilitybridges. Thin only what is proven redundant; keep facades required for frozen outward contracts.Intake: mechanical dead-bridge removal / no observable behavior — no new OpenSpec change.
Aligned with team freeze + QA refinement: delete only pure pass-through / zero-ref layers; KEEP anything with differential responsibility (projection, CLI observation/lock wrapping, stdio policy, dry-run shaping, etc.).
Inventory (import-graph proof)
src/core/uninstall-compatibility.tsuninstall.ts) → now callsexecuteCoreUninstall+createProductionCoreUninstallPortsdirectlyrunCoreSingleAgentUpdate/runCoreUpdateBatchinupdate-compatibility.tssrc/core/installation-compatibility.tscore-installation-cli.ts,lifecycle-execution-production.ts— outputPolicy injection + richer Core outcomes for v1 projectorsrc/core/update-compatibility.tslifecycle-updates-production.ts— prepare/run/dispose invocation enginesrc/core/installation-production.tsinstallation-compatibility,core/client.ts, contract tests — mutate/verify/lock/state portssrc/core/update-production.tsupdate-compatibilitydefaults; types used by lifecycle-updates-productionsrc/core/production-observation.tspackages/coreinternal)src/services/lifecycle-updates-production.tsupdate.ts,idempotency/lifecycle-policy.ts— CLI observation/lock + cancellation wrappingsrc/services/lifecycle-execution-production.tsrun.ts— human stdio inherit +--installvia installation-compatibilitysrc/services/doctor-diagnosis-production.tsdoctor.ts— CLI-coupled observations; Core diagnosis stays CLI-freesrc/services/self-upgrade-production.tsupgrade.ts— P3 out of scope; do not rewritesrc/commands/unmanaged-install-compatibility.tsinstall.ts,ensure.ts— frozen v1 no-op for unmanaged externalsKEEP rationale also recorded as short file comments on retained bridges.
Freeze confirmation
--json/--output, exit codes (incl. dry-runDRY_RUN/changed: false/ exit 0), no engine/route leak in JSON,--installenum, human stdio inherit for execinstall/ensure--dry-run --json→warnings[0].code=DRY_RUN,data.changed=false,ok=true, exit0, no top-level engine/route fieldsquantex-coreAPI expansion; no YAML /release-core.yml/ protect-mainOut of scope (explicit)
upgrade/ fix(upgrade): return NETWORK_ERROR when latest version cannot be resolved #700 /config/capabilities/commands/schema.github/workflows/**/release-core.yml/ protect-mainsrc/lifecyclemodulesLinked Artifacts
Validation
bun run memory:check(pre-push)bun run lintbun run format:checkbun run typecheckRelease Intent
Release Summary
Docs Updated
Scope Check
Closure Check
Notes