Skip to content

chore(lifecycle): prune zero-ref planners after dry-run Core preview - #704

Merged
Drswith merged 1 commit into
mainfrom
cursor/prune-zero-ref-planners-579d
Sep 6, 2026
Merged

chore(lifecycle): prune zero-ref planners after dry-run Core preview#704
Drswith merged 1 commit into
mainfrom
cursor/prune-zero-ref-planners-579d

Conversation

@Drswith

@Drswith Drswith commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

Post-1.12 P1 cleanup after #702: import-graph proof that no src/lifecycle
module became zero-reference when install/ensure --dry-run moved onto Core
preview. Delete none. Keep every still-imported module (including
update-planner, which remains on the update planning path). Archive the
completed P0 OpenSpec change route-install-ensure-dry-run-core-preview
(accepted deltas already live in openspec/specs/).

Intake: mechanical cleanup / no observable behavior — no new OpenSpec change.

Deleted vs kept

Module Result Remaining production importer(s)
agent-execution.ts KEEP src/core/execution-executor.ts (via barrel planAgentExecutionPreflight)
agent-observation.ts KEEP src/core/production-observation.ts, src/core/update-production.ts, src/services/lifecycle-observations.ts
model.ts KEEP src/state/*, Core install/uninstall/update, package-manager, services
provider-binding.ts KEEP Core install/uninstall/update/execution + core-installation-cli
provider-evidence.ts KEEP src/services/lifecycle-observations.ts, src/core/client.ts, idempotency/uninstall via barrel
uninstall-postcondition.ts KEEP src/core/uninstall-executor.ts
update-planner.ts KEEP src/planning/updates.ts, src/core/update-production.ts, src/services/lifecycle-updates-production.ts (update planning — not install/ensure dry-run)
index.ts KEEP barrel used by Core/services/idempotency

DELETE: none (0 zero-reference modules after #702).

Freeze confirmation

  • install/ensure --dry-run --json: warnings[0].code === "DRY_RUN", data.changed === false, ok: true, exit 0
  • JSON does not expose engine/route
  • Fixtures not loosened; targeted lifecycle / install / ensure / routing / update-planner tests green

Out of scope (explicit)

Linked Artifacts

Validation

  • bun run memory:check
  • bun run lint
  • bun run format:check
  • bun run typecheck
  • bun run openspec:validate
  • Targeted tests: lifecycle + install/ensure/routing + update-planner (262 pass)
  • Manual freeze smoke: install/ensure --dry-run --json → DRY_RUN / changed:false / exit 0
  • Full CI three-platform

Release Intent

  • Release: not applicable - docs/process/keep-comment cleanup only (no behavior change)

Release Summary

  • Not applicable - this source PR does not produce a release entry.

Docs Updated

  • openspec/... (archive closure of completed P0 change)
  • Not needed for product README

Scope Check

  • I did not add a new ad hoc root-level Markdown file.
  • I updated the relevant OpenSpec archive / keep comments.
  • I did not silently expand into P2/P3.

Closure Check

  • Working tree was clean after commit.
  • Branch was pushed and this PR is the active delivery artifact.
  • OpenSpec change archived (route-install-ensure-dry-run-core-preview); no new change required.
  • Release is not applicable.

Notes

  • update-planner looked like a dry-run leftover but still has production importers on the update path; hard-delete would break update planning.
  • Keep comments refreshed on update-planner.ts and uninstall-postcondition.ts for taxonomy + reviewer clarity.
Open in Web Open in Cursor 

Post-#702 import-graph proof: no src/lifecycle module has zero production
importers, so delete none. Keep update-planner for update planning paths
(not install/ensure dry-run). Archive completed OpenSpec change
route-install-ensure-dry-run-core-preview (specs already promoted).
@Drswith
Drswith marked this pull request as ready for review September 6, 2026 11:16
@Drswith
Drswith merged commit a37a6f0 into main Sep 6, 2026
11 checks passed
@Drswith
Drswith deleted the cursor/prune-zero-ref-planners-579d branch September 6, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants