chore: P5 prune zero-ref / pure pass-through leftovers - #710
Merged
Conversation
Drop leftover pass-through re-exports of Core execution and self-upgrade production from the services barrel. Commands already import those modules directly; the published v1 facade still re-exports agents and update planning. Co-authored-by: Drswith <Drswith@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-1.12 P5 cleanup after P0–P4 (#702–#709): repo-wide import-graph scan of leftover
src/lifecycle,src/services, and compatibility/production bridges. Delete only proven unused pass-through barrel re-exports; keep every still-imported module and every bridge that still adds differential behavior.Intake: mechanical unused-re-export cleanup / no observable behavior — no new OpenSpec change.
DELETE
src/services/index.tsre-exports ofexecuteAgentLifecycle+ execution types fromsrc/core/execution-executorrun.tsandlifecycle-execution-production.tsimport the Core engine directly. Not on the published CLI root (src/compatibility/index.ts/root-exports.json).src/services/index.tsre-exports ofcreateProductionLifecycleExecutionService+ typesrun.tsimports./lifecycle-execution-productiondirectly.src/services/index.tsre-exports ofcreateProductionSelfUpgradeInvocation+ typeupgrade.tsimports./self-upgrade-productiondirectly. Not an upgrade→Core rewrite.Ownership lock:
test/core/update-ownership.test.tsnow asserts the services barrel does not re-export those leftover paths and still exports the published v1 agents/update facade.Module-level zero-ref files: none (0 unused
src/modules after P0–P4).KEEP (re-scanned; still referenced and/or differential)
src/lifecycle/agent-execution.tssrc/core/execution-executor.tsvia barrel (planAgentExecutionPreflight— real preflight decisions)src/lifecycle/agent-observation.tssrc/lifecycle/model.tssrc/lifecycle/provider-binding.tscore-installation-clisrc/lifecycle/provider-evidence.tsobserveLifecycleProvider; not a pure re-exportsrc/lifecycle/uninstall-postcondition.tssrc/core/uninstall-executor.tssrc/lifecycle/update-planner.tssrc/planning/updates.ts, Core update-production, lifecycle-updates-production (update path — not install/ensure dry-run)src/lifecycle/index.tssrc/core/installation-compatibility.tssrc/core/update-compatibility.tssrc/core/installation-production.tssrc/core/update-production.tssrc/core/production-observation.tssrc/services/lifecycle-updates-production.tssrc/services/lifecycle-execution-production.ts--installvia installation-compatibilitysrc/services/doctor-diagnosis-production.tssrc/services/self-upgrade-production.tsupgrade.ts— do not move upgrade onto Coresrc/commands/unmanaged-install-compatibility.tssrc/compatibility/agent-inspection.tssrc/services/agents.ts/src/services/update.tssrc/services/index.tsagents + update re-exportssrc/compatibility/index.ts(published CLI surface)Same-file helpers that look unused from outside (
createProductionCoreUpdatePorts,updateAgentOutcome,shouldPrint, etc.) stay: they are live internals, not leftover bridges.Freeze confirmation
--json/--output, exit codes, dry-runDRY_RUN/changed: false/ exit 0, no engine/route leak in JSONquantex-coreAPI expansion; no YAML /release-core.yml/ protect-mainconfig/capabilities/commands/schemaout of scopeupgradenot moved onto CoreOut of scope (explicit)
.github/workflows/**/release-core.yml/ protect-mainsrc/lifecyclemodulesLinked Artifacts
Validation
bun run memory:check(pre-push)bun run lintbun run format:checkbun run typecheckbun run openspec:validate(pre-push)bun run test: 174 files / 2116 passed / 5 skippedinstall/ensure--dry-run --json→warnings[0].code=DRY_RUN,data.changed=false,ok=true, exit0, no top-levelengine/routerun_test_matrix=true/product-impacting(src/services + src/lifecycle)6cad43cRelease Intent
Release Summary
Docs Updated
Scope Check
Closure Check
Notes
src/modules; only unused services-barrel re-exports were pure pass-through leftovers.