') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [Java] Getter/Setter naming convention not followed in generated models by karismann · Pull Request #2095 · OpenAPITools/openapi-generator · GitHub
Skip to content

[Java] Getter/Setter naming convention not followed in generated models - #2095

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
karismann:issue-2085-java-getter-setter-naming-convention
Feb 18, 2019
Merged

[Java] Getter/Setter naming convention not followed in generated models#2095
wing328 merged 1 commit into
OpenAPITools:masterfrom
karismann:issue-2085-java-getter-setter-naming-convention

Conversation

@karismann

@karismannkarismann commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

fix the getter/setter when the second letter of the field name is already uppercase (following the JavaBeans API specification)

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    cc @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Description of the PR

[Java] Getter/Setter naming convention not followed in generated models #2085

fix the getter/setter when the second letter of the field name is already uppercase (following the JavaBeans API specification)

Details :
Override getterAndSetterCapitalize class in the AbstractJavaCodeGen class
Change Java test convert a model with a 2nd char upper-case property names (getter and setter expected results)

useful links :

@karismann
[Java] Getter/Setter naming convention not followed in generated models
da009c3
fix the getter/setter when the second letter of the field name is already uppercase (following the JavaBeans API specification)
@wing328wing328 added this to the 4.0.0 milestone Feb 18, 2019
@wing328

wing328 commented Feb 18, 2019

Copy link
Copy Markdown
Member

@karismann thanks for the PR. I think this may impact how users are currently consuming the Java client SDK but let's see if we hear any feedback to have an option to retain the old behavior.

@wing328
wing328 merged commit 594af33 into OpenAPITools:masterFeb 18, 2019
jimschubert added a commit that referenced this pull request Feb 23, 2019
@jimschubert
Merge branch 'master' into csharp-refactor-improvements
b38e317
* master: (40 commits)
[Python] remove default value from being fallback to example (#2213)
Add petstore integration tests to Ruby OAS3 client (#2211)
Gradle - make GenerateTask properties optional (#2185)
skip bats installation (#2198)
Something in the dependencies changed. This switch is no longer needed. (#1850)
Use oauth token for basic bearer auth in Rust. (#2161)
Fix missing nullable (#2189)
Enable error handling in Java WebClient library, fixes#1243 (#1244)
[core] fix referenced enum case (#2175)
rest-template: allow array parameters in path using collectionFormat (#2177)
update go petstore samples
Fix string types for cpprestsdk client generator (#1676)
update kotline samples
Remove API Key Authentication code for go when cookie is used. (#1601)
changed the package install instructions to install the .tgz package … (#1989)
okhttp-gson: allow array parameters in path using collectionFormat (#2137)
[Ruby] Fix regualr expression in error message (#2069) (#2139)
[kotlin][client] bytearray conversion (#2166)
[rust-server] Added client documentation to rust-server (#2159)
[Java] Getter/Setter naming convention not followed in generated models (#2095)
...
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@karismann@wing328
[Java] Getter/Setter naming convention not followed in generated mode…
e418331
…ls (OpenAPITools#2095)
fix the getter/setter when the second letter of the field name is already uppercase (following the JavaBeans API specification)
@karismann
karismann deleted the issue-2085-java-getter-setter-naming-convention branch March 10, 2019 12:53
@gregasgregas mentioned this pull request Feb 4, 2021
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Breaking change (without fallback)Client: JavaEnhancement: Code format

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@karismann@wing328