Skip to content

Fix missing nullable - #2189

Merged
wing328 merged 7 commits into
OpenAPITools:masterfrom
ackintosh:fix-missing-nullable
Feb 19, 2019
Merged

Fix missing nullable#2189
wing328 merged 7 commits into
OpenAPITools:masterfrom
ackintosh:fix-missing-nullable

Conversation

@ackintosh

@ackintoshackintosh commented Feb 19, 2019

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR closes#2119

@ackintoshackintosh added this to the 4.0.0 milestone Feb 19, 2019
@ackintosh

Copy link
Copy Markdown
ContributorAuthor

cc @OpenAPITools/generator-core-team

@wing328wing328 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328
wing328 merged commit 1d08296 into OpenAPITools:masterFeb 19, 2019
@ackintosh
ackintosh deleted the fix-missing-nullable branch February 20, 2019 00:19
jimschubert added a commit that referenced this pull request Feb 23, 2019
* master: (40 commits)
[Python] remove default value from being fallback to example (#2213)
Add petstore integration tests to Ruby OAS3 client (#2211)
Gradle - make GenerateTask properties optional (#2185)
skip bats installation (#2198)
Something in the dependencies changed. This switch is no longer needed. (#1850)
Use oauth token for basic bearer auth in Rust. (#2161)
Fix missing nullable (#2189)
Enable error handling in Java WebClient library, fixes#1243 (#1244)
[core] fix referenced enum case (#2175)
rest-template: allow array parameters in path using collectionFormat (#2177)
update go petstore samples
Fix string types for cpprestsdk client generator (#1676)
update kotline samples
Remove API Key Authentication code for go when cookie is used. (#1601)
changed the package install instructions to install the .tgz package … (#1989)
okhttp-gson: allow array parameters in path using collectionFormat (#2137)
[Ruby] Fix regualr expression in error message (#2069) (#2139)
[kotlin][client] bytearray conversion (#2166)
[rust-server] Added client documentation to rust-server (#2159)
[Java] Getter/Setter naming convention not followed in generated models (#2095)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Go] object nullable not working

2 participants

@ackintosh@wing328