Skip to content

okhttp-gson: allow array parameters in path using collectionFormat - #2137

Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom
jacobweber:arrayParams
Feb 18, 2019
Merged

okhttp-gson: allow array parameters in path using collectionFormat#2137
wing328 merged 2 commits into
OpenAPITools:masterfrom
jacobweber:arrayParams

Conversation

@jacobweber

Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

Description of the PR

Addresses #2125 for -g java -Dlibrary=okhttp-gson only.

I committed the result of running bin/java-petstore-okhttp-gson.sh. But I didn't commit the result of running bin/security/java-petstore-okhttp-gson.sh, because there were tons of changes there that I didn't introduce. I'm not sure what I'm supposed to do with them.

@auto-labeler

Copy link
Copy Markdown

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328wing328 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328wing328 added this to the 4.0.0 milestone Feb 18, 2019
@wing328
wing328 merged commit 534ff36 into OpenAPITools:masterFeb 18, 2019
jimschubert added a commit that referenced this pull request Feb 23, 2019
* master: (40 commits)
[Python] remove default value from being fallback to example (#2213)
Add petstore integration tests to Ruby OAS3 client (#2211)
Gradle - make GenerateTask properties optional (#2185)
skip bats installation (#2198)
Something in the dependencies changed. This switch is no longer needed. (#1850)
Use oauth token for basic bearer auth in Rust. (#2161)
Fix missing nullable (#2189)
Enable error handling in Java WebClient library, fixes#1243 (#1244)
[core] fix referenced enum case (#2175)
rest-template: allow array parameters in path using collectionFormat (#2177)
update go petstore samples
Fix string types for cpprestsdk client generator (#1676)
update kotline samples
Remove API Key Authentication code for go when cookie is used. (#1601)
changed the package install instructions to install the .tgz package … (#1989)
okhttp-gson: allow array parameters in path using collectionFormat (#2137)
[Ruby] Fix regualr expression in error message (#2069) (#2139)
[kotlin][client] bytearray conversion (#2166)
[rust-server] Added client documentation to rust-server (#2159)
[Java] Getter/Setter naming convention not followed in generated models (#2095)
...
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
…penAPITools#2137)
* okhttp-gson: allow array parameters in path using collectionFormat
* run bin/java-petstore-okhttp-gson-parcelable.sh
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacobweber@wing328