Uh oh!
There was an error while loading. Please reload this page.
Use oauth token for basic bearer auth in Rust. - #2161
Conversation
bjgill
commented
Feb 18, 2019
Thanks for the PR. I don't know much about authentication, so assume that you've verified that this works. I think the CI failure is spurious, so have restarted the build. Assuming it goes green, I'll give it a couple of days for other reviews, and then |
| req_builder = req_builder.bearer_auth(token.to_owned()); | ||
| }; | ||
| {{/isOAuth}} | ||
| {{#isBasicBearer}} |
There was a problem hiding this comment.
@boxdot thanks for the PR. I would suggest put this new block inside the {{#isBasic}} ... {{/isBasic}} block. What do you think?
And what about creating bearer_access_token instead or reusing oauth_access_token?
Some other clients are using access_token so it can be shared with OAuth, Bearer authentications.
There was a problem hiding this comment.
(I'm working with @boxdot)
I think having a single access_token also works, but I guess by adding bearer_access_token (see last commit in PR), we avoid breaking existing clients.
FYI. CircleCI error has been fixed in master. |
* master: (40 commits) [Python] remove default value from being fallback to example (#2213) Add petstore integration tests to Ruby OAS3 client (#2211) Gradle - make GenerateTask properties optional (#2185) skip bats installation (#2198) Something in the dependencies changed. This switch is no longer needed. (#1850) Use oauth token for basic bearer auth in Rust. (#2161) Fix missing nullable (#2189) Enable error handling in Java WebClient library, fixes#1243 (#1244) [core] fix referenced enum case (#2175) rest-template: allow array parameters in path using collectionFormat (#2177) update go petstore samples Fix string types for cpprestsdk client generator (#1676) update kotline samples Remove API Key Authentication code for go when cookie is used. (#1601) changed the package install instructions to install the .tgz package … (#1989) okhttp-gson: allow array parameters in path using collectionFormat (#2137) [Ruby] Fix regualr expression in error message (#2069) (#2139) [kotlin][client] bytearray conversion (#2166) [rust-server] Added client documentation to rust-server (#2159) [Java] Getter/Setter naming convention not followed in generated models (#2095) ...
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Use
req_builder.bearer_authinstead ofbasic_authwhenBearerAuthsecurity schema is specified.@frol, @farcaller, @bjgill