Uh oh!
There was an error while loading. Please reload this page.
[sqlparser-0.21] Update trimExpr members during planning - #3181
Merged
Conversation
andygrove
commented
Aug 18, 2022
Member
ayushdg
marked this pull request as ready for review
August 18, 2022 17:50
andygrove
commented
Aug 18, 2022
Member
@ayushdg Could you please rebase against |
ayushdgforce-pushed
the
update-trimexpr-sqlparser
branch
from
August 18, 2022 23:17
bd827f6 to
1e46ff8Compareayushdg
commented
Aug 18, 2022
ContributorAuthor
Done @andygrove! Lemme know if there's anything else needed for this pr. |
codecov-commenter
commented
Aug 19, 2022
Codecov Report
@@ Coverage Diff @@## sqlparser-0.21 #3181 +/- ##
==================================================
- Coverage 85.84% 85.84% -0.01%
==================================================
Files 291 291 Lines 52898 52898 ==================================================
- Hits 45411 45410 -1 - Misses 7487 7488 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andygrove
approved these changes
Aug 19, 2022
andygrove
commented
Aug 19, 2022
Member
It would be good to add some tests as well either in this PR or as a follow on PR. |
alamb
approved these changes
Aug 19, 2022
alamb pushed a commit
that referenced
this pull request
Aug 19, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (#3193) * Update planning for LIKE due to changes in sqlparser (#3194) * rename array function to make_array (#3199) * [sqlparser-0.21] Update trimExpr members during planning (#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (#3202) Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
MazterQyou pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193) * Update planning for LIKE due to changes in sqlparser (apache#3194) * rename array function to make_array (apache#3199) * [sqlparser-0.21] Update trimExpr members during planning (apache#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (apache#3202) Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
MazterQyou pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193) * Update planning for LIKE due to changes in sqlparser (apache#3194) * rename array function to make_array (apache#3199) * [sqlparser-0.21] Update trimExpr members during planning (apache#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (apache#3202) Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Extension of apache/datafusion-sqlparser-rs#568 into datafusion
Rationale for this change
Updates were made to sqlparser parsing logic apache/datafusion-sqlparser-rs#573 to handle optional trim flag and trim what Expr's better matching postgresql syntax.
What changes are included in this PR?
This pr updates the planner logic to handle the changes made to the struct members of Expr::Trim from sqlparser.
Are there any user-facing changes?
Note: Errors are related to other changes made in sqlparser around the handling of
like/ilikebeing addressed in #3101. Might need to consolidate both the changes in a single pr for tests to pass.