Uh oh!
There was an error while loading. Please reload this page.
[sqlparser-0.21] Update planning of LIKE expressions - #3194
Merged
andygrove merged 1 commit intoAug 18, 2022
Conversation
codecov-commenter
commented
Aug 18, 2022
Codecov Report
@@ Coverage Diff @@## sqlparser-0.21 #3194 +/- ##
==================================================
- Coverage 85.87% 85.84% -0.04%
==================================================
Files 291 291 Lines 52885 52898 +13 ==================================================
- Hits 45415 45410 -5 - Misses 7470 7488 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alamb
commented
Aug 18, 2022
Contributor
I think this one needs to be rebased |
andygroveforce-pushed
the
sqlparser-like-changes
branch
from
August 18, 2022 19:09
5f4d736 to
49900e4Compareandygrove
commented
Aug 18, 2022
MemberAuthor
@alamb This is now rebased |
alamb
approved these changes
Aug 18, 2022
alamb pushed a commit
that referenced
this pull request
Aug 19, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (#3193) * Update planning for LIKE due to changes in sqlparser (#3194) * rename array function to make_array (#3199) * [sqlparser-0.21] Update trimExpr members during planning (#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (#3202) Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
MazterQyou pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193) * Update planning for LIKE due to changes in sqlparser (apache#3194) * rename array function to make_array (apache#3199) * [sqlparser-0.21] Update trimExpr members during planning (apache#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (apache#3202) Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
MazterQyou pushed a commit
to cube-js/arrow-datafusion
that referenced
this pull request
Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193) * Update planning for LIKE due to changes in sqlparser (apache#3194) * rename array function to make_array (apache#3199) * [sqlparser-0.21] Update trimExpr members during planning (apache#3181) * Update sqlparser version to use main from git * Update SqlExpr::Trim struct to match latest sqlparser changes * use sqlparser 0.21 (apache#3202) Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3192
Rationale for this change
Keeping up with changes in sqlparser
What changes are included in this PR?
Likeis now a top-level expressionAre there any user-facing changes?
No