Skip to content

[sqlparser-0.21] Use released crate - #3202

Merged
andygrove merged 1 commit into
apache:sqlparser-0.21from
andygrove:sqlparser-patches
Aug 19, 2022
Merged

[sqlparser-0.21] Use released crate#3202
andygrove merged 1 commit into
apache:sqlparser-0.21from
andygrove:sqlparser-patches

Conversation

@andygrove

@andygroveandygrove commented Aug 19, 2022

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes#3192

Builds on #3181

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Aug 19, 2022
@andygroveandygrove changed the title Sqlparser patches[sqlparser-0.21] Use released crateAug 19, 2022
@andygroveandygrove mentioned this pull request Aug 19, 2022
5 tasks

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a rebase -- but I reviewed 8534b0a and it looks good to me 👍

@alamb

Copy link
Copy Markdown
Contributor

I took the liberty of rebasing this branch

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #3202 (1d3fb56) into sqlparser-0.21 (292ff5b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1d3fb56 differs from pull request most recent head 932d990. Consider uploading reports for the commit 932d990 to get more accurate results

@@ Coverage Diff @@## sqlparser-0.21 #3202 +/- ##
===============================================
Coverage 85.84% 85.84% ===============================================
Files 291 291 Lines 52898 52905 +7 ===============================================
+ Hits 45409 45417 +8 + Misses 7489 7488 -1 
Impacted FilesCoverage Δ
datafusion/core/tests/sql/expr.rs99.84% <ø> (+<0.01%)⬆️
datafusion/sql/src/planner.rs80.63% <100.00%> (+0.01%)⬆️
datafusion/expr/src/logical_plan/plan.rs77.60% <0.00%> (-0.18%)⬇️
datafusion/physical-expr/src/expressions/binary.rs97.71% <0.00%> (+0.12%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygrove

Copy link
Copy Markdown
MemberAuthor

Thank you @alamb!

@andygrove
andygrove merged commit 7752aa2 into apache:sqlparser-0.21Aug 19, 2022
@andygrove
andygrove deleted the sqlparser-patches branch August 19, 2022 11:23
alamb pushed a commit that referenced this pull request Aug 19, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (#3193)
* Update planning for LIKE due to changes in sqlparser (#3194)
* rename array function to make_array (#3199)
* [sqlparser-0.21] Update trimExpr members during planning (#3181)
* Update sqlparser version to use main from git
* Update SqlExpr::Trim struct to match latest sqlparser changes
* use sqlparser 0.21 (#3202)
Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
MazterQyou pushed a commit to cube-js/arrow-datafusion that referenced this pull request Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193)
* Update planning for LIKE due to changes in sqlparser (apache#3194)
* rename array function to make_array (apache#3199)
* [sqlparser-0.21] Update trimExpr members during planning (apache#3181)
* Update sqlparser version to use main from git
* Update SqlExpr::Trim struct to match latest sqlparser changes
* use sqlparser 0.21 (apache#3202)
Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
MazterQyou pushed a commit to cube-js/arrow-datafusion that referenced this pull request Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193)
* Update planning for LIKE due to changes in sqlparser (apache#3194)
* rename array function to make_array (apache#3199)
* [sqlparser-0.21] Update trimExpr members during planning (apache#3181)
* Update sqlparser version to use main from git
* Update SqlExpr::Trim struct to match latest sqlparser changes
* use sqlparser 0.21 (apache#3202)
Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion cratelogical-exprLogical plan and expressionssqlSQL Planner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andygrove@alamb@codecov-commenter