Skip to content

Upgrade to sqlparser 0.21 - #3200

Merged
alamb merged 5 commits into
masterfrom
sqlparser-0.21
Aug 19, 2022
Merged

Upgrade to sqlparser 0.21#3200
alamb merged 5 commits into
masterfrom
sqlparser-0.21

Conversation

@andygrove

@andygroveandygrove commented Aug 18, 2022•
edited by alamb
Loading

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes#3192
Closes#3205

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Aug 18, 2022
@github-actionsgithub-actionsBot added the physical-expr Changes to the physical-expr crates label Aug 18, 2022
@ayushdg
[sqlparser-0.21] Update trimExpr members during planning (#3181)
292ff5b
* Update sqlparser version to use main from git
* Update SqlExpr::Trim struct to match latest sqlparser changes
@codecov-commenter

codecov-commenter commented Aug 19, 2022•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3200 (7752aa2) into master (929eb6d) will decrease coverage by 0.02%.
The diff coverage is 57.69%.

@@ Coverage Diff @@## master #3200 +/- ##
==========================================
- Coverage 85.87% 85.85% -0.03% 
==========================================
Files 291 291 Lines 52885 52905 +20 ==========================================
+ Hits 45415 45419 +4 - Misses 7470 7486 +16
Impacted FilesCoverage Δ
datafusion/expr/src/expr_fn.rs91.01% <ø> (ø)
datafusion/proto/src/from_proto.rs35.27% <0.00%> (ø)
datafusion/proto/src/to_proto.rs52.84% <0.00%> (ø)
datafusion/sql/src/planner.rs80.63% <54.54%> (-0.62%)⬇️
datafusion/core/tests/sql/functions.rs100.00% <100.00%> (ø)
datafusion/expr/src/built_in_function.rs100.00% <100.00%> (ø)
datafusion/expr/src/function.rs97.75% <100.00%> (ø)
datafusion/physical-expr/src/functions.rs92.75% <100.00%> (ø)
datafusion/expr/src/logical_plan/plan.rs77.95% <0.00%> (+0.17%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygroveandygrove changed the title [WIP] Upgrade to sqlparser 0.21Upgrade to sqlparser 0.21Aug 19, 2022
@andygrove
andygrove marked this pull request as ready for review August 19, 2022 11:24
@andygrove

andygrove commented Aug 19, 2022

Copy link
Copy Markdown
MemberAuthor

@alamb This is finally ready for merging 😓

alamb
alamb approved these changes Aug 19, 2022
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb

alamb commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @andygrove@ayushdg !

@alamb
alamb merged commit 3c911ff into masterAug 19, 2022
@alamb
alamb deleted the sqlparser-0.21 branch August 19, 2022 13:10
@ursabot

ursabot commented Aug 19, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 929eb6d and contender = 3c911ff. 3c911ff is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@andygroveandygrove added the api change Changes the API exposed to users of the crate label Sep 2, 2022
MazterQyou pushed a commit to cube-js/arrow-datafusion that referenced this pull request Dec 1, 2022
@andygrove@ayushdg@MazterQyou
Upgrade sqlparser (apache#3200)
10e2ce2
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193)
* Update planning for LIKE due to changes in sqlparser (apache#3194)
* rename array function to make_array (apache#3199)
* [sqlparser-0.21] Update trimExpr members during planning (apache#3181)
* Update sqlparser version to use main from git
* Update SqlExpr::Trim struct to match latest sqlparser changes
* use sqlparser 0.21 (apache#3202)
Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
MazterQyou pushed a commit to cube-js/arrow-datafusion that referenced this pull request Dec 1, 2022
@andygrove@ayushdg@MazterQyou
Upgrade sqlparser (apache#3200)
e257063
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193)
* Update planning for LIKE due to changes in sqlparser (apache#3194)
* rename array function to make_array (apache#3199)
* [sqlparser-0.21] Update trimExpr members during planning (apache#3181)
* Update sqlparser version to use main from git
* Update SqlExpr::Trim struct to match latest sqlparser changes
* use sqlparser 0.21 (apache#3202)
Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alambalambalamb approved these changes

Assignees

No one assigned

Labels

api changeChanges the API exposed to users of the cratecoreCore DataFusion cratelogical-exprLogical plan and expressionsphysical-exprChanges to the physical-expr cratessqlSQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlparser 0.21 upgrade

5 participants

@andygrove@codecov-commenter@alamb@ursabot@ayushdg