HBASE-24624 Optimize table.jsp code by songxincun · Pull Request #1963 · apache/hbase

songxincun · 2020-06-24T09:20:15Z

No description provided.

Apache-HBase · 2020-06-24T09:32:34Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		2m 7s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1963/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1963
Optional Tests	dupname asflicense
uname	Linux f8f9865522d3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b556343`
Max. process+thread count	48 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1963/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-06-24T11:57:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 50s	master passed
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	135m 45s	hbase-server in the patch passed.
		147m 1s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1963/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#1963
Optional Tests	javac javadoc unit
uname	Linux ddf00970f7ee 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b556343`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1963/1/testReport/
Max. process+thread count	4636 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1963/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

guangxuCheng

LGTM +1

Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa)

* HBASE-24624 Optimize table.jsp code (#1963) Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa) * HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Pankaj Kumar<pankajkumar@apache.org> (cherry picked from commit 157200e) * HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d) * HBASE-20452 Master UI: Table merge button should validate required fields before submit Signed-off-by: tedyu <yuzhihong@gmail.com> (cherry picked from commit 6ce1136) --------- Co-authored-by: xincunSong <365724453@qq.com> Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com> Co-authored-by: Peng Lu <lupeng_nwpu@qq.com> Co-authored-by: Nihal Jain <nihaljain.cs@gmail.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nihal Jain <nihaljain.cs@gmail.com>

* HBASE-18382 add transport type info into Thrift UI (#880) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Viraj Jasani <virajjasani007@gmail.com> (cherry picked from commit 82e155e) * HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit ede4ccd) * HBASE-24624 Optimize table.jsp code (#1963) Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa) * HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Pankaj Kumar<pankajkumar@apache.org> (cherry picked from commit 157200e) * HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d) --------- Co-authored-by: Beata Sudi <bea0113@users.noreply.github.com> Co-authored-by: Nihal Jain <nihaljain@apache.org> Co-authored-by: xincunSong <365724453@qq.com> Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com> Co-authored-by: Peng Lu <lupeng_nwpu@qq.com> Signed-off-by: Nihal Jain <nihaljain@apache.org> Signed-off-by: Andrew Purtell <apurtell@apache.org>

* HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833) Signed-off-by: Andor Molnar <andor@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit dffc8e0) * HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer (#5215) Other changes: - Ensure info server stops during stop() - Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693) - Add hostname in the landing page instead of just port similar to other web UIs Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit a683fcf) * HBASE-18382 add transport type info into Thrift UI (#880) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Viraj Jasani <virajjasani007@gmail.com> (cherry picked from commit 82e155e) * HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit ede4ccd) * HBASE-24624 Optimize table.jsp code (#1963) Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa) * HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Pankaj Kumar<pankajkumar@apache.org> (cherry picked from commit 157200e) * HBASE-27309 Add major compact table or region operation on master web table page (#4793) Co-authored-by: zhengsicheng <zhengsicheng@jd.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit eb6b274) * HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d) * HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (#5620) Co-authored-by: Haosen Chen <haosenchen@tencent.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit e3a0174) * HBASE-20452 Master UI: Table merge button should validate required fields before submit Signed-off-by: tedyu <yuzhihong@gmail.com> (cherry picked from commit 6ce1136) * HBASE-29028 Removed Prometheus links from navbar as the feature (HBASE-20904) is not even supported by backend. --------- Co-authored-by: Luca Kovács <kovacs.luca.agota@gmail.com> Co-authored-by: Nihal Jain <nihaljain@apache.org> Co-authored-by: Beata Sudi <bea0113@users.noreply.github.com> Co-authored-by: xincunSong <365724453@qq.com> Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com> Co-authored-by: SiCheng-Zheng <643463623@qq.com> Co-authored-by: Peng Lu <lupeng_nwpu@qq.com> Co-authored-by: haosen chen <99318736+haosenchen@users.noreply.github.com> Co-authored-by: Nihal Jain <nihaljain.cs@gmail.com> Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

* HBASE-24624 Optimize table.jsp code (apache#1963) Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa) * HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (apache#2955) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Pankaj Kumar<pankajkumar@apache.org> (cherry picked from commit 157200e) * HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d) * HBASE-20452 Master UI: Table merge button should validate required fields before submit Signed-off-by: tedyu <yuzhihong@gmail.com> (cherry picked from commit 6ce1136) --------- Co-authored-by: xincunSong <365724453@qq.com> Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com> Co-authored-by: Peng Lu <lupeng_nwpu@qq.com> Co-authored-by: Nihal Jain <nihaljain.cs@gmail.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Nihal Jain <nihaljain.cs@gmail.com>

HBASE-24624 Optimize table.jsp code
1057000

infraio added the enhancement label Jun 24, 2020

guangxuCheng approved these changes Jun 30, 2020
View reviewed changes

infraio merged commit 9ad16aa into apache:masterJul 1, 2020

PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 13, 2024
HBASE-24624 Optimize table.jsp code (apache#1963)
551497b
Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa)

PDavid mentioned this pull request Dec 13, 2024
HBASE-29028 Backport missing UI patches to branch-2.5 #6542
Merged

PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 13, 2024
HBASE-24624 Optimize table.jsp code (apache#1963)
e1fad5c
Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa)

PDavid mentioned this pull request Dec 16, 2024
HBASE-29036 Backport missing UI patches to branch-2.6 #6546
Closed

PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 16, 2024
HBASE-24624 Optimize table.jsp code (apache#1963)
79a181e
Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa)

PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 16, 2024
HBASE-24624 Optimize table.jsp code (apache#1963)
69b54ab
Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa)

PDavid mentioned this pull request Dec 16, 2024
HBASE-29028 Backport missing UI patches to branch-2 #6548
Closed

PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 18, 2024
HBASE-24624 Optimize table.jsp code (apache#1963)
fc28cee
Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa)

PDavid mentioned this pull request Dec 18, 2024
HBASE-29036 Backport missing UI patches to branch-2.6 #6550
Merged

PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 18, 2024
HBASE-24624 Optimize table.jsp code (apache#1963)
3a16579
Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa)

PDavid mentioned this pull request Dec 18, 2024
HBASE-29037 Backport missing UI patches to branch-2 #6551
Merged

Navigation Menu

Uh oh!

HBASE-24624 Optimize table.jsp code - #1963

HBASE-24624 Optimize table.jsp code#1963
infraio merged 1 commit into
apache:masterfrom
songxincun:HBASE-24624

songxincun commented Jun 24, 2020

Uh oh!

Apache-HBase commented Jun 24, 2020

Uh oh!

Apache-HBase commented Jun 24, 2020

Uh oh!

guangxuCheng left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

songxincun commented Jun 24, 2020

Uh oh!

Apache-HBase commented Jun 24, 2020

Uh oh!

Apache-HBase commented Jun 24, 2020

Uh oh!

guangxuCheng left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants