HBASE-27814 Add support for dump and process metrics servlet in REST … by NihalJain · Pull Request #5215 · apache/hbase

NihalJain · 2023-05-03T12:07:47Z

…InfoServer

Other changes:

Ensure info server stops during stop()
Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693)
Add hostname in the landing page instead of just port similar to other web UIs

NihalJain · 2023-05-03T12:22:15Z

Started a local cluster and started HBase REST server.

Verified the landing page has the right page title, all the tabs are visible, hostname is displayed instead of portnumber and no error in page rendering.
- Before Patch:
- After Patch
Verified /logLevel page is fixed with appropriate tabs, as expected and shown in HBASE-20693
- Before Patch:
- After Patch
Verified newly added http://localhost:9093/processRest.jsp works as expected

Verified newly added http://localhost:9093/dump page works as expected

Sample page output

REST Server status for SOME_HOSTNAME,9092,1683113342961 as of Wed May 03 17:05:00 IST 2023
Version Info:
===========================================================
HBase 3.0.0-alpha-4-SNAPSHOT
Source code repository git://XXXX/Users/nihaljain/code/os/hbase revision=a814a2e70d6f440aabbea85027777240b5140ba8
Compiled by nihaljain on Wed May 3 16:44:26 IST 2023
From source with checksum 58bf02a2ad860d0d181b055736d30da333495012871c91398f10540c77b85a9d23c7b2254bf7f79309645ba8c0fda610aae460be7c2cfc05773bbdb55bcae1d5
Hadoop 3.2.4
Source code repository Unknown revision=7e5d9983b388e372fe640f21f048f2f2ae6e9eba
Compiled by ubuntu on 2022-07-12T11:58Z
Stacks:
===========================================================
Process Thread Dump: 28 active threads
Thread 44 (Session-Scheduler-3e8f7922-1):
State: TIMED_WAITING
Blocked count: 0
Waited count: 1
Stack:
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1093)
java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809)
java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
java.lang.Thread.run(Thread.java:748)
.
.
Thread 1 (main):
State: WAITING
Blocked count: 1
Waited count: 8
Waiting on java.lang.Object@348684ed
Stack:
java.lang.Object.wait(Native Method)
java.lang.Object.wait(Object.java:502)
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool.join(QueuedThreadPool.java:744)
org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.join(Server.java:566)
org.apache.hadoop.hbase.rest.RESTServer.join(RESTServer.java:432)
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:493)
REST Server configuration:
===========================================================
<?xml version="1.0" encoding="UTF-8" standalone="no"?><configuration>
<property><name>io.storefile.bloom.block.size</name><value>131072</value><final>false</final><source>hbase-default.xml</source></property>
<property><name>yarn.resourcemanager.opportunistic-container-allocation.enabled</name><value>false</value><final>false</final><source>yarn-default.xml</source></property>
.
.
</configuration>
Logs
===========================================================
+++++++++++++++++++++++++++++++
/Users/nihjain/Desktop/test/hbase-3.0.0-alpha-4-SNAPSHOT/bin/../logs/hbase-nihjain-rest-XXXX.log
+++++++++++++++++++++++++++++++
core file size (blocks, -c) 0
data seg size (kbytes, -d) unlimited
file size (blocks, -f) unlimited
max locked memory (kbytes, -l) unlimited
max memory size (kbytes, -m) unlimited
open files (-n) XXX
pipe size (XXX bytes, -p) 1
stack size (kbytes, -s) XXXX
cpu time (seconds, -t) unlimited
max user processes (-u) XXXX
virtual memory (kbytes, -v) unlimited
2023-05-03T16:59:01,742 INFO [main] RESTServer: ***** STARTING service 'RESTServer' *****
2023-05-03T16:59:01,766 INFO [main] util.VersionInfo: HBase 3.0.0-alpha-4-SNAPSHOT
2023-05-03T16:59:01,766 INFO [main] util.VersionInfo: Source code repository git://XXXX/Users/nihaljain/code/os/hbase revision=a814a2e70d6f440aabbea85027777240b5140ba8

Verified all other pages like /logs, /jmx, /conf works as before

Also tried the patch on a real cluster by building against 2.5.x and verified above points.

Apache-HBase · 2023-05-03T12:44:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 17s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 35s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	4m 31s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	4m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 21s	hbase-rest in the patch passed.
		23m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 080e62ab979e 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/1/testReport/
Max. process+thread count	1365 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-03T12:45:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 53s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	4m 23s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 46s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	4m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 17s	hbase-rest in the patch passed.
		24m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 78b2083755d9 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/1/testReport/
Max. process+thread count	1541 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-03T12:53:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 15s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 38s	master passed
+1 💚	compile	0m 24s	master passed
+1 💚	checkstyle	0m 9s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 25s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	0m 23s	the patch passed
-0 ⚠️	javac	0m 23s	hbase-rest generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154)
+1 💚	checkstyle	0m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 55s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		32m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 7361fdc9a79a 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-03T13:41:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 57s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 47s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	4m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	4m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 16s	hbase-rest in the patch passed.
		20m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux aba41de67454 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/2/testReport/
Max. process+thread count	1382 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-03T13:42:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 20s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 36s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	4m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 20s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	4m 26s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 26s	hbase-rest in the patch passed.
		21m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 11875bfdc996 5.4.0-137-generic #154-Ubuntu SMP Thu Jan 5 17:03:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/2/testReport/
Max. process+thread count	1359 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-05-03T13:51:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 17s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	checkstyle	0m 7s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 17s	the patch passed
+1 💚	compile	0m 23s	the patch passed
-0 ⚠️	javac	0m 23s	hbase-rest generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154)
+1 💚	checkstyle	0m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 7s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		30m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 63ef13c6b68a 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `21d61cf`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2023-06-15T08:06:43Z

Hi could someone please have a look at this, if familiar with REST web UI related code? I have attached screenshots post testing in the PR as well.
@petersomogyi , @wchevreuil, @apurtell, @ndimiduk

NihalJain · 2023-08-10T15:23:03Z

Hi @Reidddddd, are you familiar with web UI related code? If so, could you please help me with review for this?

Apache-HBase · 2023-08-10T15:50:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	4m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	4m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 26s	hbase-rest in the patch passed.
		20m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0c9151bccb69 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ab4b1d8`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/3/testReport/
Max. process+thread count	1568 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-10T15:53:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 56s	master passed
+1 💚	compile	0m 16s	master passed
+1 💚	shadedjars	5m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	5m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 10s	hbase-rest in the patch passed.
		23m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 53a1cf418a48 5.4.0-152-generic #169-Ubuntu SMP Tue Jun 6 22:23:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ab4b1d8`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/3/testReport/
Max. process+thread count	1660 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/3/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-08-10T15:54:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 49s	master passed
+1 💚	compile	0m 24s	master passed
+1 💚	checkstyle	0m 9s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	0m 22s	the patch passed
-0 ⚠️	javac	0m 22s	hbase-rest generated 2 new + 152 unchanged - 2 fixed = 154 total (was 154)
+1 💚	checkstyle	0m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	9m 33s	Patch does not cause any errors with Hadoop 3.2.4 3.3.5.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		24m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux f80271ffd086 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ab4b1d8`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/3/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk

Just some minor comments. Nice addition. Sorry to keep you waiting on the review.

NihalJain · 2024-01-10T11:07:21Z

I will rebase the code, re run all tests locally and if no issues found, will push this change as is tomorrow.

Action items based on review: https://issues.apache.org/jira/browse/HBASE-28300, https://issues.apache.org/jira/browse/HBASE-28299 will be taken up as follow up.

Apache-HBase · 2024-01-10T13:05:28Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 2s	master passed
+1 💚	compile	0m 29s	master passed
+1 💚	checkstyle	0m 12s	master passed
+1 💚	spotless	0m 45s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 32s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	0m 27s	the patch passed
-0 ⚠️	javac	0m 27s	hbase-rest generated 2 new + 163 unchanged - 2 fixed = 165 total (was 165)
+1 💚	checkstyle	0m 11s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	4m 53s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 37s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		21m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 02a4d11f817a 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0db4231`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/4/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-01-10T13:08:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 33s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 19s	master passed
+1 💚	compile	0m 15s	master passed
+1 💚	shadedjars	5m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 54s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	shadedjars	5m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 53s	hbase-rest in the patch passed.
		24m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 9900071308f7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0db4231`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/4/testReport/
Max. process+thread count	1625 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-01-10T13:10:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 8s	master passed
+1 💚	compile	0m 23s	master passed
+1 💚	shadedjars	6m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 21s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
+1 💚	shadedjars	6m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 17s	hbase-rest in the patch passed.
		26m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fd6b007b0340 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0db4231`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/4/testReport/
Max. process+thread count	1746 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/4/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…InfoServer

NihalJain · 2024-01-13T14:25:43Z

Rebased code to let CI build the change again. Also will retest the change locally.

Apache-HBase · 2024-01-13T14:48:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 14s	master passed
+1 💚	compile	0m 25s	master passed
+1 💚	checkstyle	0m 9s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 44s	the patch passed
+1 💚	compile	0m 24s	the patch passed
-0 ⚠️	javac	0m 24s	hbase-rest generated 2 new + 163 unchanged - 2 fixed = 165 total (was 165)
+1 💚	checkstyle	0m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	5m 5s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 33s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		21m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux dcfc2f8b64c6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e3a0174`
Default Java	Eclipse Adoptium-11.0.17+8
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-rest.txt
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/5/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-01-13T14:48:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 0s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 45s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	shadedjars	5m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 37s	hbase-rest in the patch passed.
		21m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b53a090eb0ce 5.4.0-166-generic #183-Ubuntu SMP Mon Oct 2 11:28:33 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e3a0174`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/5/testReport/
Max. process+thread count	1524 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-01-13T14:55:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 11s	master passed
+1 💚	compile	0m 22s	master passed
+1 💚	shadedjars	6m 54s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 15s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	0m 22s	the patch passed
+1 💚	javac	0m 22s	the patch passed
+1 💚	shadedjars	6m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 16s	the patch passed
		_ Other Tests _
+1 💚	unit	5m 30s	hbase-rest in the patch passed.
		28m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5215
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6ccf760a56f5 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e3a0174`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/5/testReport/
Max. process+thread count	1642 (vs. ulimit of 30000)
modules	C: hbase-rest U: hbase-rest
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5215/5/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-01-13T16:36:32Z

Started a local cluster and started HBase REST server.

Verified the landing page has the right page title, all the tabs are visible, hostname is displayed instead of portnumber and no error in page rendering.
- Before Patch:
- After Patch
Verified /logLevel page is fixed with appropriate tabs, as expected and shown in HBASE-20693
- Before Patch:
- After Patch
Verified newly added http://localhost:9093/processRest.jsp works as expected

Verified newly added http://localhost:9093/dump page works as expected

Sample page output

REST Server status for SOME_HOSTNAME,9092,1683113342961 as of Wed May 03 17:05:00 IST 2023
Version Info:
===========================================================
HBase 3.0.0-alpha-4-SNAPSHOT
Source code repository git://XXXX/Users/nihaljain/code/os/hbase revision=a814a2e70d6f440aabbea85027777240b5140ba8
Compiled by nihaljain on Wed May 3 16:44:26 IST 2023
From source with checksum 58bf02a2ad860d0d181b055736d30da333495012871c91398f10540c77b85a9d23c7b2254bf7f79309645ba8c0fda610aae460be7c2cfc05773bbdb55bcae1d5
Hadoop 3.2.4
Source code repository Unknown revision=7e5d9983b388e372fe640f21f048f2f2ae6e9eba
Compiled by ubuntu on 2022-07-12T11:58Z
Stacks:
===========================================================
Process Thread Dump: 28 active threads
Thread 44 (Session-Scheduler-3e8f7922-1):
State: TIMED_WAITING
Blocked count: 0
Waited count: 1
Stack:
sun.misc.Unsafe.park(Native Method)
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:1093)
java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.take(ScheduledThreadPoolExecutor.java:809)
java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1074)
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
java.lang.Thread.run(Thread.java:748)
.
.
Thread 1 (main):
State: WAITING
Blocked count: 1
Waited count: 8
Waiting on java.lang.Object@348684ed
Stack:
java.lang.Object.wait(Native Method)
java.lang.Object.wait(Object.java:502)
org.apache.hbase.thirdparty.org.eclipse.jetty.util.thread.QueuedThreadPool.join(QueuedThreadPool.java:744)
org.apache.hbase.thirdparty.org.eclipse.jetty.server.Server.join(Server.java:566)
org.apache.hadoop.hbase.rest.RESTServer.join(RESTServer.java:432)
org.apache.hadoop.hbase.rest.RESTServer.main(RESTServer.java:493)
REST Server configuration:
===========================================================
<?xml version="1.0" encoding="UTF-8" standalone="no"?><configuration>
<property><name>io.storefile.bloom.block.size</name><value>131072</value><final>false</final><source>hbase-default.xml</source></property>
<property><name>yarn.resourcemanager.opportunistic-container-allocation.enabled</name><value>false</value><final>false</final><source>yarn-default.xml</source></property>
.
.
</configuration>
Logs
===========================================================
+++++++++++++++++++++++++++++++
/Users/nihjain/Desktop/test/hbase-3.0.0-alpha-4-SNAPSHOT/bin/../logs/hbase-nihjain-rest-XXXX.log
+++++++++++++++++++++++++++++++
core file size (blocks, -c) 0
data seg size (kbytes, -d) unlimited
file size (blocks, -f) unlimited
max locked memory (kbytes, -l) unlimited
max memory size (kbytes, -m) unlimited
open files (-n) XXX
pipe size (XXX bytes, -p) 1
stack size (kbytes, -s) XXXX
cpu time (seconds, -t) unlimited
max user processes (-u) XXXX
virtual memory (kbytes, -v) unlimited
2023-05-03T16:59:01,742 INFO [main] RESTServer: ***** STARTING service 'RESTServer' *****
2023-05-03T16:59:01,766 INFO [main] util.VersionInfo: HBase 3.0.0-alpha-4-SNAPSHOT
2023-05-03T16:59:01,766 INFO [main] util.VersionInfo: Source code repository git://XXXX/Users/nihaljain/code/os/hbase revision=a814a2e70d6f440aabbea85027777240b5140ba8

Verified all other pages like /logs, /jmx, /conf works as before

Also tried the patch on a real cluster by building against 2.5.x and verified above points.

Reverfied all of this. I also wrote a simple postman collection for basic CRUD test for REST at https://gist.github.com/NihalJain/7db91823bd140e41953a88eb3df56eae

Can we keep this inside test resources of hbase REST? Might be useful for others as well. Please let me know what you think.
CC: @ndimiduk

NihalJain · 2024-01-14T06:30:26Z

@bbeaudreault please let me know if you want this in 2.6.

…InfoServer (#5215) Other changes: - Ensure info server stops during stop() - Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693) - Add hostname in the landing page instead of just port similar to other web UIs Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit a683fcf)

ndimiduk · 2024-01-15T07:41:43Z

@NihalJain

Can we keep this inside test resources of hbase REST? Might be useful for others as well. Please let me know what you think.

You mean keep the postman config definition? Can it be used for an automated testing? I've used postman before, for API development and manual testing, but I've never tried to wire it up to a maven test phase. I am in favor of improving our test coverage if it's lacking.

ndimiduk · 2024-01-15T07:42:09Z

Thanks a lot for seeing this one through, and for taking the time to file follow-up issues !

NihalJain · 2024-02-29T11:45:59Z

@bbeaudreault please let me know if you want this in 2.6.

I will pull this in branch-2.6, it is unreleased yet. And its best to keep code in sync in branch-2.6+. Also I plan to do more fixes around this in future (for eg @ndimiduk review comments), all of which may go over same code and hence we would have to skip them for branch-2.6, which is a bad idea.

…InfoServer (apache#5215) Other changes: - Ensure info server stops during stop() - Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693) - Add hostname in the landing page instead of just port similar to other web UIs Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit a683fcf)

* HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833) Signed-off-by: Andor Molnar <andor@apache.org> Signed-off-by: Balazs Meszaros <meszibalu@apache.org> (cherry picked from commit dffc8e0) * HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer (#5215) Other changes: - Ensure info server stops during stop() - Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693) - Add hostname in the landing page instead of just port similar to other web UIs Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit a683fcf) * HBASE-18382 add transport type info into Thrift UI (#880) Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org> Signed-off-by: Bharath Vissapragada <bharathv@apache.org> Signed-off-by: Viraj Jasani <virajjasani007@gmail.com> (cherry picked from commit 82e155e) * HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> (cherry picked from commit ede4ccd) * HBASE-24624 Optimize table.jsp code (#1963) Signed-off-by: Guangxu Cheng <gxcheng@apache.org> (cherry picked from commit 9ad16aa) * HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955) Signed-off-by: Duo Zhang <zhangduo@apache.org> Signed-off-by: Pankaj Kumar<pankajkumar@apache.org> (cherry picked from commit 157200e) * HBASE-27309 Add major compact table or region operation on master web table page (#4793) Co-authored-by: zhengsicheng <zhengsicheng@jd.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit eb6b274) * HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit 3caaf2d) * HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (#5620) Co-authored-by: Haosen Chen <haosenchen@tencent.com> Signed-off-by: Duo Zhang <zhangduo@apache.org> (cherry picked from commit e3a0174) * HBASE-20452 Master UI: Table merge button should validate required fields before submit Signed-off-by: tedyu <yuzhihong@gmail.com> (cherry picked from commit 6ce1136) * HBASE-29028 Removed Prometheus links from navbar as the feature (HBASE-20904) is not even supported by backend. --------- Co-authored-by: Luca Kovács <kovacs.luca.agota@gmail.com> Co-authored-by: Nihal Jain <nihaljain@apache.org> Co-authored-by: Beata Sudi <bea0113@users.noreply.github.com> Co-authored-by: xincunSong <365724453@qq.com> Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com> Co-authored-by: SiCheng-Zheng <643463623@qq.com> Co-authored-by: Peng Lu <lupeng_nwpu@qq.com> Co-authored-by: haosen chen <99318736+haosenchen@users.noreply.github.com> Co-authored-by: Nihal Jain <nihaljain.cs@gmail.com> Signed-off-by: Andrew Purtell <apurtell@apache.org> Signed-off-by: Nihal Jain <nihaljain@apache.org>

NihalJain commented May 3, 2023
View reviewed changes

Comment threadhbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTServer.java Outdated

NihalJain force-pushed the HBASE-27814 branch from 6f0f28a to 380d029Compare May 3, 2023 13:10

ndimiduk approved these changes Sep 7, 2023
View reviewed changes

Comment threadhbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTDumpServlet.java
Comment threadhbase-rest/src/main/java/org/apache/hadoop/hbase/rest/RESTDumpServlet.java
Comment threadhbase-rest/src/main/resources/hbase-webapps/rest/processRest.jsp

HBASE-27814 Add support for dump and process metrics servlet in REST …
52926d0
…InfoServer

NihalJain force-pushed the HBASE-27814 branch from 380d029 to 52926d0Compare January 13, 2024 14:24

NihalJain merged commit a683fcf into apache:masterJan 14, 2024

PDavid mentioned this pull request Dec 13, 2024
HBASE-29028 Backport missing UI patches to branch-2.5 #6542
Merged

Uh oh!

Conversation

NihalJain commented May 3, 2023

Uh oh!

NihalJain commented May 3, 2023

Uh oh!

Apache-HBase commented May 3, 2023

Uh oh!

Apache-HBase commented May 3, 2023

Uh oh!

Apache-HBase commented May 3, 2023

Uh oh!

Uh oh!

Apache-HBase commented May 3, 2023

Uh oh!

Apache-HBase commented May 3, 2023

Uh oh!

Apache-HBase commented May 3, 2023

Uh oh!

NihalJain commented Jun 15, 2023

Uh oh!

NihalJain commented Aug 10, 2023

Uh oh!

Apache-HBase commented Aug 10, 2023

Uh oh!

Apache-HBase commented Aug 10, 2023

Uh oh!

Apache-HBase commented Aug 10, 2023

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NihalJain commented Jan 10, 2024

Uh oh!

Apache-HBase commented Jan 10, 2024

Uh oh!

Apache-HBase commented Jan 10, 2024

Uh oh!

Apache-HBase commented Jan 10, 2024

Uh oh!

NihalJain commented Jan 13, 2024

Uh oh!

Apache-HBase commented Jan 13, 2024

Uh oh!

Apache-HBase commented Jan 13, 2024

Uh oh!

Apache-HBase commented Jan 13, 2024

Uh oh!

NihalJain commented Jan 13, 2024

Uh oh!

NihalJain commented Jan 14, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndimiduk commented Jan 15, 2024

Uh oh!

ndimiduk commented Jan 15, 2024

Uh oh!

NihalJain commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NihalJain commented Jan 14, 2024•
edited
Loading