Skip to content

HBASE-25402 HBase UI: sorting order by start key or end key is not considering empty start key/end key - #2955

Merged
pankaj72981 merged 1 commit into
apache:masterfrom
AkshayTSudheer:HBASE-25402
Mar 3, 2021
Merged

HBASE-25402 HBase UI: sorting order by start key or end key is not considering empty start key/end key#2955
pankaj72981 merged 1 commit into
apache:masterfrom
AkshayTSudheer:HBASE-25402

Conversation

@AkshayTSudheer

Copy link
Copy Markdown
Contributor

HBASE-25402 HBase UI: sorting order by start key or end key is not considering empty start key/end key

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall3m 55smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 26sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
9m 42s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2955
Optional Testsdupname asflicense javac
unameLinux d1405a625d5a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b2f85e5
Default JavaAdoptOpenJDK-1.8.0_232-b09
Max. process+thread count78 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 51sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 19smaster passed
+1 💚javadoc0m 43smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 4sthe patch passed
+1 💚javadoc0m 41sthe patch passed
_ Other Tests _
-1 ❌unit7m 58shbase-server in the patch failed.
23m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2955
Optional Testsjavac javadoc unit
unameLinux dfa2d60aef07 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b2f85e5
Default JavaAdoptOpenJDK-11.0.6+10
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/1/testReport/
Max. process+thread count715 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 52smaster passed
+1 💚javadoc0m 39smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 33sthe patch passed
+1 💚javadoc0m 38sthe patch passed
_ Other Tests _
+1 💚unit148m 48shbase-server in the patch passed.
160m 48s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2955
Optional Testsjavac javadoc unit
unameLinux 55265d78f18b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b2f85e5
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/1/testReport/
Max. process+thread count4173 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall5m 7smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 29sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
_ Other Tests _
+1 💚asflicense0m 16sThe patch does not generate ASF License warnings.
12m 32s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#2955
Optional Testsdupname asflicense javac
unameLinux d05a33075d4f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1beda0d
Default JavaAdoptOpenJDK-1.8.0_232-b09
Max. process+thread count78 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 4sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 40smaster passed
+1 💚javadoc0m 45smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 20sthe patch passed
+1 💚javadoc0m 43sthe patch passed
_ Other Tests _
+1 💚unit132m 52shbase-server in the patch passed.
149m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#2955
Optional Testsjavac javadoc unit
unameLinux 6143f21b7add 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1beda0d
Default JavaAdoptOpenJDK-11.0.6+10
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/2/testReport/
Max. process+thread count4402 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 6sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 26smaster passed
+1 💚javadoc0m 38smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 32sthe patch passed
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
+1 💚unit148m 45shbase-server in the patch passed.
160m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#2955
Optional Testsjavac javadoc unit
unameLinux 8c0d035c101a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 1beda0d
Default JavaAdoptOpenJDK-1.8.0_232-b09
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/2/testReport/
Max. process+thread count4437 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2955/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981pankaj72981 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pankaj72981

Copy link
Copy Markdown
Contributor

@Apache9 .. Please have a look.

@pankaj72981
pankaj72981 requested a review from Apache9March 1, 2021 06:36
@pankaj72981
pankaj72981 merged commit 157200e into apache:masterMar 3, 2021
PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 13, 2024
…empty start key/end key (apache#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 16, 2024
…empty start key/end key (apache#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 16, 2024
…empty start key/end key (apache#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 16, 2024
…empty start key/end key (apache#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 18, 2024
…empty start key/end key (apache#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 18, 2024
…empty start key/end key (apache#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
NihalJain pushed a commit that referenced this pull request Dec 24, 2024
* HBASE-24624 Optimize table.jsp code (#1963)
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
(cherry picked from commit 9ad16aa)
* HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
* HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 3caaf2d)
* HBASE-20452 Master UI: Table merge button should validate required fields before submit
Signed-off-by: tedyu <yuzhihong@gmail.com>
(cherry picked from commit 6ce1136)
---------
Co-authored-by: xincunSong <365724453@qq.com>
Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com>
Co-authored-by: Peng Lu <lupeng_nwpu@qq.com>
Co-authored-by: Nihal Jain <nihaljain.cs@gmail.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nihal Jain <nihaljain.cs@gmail.com>
NihalJain pushed a commit that referenced this pull request Jan 8, 2025
* HBASE-18382 add transport type info into Thrift UI (#880)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
(cherry picked from commit 82e155e)
* HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732)
- Fixes the way logLevel page renders in UI
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit ede4ccd)
* HBASE-24624 Optimize table.jsp code (#1963)
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
(cherry picked from commit 9ad16aa)
* HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
* HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 3caaf2d)
---------
Co-authored-by: Beata Sudi <bea0113@users.noreply.github.com>
Co-authored-by: Nihal Jain <nihaljain@apache.org>
Co-authored-by: xincunSong <365724453@qq.com>
Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com>
Co-authored-by: Peng Lu <lupeng_nwpu@qq.com>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
NihalJain pushed a commit that referenced this pull request Jan 8, 2025
* HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833)
Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
* HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer (#5215)
Other changes:
- Ensure info server stops during stop()
- Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693)
- Add hostname in the landing page instead of just port similar to other web UIs
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a683fcf)
* HBASE-18382 add transport type info into Thrift UI (#880)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
(cherry picked from commit 82e155e)
* HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732)
- Fixes the way logLevel page renders in UI
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit ede4ccd)
* HBASE-24624 Optimize table.jsp code (#1963)
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
(cherry picked from commit 9ad16aa)
* HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
* HBASE-27309 Add major compact table or region operation on master web table page (#4793)
Co-authored-by: zhengsicheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit eb6b274)
* HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 3caaf2d)
* HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (#5620)
Co-authored-by: Haosen Chen <haosenchen@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit e3a0174)
* HBASE-20452 Master UI: Table merge button should validate required fields before submit
Signed-off-by: tedyu <yuzhihong@gmail.com>
(cherry picked from commit 6ce1136)
* HBASE-29028 Removed Prometheus links from navbar as the feature (HBASE-20904) is not even supported by backend.
---------
Co-authored-by: Luca Kovács <kovacs.luca.agota@gmail.com>
Co-authored-by: Nihal Jain <nihaljain@apache.org>
Co-authored-by: Beata Sudi <bea0113@users.noreply.github.com>
Co-authored-by: xincunSong <365724453@qq.com>
Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com>
Co-authored-by: SiCheng-Zheng <643463623@qq.com>
Co-authored-by: Peng Lu <lupeng_nwpu@qq.com>
Co-authored-by: haosen chen <99318736+haosenchen@users.noreply.github.com>
Co-authored-by: Nihal Jain <nihaljain.cs@gmail.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
mokai87 pushed a commit to mokai87/hbase that referenced this pull request Aug 7, 2025
* HBASE-24624 Optimize table.jsp code (apache#1963)
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
(cherry picked from commit 9ad16aa)
* HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (apache#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
* HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (apache#6152)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 3caaf2d)
* HBASE-20452 Master UI: Table merge button should validate required fields before submit
Signed-off-by: tedyu <yuzhihong@gmail.com>
(cherry picked from commit 6ce1136)
---------
Co-authored-by: xincunSong <365724453@qq.com>
Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com>
Co-authored-by: Peng Lu <lupeng_nwpu@qq.com>
Co-authored-by: Nihal Jain <nihaljain.cs@gmail.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Nihal Jain <nihaljain.cs@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@AkshayTSudheer@Apache-HBase@pankaj72981@Apache9