Skip to content

HBASE-27406 Make "/prometheus" endpoint accessible from HBase UI - #4833

Merged
meszibalu merged 1 commit into
apache:masterfrom
lucakovacs:HBASE-27406
Oct 20, 2022
Merged

HBASE-27406 Make "/prometheus" endpoint accessible from HBase UI#4833
meszibalu merged 1 commit into
apache:masterfrom
lucakovacs:HBASE-27406

Conversation

@lucakovacs

@lucakovacslucakovacs commented Oct 17, 2022

Copy link
Copy Markdown
Contributor

Before this change, Prometheus metrics were only accessible via the '/prometheus' endpoint.

I made changes in the UI, so instead of Metrics Dump there's a dropdown menu called Metrics with the JMX and Prometheus metrics.

I also included the metrics description, so there are four endpoints available from there:

  • JMX
  • JMX with description
  • Prometheus
  • Prometheus with description

Apache JIRA:https://issues.apache.org/jira/browse/HBASE-27406

@Apache-HBase

Apache-HBase commented Oct 17, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 18smaster passed
+1 💚spotless0m 38sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 2sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 36spatch has no errors when running spotless:check.
_ Other Tests _
+1 💚asflicense0m 21sThe patch does not generate ASF License warnings.
8m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4833
Optional Testsdupname asflicense javac spotless
unameLinux 801624ec7a90 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b68229c
Default JavaTemurin-1.8.0_345-b01
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 17, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 56sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall2m 20smaster passed
+1 💚javadoc1m 1smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 13sthe patch passed
+1 💚javadoc1m 0sthe patch passed
_ Other Tests _
+1 💚unit213m 13shbase-server in the patch passed.
+1 💚unit8m 43shbase-thrift in the patch passed.
+1 💚unit3m 26shbase-rest in the patch passed.
234m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4833
Optional Testsjavac javadoc unit
unameLinux 0c890954de29 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b68229c
Default JavaTemurin-1.8.0_345-b01
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/testReport/
Max. process+thread count2657 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Oct 17, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 2sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall3m 28smaster passed
+1 💚javadoc1m 15smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 16sthe patch passed
+1 💚javadoc1m 19sthe patch passed
_ Other Tests _
+1 💚unit238m 14shbase-server in the patch passed.
+1 💚unit7m 12shbase-thrift in the patch passed.
+1 💚unit4m 22shbase-rest in the patch passed.
262m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4833
Optional Testsjavac javadoc unit
unameLinux 0d9ffc01c3e5 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / b68229c
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/testReport/
Max. process+thread count2737 (vs. ulimit of 30000)
modulesC: hbase-server hbase-thrift hbase-rest U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4833/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

anmolnar
anmolnar approved these changes Oct 19, 2022
View reviewed changes

@anmolnaranmolnar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@meszibalu
meszibalu merged commit dffc8e0 into apache:masterOct 20, 2022
asfgit pushed a commit that referenced this pull request Oct 20, 2022
@lucakovacs@meszibalu
HBASE-27406Make /prometheus endpoint accessible from HBase UI (#4833)
a31b148
Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@lucakovacsLuca Kovacs
HBASE-27406 Make /prometheus endpoint accessible from HBase UI (apach…
c23f541
…e#4833)
Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
(cherry picked from commit a31b148)
Change-Id: Id24f0f4215fe5bd46a5ace61ae33c5ee9c1ecebb
@PDavidPDavid mentioned this pull request Dec 12, 2024
Merged
PDavid pushed a commit to PDavid/hbase that referenced this pull request Dec 12, 2024
@lucakovacs@PDavid
HBASE-27406 Make /prometheus endpoint accessible from HBase UI (apach…
137c6dc
…e#4833)
Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
@PDavidPDavid mentioned this pull request Dec 13, 2024
Merged
NihalJain pushed a commit that referenced this pull request Jan 8, 2025
@PDavid
HBASE-29028Backport missing UI patches to branch-2.5 (#6542)
526bad7
* HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833)
Signed-off-by: Andor Molnar <andor@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit dffc8e0)
* HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer (#5215)
Other changes:
- Ensure info server stops during stop()
- Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693)
- Add hostname in the landing page instead of just port similar to other web UIs
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit a683fcf)
* HBASE-18382 add transport type info into Thrift UI (#880)
Signed-off-by: Wellington Chevreuil <wchevreuil@apache.org>
Signed-off-by: Bharath Vissapragada <bharathv@apache.org>
Signed-off-by: Viraj Jasani <virajjasani007@gmail.com>
(cherry picked from commit 82e155e)
* HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732)
- Fixes the way logLevel page renders in UI
Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>
(cherry picked from commit ede4ccd)
* HBASE-24624 Optimize table.jsp code (#1963)
Signed-off-by: Guangxu Cheng <gxcheng@apache.org>
(cherry picked from commit 9ad16aa)
* HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Pankaj Kumar<pankajkumar@apache.org>
(cherry picked from commit 157200e)
* HBASE-27309 Add major compact table or region operation on master web table page (#4793)
Co-authored-by: zhengsicheng <zhengsicheng@jd.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit eb6b274)
* HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152)
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit 3caaf2d)
* HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (#5620)
Co-authored-by: Haosen Chen <haosenchen@tencent.com>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
(cherry picked from commit e3a0174)
* HBASE-20452 Master UI: Table merge button should validate required fields before submit
Signed-off-by: tedyu <yuzhihong@gmail.com>
(cherry picked from commit 6ce1136)
* HBASE-29028 Removed Prometheus links from navbar as the feature (HBASE-20904) is not even supported by backend.
---------
Co-authored-by: Luca Kovács <kovacs.luca.agota@gmail.com>
Co-authored-by: Nihal Jain <nihaljain@apache.org>
Co-authored-by: Beata Sudi <bea0113@users.noreply.github.com>
Co-authored-by: xincunSong <365724453@qq.com>
Co-authored-by: Akshay Sudheer <74921542+AkshayTSudheer@users.noreply.github.com>
Co-authored-by: SiCheng-Zheng <643463623@qq.com>
Co-authored-by: Peng Lu <lupeng_nwpu@qq.com>
Co-authored-by: haosen chen <99318736+haosenchen@users.noreply.github.com>
Co-authored-by: Nihal Jain <nihaljain.cs@gmail.com>
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Nihal Jain <nihaljain@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmolnaranmolnaranmolnar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucakovacs@Apache-HBase@anmolnar@meszibalu