Skip to content

HBASE-25629 Reimplement TestCurrentHourProvider to not depend on unst… - #3013

Merged
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-25629
Mar 10, 2021
Merged

HBASE-25629 Reimplement TestCurrentHourProvider to not depend on unst…#3013
Apache9 merged 1 commit into
apache:masterfrom
Apache9:HBASE-25629

Conversation

@Apache9

Copy link
Copy Markdown
Contributor

…able TZs

@Apache9
Apache9 requested a review from apurtellMarch 4, 2021 09:12
@Apache9Apache9 self-assigned this Mar 4, 2021
@Apache9

Copy link
Copy Markdown
ContributorAuthor

Use 3 time zones to verify the current hour logic, UTC, US/Pacific(DST) and GMT+8. I think this is enough for verifying the logic for CurrentHourProvider, and these 3 TimeZones should be stable for most time I believe.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 47sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+1 💚mvninstall4m 57smaster passed
+1 💚compile3m 58smaster passed
+1 💚checkstyle1m 31smaster passed
+1 💚spotbugs2m 37smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 30sthe patch passed
+1 💚compile3m 43sthe patch passed
+1 💚javac3m 43sthe patch passed
+1 💚checkstyle1m 20shbase-server: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck22m 37sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs2m 34sthe patch passed
_ Other Tests _
+1 💚asflicense0m 14sThe patch does not generate ASF License warnings.
58m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3013/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3013
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 5eacd51ce1b5 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 830d289
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3013/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=3.1.12
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 8sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall3m 43smaster passed
+1 💚compile0m 56smaster passed
+1 💚shadedjars6m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 38smaster passed
_ Patch Compile Tests _
+1 💚mvninstall3m 28sthe patch passed
+1 💚compile0m 57sthe patch passed
+1 💚javac0m 56sthe patch passed
+1 💚shadedjars6m 35spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 35sthe patch passed
_ Other Tests _
+1 💚unit141m 20shbase-server in the patch passed.
171m 6s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3013/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3013
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7feeeab59e94 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 830d289
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3013/1/testReport/
Max. process+thread count4349 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3013/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 4sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚mvninstall4m 21smaster passed
+1 💚compile1m 7smaster passed
+1 💚shadedjars6m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 43smaster passed
_ Patch Compile Tests _
+1 💚mvninstall4m 6sthe patch passed
+1 💚compile1m 6sthe patch passed
+1 💚javac1m 6sthe patch passed
+1 💚shadedjars6m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 40sthe patch passed
_ Other Tests _
+1 💚unit146m 46shbase-server in the patch passed.
178m 45s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3013/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3013
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b74c62913325 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 830d289
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3013/1/testReport/
Max. process+thread count4005 (vs. ulimit of 30000)
modulesC: hbase-server U: hbase-server
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3013/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ddupgddupg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Apache9
Apache9 merged commit d79019b into apache:masterMar 10, 2021
Apache9 added a commit that referenced this pull request Mar 10, 2021
…able TZs (#3013)
Signed-off-by: XinSun <ddupgs@gmail.com>
Apache9 added a commit that referenced this pull request Mar 10, 2021
…able TZs (#3013)
Signed-off-by: XinSun <ddupgs@gmail.com>
petersomogyi pushed a commit that referenced this pull request Mar 20, 2021
…able TZs (#3013)
Signed-off-by: XinSun <ddupgs@gmail.com>
petersomogyi pushed a commit that referenced this pull request Mar 20, 2021
…able TZs (#3013)
Signed-off-by: XinSun <ddupgs@gmail.com>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
…able TZs (apache#3013)
Signed-off-by: XinSun <ddupgs@gmail.com>
(cherry picked from commit 9242a3d)
Change-Id: I41299b9257854f32b0baee1eedd4b2e9e3e5c544
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9@Apache-HBase@ddupg