HBASE-25861 Correct the usage of Configuration#addDeprecation by ZhaoBQ · Pull Request #3249 · apache/hbase

ZhaoBQ · 2021-05-10T02:54:04Z

No description provided.

Apache-HBase · 2021-05-10T03:58:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 52s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 49s	master passed
+1 💚	compile	5m 28s	master passed
+1 💚	checkstyle	2m 1s	master passed
+1 💚	spotbugs	4m 13s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 38s	the patch passed
+1 💚	compile	5m 24s	the patch passed
+1 💚	javac	5m 24s	the patch passed
-0 ⚠️	checkstyle	0m 24s	hbase-common: The patch generated 3 new + 4 unchanged - 1 fixed = 7 total (was 5)
-0 ⚠️	checkstyle	1m 5s	hbase-server: The patch generated 3 new + 101 unchanged - 9 fixed = 104 total (was 110)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	18m 16s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	4m 56s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 48s	The patch does not generate ASF License warnings.
		63m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname	Linux 5e57c6812672 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8c2332d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-10T06:45:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 54s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	shadedjars	8m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 38s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 40s	the patch passed
+1 💚	compile	2m 16s	the patch passed
+1 💚	javac	2m 16s	the patch passed
+1 💚	shadedjars	8m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 40s	hbase-common in the patch passed.
-1 ❌	unit	168m 26s	hbase-server in the patch failed.
+1 💚	unit	12m 57s	hbase-mapreduce in the patch passed.
+1 💚	unit	10m 50s	hbase-backup in the patch passed.
		230m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 15db92e8c7ad 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8c2332d`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/testReport/
Max. process+thread count	4788 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-10T08:37:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 22s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 56s	master passed
+1 💚	compile	2m 39s	master passed
+1 💚	shadedjars	9m 5s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 46s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 43s	the patch passed
+1 💚	compile	2m 39s	the patch passed
+1 💚	javac	2m 39s	the patch passed
+1 💚	shadedjars	9m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 12s	hbase-common in the patch passed.
-1 ❌	unit	265m 55s	hbase-server in the patch failed.
+1 💚	unit	18m 3s	hbase-mapreduce in the patch passed.
+1 💚	unit	14m 4s	hbase-backup in the patch passed.
		342m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 87b6c914856d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8c2332d`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/testReport/
Max. process+thread count	3231 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce hbase-backup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk

@ZhaoBQ this change is great!

My comments are entirely around preserving and not growing our public API surface area. You touch several classes that are InterfaceAudience.Public, so care must be taken to not alter their APIs.

One other idea: with javdoc, you can use '{@value ...}' instead of {@link ...} and the value of the constant will be generated into the Javadoc. In this case, printing the rendered string value of the configuration point is preferable to the symbol expression that stores the value. For an example look in org.apache.hadoop.hbase.master.normalizer.package-info.java.

ndimiduk · 2021-05-10T18:08:18Z

+ */
+ @Deprecated
+ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.CONFIG)
+ public static final String RS_HOSTNAME_KEY = "hbase.regionserver.hostname";


There's no reason to add all these constants to this HConstants class; it's better if we don't expand our public interface if we can avoid it. I think it would be better to use the configuration string values directly in the new HBaseConfiguration#addDeprecatedKeys().
Please do preserve the comments about removal target release.

I agree w/ the Nick comment.
This file of all the constants is a bit of an anti-pattern... should have gone away long ago.... Was hoping it would shrivel but it hasn't. Don't pour water on it (smile).

ndimiduk · 2021-05-10T18:26:32Z


 package org.apache.hadoop.hbase.io;

+import static org.apache.hadoop.hbase.HConstants.ALLOCATOR_POOL_ENABLED_KEY;


My above suggestion would mean that these symbols simply don't exist anymore for tests to make use of. I think this is preferable, if test's make use of the "public" api of the product, not the classes. This way, if a configuration key is changed in the class, and that configuration key is used by value in the test, the test would presumably fail.
So in this case, the test will define new constants that contain these configuration key strings.

ndimiduk · 2021-05-10T18:28:12Z

 public static final String MOB_DIR_NAME = "mobdir";
 public static final String MOB_REGION_NAME = ".mob";
 public static final byte[] MOB_REGION_NAME_BYTES = Bytes.toBytes(MOB_REGION_NAME);
- public static final String MOB_CLEANER_PERIOD = "hbase.master.mob.cleaner.period";


Unfortunately this class in InterfaceAudience.Public, so these symbols cannot change.

ZhaoBQ · 2021-05-11T11:39:14Z

Thanks @ndimiduk and @saintstack for review. It's cleaner after using the configuration string values directly in the HBaseConfiguration#addDeprecatedKeys().

Apache-HBase · 2021-05-11T12:33:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 1s	master passed
+1 💚	compile	4m 50s	master passed
+1 💚	checkstyle	1m 48s	master passed
+1 💚	spotbugs	3m 28s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 37s	the patch passed
+1 💚	compile	4m 44s	the patch passed
+1 💚	javac	4m 44s	the patch passed
+1 💚	checkstyle	0m 25s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	1m 1s	hbase-server: The patch generated 0 new + 44 unchanged - 3 fixed = 44 total (was 47)
+1 💚	checkstyle	0m 19s	The patch passed checkstyle in hbase-mapreduce
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	18m 11s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	4m 4s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 40s	The patch does not generate ASF License warnings.
		56m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname	Linux 9c05cb9c344c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2b6a91a`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-11T14:42:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 24s	master passed
+1 💚	compile	2m 7s	master passed
+1 💚	shadedjars	8m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 28s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 12s	the patch passed
+1 💚	compile	2m 5s	the patch passed
+1 💚	javac	2m 5s	the patch passed
+1 💚	shadedjars	8m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 26s	the patch passed
		_ Other Tests _
-1 ❌	unit	1m 14s	hbase-common in the patch failed.
+1 💚	unit	138m 21s	hbase-server in the patch passed.
+1 💚	unit	9m 56s	hbase-mapreduce in the patch passed.
		185m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cf7b0e4b0c04 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2b6a91a`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-common.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/testReport/
Max. process+thread count	4921 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-11T14:56:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 53s	master passed
+1 💚	compile	1m 51s	master passed
+1 💚	shadedjars	8m 18s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 18s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	1m 50s	the patch passed
+1 💚	javac	1m 50s	the patch passed
+1 💚	shadedjars	8m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 19s	the patch passed
		_ Other Tests _
-1 ❌	unit	1m 5s	hbase-common in the patch failed.
+1 💚	unit	153m 32s	hbase-server in the patch passed.
+1 💚	unit	10m 36s	hbase-mapreduce in the patch passed.
		200m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6d22ae748b90 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2b6a91a`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-common.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/testReport/
Max. process+thread count	4636 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2021-05-11T22:41:29Z

Thanks @ndimiduk and @saintstack for review. It's cleaner after using the configuration string values directly in the HBaseConfiguration#addDeprecatedKeys().

Yes, this looks much better. It seems the test failure is related though, mind taking a look? If the jenkins test result screen doesn't include enough information for you, you can download all the test logs.

Apache-HBase · 2021-05-12T07:08:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 25s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 33s	master passed
+1 💚	compile	4m 48s	master passed
+1 💚	checkstyle	1m 44s	master passed
+1 💚	spotbugs	3m 30s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	4m 45s	the patch passed
+1 💚	javac	4m 45s	the patch passed
+1 💚	checkstyle	0m 23s	The patch passed checkstyle in hbase-common
+1 💚	checkstyle	1m 4s	hbase-server: The patch generated 0 new + 44 unchanged - 3 fixed = 44 total (was 47)
+1 💚	checkstyle	0m 18s	The patch passed checkstyle in hbase-mapreduce
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	17m 50s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	4m 6s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		55m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml
uname	Linux f0392e70d68b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `630c73f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-12T09:19:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 28s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 11s	master passed
+1 💚	compile	2m 6s	master passed
+1 💚	shadedjars	8m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 25s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 15s	the patch passed
+1 💚	compile	2m 8s	the patch passed
+1 💚	javac	2m 8s	the patch passed
+1 💚	shadedjars	8m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 1s	hbase-common in the patch passed.
+1 💚	unit	139m 22s	hbase-server in the patch passed.
+1 💚	unit	9m 55s	hbase-mapreduce in the patch passed.
		187m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 271d5ef26790 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `630c73f`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/3/testReport/
Max. process+thread count	4936 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-12T09:40:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	master passed
+1 💚	compile	1m 51s	master passed
+1 💚	shadedjars	8m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 16s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 42s	the patch passed
+1 💚	compile	1m 56s	the patch passed
+1 💚	javac	1m 56s	the patch passed
+1 💚	shadedjars	8m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 21s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 39s	hbase-common in the patch passed.
+1 💚	unit	160m 12s	hbase-server in the patch passed.
+1 💚	unit	11m 24s	hbase-mapreduce in the patch passed.
		207m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 07cfe9bb8e22 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `630c73f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/3/testReport/
Max. process+thread count	4625 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-12T17:40:02Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 19s	master passed
+1 💚	compile	9m 17s	master passed
+1 💚	checkstyle	2m 23s	master passed
+0 🆗	refguide	3m 54s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	15m 8s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 18s	the patch passed
+1 💚	compile	9m 2s	the patch passed
+1 💚	javac	9m 2s	the patch passed
+1 💚	checkstyle	2m 10s	root: The patch generated 0 new + 49 unchanged - 3 fixed = 49 total (was 52)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+0 🆗	refguide	3m 47s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	23m 8s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	14m 46s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 46s	The patch does not generate ASF License warnings.
		104m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml refguide
uname	Linux ec342c39cba5 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `630c73f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/artifact/yetus-general-check/output/branch-site/book.html
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	126 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-12T22:14:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 45s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 16s	master passed
+1 💚	compile	4m 4s	master passed
+1 💚	shadedjars	10m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	6m 6s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 10s	the patch passed
+1 💚	compile	4m 2s	the patch passed
+1 💚	javac	4m 2s	the patch passed
+1 💚	shadedjars	10m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	5m 45s	the patch passed
		_ Other Tests _
+1 💚	unit	315m 50s	root in the patch passed.
		378m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 66664184eade 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `630c73f`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/testReport/
Max. process+thread count	4383 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-12T22:33:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 24s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 53s	master passed
+1 💚	compile	2m 36s	master passed
+1 💚	shadedjars	8m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 25s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 42s	the patch passed
+1 💚	compile	2m 35s	the patch passed
+1 💚	javac	2m 35s	the patch passed
+1 💚	shadedjars	8m 10s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	358m 12s	root in the patch failed.
		398m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2a807c53bc9d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `630c73f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/testReport/
Max. process+thread count	6050 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ZhaoBQ · 2021-05-13T02:40:54Z

The failed UTs can pass in my local env.

ndimiduk

I agree these test failures look unrelated.

I have one more request of you for this change, which is to preserve the comments regarding the deprecations in their new location. The reason is we will eventually file tickets to remove the old configs, and it's important to track when the deprecations were first added. These comments will help future maintainers track the exact version when the old configs can be deleted.

…t configured, the logs will still be printed

Apache-HBase · 2021-05-14T10:30:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 34s	master passed
+1 💚	compile	8m 13s	master passed
+1 💚	checkstyle	1m 56s	master passed
+0 🆗	refguide	3m 31s	branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	spotbugs	12m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 35s	the patch passed
+1 💚	compile	8m 16s	the patch passed
+1 💚	javac	8m 16s	the patch passed
+1 💚	checkstyle	1m 55s	root: The patch generated 0 new + 49 unchanged - 3 fixed = 49 total (was 52)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+0 🆗	refguide	3m 21s	patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚	hadoopcheck	17m 44s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	13m 29s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 53s	The patch does not generate ASF License warnings.
		88m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml refguide
uname	Linux b8b983fb4164 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0955a7a`
Default Java	AdoptOpenJDK-1.8.0_282-b08
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/artifact/yetus-general-check/output/branch-site/book.html
refguide	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count	141 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-14T14:06:22Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 57s	master passed
+1 💚	compile	3m 17s	master passed
+1 💚	shadedjars	9m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 31s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 44s	the patch passed
+1 💚	compile	3m 19s	the patch passed
+1 💚	javac	3m 19s	the patch passed
+1 💚	shadedjars	9m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	4m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	256m 45s	root in the patch passed.
		304m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 61cf5506e7f2 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0955a7a`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/testReport/
Max. process+thread count	4631 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-14T15:30:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 54s	master passed
+1 💚	compile	2m 34s	master passed
+1 💚	shadedjars	8m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 23s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 34s	the patch passed
+1 💚	compile	2m 34s	the patch passed
+1 💚	javac	2m 34s	the patch passed
+1 💚	shadedjars	8m 8s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	3m 21s	the patch passed
		_ Other Tests _
-1 ❌	unit	349m 16s	root in the patch failed.
		388m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3249
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ab45d64efbcf 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0955a7a`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/testReport/
Max. process+thread count	5725 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server hbase-mapreduce . U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3249/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…#3249) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

Co-authored-by: Baiqiang Zhao <zbq.dean@gmail.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

…#3249)" This reverts commit aab6e1d.

ndimiduk requested changes May 10, 2021
View reviewed changes

ZhaoBQ force-pushed the HBASE-25861 branch from 42d86bb to fcec908Compare May 11, 2021 11:35

ndimiduk mentioned this pull request May 11, 2021
HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name #3063
Merged

ndimiduk reviewed May 13, 2021
View reviewed changes

Comment threadsrc/main/asciidoc/_chapters/offheap_read_write.adoc
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Comment threadhbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java

ZhaoBQ added 4 commits May 14, 2021 16:20

HBASE-25861 Correct the usage of Configuration#addDeprecation
566caa5

fix failed test
9dc51dc

remove wrong logs, because even if the deprecated configuration is no…
14d2db1
…t configured, the logs will still be printed

Keep the original doc
d294c17

ZhaoBQ force-pushed the HBASE-25861 branch from 662c1a9 to d294c17Compare May 14, 2021 09:00

ndimiduk approved these changes May 14, 2021
View reviewed changes

ndimiduk merged commit d69d5c2 into apache:masterMay 14, 2021

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request May 14, 2021
HBASE-25861 Correct the usage of Configuration#addDeprecation (apache…
7614a9e
…#3249) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request May 17, 2021
HBASE-25861 Correct the usage of Configuration#addDeprecation (apache…
dd03b98
…#3249) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk added a commit that referenced this pull request May 18, 2021
HBASE-25861Correct the usage of Configuration#addDeprecation (#3249)
aab6e1d
Co-authored-by: Baiqiang Zhao <zbq.dean@gmail.com> Signed-off-by: Nick Dimiduk <ndimiduk@apache.org>

ndimiduk added a commit that referenced this pull request May 19, 2021
Revert "HBASE-25861Correct the usage of Configuration#addDeprecation (…
a8980a4
…#3249)" This reverts commit aab6e1d.


		package org.apache.hadoop.hbase.io;

		import static org.apache.hadoop.hbase.HConstants.ALLOCATOR_POOL_ENABLED_KEY;

Uh oh!

Conversation

ZhaoBQ commented May 10, 2021

Uh oh!

Apache-HBase commented May 10, 2021

Uh oh!

Apache-HBase commented May 10, 2021

Uh oh!

Apache-HBase commented May 10, 2021

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

ndimidukMay 10, 2021

Choose a reason for hiding this comment

Uh oh!

saintstackMay 10, 2021

Choose a reason for hiding this comment

Uh oh!

ndimidukMay 10, 2021

Choose a reason for hiding this comment

Uh oh!

ndimidukMay 10, 2021

Choose a reason for hiding this comment

Uh oh!

ZhaoBQ commented May 11, 2021

Uh oh!

Apache-HBase commented May 11, 2021

Uh oh!

Apache-HBase commented May 11, 2021

Uh oh!

Apache-HBase commented May 11, 2021

Uh oh!

ndimiduk commented May 11, 2021

Uh oh!

Apache-HBase commented May 12, 2021

Uh oh!

Apache-HBase commented May 12, 2021

Uh oh!

Apache-HBase commented May 12, 2021

Uh oh!

Apache-HBase commented May 12, 2021

Uh oh!

Apache-HBase commented May 12, 2021

Uh oh!

Apache-HBase commented May 12, 2021

Uh oh!

ZhaoBQ commented May 13, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ndimiduk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented May 14, 2021

Uh oh!

Apache-HBase commented May 14, 2021

Uh oh!

Apache-HBase commented May 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ZhaoBQ commented May 13, 2021•
edited
Loading