Uh oh!
There was an error while loading. Please reload this page.
HBASE-25651: NORMALIZER_TARGET_REGION_SIZE needs a unit in its name - #3063
Conversation
Apache-HBase
commented
Mar 18, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 18, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 18, 2021
🎊 +1 overall
This message was automatically generated. |
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
Mar 24, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 24, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 24, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 24, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 24, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 24, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 24, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 24, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Mar 24, 2021
🎊 +1 overall
This message was automatically generated. |
ndimiduk
left a comment
There was a problem hiding this comment.
This is looking mostly ready to go, just a couple nits. Why was it closed?
Uh oh!
There was an error while loading. Please reload this page.
| tdb.setNormalizationEnabled(JBoolean.valueOf(arg.delete(TableDescriptorBuilder::NORMALIZATION_ENABLED))) if arg.include?(TableDescriptorBuilder::NORMALIZATION_ENABLED) | ||
| tdb.setNormalizerTargetRegionCount(JInteger.valueOf(arg.delete(TableDescriptorBuilder::NORMALIZER_TARGET_REGION_COUNT))) if arg.include?(TableDescriptorBuilder::NORMALIZER_TARGET_REGION_COUNT) | ||
| # TODO: Keeping backward compatability for NORMALIZER_TARGET_REGION_SIZE with HBASE-25651 change. Can be removed in later version | ||
| tdb.setNormalizerTargetRegionSize(JLong.valueOf(arg.delete(TableDescriptorBuilder::NORMALIZER_TARGET_REGION_SIZE))) if arg.include?(TableDescriptorBuilder::NORMALIZER_TARGET_REGION_SIZE) |
There was a problem hiding this comment.
Can we have the shell print a depreciation warning when the old key is used?
Uh oh!
There was an error while loading. Please reload this page.
ndimiduk
commented
May 10, 2021
Hi @rahulLiving , I noticed you closed this PR. Are you planning to take this one in a different direction? |
rahulLiving
commented
May 11, 2021
Hi @ndimiduk I need to test out this change once, after addressing some comments. I was out for sometime, hence couldn't do it and thus closed for time being. I'll get it to closure in a week or two. |
ndimiduk
commented
May 11, 2021
Sounds good. You might be interested in concurrent working that's happening now, to improve and correct how HBase handles deprecated configurations. See #3249 . |
Apache-HBase
commented
May 13, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 13, 2021
🎊 +1 overall
This message was automatically generated. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rahulLiving
commented
May 22, 2021
@ndimiduk Thanks for the review. Have addressed the concerns, can you please have a look once. |
Uh oh!
There was an error while loading. Please reload this page.
Apache-HBase
commented
May 24, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 24, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 24, 2021
🎊 +1 overall
This message was automatically generated. |
ndimiduk
left a comment
There was a problem hiding this comment.
Looks good to me, @rahulLiving . Would you mind fixing the line-length issues reported by checkstyle?
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
May 27, 2021
🎊 +1 overall
This message was automatically generated. |
ndimiduk
commented
May 28, 2021
Thank you everyone for landing this one! |
…pache#3063) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Signed-off-by: Baiqiang Zhao <ZhaoBQ>
…pache#3063) Signed-off-by: Nick Dimiduk <ndimiduk@apache.org> Reviewed-by: Baiqiang Zhao <zbq.dean@gmail.com>
No description provided.