Skip to content

Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2 - #3271

Merged
ndimiduk merged 2 commits into
apache:branch-2from
ndimiduk:25861-correct-addDeprecation-branch-2
May 18, 2021
Merged

Backport "HBASE-25861 Correct the usage of Configuration#addDeprecation (#3249)" to branch-2#3271
ndimiduk merged 2 commits into
apache:branch-2from
ndimiduk:25861-correct-addDeprecation-branch-2

Conversation

@ndimiduk

@ndimidukndimiduk commented May 14, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Nick Dimiduk ndimiduk@apache.org

@ndimiduk

ndimiduk commented May 14, 2021

Copy link
Copy Markdown
MemberAuthor

FYI @ZhaoBQ , looks like your patch applies well enough to branch-2. Can you confirm that it can be applied without modification -- the configs you manipulate in this branch don't need some different action for the next 2.x release, and that there are not other uses of addDeprecation on branch-2 that need to be corrected? Thanks for the contribution!

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
ZhaoBQ
ZhaoBQ reviewed May 15, 2021
View reviewed changes
Comment threadhbase-common/src/main/java/org/apache/hadoop/hbase/HBaseConfiguration.java Outdated
new DeprecationDelta("hlog.input.tables", "wal.input.tables"),
new DeprecationDelta("hlog.input.tablesmap", "wal.input.tablesmap"),
new DeprecationDelta("hbase.master.mob.ttl.cleaner.period",
"hbase.master.mob.cleaner.period")

@ZhaoBQZhaoBQMay 15, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branch-2 doesn't have this configuration, so it needs to be deleted. The rest doesn't need to change.

@ndimidukndimidukMay 17, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this?

@ZhaoBQZhaoBQMay 18, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is nothing else to modify.

@ndimiduk
ndimidukforce-pushed the 25861-correct-addDeprecation-branch-2 branch from 7614a9e to 2e1810dCompareMay 17, 2021 20:01
@Apache-HBase

Apache-HBase commented May 17, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 9sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 35sbranch-2 passed
+1 💚compile8m 46sbranch-2 passed
+1 💚checkstyle2m 5sbranch-2 passed
+0 🆗refguide3m 50sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs11m 38sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile8m 42sthe patch passed
+1 💚javac8m 42sthe patch passed
+1 💚checkstyle2m 4sroot: The patch generated 0 new + 58 unchanged - 3 fixed = 58 total (was 61)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide3m 20spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck11m 42sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs12m 25sthe patch passed
_ Other Tests _
+1 💚asflicense0m 54sThe patch does not generate ASF License warnings.
82m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3271
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml refguide
unameLinux 0c0699a94e8a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 1a8d3c3
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count141 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server hbase-mapreduce . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 18, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 43sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 46sbranch-2 passed
+1 💚compile3m 9sbranch-2 passed
+1 💚shadedjars7m 33sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 29sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 31sthe patch passed
+1 💚compile3m 7sthe patch passed
-0 ⚠️javac3m 7sroot generated 1 new + 33 unchanged - 1 fixed = 34 total (was 34)
+1 💚shadedjars7m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc4m 24sthe patch passed
_ Other Tests _
+1 💚unit240m 28sroot in the patch passed.
285m 53s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3271
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 033a767c345b 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 1a8d3c3
Default JavaAdoptOpenJDK-11.0.10+9
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk11-hadoop3-check/output/diff-compile-javac-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/testReport/
Max. process+thread count4074 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server hbase-mapreduce . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented May 18, 2021

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec4m 0sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 33sbranch-2 passed
+1 💚compile2m 8sbranch-2 passed
+1 💚shadedjars5m 59sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 29sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 15sthe patch passed
+1 💚compile2m 12sthe patch passed
-0 ⚠️javac2m 12sroot generated 1 new + 33 unchanged - 1 fixed = 34 total (was 34)
+1 💚shadedjars5m 57spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 33sthe patch passed
_ Other Tests _
+1 💚unit321m 17sroot in the patch passed.
359m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3271
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 477ccf1ae865 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 1a8d3c3
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/artifact/yetus-jdk8-hadoop2-check/output/diff-compile-javac-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/testReport/
Max. process+thread count4662 (vs. ulimit of 12500)
modulesC: hbase-common hbase-server hbase-mapreduce . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3271/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk
ndimiduk merged commit aab6e1d into apache:branch-2May 18, 2021
@ndimiduk
ndimiduk deleted the 25861-correct-addDeprecation-branch-2 branch May 18, 2021 13:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZhaoBQZhaoBQZhaoBQ left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndimiduk@Apache-HBase@ZhaoBQ