Uh oh!
There was an error while loading. Please reload this page.
HBASE-25986 set default value of normalization enabled from hbase site - #3372
Conversation
Apache-HBase
commented
Jun 10, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 10, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 10, 2021
🎊 +1 overall
This message was automatically generated. |
mnpoonia
commented
Jun 13, 2021
@virajjasani Mind having a look in your free cycles. |
I think rather than site config, having a switch command would be more beneficial. |
We already have a switch command which switch the cluster level normalizer. This change is to set default table descriptor value that to something a user wants. The idea here is to enable normalizer by default to true/false for a table using configuration similar to what we do for cluster level normalizer configuration. We can always switch the normalizer to false at cluster level if there is an issue. |
Uh oh!
There was an error while loading. Please reload this page.
ndimiduk
left a comment
There was a problem hiding this comment.
What's the intended behavior? Can you outline how the system should behave based on presence/absence of values in hbase-site, TableDescriptor, and the ZooKeeper flag using a truth table?
Uh oh!
There was an error while loading. Please reload this page.
3b7ff5b to
28769a9CompareApache-HBase
commented
Jun 28, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 28, 2021
🎊 +1 overall
This message was automatically generated. |
28769a9 to
3f602b2CompareApache-HBase
commented
Jun 28, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 28, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 28, 2021
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Jun 28, 2021
🎊 +1 overall
This message was automatically generated. |
mnpoonia
commented
Jun 30, 2021
@ndimiduk - The above table defines the order in which value is being considered. |
virajjasani
left a comment
There was a problem hiding this comment.
Left a comment, still trying to understand compatibility concerns.
Uh oh!
There was an error while loading. Please reload this page.
3f602b2 to
21b8b46CompareApache-HBase
commented
Jul 6, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 6, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 6, 2021
💔 -1 overall
This message was automatically generated. |
mnpoonia
commented
Jul 7, 2021
Test failure seems to be unrelated. @virajjasani FYI |
virajjasani
left a comment
There was a problem hiding this comment.
Left few comments, almost there.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
21b8b46 to
548feddCompareApache-HBase
commented
Jul 12, 2021
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Jul 12, 2021
🎊 +1 overall
This message was automatically generated. |
virajjasani
left a comment
There was a problem hiding this comment.
+1, please create branch-2 and branch-1 PRs. We can merge them together once QA results are published.
Apache-HBase
commented
Jul 12, 2021
🎊 +1 overall
This message was automatically generated. |
No description provided.