Skip to content

HBASE-25986 set default value of normalization enabled from hbase site - #3372

Merged
virajjasani merged 1 commit into
apache:masterfrom
mnpoonia:normalizer_HBASE-25986
Jul 19, 2021
Merged

HBASE-25986 set default value of normalization enabled from hbase site#3372
virajjasani merged 1 commit into
apache:masterfrom
mnpoonia:normalizer_HBASE-25986

Conversation

@mnpoonia

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 3sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for branch
+1 💚mvninstall4m 13smaster passed
+1 💚compile5m 2smaster passed
+1 💚checkstyle2m 0smaster passed
+0 🆗refguide3m 44sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs3m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 2sthe patch passed
+1 💚compile5m 3sthe patch passed
+1 💚javac5m 3sthe patch passed
+1 💚checkstyle0m 23sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 28shbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚checkstyle1m 10sThe patch passed checkstyle in hbase-server
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide3m 38spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck19m 55sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs4m 31sthe patch passed
_ Other Tests _
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
69m 8s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3372
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux a7501911cff8 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 329f0ba
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 28sMaven dependency ordering for branch
+1 💚mvninstall4m 13smaster passed
+1 💚compile2m 2smaster passed
+1 💚shadedjars8m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 55sthe patch passed
+1 💚compile2m 0sthe patch passed
+1 💚javac2m 0sthe patch passed
+1 💚shadedjars8m 33spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 29sthe patch passed
_ Other Tests _
+1 💚unit1m 56shbase-common in the patch passed.
+1 💚unit1m 25shbase-client in the patch passed.
+1 💚unit157m 58shbase-server in the patch passed.
197m 39s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1c3d968cf2d9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 329f0ba
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/testReport/
Max. process+thread count4227 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall4m 59smaster passed
+1 💚compile2m 21smaster passed
+1 💚shadedjars9m 23sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 33smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 52sthe patch passed
+1 💚compile2m 15sthe patch passed
+1 💚javac2m 15sthe patch passed
+1 💚shadedjars9m 3spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 31sthe patch passed
_ Other Tests _
+1 💚unit2m 12shbase-common in the patch passed.
+1 💚unit1m 40shbase-client in the patch passed.
+1 💚unit208m 49shbase-server in the patch passed.
253m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7a7d59788532 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 329f0ba
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/testReport/
Max. process+thread count2655 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor

@virajjasani Mind having a look in your free cycles.

@virajjasani

virajjasani commented Jun 19, 2021

Copy link
Copy Markdown
Contributor

I think rather than site config, having a switch command would be more beneficial.
Something like switch_cluster_normalizer <true>/<false> would not require us to re-deploy with updated site config.
WDYT @ndimiduk ?

@mnpoonia

mnpoonia commented Jun 21, 2021

Copy link
Copy Markdown
ContributorAuthor

I think rather than site config, having a switch command would be more beneficial.
Something like switch_cluster_normalizer <true>/<false> would not require us to re-deploy with updated site config.

We already have a switch command which switch the cluster level normalizer. This change is to set default table descriptor value that to something a user wants. The idea here is to enable normalizer by default to true/false for a table using configuration similar to what we do for cluster level normalizer configuration.

We can always switch the normalizer to false at cluster level if there is an issue.

@virajjasani
virajjasani requested a review from Apache9June 22, 2021 10:10

@ndimidukndimiduk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the intended behavior? Can you outline how the system should behave based on presence/absence of values in hbase-site, TableDescriptor, and the ZooKeeper flag using a truth table?

@mnpoonia
mnpooniaforce-pushed the normalizer_HBASE-25986 branch from 3b7ff5b to 28769a9CompareJune 28, 2021 07:52
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 1sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall4m 14smaster passed
+1 💚compile5m 1smaster passed
+1 💚checkstyle2m 4smaster passed
+0 🆗refguide3m 40sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs3m 56smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall4m 2sthe patch passed
+1 💚compile5m 6sthe patch passed
+1 💚javac5m 6sthe patch passed
+1 💚checkstyle0m 23sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 29shbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚checkstyle1m 9sThe patch passed checkstyle in hbase-server
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+0 🆗refguide3m 40spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck20m 1sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
-1 ❌spotbugs2m 25shbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚asflicense0m 33sThe patch does not generate ASF License warnings.
69m 17s
ReasonTests
FindBugsmodule:hbase-server
Nullcheck of tblDesc at line 191 of value previously dereferenced in org.apache.hadoop.hbase.master.normalizer.RegionNormalizerWorker.calculatePlans(TableName) At RegionNormalizerWorker.java:191 of value previously dereferenced in org.apache.hadoop.hbase.master.normalizer.RegionNormalizerWorker.calculatePlans(TableName) At RegionNormalizerWorker.java:[line 191]
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3372
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux 774707785bf0 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22ec681
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-general-check/output/patch-site/book.html
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall3m 53smaster passed
+1 💚compile1m 49smaster passed
+1 💚shadedjars8m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 23smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 38sthe patch passed
+1 💚compile1m 52sthe patch passed
+1 💚javac1m 52sthe patch passed
+1 💚shadedjars8m 17spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 22sthe patch passed
_ Other Tests _
+1 💚unit1m 46shbase-common in the patch passed.
+1 💚unit1m 15shbase-client in the patch passed.
+1 💚unit130m 7shbase-server in the patch passed.
167m 22s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 65e16b7d73b5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22ec681
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/testReport/
Max. process+thread count4095 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia
mnpooniaforce-pushed the normalizer_HBASE-25986 branch from 28769a9 to 3f602b2CompareJune 28, 2021 11:14
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 37sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall6m 3smaster passed
+1 💚compile2m 36smaster passed
+1 💚shadedjars10m 44sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 18smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall5m 52sthe patch passed
+1 💚compile2m 18sthe patch passed
+1 💚javac2m 18sthe patch passed
+1 💚shadedjars9m 9spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 30sthe patch passed
_ Other Tests _
+1 💚unit2m 15shbase-common in the patch passed.
+1 💚unit1m 43shbase-client in the patch passed.
+1 💚unit181m 30shbase-server in the patch passed.
230m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 7d198451a57a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22ec681
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/testReport/
Max. process+thread count2763 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall4m 14smaster passed
+1 💚compile5m 4smaster passed
+1 💚checkstyle2m 2smaster passed
+0 🆗refguide3m 42sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs3m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 58sthe patch passed
+1 💚compile5m 1sthe patch passed
+1 💚javac5m 1sthe patch passed
+1 💚checkstyle0m 24sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 28shbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚checkstyle1m 8sThe patch passed checkstyle in hbase-server
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide3m 45spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck20m 3sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs4m 33sthe patch passed
_ Other Tests _
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
69m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3372
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux 510c5b923e14 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22ec681
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 36smaster passed
+1 💚compile1m 54smaster passed
+1 💚shadedjars8m 18sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 22smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 41sthe patch passed
+1 💚compile1m 49sthe patch passed
+1 💚javac1m 49sthe patch passed
+1 💚shadedjars8m 12spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21sthe patch passed
_ Other Tests _
+1 💚unit1m 46shbase-common in the patch passed.
+1 💚unit1m 17shbase-client in the patch passed.
-1 ❌unit129m 52shbase-server in the patch failed.
166m 48s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 318ab4c2091d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22ec681
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/testReport/
Max. process+thread count4113 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall4m 43smaster passed
+1 💚compile2m 13smaster passed
+1 💚shadedjars9m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 29smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall4m 48sthe patch passed
+1 💚compile2m 13sthe patch passed
+1 💚javac2m 13sthe patch passed
+1 💚shadedjars8m 57spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 29sthe patch passed
_ Other Tests _
+1 💚unit2m 13shbase-common in the patch passed.
+1 💚unit1m 39shbase-client in the patch passed.
+1 💚unit183m 54shbase-server in the patch passed.
226m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6545d7a31364 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 22ec681
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/testReport/
Max. process+thread count2772 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor
hbase-sitetable descriptorused
defineddefinedtable descriptor value
definednot definedhbase-site value
not defineddefinedtable descriptor value
not definednot defineduse from hbase-default

@ndimiduk - The above table defines the order in which value is being considered.
Basically if the property is defined in table descriptor than value of that is used else hbase-site value will be used. And we will always have default value false in hbase-default

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, still trying to understand compatibility concerns.

@mnpoonia
mnpooniaforce-pushed the normalizer_HBASE-25986 branch from 3f602b2 to 21b8b46CompareJuly 6, 2021 08:35
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 17smaster passed
+1 💚compile5m 1smaster passed
+1 💚checkstyle2m 1smaster passed
+0 🆗refguide3m 38sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs3m 54smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 59sthe patch passed
+1 💚compile5m 4sthe patch passed
+1 💚javac5m 4sthe patch passed
+1 💚checkstyle0m 24sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 28shbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚checkstyle1m 11sThe patch passed checkstyle in hbase-server
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 1sThe patch has no ill-formed XML file.
+0 🆗refguide3m 36spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck20m 17sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs4m 57sthe patch passed
_ Other Tests _
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
75m 31s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3372
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux db09279e7677 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a3ad97f
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count86 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 27sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 52smaster passed
+1 💚compile1m 54smaster passed
+1 💚shadedjars8m 54sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 31smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile2m 0sthe patch passed
+1 💚javac2m 0sthe patch passed
+1 💚shadedjars9m 14spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 22sthe patch passed
_ Other Tests _
+1 💚unit1m 41shbase-common in the patch passed.
+1 💚unit1m 17shbase-client in the patch passed.
+1 💚unit147m 53shbase-server in the patch passed.
187m 20s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6d0797ac4230 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a3ad97f
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/testReport/
Max. process+thread count4469 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall4m 54smaster passed
+1 💚compile2m 12smaster passed
+1 💚shadedjars9m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 32smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall4m 44sthe patch passed
+1 💚compile2m 13sthe patch passed
+1 💚javac2m 13sthe patch passed
+1 💚shadedjars9m 3spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 29sthe patch passed
_ Other Tests _
+1 💚unit2m 23shbase-common in the patch passed.
+1 💚unit1m 39shbase-client in the patch passed.
-1 ❌unit213m 1shbase-server in the patch failed.
256m 14s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fcac66082cfb 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / a3ad97f
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/testReport/
Max. process+thread count3602 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@mnpoonia

Copy link
Copy Markdown
ContributorAuthor

Test failure seems to be unrelated. @virajjasani FYI

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments, almost there.

@mnpoonia
mnpooniaforce-pushed the normalizer_HBASE-25986 branch from 21b8b46 to 548feddCompareJuly 12, 2021 06:49
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 19sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 51smaster passed
+1 💚compile4m 56smaster passed
+1 💚checkstyle1m 55smaster passed
+0 🆗refguide3m 53sbranch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚spotbugs3m 55smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 37sthe patch passed
+1 💚compile4m 55sthe patch passed
+1 💚javac4m 55sthe patch passed
+1 💚checkstyle0m 23sThe patch passed checkstyle in hbase-common
+1 💚checkstyle0m 28shbase-client: The patch generated 0 new + 29 unchanged - 1 fixed = 29 total (was 30)
+1 💚checkstyle1m 1sThe patch passed checkstyle in hbase-server
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 2sThe patch has no ill-formed XML file.
+0 🆗refguide3m 26spatch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚hadoopcheck18m 14sPatch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚spotbugs4m 19sthe patch passed
_ Other Tests _
+1 💚asflicense0m 40sThe patch does not generate ASF License warnings.
65m 52s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3372
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile refguide xml
unameLinux 0a22ab1484fb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 875b63c
Default JavaAdoptOpenJDK-1.8.0_282-b08
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/artifact/yetus-general-check/output/branch-site/book.html
refguidehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/artifact/yetus-general-check/output/patch-site/book.html
Max. process+thread count96 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 29sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 9sMaven dependency ordering for branch
+1 💚mvninstall3m 38smaster passed
+1 💚compile1m 52smaster passed
+1 💚shadedjars8m 17sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 40sthe patch passed
+1 💚compile1m 56sthe patch passed
+1 💚javac1m 56sthe patch passed
+1 💚shadedjars8m 15spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 21sthe patch passed
_ Other Tests _
+1 💚unit1m 46shbase-common in the patch passed.
+1 💚unit1m 17shbase-client in the patch passed.
+1 💚unit144m 52shbase-server in the patch passed.
181m 57s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 921443a92c82 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 875b63c
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/testReport/
Max. process+thread count3890 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, please create branch-2 and branch-1 PRs. We can merge them together once QA results are published.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 30sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚mvninstall3m 39smaster passed
+1 💚compile1m 52smaster passed
+1 💚shadedjars8m 6sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 23smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 43sthe patch passed
+1 💚compile1m 50sthe patch passed
+1 💚javac1m 50sthe patch passed
+1 💚shadedjars8m 16spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc1m 23sthe patch passed
_ Other Tests _
+1 💚unit1m 48shbase-common in the patch passed.
+1 💚unit1m 16shbase-client in the patch passed.
+1 💚unit144m 12shbase-server in the patch passed.
180m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/7/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#3372
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 86773fe5383c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 875b63c
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/7/testReport/
Max. process+thread count4017 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3372/7/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
virajjasani merged commit 0f31317 into apache:masterJul 19, 2021
virajjasani pushed a commit that referenced this pull request Jul 19, 2021
virajjasani pushed a commit that referenced this pull request Jul 19, 2021
virajjasani pushed a commit that referenced this pull request Jul 19, 2021
@mnpoonia
mnpoonia deleted the normalizer_HBASE-25986 branch July 19, 2021 11:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mnpoonia@Apache-HBase@virajjasani@ndimiduk@Apache9