Skip to content

HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2 - #3529

Merged
taklwu merged 7 commits into
apache:branch-2from
taklwu:HBASE-26124
Jul 29, 2021
Merged

HBASE-26124 Backport HBASE-25373 "Remove HTrace completely in code base and try to make use of OpenTelemetry" to branch-2#3529
taklwu merged 7 commits into
apache:branch-2from
taklwu:HBASE-26124

Conversation

@taklwu

Copy link
Copy Markdown
Contributor

1/17 commits of HBASE-22120

@taklwu

Copy link
Copy Markdown
ContributorAuthor

the original commit on master is 302d9ea

@taklwu
taklwu requested a review from apurtellJuly 27, 2021 04:03
…se and try to make use of OpenTelemetry" to branch-2
1/17 commits of HBASE-22120
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall3m 41sbranch-2 passed
+1 💚compile8m 49sbranch-2 passed
+1 💚checkstyle2m 19sbranch-2 passed
+1 💚spotbugs17m 36sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile8m 42sthe patch passed
-0 ⚠️javac8m 42sroot generated 6 new + 1884 unchanged - 3 fixed = 1890 total (was 1887)
-0 ⚠️checkstyle2m 20sroot: The patch generated 27 new + 679 unchanged - 21 fixed = 706 total (was 700)
-0 ⚠️rubocop0m 4sThe patch generated 4 new + 3 unchanged - 8 fixed = 7 total (was 11)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 16sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 47sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs19m 52sthe patch passed
_ Other Tests _
+1 💚asflicense2m 57sThe patch does not generate ASF License warnings.
94m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3529
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml rubocop
unameLinux 21881066d059 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 20a4aae
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count141 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 23sMaven dependency ordering for branch
+1 💚mvninstall4m 54sbranch-2 passed
+1 💚compile3m 13sbranch-2 passed
+1 💚shadedjars7m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 54sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 30sthe patch passed
+1 💚compile3m 5sthe patch passed
+1 💚javac3m 5sthe patch passed
+1 💚shadedjars7m 54spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 55sthe patch passed
_ Other Tests _
+1 💚unit257m 49sroot in the patch passed.
309m 4s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e3b18447e592 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 20a4aae
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/testReport/
Max. process+thread count4118 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 29sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall4m 35sbranch-2 passed
+1 💚compile3m 14sbranch-2 passed
+1 💚shadedjars7m 14sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 42sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall4m 37sthe patch passed
+1 💚compile3m 11sthe patch passed
+1 💚javac3m 11sthe patch passed
+1 💚shadedjars8m 4spatch has no errors when building our shaded downstream artifacts.
-0 ⚠️javadoc2m 52sroot generated 1 new + 54 unchanged - 1 fixed = 55 total (was 55)
_ Other Tests _
-1 ❌unit365m 11sroot in the patch failed.
416m 36s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0e8da7932790 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 20a4aae
Default JavaAdoptOpenJDK-1.8.0_282-b08
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-root.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/testReport/
Max. process+thread count2432 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 48sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for branch
+1 💚mvninstall4m 20sbranch-2 passed
+1 💚compile9m 55sbranch-2 passed
+1 💚checkstyle2m 51sbranch-2 passed
+1 💚spotbugs20m 22sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall4m 29sthe patch passed
+1 💚compile9m 49sthe patch passed
-0 ⚠️javac9m 49sroot generated 3 new + 1887 unchanged - 0 fixed = 1890 total (was 1887)
-0 ⚠️checkstyle2m 41sroot: The patch generated 27 new + 742 unchanged - 21 fixed = 769 total (was 763)
-0 ⚠️rubocop0m 4sThe patch generated 4 new + 3 unchanged - 8 fixed = 7 total (was 11)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 15sThe patch has no ill-formed XML file.
+1 💚hadoopcheck15m 35sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs23m 50sthe patch passed
_ Other Tests _
+1 💚asflicense2m 44sThe patch does not generate ASF License warnings.
113m 8s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3529
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml rubocop
unameLinux 67fdf8d83f26 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 20a4aae
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count126 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall5m 30sbranch-2 passed
+1 💚compile4m 6sbranch-2 passed
+1 💚shadedjars9m 7sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc8m 14sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for patch
+1 💚mvninstall5m 22sthe patch passed
+1 💚compile3m 40sthe patch passed
+1 💚javac3m 40sthe patch passed
+1 💚shadedjars9m 48spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 46sthe patch passed
_ Other Tests _
+1 💚unit169m 20sroot in the patch passed.
230m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 58e94616b4a2 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 20a4aae
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/testReport/
Max. process+thread count6220 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@taklwu

Copy link
Copy Markdown
ContributorAuthor

The failed test TestSnapshotScannerHDFSAclController2 passed locally and the error of NoSuchColumnFamilyException for table 'hbase:acl' should not be related to this change.

[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController2
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 38.725 s - in org.apache.hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController2
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- maven-surefire-plugin:3.0.0-M4:test (secondPartTestsExecution) @ hbase-server ---
[INFO] Tests are skipped.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:31 min
[INFO] Finished at: 2021-07-27T09:36:30-07:00
[INFO] ------------------------------------------------------------------------

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall3m 35sbranch-2 passed
+1 💚compile2m 15sbranch-2 passed
+1 💚shadedjars5m 58sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 44sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile2m 17sthe patch passed
+1 💚javac2m 17sthe patch passed
+1 💚shadedjars6m 26spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 47sthe patch passed
_ Other Tests _
-1 ❌unit327m 11sroot in the patch failed.
368m 26s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 80e68b0d9f11 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 20a4aae
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/testReport/
Max. process+thread count4826 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

<exclude>com.github.spotbugs:*</exclude>
<exclude>org.apache.htrace:*</exclude>
<exclude>org.apache.yetus:*</exclude>
<exclude>org.apache.logging.log4j:*</exclude>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from the original commit. Is this needed?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, I will remove them

<exclude>com.github.spotbugs:*</exclude>
<exclude>org.apache.htrace:*</exclude>
<exclude>org.apache.yetus:*</exclude>
<exclude>org.apache.logging.log4j:*</exclude>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Comment threadhbase-shaded/pom.xml Outdated
<exclude>com.github.spotbugs:*</exclude>
<exclude>org.apache.htrace:*</exclude>
<exclude>org.apache.yetus:*</exclude>
<exclude>org.apache.logging.log4j:*</exclude>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Change-Id: Ifd1f02c142748f15f417a780a485b45cd5a94397
@taklwu
taklwu requested a review from petersomogyiJuly 27, 2021 20:13
Change-Id: Ifce333131217ced6807b407fe66d85093b06728d
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 40sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall4m 29sbranch-2 passed
+1 💚compile10m 55sbranch-2 passed
+1 💚checkstyle2m 41sbranch-2 passed
+1 💚spotbugs18m 56sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall3m 42sthe patch passed
+1 💚compile9m 25sthe patch passed
-0 ⚠️javac9m 25sroot generated 3 new + 1887 unchanged - 0 fixed = 1890 total (was 1887)
-0 ⚠️checkstyle2m 37sroot: The patch generated 25 new + 742 unchanged - 21 fixed = 767 total (was 763)
-0 ⚠️rubocop0m 4sThe patch generated 4 new + 3 unchanged - 8 fixed = 7 total (was 11)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 15sThe patch has no ill-formed XML file.
+1 💚hadoopcheck14m 25sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs22m 51sthe patch passed
_ Other Tests _
+1 💚asflicense2m 35sThe patch does not generate ASF License warnings.
106m 58s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3529
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml rubocop
unameLinux e3d4bb270a8f 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count126 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 27sMaven dependency ordering for branch
+1 💚mvninstall4m 31sbranch-2 passed
+1 💚compile2m 55sbranch-2 passed
+1 💚shadedjars6m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 3sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall4m 5sthe patch passed
+1 💚compile2m 53sthe patch passed
+1 💚javac2m 53sthe patch passed
+1 💚shadedjars7m 56spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 48sthe patch passed
_ Other Tests _
+1 💚unit187m 6sroot in the patch passed.
237m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux f8f278f6a7c6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/testReport/
Max. process+thread count6171 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 15sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for branch
+1 💚mvninstall4m 8sbranch-2 passed
+1 💚compile2m 33sbranch-2 passed
+1 💚shadedjars6m 40sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 6sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 53sthe patch passed
+1 💚compile2m 32sthe patch passed
+1 💚javac2m 32sthe patch passed
+1 💚shadedjars7m 4spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 17sthe patch passed
_ Other Tests _
+1 💚unit416m 59sroot in the patch passed.
462m 38s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 95d44e6c18b7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/testReport/
Max. process+thread count3553 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 44sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 36sMaven dependency ordering for branch
+1 💚mvninstall4m 8sbranch-2 passed
+1 💚compile10m 10sbranch-2 passed
+1 💚checkstyle2m 39sbranch-2 passed
+1 💚spotbugs22m 5sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall3m 48sthe patch passed
+1 💚compile11m 46sthe patch passed
-0 ⚠️javac11m 46sroot generated 3 new + 1887 unchanged - 0 fixed = 1890 total (was 1887)
-0 ⚠️checkstyle2m 53sroot: The patch generated 25 new + 742 unchanged - 21 fixed = 767 total (was 763)
-0 ⚠️rubocop0m 6sThe patch generated 4 new + 3 unchanged - 8 fixed = 7 total (was 11)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 14sThe patch has no ill-formed XML file.
+1 💚hadoopcheck15m 37sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs26m 37sthe patch passed
_ Other Tests _
+1 💚asflicense3m 4sThe patch does not generate ASF License warnings.
118m 55s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3529
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml rubocop
unameLinux 68a432edeb0d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count126 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyipetersomogyi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the javac, checkstyle and rubocop warnings are fixed.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 43sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall5m 6sbranch-2 passed
+1 💚compile3m 44sbranch-2 passed
+1 💚shadedjars8m 8sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 52sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall5m 24sthe patch passed
+1 💚compile3m 29sthe patch passed
+1 💚javac3m 29sthe patch passed
+1 💚shadedjars8m 42spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc8m 5sthe patch passed
_ Other Tests _
+1 💚unit255m 19sroot in the patch passed.
312m 53s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 89f949f79e34 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/testReport/
Max. process+thread count4062 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 19sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall3m 37sbranch-2 passed
+1 💚compile2m 18sbranch-2 passed
+1 💚shadedjars5m 54sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 42sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile2m 21sthe patch passed
+1 💚javac2m 21sthe patch passed
+1 💚shadedjars6m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 1sthe patch passed
_ Other Tests _
-1 ❌unit330m 4sroot in the patch failed.
372m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3d3a31e3fd6b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/testReport/
Max. process+thread count4605 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: I2e1c41e50daaf353c5da8b0763677a69fe233de4
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 25sMaven dependency ordering for branch
+1 💚mvninstall3m 39sbranch-2 passed
+1 💚compile8m 46sbranch-2 passed
+1 💚checkstyle2m 24sbranch-2 passed
+1 💚spotbugs17m 28sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile8m 48sthe patch passed
-0 ⚠️javac8m 48sroot generated 4 new + 1885 unchanged - 2 fixed = 1889 total (was 1887)
+1 💚checkstyle2m 19sroot: The patch generated 0 new + 736 unchanged - 27 fixed = 736 total (was 763)
+1 💚rubocop0m 3sThe patch generated 0 new + 3 unchanged - 8 fixed = 3 total (was 11)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 16sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 47sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs19m 32sthe patch passed
_ Other Tests _
+1 💚asflicense2m 58sThe patch does not generate ASF License warnings.
93m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3529
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml rubocop
unameLinux 57297ea9521b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count141 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 36sMaven dependency ordering for branch
+1 💚mvninstall4m 44sbranch-2 passed
+1 💚compile3m 10sbranch-2 passed
+1 💚shadedjars7m 46sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 17sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 37sthe patch passed
+1 💚compile3m 13sthe patch passed
+1 💚javac3m 13sthe patch passed
+1 💚shadedjars8m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 11sthe patch passed
_ Other Tests _
+1 💚unit244m 36sroot in the patch passed.
297m 14s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b23128fdef28 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/testReport/
Max. process+thread count4029 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for branch
+1 💚mvninstall3m 35sbranch-2 passed
+1 💚compile2m 14sbranch-2 passed
+1 💚shadedjars6m 0sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 40sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 18sthe patch passed
+1 💚compile2m 16sthe patch passed
+1 💚javac2m 16sthe patch passed
+1 💚shadedjars6m 23spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 58sthe patch passed
_ Other Tests _
-1 ❌unit315m 56sroot in the patch failed.
357m 43s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 041eca4f9473 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/testReport/
Max. process+thread count4533 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 32sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall3m 21sbranch-2 passed
+1 💚compile8m 50sbranch-2 passed
+1 💚checkstyle2m 23sbranch-2 passed
+1 💚spotbugs17m 28sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile8m 44sthe patch passed
-0 ⚠️javac8m 44sroot generated 2 new + 1885 unchanged - 2 fixed = 1887 total (was 1887)
+1 💚checkstyle2m 18sroot: The patch generated 0 new + 736 unchanged - 27 fixed = 736 total (was 763)
+1 💚rubocop0m 4sThe patch generated 0 new + 3 unchanged - 8 fixed = 3 total (was 11)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 16sThe patch has no ill-formed XML file.
+1 💚hadoopcheck11m 39sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs19m 47sthe patch passed
_ Other Tests _
+1 💚asflicense2m 56sThe patch does not generate ASF License warnings.
93m 49s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3529
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml rubocop
unameLinux 09f3cf1d8289 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/6/artifact/yetus-general-check/output/diff-compile-javac-root.txt
Max. process+thread count142 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/6/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 5sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall4m 34sbranch-2 passed
+1 💚compile3m 7sbranch-2 passed
+1 💚shadedjars7m 29sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 55sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 30sthe patch passed
+1 💚compile3m 6sthe patch passed
+1 💚javac3m 6sthe patch passed
+1 💚shadedjars8m 0spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc6m 52sthe patch passed
_ Other Tests _
+1 💚unit252m 56sroot in the patch passed.
303m 32s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6edc7ad63877 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/6/testReport/
Max. process+thread count3994 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: I7b8b3df00465d7fc065cff7aa9b65d3878523a30
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 26sMaven dependency ordering for branch
+1 💚mvninstall3m 37sbranch-2 passed
+1 💚compile2m 19sbranch-2 passed
+1 💚shadedjars6m 4sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 48sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile2m 16sthe patch passed
+1 💚javac2m 16sthe patch passed
+1 💚shadedjars6m 20spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc5m 56sthe patch passed
_ Other Tests _
+1 💚unit331m 41sroot in the patch passed.
373m 8s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d469db62d4d2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/6/testReport/
Max. process+thread count4304 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall3m 32sbranch-2 passed
+1 💚compile8m 50sbranch-2 passed
+1 💚checkstyle2m 17sbranch-2 passed
+1 💚spotbugs18m 20sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 27sthe patch passed
+1 💚compile9m 3sthe patch passed
+1 💚javac9m 3sthe patch passed
+1 💚checkstyle2m 22sroot: The patch generated 0 new + 736 unchanged - 27 fixed = 736 total (was 763)
+1 💚rubocop0m 3sThe patch generated 0 new + 3 unchanged - 8 fixed = 3 total (was 11)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚xml0m 16sThe patch has no ill-formed XML file.
+1 💚hadoopcheck12m 30sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚spotbugs21m 25sthe patch passed
_ Other Tests _
+1 💚asflicense2m 46sThe patch does not generate ASF License warnings.
97m 40s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3529
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile xml rubocop
unameLinux 6c965c001b97 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count141 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 48sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 43sMaven dependency ordering for branch
+1 💚mvninstall6m 19sbranch-2 passed
+1 💚compile4m 0sbranch-2 passed
+1 💚shadedjars11m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc8m 9sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall4m 19sthe patch passed
+1 💚compile3m 32sthe patch passed
+1 💚javac3m 32sthe patch passed
+1 💚shadedjars7m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc7m 33sthe patch passed
_ Other Tests _
+1 💚unit186m 4sroot in the patch passed.
246m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3529
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fb6428c06c41 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/testReport/
Max. process+thread count6756 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-common hbase-client hbase-zookeeper hbase-asyncfs hbase-server hbase-mapreduce hbase-shell hbase-it hbase-shaded hbase-shaded/hbase-shaded-client hbase-external-blockcache hbase-shaded/hbase-shaded-testing-util . U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3529/7/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@taklwu

Copy link
Copy Markdown
ContributorAuthor

javac, checkstyle and rubocop have all been fixed, merging.

@taklwu
taklwu merged commit f049301 into apache:branch-2Jul 29, 2021
@Apache9

Copy link
Copy Markdown
Contributor

Be lated +1.

Thanks @taklwu for taking this work.

This PR seems OK to merge to branch-2 directly, but I'm not sure if is better to backport to a branch-2 based feature branch first for the other issues?

@taklwu

taklwu commented Aug 2, 2021

Copy link
Copy Markdown
ContributorAuthor

@Apache9 hey Duo, having your +1 is good and it's never late to comment!.

(updated) let me clarify with you first, do you mean we should have a single feature branch for all remaining commits (about 14 commits remaining) , then have a single PR for reviewing all cherry-picks (with merge conflicts) such we can move the review faster ? (in fact I actually had backported all 17 commits in my local repository)

or, do you have other concerns for "the other issues" (what does "other" means here)?

@Apache9

Copy link
Copy Markdown
Contributor

@Apache9 hey Duo, having your +1 is good and it's never late to comment!.

(updated) let me clarify with you first, do you mean we should have a single feature branch for all remaining commits (about 14 commits remaining) , then have a single PR for reviewing all cherry-picks (with merge conflicts) such we can move the review faster ? (in fact I actually had backported all 17 commits in my local repository)

or, do you have other concerns for "the other issues" (what does "other" means here)?

This is a big new feature and until all the sub-tasks for HBASE-22120 are back port, the feature can be considered as 'complete'. So this means during the backporting, we have a partial implemented feature in one of our main branches, which is not good IMO.

Thanks.

@taklwu

Copy link
Copy Markdown
ContributorAuthor

cool, thanks @Apache9 Duo, I will open a feature branch HBASE-25853 based on branch-2 and and open up PRs with all remaining commits.

taklwu added a commit to taklwu/hbase that referenced this pull request Aug 4, 2021
… code base and try to make use of OpenTelemetry" to branch-2 (apache#3529)"
This reverts commit f049301.
taklwu added a commit that referenced this pull request Aug 4, 2021
… code base and try to make use of OpenTelemetry" to branch-2 (#3529)"
This reverts commit f049301.
taklwu added a commit that referenced this pull request Aug 5, 2021
…se and try to make use of OpenTelemetry" to branch-2 (#3529)
1/17 commits of HBASE-22120
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
taklwu added a commit that referenced this pull request Aug 27, 2021
…se and try to make use of OpenTelemetry" to branch-2 (#3529)
1/17 commits of HBASE-22120
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
taklwu added a commit that referenced this pull request Sep 1, 2021
…se and try to make use of OpenTelemetry" to branch-2 (#3529)
1/17 commits of HBASE-22120
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
…se and try to make use of OpenTelemetry" to branch-2 (apache#3529)
1/17 commits of HBASE-22120
Signed-off-by: Peter Somogyi <psomogyi@apache.org>
(cherry picked from commit f049301)
Ref: CDPD-32259
Reason: CVE / Security
Notes: This is an directly backport from upstream f049301 instead of porting it from CDPD-26769 because branch-2.4 is mostly aligned with upstream branch-2.
Change-Id: If50b88b45c2e1afc24a7924440651c7c68dc24e1
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@taklwu@Apache-HBase@Apache9@petersomogyi