Skip to content

HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves - #3536

Closed
bbeaudreault wants to merge 3 commits into
apache:branch-2from
bbeaudreault:dry_run_balancer_upstream
Closed

HBASE-26147: Add dry_run_balancer and related Admin interfaces for running the balancer without executing any region moves#3536
bbeaudreault wants to merge 3 commits into
apache:branch-2from
bbeaudreault:dry_run_balancer_upstream

Conversation

@bbeaudreault

@bbeaudreaultbbeaudreault commented Jul 27, 2021

Copy link
Copy Markdown
Contributor

See https://issues.apache.org/jira/browse/HBASE-26147

I considered adding another overload of the existing balance() methods, but I felt there already existed a lot of overloads there between the deprecated balancer() methods and the force boolean. Adding a separate dryRunBalance() method seemed like the cleanest and most intuitive way to add this new functionality in a backwards compatible way.

@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch from 9a6544b to 6520805CompareJuly 27, 2021 21:52
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 41sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 44sbranch-2 passed
+1 💚compile9m 1sbranch-2 passed
+1 💚checkstyle2m 53sbranch-2 passed
+1 💚spotbugs7m 46sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall3m 24sthe patch passed
+1 💚compile6m 42sthe patch passed
+1 💚cc6m 42sthe patch passed
+1 💚javac6m 42sthe patch passed
-0 ⚠️checkstyle0m 38shbase-client: The patch generated 2 new + 151 unchanged - 0 fixed = 153 total (was 151)
-0 ⚠️checkstyle1m 21shbase-server: The patch generated 4 new + 107 unchanged - 0 fixed = 111 total (was 107)
-0 ⚠️rubocop0m 2sThe patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 11sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc3m 6sthe patch passed
+1 💚spotbugs8m 27sthe patch passed
_ Other Tests _
-1 ❌asflicense1m 1sThe patch generated 1 ASF License warnings.
71m 36s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 8ac81ddfdce3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
asflicensehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 40sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 4sbranch-2 passed
+1 💚compile3m 19sbranch-2 passed
+1 💚shadedjars6m 37sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 8sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 21sMaven dependency ordering for patch
+1 💚mvninstall3m 47sthe patch passed
+1 💚compile3m 21sthe patch passed
+1 💚javac3m 21sthe patch passed
-1 ❌shadedjars5m 31spatch has 10 errors when building our shaded downstream artifacts.
+1 💚javadoc2m 7sthe patch passed
_ Other Tests _
+1 💚unit0m 45shbase-protocol-shaded in the patch passed.
+1 💚unit2m 40shbase-client in the patch passed.
+1 💚unit148m 12shbase-server in the patch passed.
+1 💚unit6m 27shbase-thrift in the patch passed.
+1 💚unit7m 13shbase-shell in the patch passed.
200m 35s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a500893300e6 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/testReport/
Max. process+thread count3686 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 46sDocker mode activated.
-0 ⚠️yetus0m 9sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall5m 46sbranch-2 passed
+1 💚compile4m 45sbranch-2 passed
+1 💚shadedjars9m 29sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 11sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 24sMaven dependency ordering for patch
+1 💚mvninstall5m 34sthe patch passed
+1 💚compile4m 36sthe patch passed
+1 💚javac4m 36sthe patch passed
-1 ❌shadedjars7m 35spatch has 10 errors when building our shaded downstream artifacts.
+1 💚javadoc3m 1sthe patch passed
_ Other Tests _
+1 💚unit1m 6shbase-protocol-shaded in the patch passed.
+1 💚unit3m 0shbase-client in the patch passed.
+1 💚unit150m 46shbase-server in the patch passed.
+1 💚unit6m 23shbase-thrift in the patch passed.
+1 💚unit7m 15shbase-shell in the patch passed.
217m 17s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9de502d8d5f7 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-11.0.10+9
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/testReport/
Max. process+thread count4244 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch from 6520805 to eca1e48CompareJuly 28, 2021 16:39
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 23sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 58sbranch-2 passed
+1 💚compile7m 14sbranch-2 passed
+1 💚checkstyle2m 56sbranch-2 passed
+1 💚spotbugs7m 46sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 43sthe patch passed
+1 💚compile7m 11sthe patch passed
+1 💚cc7m 11sthe patch passed
+1 💚javac7m 11sthe patch passed
-0 ⚠️checkstyle0m 35shbase-client: The patch generated 2 new + 151 unchanged - 0 fixed = 153 total (was 151)
-0 ⚠️checkstyle1m 16shbase-server: The patch generated 4 new + 107 unchanged - 0 fixed = 111 total (was 107)
-0 ⚠️rubocop0m 3sThe patch generated 7 new + 0 unchanged - 0 fixed = 7 total (was 0)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 52sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc2m 46sthe patch passed
+1 💚spotbugs8m 18sthe patch passed
_ Other Tests _
+1 💚asflicense0m 52sThe patch does not generate ASF License warnings.
71m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux ce774313b86d 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count86 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 16sbranch-2 passed
+1 💚compile3m 27sbranch-2 passed
+1 💚shadedjars6m 48sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 28sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall4m 2sthe patch passed
+1 💚compile3m 27sthe patch passed
+1 💚javac3m 27sthe patch passed
+1 💚shadedjars6m 48spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 26sthe patch passed
_ Other Tests _
+1 💚unit0m 52shbase-protocol-shaded in the patch passed.
+1 💚unit2m 52shbase-client in the patch passed.
+1 💚unit132m 59shbase-server in the patch passed.
+1 💚unit6m 47shbase-thrift in the patch passed.
+1 💚unit7m 8shbase-shell in the patch passed.
188m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 434d45fa8f3d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/testReport/
Max. process+thread count4124 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall3m 41sbranch-2 passed
+1 💚compile3m 16sbranch-2 passed
+1 💚shadedjars6m 16sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 12sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 39sthe patch passed
+1 💚compile3m 17sthe patch passed
+1 💚javac3m 17sthe patch passed
+1 💚shadedjars6m 18spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 12sthe patch passed
_ Other Tests _
+1 💚unit0m 43shbase-protocol-shaded in the patch passed.
+1 💚unit2m 47shbase-client in the patch passed.
+1 💚unit156m 21shbase-server in the patch passed.
+1 💚unit6m 37shbase-thrift in the patch passed.
+1 💚unit7m 17shbase-shell in the patch passed.
209m 7s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux d04e8c71b767 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d470b25
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/testReport/
Max. process+thread count3456 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/3/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@joshelserjoshelser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea. I think we could take this good idea and make it a great idea though :)

Comment threadhbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java Outdated
Comment threadhbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Outdated
Comment threadhbase-shell/src/main/ruby/shell/commands/dry_run_balancer.rb Outdated
@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

@joshelser I pushed a commit which addresses most of your feedback. Thanks again! I have not addressed the interface changes, pending your thoughts on my recent comments. Happy to address those and squash all the commits once we come to a decision.

@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch from eca1e48 to 787c350CompareAugust 5, 2021 22:04
@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

I just pushed a commit which makes the changes we talked about in the Admin and RSGroupAdmin interfaces. I still need to update the shell, will do that tomorrow.

Overall I like how this came out, as I said I used a factory for now because we really don't have enough arguments to justify a builder. One thing I don't love is the duplication between hmaster and rsgroup, but that seems to be the name of the game with rsgroup for now. It caused a little bit of funkiness in order to handle the more strict RSGroupAdminServer interface though (i.e. the private BalanceRequest.forRunMode method).

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 56sbranch-2 passed
+1 💚compile7m 53sbranch-2 passed
+1 💚checkstyle3m 11sbranch-2 passed
+1 💚spotbugs8m 17sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 44sthe patch passed
+1 💚compile7m 49sthe patch passed
+1 💚cc7m 49sthe patch passed
-0 ⚠️javac0m 54shbase-rsgroup generated 6 new + 185 unchanged - 6 fixed = 191 total (was 191)
-0 ⚠️checkstyle0m 40shbase-client: The patch generated 12 new + 402 unchanged - 1 fixed = 414 total (was 403)
-0 ⚠️checkstyle1m 15shbase-server: The patch generated 3 new + 107 unchanged - 0 fixed = 110 total (was 107)
-0 ⚠️checkstyle0m 11shbase-rsgroup: The patch generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2)
-0 ⚠️rubocop0m 27sThe patch generated 16 new + 673 unchanged - 3 fixed = 689 total (was 676)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck12m 49sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc3m 10sthe patch passed
+1 💚spotbugs9m 16sthe patch passed
_ Other Tests _
+1 💚asflicense1m 3sThe patch does not generate ASF License warnings.
76m 1s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 2172bbf1cda7 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f0f519
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count86 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 33sMaven dependency ordering for branch
+1 💚mvninstall4m 8sbranch-2 passed
+1 💚compile3m 56sbranch-2 passed
+1 💚shadedjars6m 45sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 48sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 1sthe patch passed
+1 💚compile3m 54sthe patch passed
+1 💚javac3m 54sthe patch passed
+1 💚shadedjars6m 46spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 49sthe patch passed
_ Other Tests _
+1 💚unit0m 51shbase-protocol-shaded in the patch passed.
+1 💚unit2m 46shbase-client in the patch passed.
+1 💚unit133m 49shbase-server in the patch passed.
+1 💚unit6m 50shbase-thrift in the patch passed.
-1 ❌unit3m 8shbase-rsgroup in the patch failed.
-1 ❌unit7m 5shbase-shell in the patch failed.
194m 32s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a086c63719d3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f0f519
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/testReport/
Max. process+thread count4238 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 32sMaven dependency ordering for branch
+1 💚mvninstall3m 23sbranch-2 passed
+1 💚compile3m 27sbranch-2 passed
+1 💚shadedjars6m 2sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 25sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 19sthe patch passed
+1 💚compile3m 25sthe patch passed
+1 💚javac3m 25sthe patch passed
+1 💚shadedjars6m 3spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 23sthe patch passed
_ Other Tests _
+1 💚unit0m 41shbase-protocol-shaded in the patch passed.
+1 💚unit2m 42shbase-client in the patch passed.
-1 ❌unit145m 49shbase-server in the patch failed.
+1 💚unit6m 34shbase-thrift in the patch passed.
-1 ❌unit3m 50shbase-rsgroup in the patch failed.
-1 ❌unit7m 21shbase-shell in the patch failed.
202m 2s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 23cbc4fc89ca 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f0f519
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/testReport/
Max. process+thread count4168 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/4/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch from 8f4808a to 850b042CompareAugust 6, 2021 17:22
@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch 2 times, most recently from ec09f26 to ee1dec2CompareAugust 6, 2021 18:06
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 37sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 36sMaven dependency ordering for branch
+1 💚mvninstall4m 51sbranch-2 passed
+1 💚compile9m 40sbranch-2 passed
+1 💚checkstyle3m 33sbranch-2 passed
+1 💚spotbugs10m 3sbranch-2 passed
-0 ⚠️patch1m 39sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 39sthe patch passed
+1 💚compile9m 2sthe patch passed
+1 💚cc9m 2sthe patch passed
-0 ⚠️javac1m 2shbase-rsgroup generated 10 new + 181 unchanged - 10 fixed = 191 total (was 191)
-0 ⚠️checkstyle0m 47shbase-client: The patch generated 10 new + 387 unchanged - 1 fixed = 397 total (was 388)
-0 ⚠️checkstyle1m 25shbase-server: The patch generated 4 new + 97 unchanged - 0 fixed = 101 total (was 97)
-0 ⚠️checkstyle0m 15shbase-rsgroup: The patch generated 7 new + 2 unchanged - 0 fixed = 9 total (was 2)
-0 ⚠️rubocop0m 35sThe patch generated 20 new + 657 unchanged - 3 fixed = 677 total (was 660)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck15m 31sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc3m 44sthe patch passed
+1 💚spotbugs10m 37sthe patch passed
_ Other Tests _
+1 💚asflicense1m 8sThe patch does not generate ASF License warnings.
90m 56s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux f3575e338ffe 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f0f519
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count86 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch from ee1dec2 to 8bedb53CompareAugust 6, 2021 19:55
@bbeaudreault

bbeaudreault commented Aug 6, 2021

Copy link
Copy Markdown
ContributorAuthor

@joshelser@clarax This is ready for another look. To summarize the changes:

  • All of the interface changes have been combined into the new commit I just added. I'll squash everything into 1 commit once we are done here.
  • New class BalanceRequest (public/evolving), with 2 public factory methods, and 1 public builder method.
    • Create the BalancerRequest with either BalanceRequest#execute() or BalancerRequest#dryRun()
    • Once you have a BalancerRequest, you can optionally enable the old force mode with request#ignoreRegionsInTransition(). I thought it would be good to clarify what force means here, whereas a boolean is rather opaque.
    • As a result, both normal and dryRun can be modified with ignoreRegionsInTransition. This actually seems reasonable, and simplifies some things.
  • Similarly, I updated the hbase shell to have a single balance command. Previously you could execute the balance command with a "force" argument, now you can also specify a "dry_run" argument. You can also combine them, like with the BalanceRequest. I added a 'ignore_rit' option as replacement for 'force' in the future.
  • Both changes have also been applied to the RSGroup balance command.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for branch
+1 💚mvninstall3m 55sbranch-2 passed
+1 💚compile3m 54sbranch-2 passed
+1 💚shadedjars6m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 49sbranch-2 passed
-0 ⚠️patch10m 45sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall4m 1sthe patch passed
+1 💚compile3m 55sthe patch passed
+1 💚javac3m 55sthe patch passed
+1 💚shadedjars6m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 49sthe patch passed
_ Other Tests _
+1 💚unit0m 52shbase-protocol-shaded in the patch passed.
+1 💚unit2m 55shbase-client in the patch passed.
+1 💚unit134m 15shbase-server in the patch passed.
+1 💚unit6m 40shbase-thrift in the patch passed.
+1 💚unit3m 3shbase-rsgroup in the patch passed.
+1 💚unit7m 3shbase-shell in the patch passed.
194m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux c6a9402a5afb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f0f519
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/testReport/
Max. process+thread count4110 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 39sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 44sbranch-2 passed
+1 💚compile3m 25sbranch-2 passed
+1 💚shadedjars6m 1sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 28sbranch-2 passed
-0 ⚠️patch9m 34sUsed diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 24sthe patch passed
+1 💚compile3m 26sthe patch passed
+1 💚javac3m 26sthe patch passed
+1 💚shadedjars6m 5spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 25sthe patch passed
_ Other Tests _
+1 💚unit0m 42shbase-protocol-shaded in the patch passed.
+1 💚unit2m 39shbase-client in the patch passed.
+1 💚unit144m 8shbase-server in the patch passed.
+1 💚unit6m 29shbase-thrift in the patch passed.
+1 💚unit3m 18shbase-rsgroup in the patch passed.
+1 💚unit7m 15shbase-shell in the patch passed.
200m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 9914e2a4cea2 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f0f519
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/testReport/
Max. process+thread count4265 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/5/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 36sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 18sbranch-2 passed
+1 💚compile3m 24sbranch-2 passed
+1 💚shadedjars5m 58sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 24sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
-1 ❌mvninstall0m 59sroot in the patch failed.
-1 ❌compile0m 23shbase-client in the patch failed.
-1 ❌compile0m 37shbase-server in the patch failed.
-1 ❌compile0m 27shbase-thrift in the patch failed.
-1 ❌compile0m 22shbase-rsgroup in the patch failed.
-0 ⚠️javac0m 23shbase-client in the patch failed.
-0 ⚠️javac0m 37shbase-server in the patch failed.
-0 ⚠️javac0m 27shbase-thrift in the patch failed.
-0 ⚠️javac0m 22shbase-rsgroup in the patch failed.
-1 ❌shadedjars2m 55spatch has 52 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 25shbase-client generated 16 new + 3 unchanged - 0 fixed = 19 total (was 3)
-0 ⚠️javadoc0m 36shbase-server generated 4 new + 21 unchanged - 0 fixed = 25 total (was 21)
-0 ⚠️javadoc0m 32shbase-thrift generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13)
-0 ⚠️javadoc0m 22shbase-rsgroup generated 17 new + 0 unchanged - 0 fixed = 17 total (was 0)
_ Other Tests _
+1 💚unit0m 41shbase-protocol-shaded in the patch passed.
-1 ❌unit0m 23shbase-client in the patch failed.
-1 ❌unit0m 39shbase-server in the patch failed.
-1 ❌unit0m 28shbase-thrift in the patch failed.
-1 ❌unit0m 21shbase-rsgroup in the patch failed.
-1 ❌unit2m 33shbase-shell in the patch failed.
32m 46s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux b1dce07a601f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f0f519
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-thrift.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-rsgroup.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-client.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-thrift.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-compile-hbase-rsgroup.txt
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-client.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-thrift.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-thrift.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/testReport/
Max. process+thread count2413 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall4m 20sbranch-2 passed
+1 💚compile3m 56sbranch-2 passed
+1 💚shadedjars6m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 54sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
-1 ❌mvninstall1m 13sroot in the patch failed.
-1 ❌compile0m 26shbase-client in the patch failed.
-1 ❌compile0m 40shbase-server in the patch failed.
-1 ❌compile0m 30shbase-thrift in the patch failed.
-1 ❌compile0m 24shbase-rsgroup in the patch failed.
-0 ⚠️javac0m 26shbase-client in the patch failed.
-0 ⚠️javac0m 40shbase-server in the patch failed.
-0 ⚠️javac0m 30shbase-thrift in the patch failed.
-0 ⚠️javac0m 24shbase-rsgroup in the patch failed.
-1 ❌shadedjars3m 18spatch has 52 errors when building our shaded downstream artifacts.
-0 ⚠️javadoc0m 18shbase-client in the patch failed.
-0 ⚠️javadoc0m 23shbase-server in the patch failed.
-0 ⚠️javadoc0m 19shbase-thrift in the patch failed.
-0 ⚠️javadoc0m 18shbase-rsgroup in the patch failed.
_ Other Tests _
+1 💚unit0m 52shbase-protocol-shaded in the patch passed.
-1 ❌unit0m 26shbase-client in the patch failed.
-1 ❌unit0m 41shbase-server in the patch failed.
-1 ❌unit0m 31shbase-thrift in the patch failed.
-1 ❌unit0m 24shbase-rsgroup in the patch failed.
-1 ❌unit2m 5shbase-shell in the patch failed.
35m 57s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux ac3b538dbd01 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f0f519
Default JavaAdoptOpenJDK-11.0.10+9
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-rsgroup.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-rsgroup.txt
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-thrift.txt
javadochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-thrift.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/testReport/
Max. process+thread count2299 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 59sbranch-2 passed
+1 💚compile7m 56sbranch-2 passed
+1 💚checkstyle3m 13sbranch-2 passed
+1 💚spotbugs8m 11sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
-1 ❌mvninstall1m 2sroot in the patch failed.
-1 ❌compile0m 25shbase-client in the patch failed.
-1 ❌compile0m 41shbase-server in the patch failed.
-1 ❌compile0m 29shbase-thrift in the patch failed.
-1 ❌compile0m 21shbase-rsgroup in the patch failed.
-0 ⚠️cc0m 25shbase-client in the patch failed.
-0 ⚠️cc0m 41shbase-server in the patch failed.
-0 ⚠️cc0m 29shbase-thrift in the patch failed.
-0 ⚠️cc0m 21shbase-rsgroup in the patch failed.
-0 ⚠️javac0m 25shbase-client in the patch failed.
-0 ⚠️javac0m 41shbase-server in the patch failed.
-0 ⚠️javac0m 29shbase-thrift in the patch failed.
-0 ⚠️javac0m 21shbase-rsgroup in the patch failed.
-0 ⚠️checkstyle0m 39shbase-client: The patch generated 9 new + 402 unchanged - 1 fixed = 411 total (was 403)
-0 ⚠️checkstyle1m 14shbase-server: The patch generated 3 new + 107 unchanged - 0 fixed = 110 total (was 107)
-0 ⚠️checkstyle0m 11shbase-rsgroup: The patch generated 4 new + 2 unchanged - 0 fixed = 6 total (was 2)
-0 ⚠️rubocop0m 34sThe patch generated 53 new + 680 unchanged - 3 fixed = 733 total (was 683)
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌hadoopcheck1m 31sThe patch causes 52 errors with Hadoop v3.1.2.
-1 ❌hadoopcheck3m 1sThe patch causes 52 errors with Hadoop v3.2.1.
-1 ❌hbaseprotoc0m 22shbase-client in the patch failed.
-1 ❌hbaseprotoc0m 37shbase-server in the patch failed.
-1 ❌hbaseprotoc0m 28shbase-thrift in the patch failed.
-1 ❌hbaseprotoc0m 20shbase-rsgroup in the patch failed.
-1 ❌spotbugs0m 21shbase-client in the patch failed.
-1 ❌spotbugs0m 35shbase-server in the patch failed.
-1 ❌spotbugs0m 25shbase-thrift in the patch failed.
-1 ❌spotbugs0m 19shbase-rsgroup in the patch failed.
_ Other Tests _
+1 💚asflicense0m 54sThe patch does not generate ASF License warnings.
47m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux c99c783def07 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 4f0f519
Default JavaAdoptOpenJDK-1.8.0_282-b08
mvninstallhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt
compilehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-rsgroup.txt
cchttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
cchttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
cchttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt
cchttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-rsgroup.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-client.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-thrift.txt
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-compile-hbase-rsgroup.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/whitespace-eol.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheckhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-javac-3.2.1.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-client.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-server.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-thrift.txt
hbaseprotochttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-hbaseprotoc-hbase-rsgroup.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-client.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-thrift.txt
spotbugshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/artifact/yetus-general-check/output/patch-spotbugs-hbase-rsgroup.txt
Max. process+thread count86 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/6/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch 2 times, most recently from 42d3dff to f89b5b6CompareAugust 7, 2021 00:34
…nning the balancer without executing any region moves
@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch from c049fe3 to 4edd432CompareAugust 23, 2021 17:11
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 17sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 35sbranch-2 passed
+1 💚compile7m 41sbranch-2 passed
+1 💚checkstyle3m 12sbranch-2 passed
+1 💚spotbugs7m 55sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile7m 38sthe patch passed
+1 💚cc7m 38sthe patch passed
-0 ⚠️javac0m 53shbase-rsgroup generated 6 new + 185 unchanged - 6 fixed = 191 total (was 191)
-0 ⚠️checkstyle0m 42shbase-client: The patch generated 6 new + 387 unchanged - 1 fixed = 393 total (was 388)
-0 ⚠️checkstyle1m 10shbase-server: The patch generated 8 new + 181 unchanged - 1 fixed = 189 total (was 182)
-0 ⚠️checkstyle0m 41shbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle0m 13shbase-rsgroup: The patch generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2)
-0 ⚠️rubocop0m 26sThe patch generated 44 new + 657 unchanged - 3 fixed = 701 total (was 660)
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck11m 42sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc3m 16sthe patch passed
+1 💚spotbugs8m 43sthe patch passed
_ Other Tests _
+1 💚asflicense1m 18sThe patch does not generate ASF License warnings.
73m 3s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 7358aa322dcf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6ad7eb8
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
-0 ⚠️yetus0m 8sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 35sbranch-2 passed
+1 💚compile3m 27sbranch-2 passed
+1 💚shadedjars6m 3sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 27sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 22sthe patch passed
+1 💚compile3m 25sthe patch passed
+1 💚javac3m 25sthe patch passed
+1 💚shadedjars6m 2spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 25sthe patch passed
_ Other Tests _
+1 💚unit0m 42shbase-protocol-shaded in the patch passed.
+1 💚unit2m 37shbase-client in the patch passed.
+1 💚unit144m 25shbase-server in the patch passed.
+1 💚unit6m 57shbase-thrift in the patch passed.
+1 💚unit3m 23shbase-rsgroup in the patch passed.
+1 💚unit7m 21shbase-shell in the patch passed.
200m 53s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux e08925fdc574 4.15.0-151-generic #157-Ubuntu SMP Fri Jul 9 23:07:57 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6ad7eb8
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/testReport/
Max. process+thread count4219 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

Hey all, here's an update:

  • I've rolled all of the original commits into 1 commit, and included fixes for @ndimiduk's latest review.
  • I've also added a new commit which adds a BalanceResponse object, as we discussed. I am not sure I'll have time to come back to balancer improvements before 2.5.0, and I wanted to make sure we at least lock in the new IA.Evolving interface in case 2.5.0 ships before I or anyone else can get to it. In this PR, I do not want to go too crazy imagining all of the cool things we can add to the response. The new object has 3 fields: isBalancerRan, getMovesCalculated, getMovesExecuted. I actually think these on there own are useful for operators, so it seems like an OK starting place.

I'm not able to run the full test suite right now, so will be keeping an eye on the jenkins build and update if any tests fail. I didn't add an explicit testBalancerResponses test, but I did include assertions about the new fields in some existing tests.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 43sbranch-2 passed
+1 💚compile4m 7sbranch-2 passed
+1 💚shadedjars7m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 56sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for patch
+1 💚mvninstall4m 32sthe patch passed
+1 💚compile4m 7sthe patch passed
+1 💚javac4m 7sthe patch passed
+1 💚shadedjars7m 32spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 54sthe patch passed
_ Other Tests _
+1 💚unit0m 57shbase-protocol-shaded in the patch passed.
+1 💚unit3m 12shbase-client in the patch passed.
+1 💚unit202m 49shbase-server in the patch passed.
+1 💚unit7m 44shbase-thrift in the patch passed.
+1 💚unit4m 5shbase-rsgroup in the patch passed.
+1 💚unit8m 18shbase-shell in the patch passed.
270m 18s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 65d124ada2a9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6ad7eb8
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/testReport/
Max. process+thread count2760 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/18/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 7sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall3m 56sbranch-2 passed
+1 💚compile7m 52sbranch-2 passed
+1 💚checkstyle3m 12sbranch-2 passed
+1 💚spotbugs8m 19sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for patch
+1 💚mvninstall3m 37sthe patch passed
+1 💚compile7m 54sthe patch passed
+1 💚cc7m 54sthe patch passed
-0 ⚠️javac0m 55shbase-rsgroup generated 14 new + 177 unchanged - 14 fixed = 191 total (was 191)
-0 ⚠️checkstyle0m 41shbase-client: The patch generated 7 new + 385 unchanged - 3 fixed = 392 total (was 388)
-0 ⚠️checkstyle1m 17shbase-server: The patch generated 9 new + 189 unchanged - 1 fixed = 198 total (was 190)
-0 ⚠️checkstyle0m 45shbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle0m 12shbase-rsgroup: The patch generated 8 new + 2 unchanged - 0 fixed = 10 total (was 2)
-0 ⚠️rubocop0m 31sThe patch generated 47 new + 656 unchanged - 4 fixed = 703 total (was 660)
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck12m 57sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc3m 9sthe patch passed
+1 💚spotbugs9m 11sthe patch passed
_ Other Tests _
-1 ❌asflicense1m 5sThe patch generated 1 ASF License warnings.
75m 47s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 7aa3468b653a 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6ad7eb8
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/whitespace-eol.txt
asflicensehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-general-check/output/patch-asflicense-problems.txt
Max. process+thread count86 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 10sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall4m 50sbranch-2 passed
+1 💚compile4m 8sbranch-2 passed
+1 💚shadedjars7m 32sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 52sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 19sMaven dependency ordering for patch
+1 💚mvninstall4m 29sthe patch passed
+1 💚compile4m 8sthe patch passed
+1 💚javac4m 8sthe patch passed
-1 ❌shadedjars3m 42spatch has 10 errors when building our shaded downstream artifacts.
+1 💚javadoc2m 52sthe patch passed
_ Other Tests _
+1 💚unit0m 56shbase-protocol-shaded in the patch passed.
+1 💚unit3m 21shbase-client in the patch passed.
-1 ❌unit204m 48shbase-server in the patch failed.
+1 💚unit7m 51shbase-thrift in the patch passed.
-1 ❌unit4m 6shbase-rsgroup in the patch failed.
-1 ❌unit8m 18shbase-shell in the patch failed.
268m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a8ab896740f4 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6ad7eb8
Default JavaAdoptOpenJDK-11.0.10+9
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/testReport/
Max. process+thread count2855 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 11sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 59sbranch-2 passed
+1 💚compile3m 28sbranch-2 passed
+1 💚shadedjars6m 35sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 17sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall3m 46sthe patch passed
+1 💚compile3m 23sthe patch passed
+1 💚javac3m 23sthe patch passed
-1 ❌shadedjars3m 14spatch has 10 errors when building our shaded downstream artifacts.
+1 💚javadoc2m 17sthe patch passed
_ Other Tests _
+1 💚unit0m 43shbase-protocol-shaded in the patch passed.
+1 💚unit2m 54shbase-client in the patch passed.
-1 ❌unit220m 23shbase-server in the patch failed.
+1 💚unit8m 0shbase-thrift in the patch passed.
-1 ❌unit4m 49shbase-rsgroup in the patch failed.
-1 ❌unit7m 8shbase-shell in the patch failed.
277m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 3dab6ac1a5cb 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6ad7eb8
Default JavaAdoptOpenJDK-1.8.0_282-b08
shadedjarshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/patch-shadedjars.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/testReport/
Max. process+thread count2569 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/19/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch from 7995e64 to e20b5f7CompareAugust 24, 2021 12:10
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall3m 43sbranch-2 passed
+1 💚compile7m 56sbranch-2 passed
+1 💚checkstyle3m 9sbranch-2 passed
+1 💚spotbugs8m 20sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall3m 41sthe patch passed
+1 💚compile7m 51sthe patch passed
+1 💚cc7m 51sthe patch passed
-0 ⚠️javac0m 54shbase-rsgroup generated 14 new + 177 unchanged - 14 fixed = 191 total (was 191)
-0 ⚠️checkstyle0m 39shbase-client: The patch generated 7 new + 385 unchanged - 3 fixed = 392 total (was 388)
-0 ⚠️checkstyle1m 17shbase-server: The patch generated 9 new + 189 unchanged - 1 fixed = 198 total (was 190)
-0 ⚠️checkstyle0m 44shbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle0m 12shbase-rsgroup: The patch generated 8 new + 2 unchanged - 0 fixed = 10 total (was 2)
-0 ⚠️rubocop0m 30sThe patch generated 50 new + 656 unchanged - 4 fixed = 706 total (was 660)
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck12m 51sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc3m 10sthe patch passed
+1 💚spotbugs9m 13sthe patch passed
_ Other Tests _
+1 💚asflicense1m 2sThe patch does not generate ASF License warnings.
75m 56s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 58143f247837 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d8fb978
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count86 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 31sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 28sMaven dependency ordering for branch
+1 💚mvninstall3m 24sbranch-2 passed
+1 💚compile3m 24sbranch-2 passed
+1 💚shadedjars6m 25sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 25sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for patch
+1 💚mvninstall3m 30sthe patch passed
+1 💚compile3m 27sthe patch passed
+1 💚javac3m 27sthe patch passed
+1 💚shadedjars6m 21spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 25sthe patch passed
_ Other Tests _
+1 💚unit0m 44shbase-protocol-shaded in the patch passed.
+1 💚unit2m 47shbase-client in the patch passed.
+1 💚unit146m 40shbase-server in the patch passed.
+1 💚unit6m 57shbase-thrift in the patch passed.
-1 ❌unit3m 31shbase-rsgroup in the patch failed.
-1 ❌unit7m 13shbase-shell in the patch failed.
204m 23s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 06113b81d516 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d8fb978
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/testReport/
Max. process+thread count3740 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault
bbeaudreaultforce-pushed the dry_run_balancer_upstream branch from e20b5f7 to 279d251CompareAugust 24, 2021 17:19
@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 41sDocker mode activated.
-0 ⚠️yetus0m 5sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall5m 27sbranch-2 passed
+1 💚compile5m 4sbranch-2 passed
+1 💚shadedjars9m 20sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 47sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 22sMaven dependency ordering for patch
+1 💚mvninstall5m 34sthe patch passed
+1 💚compile4m 56sthe patch passed
+1 💚javac4m 56sthe patch passed
+1 💚shadedjars9m 22spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 21sthe patch passed
_ Other Tests _
+1 💚unit1m 3shbase-protocol-shaded in the patch passed.
+1 💚unit3m 21shbase-client in the patch passed.
+1 💚unit231m 55shbase-server in the patch passed.
+1 💚unit9m 27shbase-thrift in the patch passed.
-1 ❌unit5m 45shbase-rsgroup in the patch failed.
-1 ❌unit7m 15shbase-shell in the patch failed.
311m 26s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fc157ee9504a 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / d8fb978
Default JavaAdoptOpenJDK-11.0.10+9
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rsgroup.txt
unithttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-shell.txt
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/testReport/
Max. process+thread count2802 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/20/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 0sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 34sMaven dependency ordering for branch
+1 💚mvninstall4m 38sbranch-2 passed
+1 💚compile9m 34sbranch-2 passed
+1 💚checkstyle3m 45sbranch-2 passed
+1 💚spotbugs10m 10sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall4m 17sthe patch passed
+1 💚compile9m 33sthe patch passed
+1 💚cc9m 33sthe patch passed
-0 ⚠️javac1m 2shbase-rsgroup generated 12 new + 179 unchanged - 12 fixed = 191 total (was 191)
-0 ⚠️checkstyle0m 48shbase-client: The patch generated 7 new + 385 unchanged - 3 fixed = 392 total (was 388)
-0 ⚠️checkstyle1m 26shbase-server: The patch generated 9 new + 189 unchanged - 1 fixed = 198 total (was 190)
-0 ⚠️checkstyle0m 50shbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle0m 15shbase-rsgroup: The patch generated 8 new + 2 unchanged - 0 fixed = 10 total (was 2)
-0 ⚠️rubocop0m 43sThe patch generated 50 new + 656 unchanged - 4 fixed = 706 total (was 660)
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck15m 55sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc3m 48sthe patch passed
+1 💚spotbugs11m 37sthe patch passed
_ Other Tests _
+1 💚asflicense1m 13sThe patch does not generate ASF License warnings.
93m 6s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 7c5c3289e7dc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5dad395
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for branch
+1 💚mvninstall4m 23sbranch-2 passed
+1 💚compile4m 4sbranch-2 passed
+1 💚shadedjars6m 51sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 47sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 20sMaven dependency ordering for patch
+1 💚mvninstall4m 7sthe patch passed
+1 💚compile3m 57sthe patch passed
+1 💚javac3m 57sthe patch passed
+1 💚shadedjars6m 59spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 51sthe patch passed
_ Other Tests _
+1 💚unit0m 53shbase-protocol-shaded in the patch passed.
+1 💚unit2m 29shbase-client in the patch passed.
+1 💚unit134m 18shbase-server in the patch passed.
+1 💚unit6m 8shbase-thrift in the patch passed.
+1 💚unit3m 46shbase-rsgroup in the patch passed.
+1 💚unit7m 57shbase-shell in the patch passed.
196m 26s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 6cad95254a5c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5dad395
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/testReport/
Max. process+thread count3852 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall3m 55sbranch-2 passed
+1 💚compile3m 26sbranch-2 passed
+1 💚shadedjars6m 37sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 19sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for patch
+1 💚mvninstall3m 45sthe patch passed
+1 💚compile3m 26sthe patch passed
+1 💚javac3m 26sthe patch passed
+1 💚shadedjars6m 39spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 15sthe patch passed
_ Other Tests _
+1 💚unit0m 42shbase-protocol-shaded in the patch passed.
+1 💚unit2m 33shbase-client in the patch passed.
+1 💚unit221m 10shbase-server in the patch passed.
+1 💚unit7m 33shbase-thrift in the patch passed.
+1 💚unit4m 56shbase-rsgroup in the patch passed.
+1 💚unit7m 17shbase-shell in the patch passed.
281m 0s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 1182ea171bf9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 5dad395
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/testReport/
Max. process+thread count2557 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/21/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

@joshelser@ndimiduk fyi this is ready for review again. Tests are now passing.

@joshelserjoshelser left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions around javadoc on public classes. Given the magnitude of this patch (and my tardiness on reviews), I'm OK to defer that to a follow-on.

The documentation and new tests included in this already is excellent. Wonderful work.

I like how the BalancerRequest/Response worked out on the API. I almost left a comment about re-using BalancerRequest on the BalanceRSGroupRequest (rather than duplicating the attributes), but decided against it.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

Thanks for the reviews everyone. I discussed with @joshelser and will submit a separate PR for documentation improvements since this one already has a long and storied past.

If someone could merge, that'd be great. Unfortunately it does not apply cleanly to master, so I will work on a PR for that now.

@bbeaudreault

Copy link
Copy Markdown
ContributorAuthor

Soo, in the master port PR Duo asked that I remove the InterfaceStability annotations. I didn't realize those were not supposed to be on IA.Public. I just pushed a commit here to do that as well, and as part of that I addressed @joshelser's feedback about docs. Hopefully we're good now! :)

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 33sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗prototool0m 0sprototool was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 18sMaven dependency ordering for branch
+1 💚mvninstall3m 51sbranch-2 passed
+1 💚compile8m 28sbranch-2 passed
+1 💚checkstyle3m 21sbranch-2 passed
+1 💚spotbugs8m 42sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for patch
+1 💚mvninstall3m 35sthe patch passed
+1 💚compile8m 32sthe patch passed
+1 💚cc8m 32sthe patch passed
-0 ⚠️javac0m 59shbase-rsgroup generated 12 new + 179 unchanged - 12 fixed = 191 total (was 191)
-0 ⚠️checkstyle0m 43shbase-client: The patch generated 7 new + 385 unchanged - 3 fixed = 392 total (was 388)
-0 ⚠️checkstyle1m 14shbase-server: The patch generated 9 new + 189 unchanged - 1 fixed = 198 total (was 190)
-0 ⚠️checkstyle0m 42shbase-thrift: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-0 ⚠️checkstyle0m 14shbase-rsgroup: The patch generated 8 new + 2 unchanged - 0 fixed = 10 total (was 2)
-0 ⚠️rubocop0m 27sThe patch generated 50 new + 656 unchanged - 4 fixed = 706 total (was 660)
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚hadoopcheck12m 30sPatch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚hbaseprotoc3m 29sthe patch passed
+1 💚spotbugs9m 50sthe patch passed
_ Other Tests _
+1 💚asflicense1m 21sThe patch does not generate ASF License warnings.
78m 15s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool rubocop
unameLinux 14f9dc81c71a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 3b1482e
Default JavaAdoptOpenJDK-1.8.0_282-b08
javachttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-compile-javac-hbase-rsgroup.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-checkstyle-hbase-thrift.txt
checkstylehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-checkstyle-hbase-rsgroup.txt
rubocophttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/diff-patch-rubocop.txt
whitespacehttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count96 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec3m 53sDocker mode activated.
-0 ⚠️yetus0m 7sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 16sMaven dependency ordering for branch
+1 💚mvninstall3m 41sbranch-2 passed
+1 💚compile3m 27sbranch-2 passed
+1 💚shadedjars6m 7sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 24sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall3m 18sthe patch passed
+1 💚compile3m 23sthe patch passed
+1 💚javac3m 23sthe patch passed
+1 💚shadedjars6m 1spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 25sthe patch passed
_ Other Tests _
+1 💚unit0m 45shbase-protocol-shaded in the patch passed.
+1 💚unit2m 32shbase-client in the patch passed.
+1 💚unit145m 14shbase-server in the patch passed.
+1 💚unit7m 35shbase-thrift in the patch passed.
+1 💚unit3m 55shbase-rsgroup in the patch passed.
+1 💚unit7m 20shbase-shell in the patch passed.
206m 7s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 0cf785622332 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 3b1482e
Default JavaAdoptOpenJDK-1.8.0_282-b08
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/testReport/
Max. process+thread count4113 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 51sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 30sMaven dependency ordering for branch
+1 💚mvninstall4m 34sbranch-2 passed
+1 💚compile4m 16sbranch-2 passed
+1 💚shadedjars7m 42sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 58sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 17sMaven dependency ordering for patch
+1 💚mvninstall4m 48sthe patch passed
+1 💚compile4m 15sthe patch passed
+1 💚javac4m 15sthe patch passed
+1 💚shadedjars7m 37spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 57sthe patch passed
_ Other Tests _
+1 💚unit0m 59shbase-protocol-shaded in the patch passed.
+1 💚unit2m 40shbase-client in the patch passed.
+1 💚unit144m 3shbase-server in the patch passed.
+1 💚unit6m 20shbase-thrift in the patch passed.
+1 💚unit4m 3shbase-rsgroup in the patch passed.
+1 💚unit8m 12shbase-shell in the patch passed.
210m 19s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#3536
JIRA IssueHBASE-26147
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 23e91798c123 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 3b1482e
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/testReport/
Max. process+thread count3715 (vs. ulimit of 12500)
modulesC: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-rsgroup hbase-shell U: .
Console outputhttps://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3536/22/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@joshelser

Copy link
Copy Markdown
Member

Flakiness on TestFSHLogProvider. Passed on rerun.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@bbeaudreault@Apache-HBase@clarax@ndimiduk@joshelser@saintstack@apurtell