Skip to content

HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (#4747) - #4751

Merged
meszibalu merged 1 commit into
apache:branch-2from
anmolnar:HBASE-27342_b2
Sep 1, 2022
Merged

HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (#4747)#4751
meszibalu merged 1 commit into
apache:branch-2from
anmolnar:HBASE-27342_b2

Conversation

@anmolnar

@anmolnaranmolnar commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Andrew Purtell apurtell@apache.org
Signed-off-by: Duo Zhang zhangduo@apache.org
Signed-off-by: Balazs Meszaros meszibalu@apache.org

@Apache-HBase

Apache-HBase commented Aug 31, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 51sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 43sMaven dependency ordering for branch
+1 💚mvninstall2m 26sbranch-2 passed
+1 💚compile6m 50sbranch-2 passed
+1 💚checkstyle1m 4sbranch-2 passed
+1 💚spotless0m 40sbranch has no errors when running spotless:check.
+1 💚spotbugs9m 43sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 13sthe patch passed
+1 💚compile6m 35sthe patch passed
+1 💚javac6m 35sthe patch passed
+1 💚checkstyle0m 58sthe patch passed
+1 💚shellcheck0m 1sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 32sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 40spatch has no errors when running spotless:check.
+1 💚spotbugs10m 8sthe patch passed
_ Other Tests _
+1 💚asflicense0m 32sThe patch does not generate ASF License warnings.
58m 36s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4751
Optional Testsdupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux fbad4135bdf4 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6a7a91a
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count138 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/1/console
versionsgit=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 31, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 52sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall2m 51sbranch-2 passed
+1 💚compile1m 45sbranch-2 passed
+1 💚shadedjars4m 13sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 44sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 33sthe patch passed
+1 💚compile1m 45sthe patch passed
+1 💚javac1m 45sthe patch passed
+1 💚shadedjars4m 7spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 40sthe patch passed
_ Other Tests _
+1 💚unit243m 0sroot in the patch passed.
269m 41s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4751
Optional Testsjavac javadoc unit shadedjars compile
unameLinux a148e69b6a3c 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6a7a91a
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/1/testReport/
Max. process+thread count5139 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 31, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec2m 4sDocker mode activated.
-0 ⚠️yetus0m 4sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 14sMaven dependency ordering for branch
+1 💚mvninstall3m 3sbranch-2 passed
+1 💚compile2m 6sbranch-2 passed
+1 💚shadedjars4m 53sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 20sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 37sthe patch passed
+1 💚compile2m 16sthe patch passed
+1 💚javac2m 16sthe patch passed
+1 💚shadedjars4m 11spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 21sthe patch passed
_ Other Tests _
-1 ❌unit288m 47sroot in the patch failed.
319m 10s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4751
Optional Testsjavac javadoc unit shadedjars compile
unameLinux cdd4268e7622 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / 6a7a91a
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/1/testReport/
Max. process+thread count2063 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Aug 31, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 56sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 1sNo case conflicting files found.
+0 🆗shelldocs0m 1sShelldocs was not available.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall2m 26sbranch-2 passed
+1 💚compile7m 58sbranch-2 passed
+1 💚checkstyle1m 5sbranch-2 passed
+1 💚spotless0m 53sbranch has no errors when running spotless:check.
+1 💚spotbugs11m 52sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 33sthe patch passed
+1 💚compile8m 3sthe patch passed
+1 💚javac8m 3sthe patch passed
+1 💚checkstyle1m 18sthe patch passed
+1 💚shellcheck0m 2sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck10m 11sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 54spatch has no errors when running spotless:check.
+1 💚spotbugs14m 27sthe patch passed
_ Other Tests _
+1 💚asflicense1m 3sThe patch does not generate ASF License warnings.
71m 12s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4751
Optional Testsdupname asflicense spotless shellcheck shelldocs javac spotbugs hadoopcheck hbaseanti checkstyle compile
unameLinux 80468bf100b6 5.4.0-1083-aws #90~18.04.1-Ubuntu SMP Fri Aug 5 08:12:44 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a7dab37
Default JavaAdoptOpenJDK-1.8.0_282-b08
Max. process+thread count138 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/2/console
versionsgit=2.17.1 maven=3.6.3 shellcheck=0.4.6 spotbugs=4.2.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 1, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 54sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
+1 💚mvninstall2m 52sbranch-2 passed
+1 💚compile1m 49sbranch-2 passed
+1 💚shadedjars4m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 42sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for patch
+1 💚mvninstall2m 30sthe patch passed
+1 💚compile1m 46sthe patch passed
+1 💚javac1m 46sthe patch passed
+1 💚shadedjars4m 8spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 43sthe patch passed
_ Other Tests _
+1 💚unit237m 51sroot in the patch passed.
263m 34s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4751
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 83f29f860afe 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a7dab37
Default JavaAdoptOpenJDK-11.0.10+9
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/2/testReport/
Max. process+thread count5021 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 1, 2022

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 32sDocker mode activated.
-0 ⚠️yetus0m 6sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2 Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for branch
+1 💚mvninstall3m 2sbranch-2 passed
+1 💚compile2m 13sbranch-2 passed
+1 💚shadedjars5m 11sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc3m 14sbranch-2 passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall3m 1sthe patch passed
+1 💚compile2m 14sthe patch passed
+1 💚javac2m 14sthe patch passed
+1 💚shadedjars4m 21spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc2m 59sthe patch passed
_ Other Tests _
-1 ❌unit335m 22sroot in the patch failed.
366m 24s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR#4751
Optional Testsjavac javadoc unit shadedjars compile
unameLinux fcb6d06c857f 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionbranch-2 / a7dab37
Default JavaAdoptOpenJDK-1.8.0_282-b08
unithttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/2/testReport/
Max. process+thread count2108 (vs. ulimit of 30000)
modulesC: hbase-common hbase-client hbase-server . U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4751/2/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@anmolnar
HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS k…
e1c1fe9
…ey/trust stores (apache#4747)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
@meszibalu
meszibalu merged commit 9838c07 into apache:branch-2Sep 1, 2022
@anmolnar
anmolnar deleted the HBASE-27342_b2 branch September 1, 2022 12:00
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Oct 4, 2022
@anmolnar@bbeaudreault
HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS k…
21d6409
…ey/trust stores (apache#4751)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Apr 2, 2023
@anmolnar@bbeaudreault
HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS k…
45eecf2
…ey/trust stores (apache#4751)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Apr 4, 2023
@anmolnar@bbeaudreault
HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS k…
6676fac
…ey/trust stores (apache#4751)
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
bbeaudreault added a commit to HubSpot/hbase that referenced this pull request Apr 7, 2023
@bbeaudreault
Backport native TLS to hubspot-2.5 (#49)
51bdd16
* HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty handler (apache#4624)
* HBASE-27185 Addendum fix TestShadeSaslAuthenticationProvider
* HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (apache#4676)
* HBASE-26666 Add native TLS encryption support to RPC server/client (apache#4666)
* HBASE-27278 Improve TestTlsIPC to reuse existing IPC test code (apache#4682)
* HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler (apache#4705)
* HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (apache#4751)
* HBASE-27346 Autodetect key/truststore file type from file extension (apache#4757)
* HBASE-27280 Add mutual authentication support to TLS (apache#4796)
* HBASE-27673 Fix mTLS client hostname verification (apache#5066)
* HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) (apache#4897)
* HBASE-27779 Make X509Util config constants public
* HBASE-27578 Upgrade hbase-thirdparty to 4.1.4 (apache#4985)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@anmolnar
CDPD-43982 Use Hadoop Credentials API to retrieve passwords of TLS ke…
346a9c1
…y/trust stores
Backport the change related to the follwing Jira:
HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (apache#4751)
This commit does not contain secrets.
Signed-off-by: Andrew Purtell <apurtell@apache.org>
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Signed-off-by: Balazs Meszaros <meszibalu@apache.org>
(cherry picked from commit 9838c07)
Change-Id: I593ede1759c818539b20f3c6e8aa399bfa3088d4
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meszibalumeszibalumeszibalu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anmolnar@Apache-HBase@meszibalu