Skip to content

HBASE-27280 Add mutual authentication support to TLS - #4796

Merged
bbeaudreault merged 2 commits into
apache:masterfrom
HubSpot:HBASE-27280-take-two
Sep 23, 2022
Merged

HBASE-27280 Add mutual authentication support to TLS#4796
bbeaudreault merged 2 commits into
apache:masterfrom
HubSpot:HBASE-27280-take-two

Conversation

@bbeaudreault

@bbeaudreaultbbeaudreault commented Sep 23, 2022

Copy link
Copy Markdown
Contributor

Recreating #4724 due to build issues

cc @Apache9

@Apache-HBase

Apache-HBase commented Sep 23, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 38sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
+1 💚mvninstall2m 23smaster passed
+1 💚compile2m 48smaster passed
+1 💚checkstyle0m 38smaster passed
+1 💚spotless0m 40sbranch has no errors when running spotless:check.
+1 💚spotbugs1m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 10sMaven dependency ordering for patch
+1 💚mvninstall2m 12sthe patch passed
+1 💚compile2m 46sthe patch passed
-0 ⚠️javac2m 17shbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚checkstyle0m 39sthe patch passed
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚hadoopcheck8m 2sPatch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚spotless0m 37spatch has no errors when running spotless:check.
+1 💚spotbugs1m 51sthe patch passed
_ Other Tests _
+1 💚asflicense0m 15sThe patch does not generate ASF License warnings.
31m 9s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4796/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#4796
Optional Testsdupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
unameLinux f52fe3ea24a0 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cc4268a
Default JavaTemurin-1.8.0_345-b01
javachttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4796/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count64 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4796/1/console
versionsgit=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 23, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 13sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 42smaster passed
+1 💚compile1m 3smaster passed
+1 💚shadedjars3m 50sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 44smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 34sthe patch passed
+1 💚compile1m 5sthe patch passed
+1 💚javac1m 5sthe patch passed
+1 💚shadedjars3m 47spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 42sthe patch passed
_ Other Tests _
+1 💚unit2m 8shbase-common in the patch passed.
+1 💚unit205m 20shbase-server in the patch passed.
227m 26s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4796/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#4796
Optional Testsjavac javadoc unit shadedjars compile
unameLinux 377012c3ac1e 5.4.0-122-generic #138-Ubuntu SMP Wed Jun 22 15:00:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cc4268a
Default JavaEclipse Adoptium-11.0.16.1+1
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4796/1/testReport/
Max. process+thread count2276 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4796/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Apache-HBase commented Sep 23, 2022

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 23sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚mvninstall2m 22smaster passed
+1 💚compile0m 55smaster passed
+1 💚shadedjars3m 48sbranch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 41smaster passed
_ Patch Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for patch
+1 💚mvninstall2m 15sthe patch passed
+1 💚compile0m 55sthe patch passed
+1 💚javac0m 55sthe patch passed
+1 💚shadedjars3m 51spatch has no errors when building our shaded downstream artifacts.
+1 💚javadoc0m 39sthe patch passed
_ Other Tests _
+1 💚unit1m 52shbase-common in the patch passed.
+1 💚unit209m 26shbase-server in the patch passed.
230m 26s
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4796/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#4796
Optional Testsjavac javadoc unit shadedjars compile
unameLinux bf89bec0e1d0 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / cc4268a
Default JavaTemurin-1.8.0_345-b01
Test Resultshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4796/1/testReport/
Max. process+thread count2633 (vs. ulimit of 30000)
modulesC: hbase-common hbase-server U: .
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4796/1/console
versionsgit=2.17.1 maven=3.6.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9
Apache9 approved these changes Sep 23, 2022
View reviewed changes

@Apache9Apache9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it

@bbeaudreault
bbeaudreault merged commit 5baeacb into apache:masterSep 23, 2022
@bbeaudreault
bbeaudreault deleted the HBASE-27280-take-two branch September 23, 2022 12:36
bbeaudreault added a commit that referenced this pull request Sep 23, 2022
@bbeaudreault
HBASE-27280Add mutual authentication support to TLS (#4796)
2a92819
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Andor Molnár <andor@cloudera.com>
bbeaudreault added a commit to HubSpot/hbase that referenced this pull request Oct 4, 2022
@bbeaudreault
HBASE-27280 Add mutual authentication support to TLS (apache#4796)
933e011
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Andor Molnár <andor@cloudera.com>
bbeaudreault added a commit to HubSpot/hbase that referenced this pull request Apr 2, 2023
@bbeaudreault
HBASE-27280 Add mutual authentication support to TLS (apache#4796)
05ee184
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Andor Molnár <andor@cloudera.com>
bbeaudreault added a commit to HubSpot/hbase that referenced this pull request Apr 4, 2023
@bbeaudreault
HBASE-27280 Add mutual authentication support to TLS (apache#4796)
92c65b8
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Andor Molnár <andor@cloudera.com>
bbeaudreault added a commit to HubSpot/hbase that referenced this pull request Apr 7, 2023
@bbeaudreault
Backport native TLS to hubspot-2.5 (#49)
51bdd16
* HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty handler (apache#4624)
* HBASE-27185 Addendum fix TestShadeSaslAuthenticationProvider
* HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (apache#4676)
* HBASE-26666 Add native TLS encryption support to RPC server/client (apache#4666)
* HBASE-27278 Improve TestTlsIPC to reuse existing IPC test code (apache#4682)
* HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler (apache#4705)
* HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (apache#4751)
* HBASE-27346 Autodetect key/truststore file type from file extension (apache#4757)
* HBASE-27280 Add mutual authentication support to TLS (apache#4796)
* HBASE-27673 Fix mTLS client hostname verification (apache#5066)
* HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) (apache#4897)
* HBASE-27779 Make X509Util config constants public
* HBASE-27578 Upgrade hbase-thirdparty to 4.1.4 (apache#4985)
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@bbeaudreault@meszibalu
HBASE-27280 Add mutual authentication support to TLS (apache#4796)
c8c7d65
Signed-off-by: Duo Zhang <zhangduo@apache.org>
Reviewed-by: Andor Molnár <andor@cloudera.com>
(cherry picked from commit 2a92819)
Change-Id: I99ccb0c39e410bf63e0a03b3b956c0f880831675
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Apache9Apache9Apache9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bbeaudreault@Apache-HBase@Apache9