Uh oh!
There was an error while loading. Please reload this page.
HBASE-27278 Improve TestTlsIPC to reuse existing IPC test code - #4682
Conversation
Apache9
commented
Aug 7, 2022
This is what I got so far, the bad news is, there are several failures, such as testAsyncEcho... Seems like multi threading problems, as in async mode we can send multiple request at once. Will dig more. |
Apache9
commented
Aug 7, 2022
Apache-HBase
commented
Aug 7, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 7, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 7, 2022
💔 -1 overall
This message was automatically generated. |
anmolnar
commented
Aug 7, 2022
publicvoidtestAsyncEcho() throwsIOException {
Configurationconf = HBaseConfiguration.create();
RpcServerrpcServer = createRpcServer(null, "testRpcServer",
Lists.newArrayList(newRpcServer.BlockingServiceAndInterface(SERVICE, null)),
newInetSocketAddress("localhost", 0), CONF, newFifoRpcScheduler(CONF, 1));
try (AbstractRpcClient<?> client = createRpcClient(conf)) {Looks like client TLS never gets enabled in this test. If I change "conf" to "CONF", the test will pass. |
anmolnar
commented
Aug 7, 2022
I can make the other 2 tests passing by deriving the client config from CONF. Though I'm not sure, if this is the right thing to do as creating new config for the client might be intentional. So, the other thing we can do is to enable client TLS separately for these config instances. |
| /** | ||
| * Will cache X509TestContext to speed up tests. | ||
| */ | ||
| public class X509TestContextProvider { |
There was a problem hiding this comment.
Did you copy this file from ZooKeeper codebase by any chance? We have exactly the same cache for the same purpose.
There was a problem hiding this comment.
No, I implemented it by my own. Glad to see that people have the same thoughts :)
Apache9
commented
Aug 8, 2022
OK, the failure is just a test issue. Updated the PR. |
Apache9
commented
Aug 8, 2022
Yes, this is the problem. I change the tests to create a new configuration based on the existing one, not a fresh new one. |
Apache9
commented
Aug 8, 2022
I also changed the tests to be more 'HBase style'. For example, rename 'hbaseConf' to 'conf' since we are already in the hbase project. And also, use HBaseCommonTestingUtil to create/remove testing directories, etc. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache9
commented
Aug 8, 2022
Seems a pre commit problem... I've already removed TestTlsIPC in the patch but when compiling we still reference it... |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
🎊 +1 overall
This message was automatically generated. |
anmolnar
commented
Aug 8, 2022
@busbey mentioned some weird behaviour with Yetus about an entire test file cannot be removed in a single patch. You have to mark it with Ignore first and remove it in an upcoming PR. |
Apache9
commented
Aug 8, 2022
Seems OK now. |
Apache-HBase
commented
Aug 8, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 8, 2022
💔 -1 overall
This message was automatically generated. |
Apache9
commented
Aug 9, 2022
@anmolnar PTAL? Thanks. |
Apache-HBase
commented
Aug 9, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2022
💔 -1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2022
🎊 +1 overall
This message was automatically generated. |
Apache-HBase
commented
Aug 9, 2022
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
left a comment
There was a problem hiding this comment.
Nice, looks like a good testing improvement/unification. Thanks!
Apache9
commented
Aug 12, 2022
Thanks @bbeaudreault ! |
Signed-off-by: Bryan Beaudreault <bbeaudreault@apache.org> (cherry picked from commit 3309108)
anmolnar
left a comment
There was a problem hiding this comment.
+1
Sorry for the late review, I was on vacation.
* HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty handler (apache#4624) * HBASE-27185 Addendum fix TestShadeSaslAuthenticationProvider * HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (apache#4676) * HBASE-26666 Add native TLS encryption support to RPC server/client (apache#4666) * HBASE-27278 Improve TestTlsIPC to reuse existing IPC test code (apache#4682) * HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler (apache#4705) * HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (apache#4751) * HBASE-27346 Autodetect key/truststore file type from file extension (apache#4757) * HBASE-27280 Add mutual authentication support to TLS (apache#4796) * HBASE-27673 Fix mTLS client hostname verification (apache#5066) * HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) (apache#4897) * HBASE-27779 Make X509Util config constants public * HBASE-27578 Upgrade hbase-thirdparty to 4.1.4 (apache#4985)
No description provided.