Skip to content

HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform - #5286

Merged
wchevreuil merged 2 commits into
apache:masterfrom
wchevreuil:HBASE-27915
May 22, 2024
Merged

HBASE-27915 Update hbase_docker with an extra Dockerfile compatible with mac m1 platform#5286
wchevreuil merged 2 commits into
apache:masterfrom
wchevreuil:HBASE-27915

Conversation

@wchevreuil

Copy link
Copy Markdown
Contributor

No description provided.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 3sMaven dependency ordering for patch
_ Other Tests _
1m 25s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5286
Optional Tests
unameLinux 140b3979593e 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d9757c7
Max. process+thread count40 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 3sMaven dependency ordering for patch
_ Other Tests _
1m 24s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5286
Optional Tests
unameLinux 3a5472d7dee9 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d9757c7
Max. process+thread count33 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 58sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+0 🆗markdownlint0m 0smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
+1 💚spotless0m 56sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for patch
-1 ❌hadolint0m 0sThe patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌spotless0m 6spatch has 17 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
3m 5s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5286
Optional Testsdupname asflicense spotless hadolint shellcheck shelldocs markdownlint
unameLinux 2a492cf31d59 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / d9757c7
hadolinthttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-general-check/output/diff-patch-hadolint.txt
whitespacehttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-general-check/output/whitespace-eol.txt
spotlesshttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count43 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/1/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0 hadolint=Haskell Dockerfile Linter 2.10.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
Contributor

What if we just change the original dockerfile? It will break normal x86 or arm platform?

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 3sMaven dependency ordering for patch
_ Other Tests _
1m 18s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5286
Optional Tests
unameLinux 86e52380b30c 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 68da890
Max. process+thread count32 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 8sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 11sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
_ Other Tests _
2m 8s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5286
Optional Tests
unameLinux 83b3f2d29f31 5.4.0-144-generic #161-Ubuntu SMP Fri Feb 3 14:49:04 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 68da890
Max. process+thread count38 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 50sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+0 🆗markdownlint0m 0smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚spotless0m 41sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
-1 ❌hadolint0m 0sThe patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
-0 ⚠️whitespace0m 0sThe patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌spotless0m 5spatch has 17 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
2m 38s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5286
Optional Testsdupname asflicense spotless hadolint shellcheck shelldocs markdownlint
unameLinux 54a29a480721 5.4.0-148-generic #165-Ubuntu SMP Tue Apr 18 08:53:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 68da890
hadolinthttps://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-general-check/output/diff-patch-hadolint.txt
whitespacehttps://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-general-check/output/whitespace-eol.txt
spotlesshttps://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count43 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/hbase-kustomize-github-pr/job/PR-5286/1/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0 hadolint=Haskell Dockerfile Linter 2.10.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9

Copy link
Copy Markdown
Contributor

Any updates here?

@Apache9

Copy link
Copy Markdown
Contributor

Ping @wchevreuil

@taklwutaklwu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all a sudden I upgraded my laptop and found this ....PR and fixed my issue, so +1

# See the License for the specific language governing permissions and
# limitations under the License.

FROM --platform=linux/amd64 ubuntu:22.04 AS base_image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--platform=linux/amd64 should be the only change, so it looks good to me.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right way to do things. Instead, you should provide --platform to the docker command line invocation when building the image. That will cause it to pull down the ubuntu image of the specified platform.

I left a comment on the Jira with an example of how to do a multi-platform docker image. It's not the only way to do it, but it's the style I've been using in the kustomize repo. Yetus project may have an alternative example of how to achieve this.

@taklwu

Copy link
Copy Markdown
Contributor

@wchevreuil maybe you can fix the style issue?

Change-Id: Ie12bfd25d8fc6ab314cf4f43bf8a5fc4b855c0e4
@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 26sDocker mode activated.
-0 ⚠️yetus0m 2sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 3sMaven dependency ordering for patch
_ Other Tests _
1m 28s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR#5286
Optional Tests
unameLinux 0dfc7575fae2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 419666b
Max. process+thread count41 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 34sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 13sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for patch
_ Other Tests _
1m 40s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR#5286
Optional Tests
unameLinux e009e7314e2d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 419666b
Max. process+thread count28 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

🎊 +1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 45sDocker mode activated.
-0 ⚠️yetus0m 3sUnprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗mvndep0m 15sMaven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗mvndep0m 4sMaven dependency ordering for patch
_ Other Tests _
2m 6s
SubsystemReport/Notes
DockerClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR#5286
Optional Tests
unameLinux 7350ef9aa276 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 419666b
Max. process+thread count40 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/console
versionsgit=2.34.1 maven=3.8.6
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase

Copy link
Copy Markdown

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 35sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+0 🆗shelldocs0m 0sShelldocs was not available.
+0 🆗markdownlint0m 0smarkdownlint was not available.
+1 💚@author0m 0sThe patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗mvndep0m 12sMaven dependency ordering for branch
+1 💚spotless0m 43sbranch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗mvndep0m 5sMaven dependency ordering for patch
-1 ❌hadolint0m 0sThe patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚shellcheck0m 0sThere were no new shellcheck issues.
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚spotless0m 39spatch has no errors when running spotless:check.
_ Other Tests _
+0 🆗asflicense0m 0sASF License check generated no output?
3m 3s
SubsystemReport/Notes
DockerClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#5286
Optional Testsdupname asflicense spotless hadolint shellcheck shelldocs markdownlint
unameLinux 45f86b8f90b2 5.4.0-182-generic #202-Ubuntu SMP Fri Apr 26 12:29:36 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev-support/hbase-personality.sh
git revisionmaster / 419666b
hadolinthttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/artifact/yetus-general-check/output/diff-patch-hadolint.txt
Max. process+thread count46 (vs. ulimit of 30000)
modulesC: U:
Console outputhttps://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5286/2/console
versionsgit=2.34.1 maven=3.8.6 shellcheck=0.8.0 hadolint=Haskell Dockerfile Linter 2.10.0
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@wchevreuil
wchevreuil merged commit e5b5816 into apache:masterMay 22, 2024
wchevreuil added a commit that referenced this pull request May 22, 2024
…ith mac m1 platform (#5286)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
wchevreuil added a commit that referenced this pull request May 22, 2024
…ith mac m1 platform (#5286)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
wchevreuil added a commit that referenced this pull request May 22, 2024
…ith mac m1 platform (#5286)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
wchevreuil added a commit that referenced this pull request May 22, 2024
…ith mac m1 platform (#5286)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
wchevreuil added a commit that referenced this pull request May 22, 2024
…ith mac m1 platform (#5286)
Signed-off-by: Tak Lon (Stephen) Wu <taklwu@apache.org>
(cherry picked from commit e5b5816)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@wchevreuil@Apache-HBase@Apache9@taklwu@ndimiduk