Skip to content

Phoenix 6387 Conditional Updates - #1249

Merged
swaroopak merged 2 commits into
apache:4.xfrom
tkhurana:PHOENIX-6387-4.x
Jun 16, 2021
Merged

Phoenix 6387 Conditional Updates#1249
swaroopak merged 2 commits into
apache:4.xfrom
tkhurana:PHOENIX-6387-4.x

Conversation

@tkhurana

Copy link
Copy Markdown
Contributor

Cherry-picking to 4.x

* PHOENIX-6387 Conditional updates on tables with indexes client side
* PHOENIX-6387 Conditional updates on tables with indexes server side
* Remove the extra read For regular upserts on tables with local index
* Addressed review comments
* PHOENIX-6474 Client and server metrics for atomic upserts
* Fixed failing tests related to metrics
@tkhurana

Copy link
Copy Markdown
ContributorAuthor

@swaroopak

@tkhuranatkhurana changed the title Phoenix 6387 4.xPhoenix 6387 Conditional UpdatesJun 16, 2021
@swaroopak
swaroopak merged commit 68ef271 into apache:4.xJun 16, 2021
@stoty

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec0m 28sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ 4.x Compile Tests _
-1 ❌mvninstall13m 45sroot in 4.x failed.
+1 💚compile1m 2s4.x passed
+1 💚checkstyle2m 40s4.x passed
+1 💚javadoc0m 46s4.x passed
+0 🆗spotbugs3m 1sphoenix-core in 4.x has 958 extant spotbugs warnings.
_ Patch Compile Tests _
-1 ❌mvninstall5m 24sroot in the patch failed.
+1 💚compile1m 0sthe patch passed
+1 💚javac1m 0sthe patch passed
-1 ❌checkstyle2m 46sphoenix-core: The patch generated 242 new + 5325 unchanged - 61 fixed = 5567 total (was 5386)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 45sthe patch passed
-1 ❌spotbugs3m 14sphoenix-core generated 1 new + 956 unchanged - 2 fixed = 957 total (was 958)
_ Other Tests _
-1 ❌unit137m 4sphoenix-core in the patch failed.
+1 💚asflicense0m 50sThe patch does not generate ASF License warnings.
175m 34s
ReasonTests
FindBugsmodule:phoenix-core
Switch statement found in org.apache.phoenix.hbase.index.IndexRegionObserver.applyOnePendingDeleteMutation(IndexRegionObserver$BatchMutateContext, Delete) where default case is missing At IndexRegionObserver.java:Delete) where default case is missing At IndexRegionObserver.java:[lines 682-689]
Failed junit testsphoenix.end2end.UpsertSelectIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1249/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1249
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
unameLinux 0c6a0e9cb216 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revision4.x / 3836a91
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1249/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
mvninstallhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1249/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1249/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1249/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1249/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1249/1/testReport/
Max. process+thread count5770 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1249/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tkhurana@stoty@swaroopak