Skip to content

PHOENIX-6387: Conditional updates on tables with indexes - #1281

Merged
virajjasani merged 1 commit into
apache:masterfrom
tkhurana:PHOENIX-6387-master
Aug 17, 2021
Merged

PHOENIX-6387: Conditional updates on tables with indexes#1281
virajjasani merged 1 commit into
apache:masterfrom
tkhurana:PHOENIX-6387-master

Conversation

@tkhurana

@tkhuranatkhurana commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

cherry-pick into master

@tkhurana
PHOENIX-6387: Conditional updates on tables with indexes
2b3b787
* PHOENIX-6387 Conditional updates on tables with indexes (apache#1215)
* PHOENIX-6387 Conditional updates on tables with indexes client side
* PHOENIX-6387 Conditional updates on tables with indexes server side
* Remove the extra read For regular upserts on tables with local index
* Addressed review comments
* PHOENIX-6474 Client and server metrics for atomic upserts (apache#1237)
* PHOENIX-6474 Client and server metrics for atomic upserts
* Fixed failing tests related to metrics
@tkhurana

tkhurana commented Aug 4, 2021

Copy link
Copy Markdown
ContributorAuthor

@virajjasani

@stoty

stoty commented Aug 4, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec6m 57sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall26m 23smaster passed
+0hbaserecompile34m 8sHBase recompiled.
+1 💚compile1m 13smaster passed
+1 💚checkstyle1m 43smaster passed
+1 💚javadoc1m 3smaster passed
+0 🆗spotbugs3m 55sphoenix-core in master has 973 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall18m 45sthe patch passed
+0hbaserecompile31m 27sHBase recompiled.
+1 💚compile1m 29sthe patch passed
+1 💚javac1m 29sthe patch passed
-1 ❌checkstyle2m 0sphoenix-core: The patch generated 257 new + 2073 unchanged - 64 fixed = 2330 total (was 2137)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc1m 2sthe patch passed
-1 ❌spotbugs4m 24sphoenix-core generated 1 new + 971 unchanged - 2 fixed = 972 total (was 973)
_ Other Tests _
-1 ❌unit135m 32sphoenix-core in the patch failed.
+1 💚asflicense0m 36sThe patch does not generate ASF License warnings.
224m 42s
ReasonTests
FindBugsmodule:phoenix-core
Switch statement found in org.apache.phoenix.hbase.index.IndexRegionObserver.applyOnePendingDeleteMutation(IndexRegionObserver$BatchMutateContext, Delete) where default case is missing At IndexRegionObserver.java:Delete) where default case is missing At IndexRegionObserver.java:[lines 694-701]
Failed junit testsphoenix.end2end.BackwardCompatibilityIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1281
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 44be50c938e9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 025a4af
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/1/testReport/
Max. process+thread count7250 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/1/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty

stoty commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

💔 -1 overall

VoteSubsystemRuntimeComment
+0 🆗reexec1m 4sDocker mode activated.
_ Prechecks _
+1 💚dupname0m 0sNo case conflicting files found.
+1 💚hbaseanti0m 0sPatch does not have any anti-patterns.
+1 💚@author0m 0sThe patch does not contain any @author tags.
+1 💚test4tests0m 0sThe patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚mvninstall23m 55smaster passed
+0hbaserecompile31m 32sHBase recompiled.
+1 💚compile1m 5smaster passed
+1 💚checkstyle1m 36smaster passed
+1 💚javadoc0m 52smaster passed
+0 🆗spotbugs3m 20sphoenix-core in master has 973 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚mvninstall16m 57sthe patch passed
+0hbaserecompile27m 21sHBase recompiled.
+1 💚compile1m 7sthe patch passed
+1 💚javac1m 7sthe patch passed
-1 ❌checkstyle1m 43sphoenix-core: The patch generated 231 new + 2099 unchanged - 38 fixed = 2330 total (was 2137)
+1 💚whitespace0m 0sThe patch has no whitespace issues.
+1 💚javadoc0m 52sthe patch passed
-1 ❌spotbugs3m 37sphoenix-core generated 1 new + 971 unchanged - 2 fixed = 972 total (was 973)
_ Other Tests _
-1 ❌unit122m 16sphoenix-core in the patch failed.
+1 💚asflicense0m 35sThe patch does not generate ASF License warnings.
196m 40s
ReasonTests
FindBugsmodule:phoenix-core
Switch statement found in org.apache.phoenix.hbase.index.IndexRegionObserver.applyOnePendingDeleteMutation(IndexRegionObserver$BatchMutateContext, Delete) where default case is missing At IndexRegionObserver.java:Delete) where default case is missing At IndexRegionObserver.java:[lines 694-701]
Failed junit testsphoenix.end2end.ConcurrentUpsertsWithoutIndexedColsIT
SubsystemReport/Notes
DockerClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR#1281
Optional Testsdupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
unameLinux 0bbfd4d225dc 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build toolmaven
Personalitydev/phoenix-personality.sh
git revisionmaster / 025a4af
Default JavaPrivate Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstylehttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unithttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Resultshttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/2/testReport/
Max. process+thread count10657 (vs. ulimit of 30000)
modulesC: phoenix-core U: phoenix-core
Console outputhttps://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1281/2/console
versionsgit=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered byApache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Aug 17, 2021
View reviewed changes

@virajjasanivirajjasani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as #1249 is already merged to 4.x and this PR doesn't have changes other than using thirdparty imports when required. Thanks @tkhurana

@virajjasani
virajjasani merged commit fb90657 into apache:masterAug 17, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@virajjasanivirajjasanivirajjasani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tkhurana@stoty@virajjasani