Uh oh!
There was an error while loading. Please reload this page.
[SPARK-13257] [Improvement] Scala naive Bayes example: check model after loading - #11192
[SPARK-13257] [Improvement] Scala naive Bayes example: check model after loading#11192movelikeriver wants to merge 2 commits into
Conversation
| */ | ||
| /* | ||
| * Usage: |
There was a problem hiding this comment.
So this usage text probably isn't the format we want, its pretty specific to each Spark release. Maybe look at some of the other files in this directory and see how they do their usage?
holdenk
commented
Apr 28, 2016
Thanks for taking on this issue & fixing it across multiple languages. A super minor thing is generally we try and have separate JIRAs for separate PRs - so in this case creating a sub task on the initial PR to also update Scala might be better from a tracking point of view (since when I went to look at this PR my first thought was that the issue had already been resolved). You might also want to try running the scala linter locally on your code (e.g. |
HyukjinKwon
commented
Feb 9, 2017
Hi @movelikeriver, are you able to proceed this further? If not, maybe it'd be better closed for now. |
AmplabJenkins
commented
Feb 12, 2017
Can one of the admins verify this patch? |
## What changes were proposed in this pull request? This PR proposes to close stale PRs. What I mean by "stale" here includes that there are some review comments by reviewers but the author looks inactive without any answer to them more than a month. I left some comments roughly a week ago to ping and the author looks still inactive in these PR below These below includes some PR suggested to be closed and a PR against another branch which seems obviously inappropriate. Given the comments in the last three PRs below, they are probably worth being taken over by anyone who is interested in it. Closesapache#7963Closesapache#8374Closesapache#11192Closesapache#11374Closesapache#11692Closesapache#12243Closesapache#12583Closesapache#12620Closesapache#12675Closesapache#12697Closesapache#12800Closesapache#13715Closesapache#14266Closesapache#15053Closesapache#15159Closesapache#15209Closesapache#15264Closesapache#15267Closesapache#15871Closesapache#15861Closesapache#16319Closesapache#16324Closesapache#16890Closesapache#12398Closesapache#12933Closesapache#14517 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#16937 from HyukjinKwon/stale-prs-close.
Refine naive Bayes example by checking model after loading it.
This is Java version, to be consistent with Python version in #11125