Uh oh!
There was an error while loading. Please reload this page.
[SPARK-17605][SPARK_SUBMIT] Add option spark.usePython and spark.useR for applications that use both pyspark and sparkr - #15159
[SPARK-17605][SPARK_SUBMIT] Add option spark.usePython and spark.useR for applications that use both pyspark and sparkr#15159zjffdu wants to merge 1 commit into
Conversation
SparkQA
commented
Sep 20, 2016
Test build #65644 has finished for PR 15159 at commit
|
felixcheung
commented
Sep 20, 2016
Do you have a test or use case that have both Python and R code? I'm not quite sure that actually work.. |
@felixcheung Thanks for review, as I mention in the jira description, zeppelin/livy would use both pyspark and sparkR. I try this PR with zeppelin (but needs some code change in zeppelin), and it works. |
There was a problem hiding this comment.
so now there's an isPython and usePython? Can you just use the old one?
There was a problem hiding this comment.
isPython and usePython has different semantic. isPython means it is pyspark application and the primary resource should be python script or pyspark-shell, and we use isPython to figure out the mainClass. While usePython doesn't mean it is pyspark application ( it could be scala application but use pyspark internally ), and it is not related with mainClass.
zjffdu
commented
Sep 23, 2016
Add @rxin@davies@JoshRosen@shivaram for more feedback. |
holdenk
commented
Oct 7, 2016
Just a heads up this has conflicts with master so it might be good to update (since I know a lot of reviewers use the spark-pr dashboard and maybe skip PRs which aren't mergable). |
holdenk
commented
Oct 7, 2016
@zjffdu so is the intent of this to allow people to use PySpark from Scala Spark applications? |
… for applications that use both pyspark and sparkr
zjffdu
commented
Oct 9, 2016
@holdenk that's correct. |
SparkQA
commented
Oct 9, 2016
Test build #66594 has finished for PR 15159 at commit
|
vanzin
commented
Dec 15, 2016
I wonder if there isn't a better way to handle this without having to add more configs. e.g., just distribute things if the user asks for it. For example, if Similar things for R, although I'm not really familiar with that path. I might be overseeing something, but I think it would be nice to avoid adding more config options if possible. |
HyukjinKwon
commented
Feb 9, 2017
(gentle ping @zjffdu) |
## What changes were proposed in this pull request? This PR proposes to close stale PRs. What I mean by "stale" here includes that there are some review comments by reviewers but the author looks inactive without any answer to them more than a month. I left some comments roughly a week ago to ping and the author looks still inactive in these PR below These below includes some PR suggested to be closed and a PR against another branch which seems obviously inappropriate. Given the comments in the last three PRs below, they are probably worth being taken over by anyone who is interested in it. Closesapache#7963Closesapache#8374Closesapache#11192Closesapache#11374Closesapache#11692Closesapache#12243Closesapache#12583Closesapache#12620Closesapache#12675Closesapache#12697Closesapache#12800Closesapache#13715Closesapache#14266Closesapache#15053Closesapache#15159Closesapache#15209Closesapache#15264Closesapache#15267Closesapache#15871Closesapache#15861Closesapache#16319Closesapache#16324Closesapache#16890Closesapache#12398Closesapache#12933Closesapache#14517 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#16937 from HyukjinKwon/stale-prs-close.
What changes were proposed in this pull request?
It is mostly for yarn mode, standalone mode don't need to distribute resources (sparkr.zip, pyspark.zip and etc) if I understand correctly. Add 2 options spark.usePython and spark.useR, so that any project using both sparkR and pyspark can leverage these 2 options.
How was this patch tested?
Use the following command to launch SparkPi and notice pyspark.zip, sparkr.zip and py4j are all distirbuted to executors.
Client output