Uh oh!
There was an error while loading. Please reload this page.
[SPARK-14754][SPARK CORE] Metrics as logs are not coming through slf4j - #12697
Closed
mihir6692 wants to merge 4 commits into
Closed
[SPARK-14754][SPARK CORE] Metrics as logs are not coming through slf4j#12697mihir6692 wants to merge 4 commits into
mihir6692 wants to merge 4 commits into
Conversation
AmplabJenkins
commented
Apr 26, 2016
Can one of the admins verify this patch? |
| MetricsSystem.checkMinimalPollingPeriod(pollUnit, pollPeriod) | ||
| val reporter: Slf4jReporter = Slf4jReporter.forRegistry(registry) | ||
| .outputTo(LoggerFactory.getLogger("org.apache.spark.metrics")) |
Member
There was a problem hiding this comment.
Why not the class name for the logger name here, per your JIRA?
Updated import style as per conventions
Update class name for logger
mihir6692
commented
Apr 26, 2016
Author
I have added 2 more commits and updated the pull request. Please have a look. |
| MetricsSystem.checkMinimalPollingPeriod(pollUnit, pollPeriod) | ||
| val reporter: Slf4jReporter = Slf4jReporter.forRegistry(registry) | ||
| .outputTo(LoggerFactory.getLogger("org.apache.spark.metrics.sink.Slf4jSink")) |
Member
There was a problem hiding this comment.
Sure, it can be classOf[Slf4jSink].getName for simplicity and to avoid forgetting to update it if for some reason this moves.
Author
There was a problem hiding this comment.
For Slf4jSink.scala :-
Its not about class path or class level in package. It is just a name. Ex.
If you keep name like Spark.log4j, it would still work. ( and use the
same Spark.log4j in log4j.properties). So it won't matter even if we
move class to some other folder or package.
EDIT :-
I understood what you are trying to say. I will update it with new commit. Thanks for guidance.
HyukjinKwon
commented
Oct 12, 2016
Member
gentle ping @mihir6692 |
1 similar comment
HyukjinKwon
commented
Feb 9, 2017
Member
gentle ping @mihir6692 |
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
## What changes were proposed in this pull request? This PR proposes to close stale PRs. What I mean by "stale" here includes that there are some review comments by reviewers but the author looks inactive without any answer to them more than a month. I left some comments roughly a week ago to ping and the author looks still inactive in these PR below These below includes some PR suggested to be closed and a PR against another branch which seems obviously inappropriate. Given the comments in the last three PRs below, they are probably worth being taken over by anyone who is interested in it. Closesapache#7963Closesapache#8374Closesapache#11192Closesapache#11374Closesapache#11692Closesapache#12243Closesapache#12583Closesapache#12620Closesapache#12675Closesapache#12697Closesapache#12800Closesapache#13715Closesapache#14266Closesapache#15053Closesapache#15159Closesapache#15209Closesapache#15264Closesapache#15267Closesapache#15871Closesapache#15861Closesapache#16319Closesapache#16324Closesapache#16890Closesapache#12398Closesapache#12933Closesapache#14517 ## How was this patch tested? N/A Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#16937 from HyukjinKwon/stale-prs-close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Two changes need to be done :
Slf4jsink.scala
Added class name for logging. (Reference : https://dropwizard.github.io/metrics/3.1.0/manual/core/#man-core-reporters-slf4j )
log4j.properties.template
Added log configuration in log4j.properties.template for in support of above changes.
How was this patch tested?
It is tested with manual testing. I build spark with make-distribution.sh and then tried few example job to print Metrics in log files.