Uh oh!
There was an error while loading. Please reload this page.
[SPARK-15574][ML][PySpark] Python meta-algorithms in Scala - #13794
[SPARK-15574][ML][PySpark] Python meta-algorithms in Scala#13794yinxusen wants to merge 65 commits into
Conversation
SparkQA
commented
Jun 23, 2016
Test build #61127 has finished for PR 13794 at commit
|
yinxusen
commented
Jun 23, 2016
test it please |
SparkQA
commented
Jun 23, 2016
Test build #61129 has finished for PR 13794 at commit
|
yinxusen
commented
Jun 23, 2016
test it please |
SparkQA
commented
Jun 24, 2016
Test build #61133 has finished for PR 13794 at commit
|
yinxusen
commented
Jun 24, 2016
retest this please |
SparkQA
commented
Jun 24, 2016
Test build #61197 has finished for PR 13794 at commit
|
yinxusen
commented
Jun 24, 2016
@jkbradley Update: Now I've added the PythonEstimator and PythonModel. For PythonEvaluator, it's better to commit in along with changes of CrossValidator. It's ready to review. |
holdenk
commented
Oct 7, 2016
@yinxusen - is this something you are still interested in? If so updating it to master would be good as well as making sure the unit tests pass in jenkins (a lot of reviwers just skip PRs which are failing tests). Although this is also pretty big so it might make sense to check with @jkbradley that this is something he is still interested in as well before you spend your time on it. |
yinxusen
commented
Oct 7, 2016
Thanks @holdenk Yes, I am still interested in this. @jkbradley Do we still need the PR to support meta-algorithms in PySpark? |
ueshin
commented
Jun 20, 2017
@yinxusen Hi, are you still working on this? |
jkbradley
commented
Jul 17, 2017
@yinxusen Thanks for this PR! I still think this seems like a very cool feature, but I've become less convinced that it's worth the engineering and maintenance effort. The alternative to this feature is to have meta-algorithms all implemented in Python as well as Scala. Since there are not many such meta-algorithms (4 currently), I think that sounds easier than implementing something like this. That's my current opinion, at least, especially since I have not seen a lot of demand for more meta-algorithms in MLlib. |
WeichenXu123
commented
Sep 5, 2017
+1 @jkbradley For now it is better to keep the current implementation for the 4 meta-algo in pyspark. |
WeichenXu123
commented
Sep 22, 2017
cc @srowen Can you help close this ? We won't need this feature for now. |
Closesapache#13794Closesapache#18474Closesapache#18897Closesapache#18978Closesapache#19152Closesapache#19238Closesapache#19295Closesapache#19334Closesapache#19335Closesapache#19347Closesapache#19236Closesapache#19244Closesapache#19300Closesapache#19315Closesapache#19356Closesapache#15009Closesapache#18253 Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#19348 from HyukjinKwon/stale-prs.
What changes were proposed in this pull request?
How was this patch tested?
Test with Python unit test and doc test.