Skip to content

SPARK-22021 - #19244

Closed
narahari92 wants to merge 3 commits into
apache:masterfrom
narahari92:master
Closed

SPARK-22021#19244
narahari92 wants to merge 3 commits into
apache:masterfrom
narahari92:master

Conversation

@narahari92

Copy link
Copy Markdown

What changes were proposed in this pull request?

This adds a new feature transformer which will take a javascript function and based on the logic provided in that, derives new features.

How was this patch tested?

There is proper unit test written for this transformer and also it's been testing in local and yarn-client mode.
Please review http://spark.apache.org/contributing.html before opening a pull request.

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@srowensrowen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just implement Transformer. This adds very little

import org.apache.spark.sql.types.StructField
import org.apache.spark.sql.types.StructType

import javax.script.ScriptEngineManager

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think introducing Javascript is a non-starter

@srowensrowen mentioned this pull request Sep 26, 2017
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Closesapache#13794Closesapache#18474Closesapache#18897Closesapache#18978Closesapache#19152Closesapache#19238Closesapache#19295Closesapache#19334Closesapache#19335Closesapache#19347Closesapache#19236Closesapache#19244Closesapache#19300Closesapache#19315Closesapache#19356Closesapache#15009Closesapache#18253
Author: hyukjinkwon <gurwls223@gmail.com>
Closesapache#19348 from HyukjinKwon/stale-prs.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@narahari92@AmplabJenkins@srowen