Uh oh!
There was an error while loading. Please reload this page.
[SPARK-22082][SparkR]Spelling mistake: "choosen" in API doc of R. - #19300
[SPARK-22082][SparkR]Spelling mistake: "choosen" in API doc of R.#19300zuotingbing wants to merge 1 commit into
Conversation
srowen
commented
Sep 21, 2017
Please review and fix typos in a whole batch of code, or don't bother and close this |
HyukjinKwon
commented
Sep 21, 2017
I am fixing some codes around here - https://github.com/apache/spark/pull/19290/files#diff-d9f92e07db6424e2527a7f9d7caa9013R328. If this one is only the one, let me fold this into mine. |
zuotingbing
commented
Sep 21, 2017
I have not found other typos and sorry i'm not agree with you. Since this spelling mistake affects the API doc in official website, we should fix it of course rather than 'don't bother and close this'. Thanks. |
HyukjinKwon
commented
Sep 21, 2017
I don't think we should ever encourage to fix a single typo. It doesn't look making any harm to the context or contents really. |
I can give you many reasons - reviewing cost, build cost (including retriggering Jenkins build when failed unexpectedly, for example, -9 signal), potentially making conflicts / rebasing in other PRs, potentially swarming PRs and potentially inactive PRs that someone should ping (and should be manually closed by another PR). Do you really think it is worth fixing it over those minimal costs? |
zuotingbing
commented
Sep 22, 2017
@cloud-fan@gatorsmile Could you please help to review this and merge it to master? Thanks. |
srowen
commented
Sep 22, 2017
@HyukjinKwon will make this change in another PR. We do need to push back on tiny PRs. It's a problem because some people are actually incentivized based on number of patches and it costs the project to accept that. |
zuotingbing
commented
Sep 22, 2017
if we find some mistakes likes this , shouldn't we to report it at first? |
HyukjinKwon
commented
Sep 22, 2017
I'd help review other PRs and leave a comment when someone fixes some codes around it rather than proposing it alone, or you can buffer it in your local and flush it. |
felixcheung
commented
Sep 22, 2017
or find and fix more typos ;) |
Closesapache#13794Closesapache#18474Closesapache#18897Closesapache#18978Closesapache#19152Closesapache#19238Closesapache#19295Closesapache#19334Closesapache#19335Closesapache#19347Closesapache#19236Closesapache#19244Closesapache#19300Closesapache#19315Closesapache#19356Closesapache#15009Closesapache#18253 Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#19348 from HyukjinKwon/stale-prs.
What changes were proposed in this pull request?
"choosen" should be "chosen" in API doc of R.
http://spark.apache.org/docs/latest/api/R/index.html , see
spark.kmeansHow was this patch tested?
NA