Uh oh!
There was an error while loading. Please reload this page.
[MINOR][ML]Updated english.txt word ordering - #19315
Conversation
Ordered alphabetically, for better readability.
AmplabJenkins
commented
Sep 22, 2017
Can one of the admins verify this patch? |
jerryshao
commented
Sep 22, 2017
@animenon can you please fix the PR title like what other PR did. Also is this only for better readability or do you fix any other issue? IMO, I found that previous txt is more readable than your change, since they're ordered by different kind. |
srowen
left a comment
There was a problem hiding this comment.
The ordering is unimportant. It also came from an external source so easier to leave it like the original. Not worthwhile here.
@jerryshao done. And browsing through the list is made easier with this ordering. @srowen I wanted to search if few of the words were on the list and found it to be rather tough to find. It would be much easier to browse through this way. And ya I saw the old thread, source is NLTK data. |
srowen
commented
Sep 22, 2017
Just ctrl-F and find? |
animenon
commented
Sep 22, 2017
Right, but if you want to check a few things together like "who", "who's", "why", "when", etc you will have to do many finds; but in an ordered document it would be much easier. |
Closesapache#13794Closesapache#18474Closesapache#18897Closesapache#18978Closesapache#19152Closesapache#19238Closesapache#19295Closesapache#19334Closesapache#19335Closesapache#19347Closesapache#19236Closesapache#19244Closesapache#19300Closesapache#19315Closesapache#19356Closesapache#15009Closesapache#18253 Author: hyukjinkwon <gurwls223@gmail.com> Closesapache#19348 from HyukjinKwon/stale-prs.
Ordered alphabetically, for better readability.
What changes were proposed in this pull request?
Alphabetical ordering of the stop words.