Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19714][ML] Bucketizer.handleInvalid docs improved - #17169
Closed
wojtek-szymanski wants to merge 2 commits into
Closed
[SPARK-19714][ML] Bucketizer.handleInvalid docs improved#17169wojtek-szymanski wants to merge 2 commits into
wojtek-szymanski wants to merge 2 commits into
Conversation
MLnick
reviewed
Mar 6, 2017
| * Param for how to handle invalid entries. Options are 'skip' (filter out rows with | ||
| * invalid values), 'error' (throw an error), or 'keep' (keep invalid values in a special | ||
| * additional bucket). | ||
| * Param for how to handle invalid entries containing either NaN or null values. |
Contributor
There was a problem hiding this comment.
This is actually not true currently - null is not handled as an invalid value - see https://issues.apache.org/jira/browse/SPARK-19781
Contributor
There was a problem hiding this comment.
I guess once #17123 maybe merged it will hold true
ContributorAuthor
There was a problem hiding this comment.
You are right. I will update docs with null values support once #17123 gets merged.
MLnick
commented
Mar 6, 2017
Contributor
ok to test |
SparkQA
commented
Mar 6, 2017
Test build #74008 has finished for PR 17169 at commit
|
SparkQA
commented
Mar 6, 2017
Test build #74041 has finished for PR 17169 at commit
|
AmplabJenkins
commented
Jun 9, 2018
Can one of the admins verify this patch? |
srowen
commented
Jul 27, 2018
Member
@wojtek-szymanski if you'll rebase this I'll merge it. |
wangyum
commented
Nov 10, 2018
Member
srowen
commented
Nov 10, 2018
Member
True, though the sentence that is added in this PR isn't added. I can just add it to close the loop here. This PR can be closed , as it seems abandoned |
asfgit pushed a commit
that referenced
this pull request
Nov 11, 2018
## What changes were proposed in this pull request? Clarify Bucketizer handleInvalid docs. Just a resubmit of #17169 ## How was this patch tested? N/A Closes#23003 from srowen/SPARK-19714. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
jackylee-ch pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Clarify Bucketizer handleInvalid docs. Just a resubmit of apache#17169 ## How was this patch tested? N/A Closesapache#23003 from srowen/SPARK-19714. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
Closesapache#21766Closesapache#21679Closesapache#21161Closesapache#20846Closesapache#19434Closesapache#18080Closesapache#17648Closesapache#17169 Add: Closesapache#22813Closesapache#21994Closesapache#22005Closesapache#22463 Add: Closesapache#15899 Add: Closesapache#22539Closesapache#21868Closesapache#21514Closesapache#21402Closesapache#21322Closesapache#21257Closesapache#20163Closesapache#19691Closesapache#18697Closesapache#18636Closesapache#17176Closesapache#23001 from wangyum/CloseStalePRs. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: hyukjinkwon <gurwls223@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Docs for
Bucketizer.handleInvalidhas been enhanced with more detailed information about supported and not supported types of invalid entries.How was this patch tested?
N/A, just dosc update.