Uh oh!
There was an error while loading. Please reload this page.
[SPARK-24529][Build][test-maven][follow-up] Add spotbugs 3.1.6 into maven build process - #21994
[SPARK-24529][Build][test-maven][follow-up] Add spotbugs 3.1.6 into maven build process#21994kiszk wants to merge 1 commit into
Conversation
SparkQA
commented
Aug 3, 2018
Test build #94177 has finished for PR 21994 at commit
|
HyukjinKwon
commented
Aug 4, 2018
retest this please |
HyukjinKwon
commented
Aug 4, 2018
cc @yhuai too |
SparkQA
commented
Aug 4, 2018
Test build #94197 has finished for PR 21994 at commit
|
HyukjinKwon
commented
Aug 4, 2018
retest this please |
SparkQA
commented
Aug 4, 2018
Test build #94210 has finished for PR 21994 at commit
|
| </plugin> | ||
| <plugin> | ||
| <groupId>com.github.spotbugs</groupId> | ||
| <artifactId>spotbugs-maven-plugin</artifactId> |
There was a problem hiding this comment.
Actually, after having this plugin, I were unable to perform parallel builds.
https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3
There was a problem hiding this comment.
It sounds like this plug in is not thread safe.
There was a problem hiding this comment.
Oh, I have not tried this with parallel build. Spotbugs looks non MT-safe
There was a problem hiding this comment.
Adding spotbugs slows down my local build a lot. Can we hold this?
There was a problem hiding this comment.
Yea, this slows down 16ish mins and that was my concern at the very first place. Currently, it only affects Maven build though. +1 for holding on for now.
There was a problem hiding this comment.
let me check the elapsed time on my environment. +1 for holding on for now.
Closesapache#21766Closesapache#21679Closesapache#21161Closesapache#20846Closesapache#19434Closesapache#18080Closesapache#17648Closesapache#17169 Add: Closesapache#22813Closesapache#21994Closesapache#22005Closesapache#22463 Add: Closesapache#15899 Add: Closesapache#22539Closesapache#21868Closesapache#21514Closesapache#21402Closesapache#21322Closesapache#21257Closesapache#20163Closesapache#19691Closesapache#18697Closesapache#18636Closesapache#17176Closesapache#23001 from wangyum/CloseStalePRs. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: hyukjinkwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This PR tries to add spotbugs after upgrading mvn. This is because we met a problem with old mvn.
How was this patch tested?
existing UTs