Skip to content

remove annotation @Experimental - #22463

Closed
wanqulou wants to merge 2 commits into
apache:masterfrom
wanqulou:master
Closed

remove annotation @Experimental#22463
wanqulou wants to merge 2 commits into
apache:masterfrom
wanqulou:master

Conversation

@wanqulou

@wanqulouwanqulou commented Sep 19, 2018

Copy link
Copy Markdown

What changes were proposed in this pull request?

http://spark.apache.org/docs/latest/streaming-kafka-integration.html
spark-streaming-kafka-0-8 is deprecated and spark-streaming-kafka-0-10 is stable

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@HyukjinKwon

Copy link
Copy Markdown
Member

Why don't we just leave it or mark them as deprecated.

@markhamstra

Copy link
Copy Markdown
Contributor

Where is the discussion on these utility methods no longer being Experimental? I'm not saying that they are not stable, but the Kafka 0.10 API in general being considered to be stable doesn't preclude some Kafka-related methods from still being other than stable, and promoting API to stable (i.e. cannot be changed without a major release) is a pretty big deal.

@srowen

Copy link
Copy Markdown
Member

Yeah, I think Experimental is over-used in the APIs. They just never get un-marked and lots of pretty old stuff, that de facto is just not changeable now, is still labeled this way. This seems to be more "DeveloperAPI" than "Experimental". Still, I also don't know the right answer for this code. Ping the author?

I figured we'd remove just about all current Experimental tags when, say, Spark 3 rolls around.

@srowen

Copy link
Copy Markdown
Member

I'd close this, evaluate which Experimental tags look clearly 'wrong' (i.e. something long established in a public API) and then open a JIRA targeted at 3.0 to consider removing them.

@srowensrowen mentioned this pull request Nov 10, 2018
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Closesapache#21766Closesapache#21679Closesapache#21161Closesapache#20846Closesapache#19434Closesapache#18080Closesapache#17648Closesapache#17169
Add:
Closesapache#22813Closesapache#21994Closesapache#22005Closesapache#22463
Add:
Closesapache#15899
Add:
Closesapache#22539Closesapache#21868Closesapache#21514Closesapache#21402Closesapache#21322Closesapache#21257Closesapache#20163Closesapache#19691Closesapache#18697Closesapache#18636Closesapache#17176Closesapache#23001 from wangyum/CloseStalePRs.
Authored-by: Yuming Wang <yumwang@ebay.com>
Signed-off-by: hyukjinkwon <gurwls223@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@wanqulou@AmplabJenkins@HyukjinKwon@markhamstra@srowen