Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19851] Add support for EVERY and ANY (SOME) aggregates - #17648
[SPARK-19851] Add support for EVERY and ANY (SOME) aggregates#17648ptkool wants to merge 8 commits into
Conversation
ptkool
commented
Apr 16, 2017
Moved this PR to a feature branch and lost comments. The original PR is here: #17194 |
Can we just do a logical rewrite to turn them into "condA + condB + condC > 0" (for Some/Any) and "condA + condB + condC = 3" for Every? |
ptkool
commented
Apr 21, 2017
@rxin I'm not sure where you're going with your proposal. These are aggregate functions, not scalar functions. |
rxin
commented
Apr 21, 2017
I was saying rather than implementing them, just rewrite them into an aggregate on the conditions and compare them against the value. |
ptkool
commented
Apr 24, 2017
@rxin Ok. So you're proposing rewrites for these aggregates that look something like this? |
ptkool
commented
Apr 24, 2017
@rxin Actually, @hvanhovell proposed the following rewrites which I think are better: |
rxin
commented
Apr 24, 2017
sgtm |
gatorsmile
commented
Oct 28, 2017
@ptkool Could you address the comments and we can review it? Thanks! |
97bec05 to
e0b5cc6CompareHyukjinKwon
commented
Jul 16, 2018
ok to test |
HyukjinKwon
commented
Jul 16, 2018
@ptkool mind updating the PR please? |
SparkQA
commented
Jul 16, 2018
Test build #93044 has finished for PR 17648 at commit
|
gatorsmile
commented
Jul 30, 2018
@dilipbiswal Could you take this over? |
dilipbiswal
commented
Jul 30, 2018
@gatorsmile Sure. |
gatorsmile
commented
Nov 11, 2018
@ptkool Thanks for your contribution! This feature will be available in the next release. Spark 3.0 |
Closesapache#21766Closesapache#21679Closesapache#21161Closesapache#20846Closesapache#19434Closesapache#18080Closesapache#17648Closesapache#17169 Add: Closesapache#22813Closesapache#21994Closesapache#22005Closesapache#22463 Add: Closesapache#15899 Add: Closesapache#22539Closesapache#21868Closesapache#21514Closesapache#21402Closesapache#21322Closesapache#21257Closesapache#20163Closesapache#19691Closesapache#18697Closesapache#18636Closesapache#17176Closesapache#23001 from wangyum/CloseStalePRs. Authored-by: Yuming Wang <yumwang@ebay.com> Signed-off-by: hyukjinkwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This pull request implements the EVERY and ANY aggregates.
How was this patch tested?
Testing was performed using unit tests, integration tests, and manual tests.