Skip to content

Fix annnotation on docker config create --template-driver - #1769

Merged
thaJeztah merged 1 commit into
docker:masterfrom
simonferquel:fix-config-create-annotation
Mar 21, 2019
Merged

Fix annnotation on docker config create --template-driver#1769
thaJeztah merged 1 commit into
docker:masterfrom
simonferquel:fix-config-create-annotation

Conversation

@simonferquel

Copy link
Copy Markdown
Contributor

- What I did
Fixed an annotation that was set on an incorrect flag
- How I did it
Spotted it while working on deferred client initialization

cc @thaJeztah

Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1769 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #1769 +/- ##
=======================================
Coverage 56.32% 56.32% =======================================
Files 307 307 Lines 21177 21177 =======================================
Hits 11928 11928 Misses 8382 8382 Partials 867 867

1 similar comment
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1769 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #1769 +/- ##
=======================================
Coverage 56.32% 56.32% =======================================
Files 307 307 Lines 21177 21177 =======================================
Hits 11928 11928 Misses 8382 8382 Partials 867 867

@thaJeztah

Copy link
Copy Markdown
Member

introduced in #896 (part of 18.03)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonferquel@codecov-io@thaJeztah@GordonTheTurtle