Skip to content

[18.09 backport] fix annotations on --template-driver - #1788

Merged
andrewhsu merged 2 commits into
docker:18.09from
thaJeztah:18.09_backport_annotations
Mar 28, 2019
Merged

[18.09 backport] fix annotations on --template-driver#1788
andrewhsu merged 2 commits into
docker:18.09from
thaJeztah:18.09_backport_annotations

Conversation

@thaJeztah

@thaJeztahthaJeztah commented Mar 28, 2019

Copy link
Copy Markdown
Member

backport of;

relates to #896

simonferqueland others added 2 commits March 29, 2019 00:32
@simonferquel@thaJeztah
Fix annnotation on docker config create --template-driver
85148aa
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
(cherry picked from commit 470afe1)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@sirlatrom@thaJeztah
Fix annotation on docker secret create --template-driver
356eda4
Signed-off-by: Sune Keller <absukl@almbrand.dk>
(cherry picked from commit 217308d)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztahthaJeztah added this to the 18.09.5 milestone Mar 28, 2019
@thaJeztah

thaJeztah commented Mar 28, 2019

Copy link
Copy Markdown
MemberAuthor

ping @tiborvass@silvin-lubecki@vdemeester PTAL

@codecov-io

codecov-io commented Mar 28, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1788 into 18.09 will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## 18.09 #1788 +/- ##
=======================================
Coverage 54.22% 54.22% =======================================
Files 290 290 Lines 19428 19428 =======================================
Hits 10535 10535 Misses 8214 8214 Partials 679 679

@andrewhsu
andrewhsu merged commit e1fe8f3 into docker:18.09Mar 28, 2019
@thaJeztah
thaJeztah deleted the 18.09_backport_annotations branch March 28, 2019 23:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiborvasstiborvasstiborvass approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

18.09.5

Development

Successfully merging this pull request may close these issues.

7 participants

@thaJeztah@codecov-io@tiborvass@andrewhsu@GordonTheTurtle@simonferquel@sirlatrom