Skip to content

Fix annotation on docker secret create --template-driver - #1785

Merged
thaJeztah merged 1 commit into
docker:masterfrom
sirlatrom:fix_secret_template_driver_annotation
Mar 28, 2019
Merged

Fix annotation on docker secret create --template-driver#1785
thaJeztah merged 1 commit into
docker:masterfrom
sirlatrom:fix_secret_template_driver_annotation

Conversation

@sirlatrom

Copy link
Copy Markdown
Contributor

Full disclosure: This issue is a copy-cat act inspired by #1769.

- What I did
Fixed an annotation that was set on an incorrect flag
- How I did it
Spotted it while working on deferred client initialization

cc @thaJeztah

Signed-off-by: Sune Keller <absukl@almbrand.dk>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #1785 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #1785 +/- ##
=======================================
Coverage 56.26% 56.26% =======================================
Files 308 308 Lines 21293 21293 =======================================
Hits 11980 11980 Misses 8439 8439 Partials 874 874

@thaJeztah

Copy link
Copy Markdown
Member

introduced in #896 (part of 18.03)

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
thaJeztah merged commit 788ce43 into docker:masterMar 28, 2019
@GordonTheTurtleGordonTheTurtle added this to the 19.03.0 milestone Mar 28, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@sirlatrom@codecov-io@thaJeztah@GordonTheTurtle