Revert potential UB due to aliasing + more WB removals by EgorBo · Pull Request #111733 · dotnet/runtime

EgorBo · 2025-01-23T01:49:54Z

Remove potential UB from #111576 (move it to importer) + enable more cases where we eliminate write barriers, e.g. this:

publicrefstructTestS{publicMyStructs1;publicMyStructs2;publicvoidTest(){s1=s2;// no barrier needed, but we generate (two)}}publicstructMyStruct// Not byref-like{publicstringA;publicstringB;}

dotnet-policy-service · 2025-01-23T01:50:26Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

EgorBo · 2025-01-23T01:51:16Z

@MihuBot

EgorBo · 2025-01-23T02:35:40Z

Some regressions with barrier-free code e.g. https://www.diffchecker.com/Sz7TI32G/

(when we save a nonbyref-like struct with gc pointers to a field of byreflike struct)

jakobbotsch · 2025-01-23T10:11:05Z

+ flagsToPropagate |= GTF_IND_TGT_NOT_HEAP | GTF_IND_TGT_HEAP;
 addr = m_store->AsIndir()->Addr();
- indirFlags = m_store->gtFlags & GTF_IND_COPYABLE_FLAGS;
+ indirFlags = m_store->gtFlags & flagsToPropagate;


Is there any benefit to adding something like
if (m_store->AsBlk()->GetLayout()->IsStackOnly()) indirFlags |= GTF_IND_TGT_NOT_HEAP;
here (and in morphblock.cpp)? Or will m_store already have this flag set for this case?

@jakobbotsch I don't see diffs, but this PR already produces too many missing contexts 🙂
Presumably, this is not enough, because some GT_STORE_BLK have this flag without its layout being IsStackOnly. E.g. when we store a non-byreflike struct to byreflike-struct's field

Yeah, it makes sense to me to propagate the flags, but it also makes sense to me to set the flags anew here, since the decomposition is "losing" the information at this point. I will leave it up to you.

Added. Looks like MihuBot found a few diffs with it

EgorBo · 2025-01-23T12:33:49Z

@MihuBot

EgorBo · 2025-01-23T12:55:58Z

@MihuBot

EgorBo · 2025-01-23T14:36:20Z

PTAL @jakobbotsch Diffs: MihuBot/runtime-utils#932 (SPMI diffs report missing contexts: https://dev.azure.com/dnceng-public/public/_build/results?buildId=926588&view=ms.vss-build-web.run-extensions-tab)

There are a few regressions where WB is lighter than no-WB (e.g. https://www.diffchecker.com/Sz7TI32G/)
And there are some regressions where previous VN based code could detect more opportunities (mostly, mixed with inlining). I managed to create a minimal repro:

[InlineArray(4)]internalstructArgumentData<T>{privateT_arg0;}[StructLayout(LayoutKind.Sequential)]internalrefstructTest{[MethodImpl(MethodImplOptions.NoInlining)]publicTest(objecta){_args[1]=a;}internalArgumentData<object?>_args;}

here we end up with:

 [000011] -ACXG------ * STOREIND ref [000009] --C-------- +--* RET_EXPR byref (for [000007])
[000010] ----------- \--* LCL_VAR ref V01 arg1

and we can't extract class info easily (stind.ref opcode doesn't contain any class token nor we can extract it from ops).

I might look into this and more cases separately (overall it's a regression only for previously merged PR)

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

EgorBo · 2025-01-23T01:49:54Z

Remove potential UB from #111576 (move it to importer) + enable more cases where we eliminate write barriers, e.g. this:

publicrefstructTestS{publicMyStructs1;publicMyStructs2;publicvoidTest(){s1=s2;// no barrier needed, but we generate (two)}}publicstructMyStruct// Not byref-like{publicstringA;publicstringB;}

dotnet-policy-service · 2025-01-23T01:50:26Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

EgorBo · 2025-01-23T01:51:16Z

@MihuBot

EgorBo · 2025-01-23T02:35:40Z

Some regressions with barrier-free code e.g. https://www.diffchecker.com/Sz7TI32G/

(when we save a nonbyref-like struct with gc pointers to a field of byreflike struct)

jakobbotsch · 2025-01-23T10:11:05Z

+ flagsToPropagate |= GTF_IND_TGT_NOT_HEAP | GTF_IND_TGT_HEAP;
 addr = m_store->AsIndir()->Addr();
- indirFlags = m_store->gtFlags & GTF_IND_COPYABLE_FLAGS;
+ indirFlags = m_store->gtFlags & flagsToPropagate;


Is there any benefit to adding something like
if (m_store->AsBlk()->GetLayout()->IsStackOnly()) indirFlags |= GTF_IND_TGT_NOT_HEAP;
here (and in morphblock.cpp)? Or will m_store already have this flag set for this case?

@jakobbotsch I don't see diffs, but this PR already produces too many missing contexts 🙂
Presumably, this is not enough, because some GT_STORE_BLK have this flag without its layout being IsStackOnly. E.g. when we store a non-byreflike struct to byreflike-struct's field

Yeah, it makes sense to me to propagate the flags, but it also makes sense to me to set the flags anew here, since the decomposition is "losing" the information at this point. I will leave it up to you.

Added. Looks like MihuBot found a few diffs with it

EgorBo · 2025-01-23T12:33:49Z

@MihuBot

EgorBo · 2025-01-23T12:55:58Z

@MihuBot

EgorBo · 2025-01-23T14:36:20Z

PTAL @jakobbotsch Diffs: MihuBot/runtime-utils#932 (SPMI diffs report missing contexts: https://dev.azure.com/dnceng-public/public/_build/results?buildId=926588&view=ms.vss-build-web.run-extensions-tab)

There are a few regressions where WB is lighter than no-WB (e.g. https://www.diffchecker.com/Sz7TI32G/)
And there are some regressions where previous VN based code could detect more opportunities (mostly, mixed with inlining). I managed to create a minimal repro:

[InlineArray(4)]internalstructArgumentData<T>{privateT_arg0;}[StructLayout(LayoutKind.Sequential)]internalrefstructTest{[MethodImpl(MethodImplOptions.NoInlining)]publicTest(objecta){_args[1]=a;}internalArgumentData<object?>_args;}

here we end up with:

 [000011] -ACXG------ * STOREIND ref [000009] --C-------- +--* RET_EXPR byref (for [000007])
[000010] ----------- \--* LCL_VAR ref V01 arg1

and we can't extract class info easily (stind.ref opcode doesn't contain any class token nor we can extract it from ops).

I might look into this and more cases separately (overall it's a regression only for previously merged PR)

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

EgorBo · 2025-01-23T01:49:54Z

Remove potential UB from #111576 (move it to importer) + enable more cases where we eliminate write barriers, e.g. this:

publicrefstructTestS{publicMyStructs1;publicMyStructs2;publicvoidTest(){s1=s2;// no barrier needed, but we generate (two)}}publicstructMyStruct// Not byref-like{publicstringA;publicstringB;}

dotnet-policy-service · 2025-01-23T01:50:26Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

EgorBo · 2025-01-23T01:51:16Z

@MihuBot

EgorBo · 2025-01-23T02:35:40Z

Some regressions with barrier-free code e.g. https://www.diffchecker.com/Sz7TI32G/

(when we save a nonbyref-like struct with gc pointers to a field of byreflike struct)

jakobbotsch · 2025-01-23T10:11:05Z

+ flagsToPropagate |= GTF_IND_TGT_NOT_HEAP | GTF_IND_TGT_HEAP;
 addr = m_store->AsIndir()->Addr();
- indirFlags = m_store->gtFlags & GTF_IND_COPYABLE_FLAGS;
+ indirFlags = m_store->gtFlags & flagsToPropagate;


Is there any benefit to adding something like
if (m_store->AsBlk()->GetLayout()->IsStackOnly()) indirFlags |= GTF_IND_TGT_NOT_HEAP;
here (and in morphblock.cpp)? Or will m_store already have this flag set for this case?

@jakobbotsch I don't see diffs, but this PR already produces too many missing contexts 🙂
Presumably, this is not enough, because some GT_STORE_BLK have this flag without its layout being IsStackOnly. E.g. when we store a non-byreflike struct to byreflike-struct's field

Yeah, it makes sense to me to propagate the flags, but it also makes sense to me to set the flags anew here, since the decomposition is "losing" the information at this point. I will leave it up to you.

Added. Looks like MihuBot found a few diffs with it

EgorBo · 2025-01-23T12:33:49Z

@MihuBot

EgorBo · 2025-01-23T12:55:58Z

@MihuBot

EgorBo · 2025-01-23T14:36:20Z

PTAL @jakobbotsch Diffs: MihuBot/runtime-utils#932 (SPMI diffs report missing contexts: https://dev.azure.com/dnceng-public/public/_build/results?buildId=926588&view=ms.vss-build-web.run-extensions-tab)

There are a few regressions where WB is lighter than no-WB (e.g. https://www.diffchecker.com/Sz7TI32G/)
And there are some regressions where previous VN based code could detect more opportunities (mostly, mixed with inlining). I managed to create a minimal repro:

[InlineArray(4)]internalstructArgumentData<T>{privateT_arg0;}[StructLayout(LayoutKind.Sequential)]internalrefstructTest{[MethodImpl(MethodImplOptions.NoInlining)]publicTest(objecta){_args[1]=a;}internalArgumentData<object?>_args;}

here we end up with:

 [000011] -ACXG------ * STOREIND ref [000009] --C-------- +--* RET_EXPR byref (for [000007])
[000010] ----------- \--* LCL_VAR ref V01 arg1

and we can't extract class info easily (stind.ref opcode doesn't contain any class token nor we can extract it from ops).

I might look into this and more cases separately (overall it's a regression only for previously merged PR)

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

EgorBo · 2025-01-23T01:49:54Z

Remove potential UB from #111576 (move it to importer) + enable more cases where we eliminate write barriers, e.g. this:

publicrefstructTestS{publicMyStructs1;publicMyStructs2;publicvoidTest(){s1=s2;// no barrier needed, but we generate (two)}}publicstructMyStruct// Not byref-like{publicstringA;publicstringB;}

dotnet-policy-service · 2025-01-23T01:50:26Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

EgorBo · 2025-01-23T01:51:16Z

@MihuBot

EgorBo · 2025-01-23T02:35:40Z

Some regressions with barrier-free code e.g. https://www.diffchecker.com/Sz7TI32G/

(when we save a nonbyref-like struct with gc pointers to a field of byreflike struct)

jakobbotsch · 2025-01-23T10:11:05Z

+ flagsToPropagate |= GTF_IND_TGT_NOT_HEAP | GTF_IND_TGT_HEAP;
 addr = m_store->AsIndir()->Addr();
- indirFlags = m_store->gtFlags & GTF_IND_COPYABLE_FLAGS;
+ indirFlags = m_store->gtFlags & flagsToPropagate;


Is there any benefit to adding something like
if (m_store->AsBlk()->GetLayout()->IsStackOnly()) indirFlags |= GTF_IND_TGT_NOT_HEAP;
here (and in morphblock.cpp)? Or will m_store already have this flag set for this case?

@jakobbotsch I don't see diffs, but this PR already produces too many missing contexts 🙂
Presumably, this is not enough, because some GT_STORE_BLK have this flag without its layout being IsStackOnly. E.g. when we store a non-byreflike struct to byreflike-struct's field

Yeah, it makes sense to me to propagate the flags, but it also makes sense to me to set the flags anew here, since the decomposition is "losing" the information at this point. I will leave it up to you.

Added. Looks like MihuBot found a few diffs with it

EgorBo · 2025-01-23T12:33:49Z

@MihuBot

EgorBo · 2025-01-23T12:55:58Z

@MihuBot

EgorBo · 2025-01-23T14:36:20Z

PTAL @jakobbotsch Diffs: MihuBot/runtime-utils#932 (SPMI diffs report missing contexts: https://dev.azure.com/dnceng-public/public/_build/results?buildId=926588&view=ms.vss-build-web.run-extensions-tab)

There are a few regressions where WB is lighter than no-WB (e.g. https://www.diffchecker.com/Sz7TI32G/)
And there are some regressions where previous VN based code could detect more opportunities (mostly, mixed with inlining). I managed to create a minimal repro:

[InlineArray(4)]internalstructArgumentData<T>{privateT_arg0;}[StructLayout(LayoutKind.Sequential)]internalrefstructTest{[MethodImpl(MethodImplOptions.NoInlining)]publicTest(objecta){_args[1]=a;}internalArgumentData<object?>_args;}

here we end up with:

 [000011] -ACXG------ * STOREIND ref [000009] --C-------- +--* RET_EXPR byref (for [000007])
[000010] ----------- \--* LCL_VAR ref V01 arg1

and we can't extract class info easily (stind.ref opcode doesn't contain any class token nor we can extract it from ops).

I might look into this and more cases separately (overall it's a regression only for previously merged PR)

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

EgorBo · 2025-01-23T01:49:54Z

Remove potential UB from #111576 (move it to importer) + enable more cases where we eliminate write barriers, e.g. this:

publicrefstructTestS{publicMyStructs1;publicMyStructs2;publicvoidTest(){s1=s2;// no barrier needed, but we generate (two)}}publicstructMyStruct// Not byref-like{publicstringA;publicstringB;}

dotnet-policy-service · 2025-01-23T01:50:26Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

EgorBo · 2025-01-23T01:51:16Z

@MihuBot

EgorBo · 2025-01-23T02:35:40Z

Some regressions with barrier-free code e.g. https://www.diffchecker.com/Sz7TI32G/

(when we save a nonbyref-like struct with gc pointers to a field of byreflike struct)

jakobbotsch · 2025-01-23T10:11:05Z

+ flagsToPropagate |= GTF_IND_TGT_NOT_HEAP | GTF_IND_TGT_HEAP;
 addr = m_store->AsIndir()->Addr();
- indirFlags = m_store->gtFlags & GTF_IND_COPYABLE_FLAGS;
+ indirFlags = m_store->gtFlags & flagsToPropagate;


Is there any benefit to adding something like
if (m_store->AsBlk()->GetLayout()->IsStackOnly()) indirFlags |= GTF_IND_TGT_NOT_HEAP;
here (and in morphblock.cpp)? Or will m_store already have this flag set for this case?

@jakobbotsch I don't see diffs, but this PR already produces too many missing contexts 🙂
Presumably, this is not enough, because some GT_STORE_BLK have this flag without its layout being IsStackOnly. E.g. when we store a non-byreflike struct to byreflike-struct's field

Yeah, it makes sense to me to propagate the flags, but it also makes sense to me to set the flags anew here, since the decomposition is "losing" the information at this point. I will leave it up to you.

Added. Looks like MihuBot found a few diffs with it

EgorBo · 2025-01-23T12:33:49Z

@MihuBot

EgorBo · 2025-01-23T12:55:58Z

@MihuBot

EgorBo · 2025-01-23T14:36:20Z

PTAL @jakobbotsch Diffs: MihuBot/runtime-utils#932 (SPMI diffs report missing contexts: https://dev.azure.com/dnceng-public/public/_build/results?buildId=926588&view=ms.vss-build-web.run-extensions-tab)

There are a few regressions where WB is lighter than no-WB (e.g. https://www.diffchecker.com/Sz7TI32G/)
And there are some regressions where previous VN based code could detect more opportunities (mostly, mixed with inlining). I managed to create a minimal repro:

[InlineArray(4)]internalstructArgumentData<T>{privateT_arg0;}[StructLayout(LayoutKind.Sequential)]internalrefstructTest{[MethodImpl(MethodImplOptions.NoInlining)]publicTest(objecta){_args[1]=a;}internalArgumentData<object?>_args;}

here we end up with:

 [000011] -ACXG------ * STOREIND ref [000009] --C-------- +--* RET_EXPR byref (for [000007])
[000010] ----------- \--* LCL_VAR ref V01 arg1

and we can't extract class info easily (stind.ref opcode doesn't contain any class token nor we can extract it from ops).

I might look into this and more cases separately (overall it's a regression only for previously merged PR)

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

EgorBo · 2025-01-23T01:49:54Z

Remove potential UB from #111576 (move it to importer) + enable more cases where we eliminate write barriers, e.g. this:

publicrefstructTestS{publicMyStructs1;publicMyStructs2;publicvoidTest(){s1=s2;// no barrier needed, but we generate (two)}}publicstructMyStruct// Not byref-like{publicstringA;publicstringB;}

dotnet-policy-service · 2025-01-23T01:50:26Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

EgorBo · 2025-01-23T01:51:16Z

@MihuBot

EgorBo · 2025-01-23T02:35:40Z

Some regressions with barrier-free code e.g. https://www.diffchecker.com/Sz7TI32G/

(when we save a nonbyref-like struct with gc pointers to a field of byreflike struct)

jakobbotsch · 2025-01-23T10:11:05Z

+ flagsToPropagate |= GTF_IND_TGT_NOT_HEAP | GTF_IND_TGT_HEAP;
 addr = m_store->AsIndir()->Addr();
- indirFlags = m_store->gtFlags & GTF_IND_COPYABLE_FLAGS;
+ indirFlags = m_store->gtFlags & flagsToPropagate;


Is there any benefit to adding something like
if (m_store->AsBlk()->GetLayout()->IsStackOnly()) indirFlags |= GTF_IND_TGT_NOT_HEAP;
here (and in morphblock.cpp)? Or will m_store already have this flag set for this case?

@jakobbotsch I don't see diffs, but this PR already produces too many missing contexts 🙂
Presumably, this is not enough, because some GT_STORE_BLK have this flag without its layout being IsStackOnly. E.g. when we store a non-byreflike struct to byreflike-struct's field

Yeah, it makes sense to me to propagate the flags, but it also makes sense to me to set the flags anew here, since the decomposition is "losing" the information at this point. I will leave it up to you.

Added. Looks like MihuBot found a few diffs with it

EgorBo · 2025-01-23T12:33:49Z

@MihuBot

EgorBo · 2025-01-23T12:55:58Z

@MihuBot

EgorBo · 2025-01-23T14:36:20Z

PTAL @jakobbotsch Diffs: MihuBot/runtime-utils#932 (SPMI diffs report missing contexts: https://dev.azure.com/dnceng-public/public/_build/results?buildId=926588&view=ms.vss-build-web.run-extensions-tab)

There are a few regressions where WB is lighter than no-WB (e.g. https://www.diffchecker.com/Sz7TI32G/)
And there are some regressions where previous VN based code could detect more opportunities (mostly, mixed with inlining). I managed to create a minimal repro:

[InlineArray(4)]internalstructArgumentData<T>{privateT_arg0;}[StructLayout(LayoutKind.Sequential)]internalrefstructTest{[MethodImpl(MethodImplOptions.NoInlining)]publicTest(objecta){_args[1]=a;}internalArgumentData<object?>_args;}

here we end up with:

 [000011] -ACXG------ * STOREIND ref [000009] --C-------- +--* RET_EXPR byref (for [000007])
[000010] ----------- \--* LCL_VAR ref V01 arg1

and we can't extract class info easily (stind.ref opcode doesn't contain any class token nor we can extract it from ops).

I might look into this and more cases separately (overall it's a regression only for previously merged PR)

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

EgorBo · 2025-01-23T01:49:54Z

Remove potential UB from #111576 (move it to importer) + enable more cases where we eliminate write barriers, e.g. this:

publicrefstructTestS{publicMyStructs1;publicMyStructs2;publicvoidTest(){s1=s2;// no barrier needed, but we generate (two)}}publicstructMyStruct// Not byref-like{publicstringA;publicstringB;}

dotnet-policy-service · 2025-01-23T01:50:26Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

EgorBo · 2025-01-23T01:51:16Z

@MihuBot

EgorBo · 2025-01-23T02:35:40Z

Some regressions with barrier-free code e.g. https://www.diffchecker.com/Sz7TI32G/

(when we save a nonbyref-like struct with gc pointers to a field of byreflike struct)

jakobbotsch · 2025-01-23T10:11:05Z

+ flagsToPropagate |= GTF_IND_TGT_NOT_HEAP | GTF_IND_TGT_HEAP;
 addr = m_store->AsIndir()->Addr();
- indirFlags = m_store->gtFlags & GTF_IND_COPYABLE_FLAGS;
+ indirFlags = m_store->gtFlags & flagsToPropagate;


Is there any benefit to adding something like
if (m_store->AsBlk()->GetLayout()->IsStackOnly()) indirFlags |= GTF_IND_TGT_NOT_HEAP;
here (and in morphblock.cpp)? Or will m_store already have this flag set for this case?

@jakobbotsch I don't see diffs, but this PR already produces too many missing contexts 🙂
Presumably, this is not enough, because some GT_STORE_BLK have this flag without its layout being IsStackOnly. E.g. when we store a non-byreflike struct to byreflike-struct's field

Yeah, it makes sense to me to propagate the flags, but it also makes sense to me to set the flags anew here, since the decomposition is "losing" the information at this point. I will leave it up to you.

Added. Looks like MihuBot found a few diffs with it

EgorBo · 2025-01-23T12:33:49Z

@MihuBot

EgorBo · 2025-01-23T12:55:58Z

@MihuBot

EgorBo · 2025-01-23T14:36:20Z

PTAL @jakobbotsch Diffs: MihuBot/runtime-utils#932 (SPMI diffs report missing contexts: https://dev.azure.com/dnceng-public/public/_build/results?buildId=926588&view=ms.vss-build-web.run-extensions-tab)

There are a few regressions where WB is lighter than no-WB (e.g. https://www.diffchecker.com/Sz7TI32G/)
And there are some regressions where previous VN based code could detect more opportunities (mostly, mixed with inlining). I managed to create a minimal repro:

[InlineArray(4)]internalstructArgumentData<T>{privateT_arg0;}[StructLayout(LayoutKind.Sequential)]internalrefstructTest{[MethodImpl(MethodImplOptions.NoInlining)]publicTest(objecta){_args[1]=a;}internalArgumentData<object?>_args;}

here we end up with:

 [000011] -ACXG------ * STOREIND ref [000009] --C-------- +--* RET_EXPR byref (for [000007])
[000010] ----------- \--* LCL_VAR ref V01 arg1

and we can't extract class info easily (stind.ref opcode doesn't contain any class token nor we can extract it from ops).

I might look into this and more cases separately (overall it's a regression only for previously merged PR)

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

EgorBo · 2025-01-23T01:49:54Z

Remove potential UB from #111576 (move it to importer) + enable more cases where we eliminate write barriers, e.g. this:

publicrefstructTestS{publicMyStructs1;publicMyStructs2;publicvoidTest(){s1=s2;// no barrier needed, but we generate (two)}}publicstructMyStruct// Not byref-like{publicstringA;publicstringB;}

dotnet-policy-service · 2025-01-23T01:50:26Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

EgorBo · 2025-01-23T01:51:16Z

@MihuBot

EgorBo · 2025-01-23T02:35:40Z

Some regressions with barrier-free code e.g. https://www.diffchecker.com/Sz7TI32G/

(when we save a nonbyref-like struct with gc pointers to a field of byreflike struct)

jakobbotsch · 2025-01-23T10:11:05Z

+ flagsToPropagate |= GTF_IND_TGT_NOT_HEAP | GTF_IND_TGT_HEAP;
 addr = m_store->AsIndir()->Addr();
- indirFlags = m_store->gtFlags & GTF_IND_COPYABLE_FLAGS;
+ indirFlags = m_store->gtFlags & flagsToPropagate;


Is there any benefit to adding something like
if (m_store->AsBlk()->GetLayout()->IsStackOnly()) indirFlags |= GTF_IND_TGT_NOT_HEAP;
here (and in morphblock.cpp)? Or will m_store already have this flag set for this case?

@jakobbotsch I don't see diffs, but this PR already produces too many missing contexts 🙂
Presumably, this is not enough, because some GT_STORE_BLK have this flag without its layout being IsStackOnly. E.g. when we store a non-byreflike struct to byreflike-struct's field

Yeah, it makes sense to me to propagate the flags, but it also makes sense to me to set the flags anew here, since the decomposition is "losing" the information at this point. I will leave it up to you.

Added. Looks like MihuBot found a few diffs with it

EgorBo · 2025-01-23T12:33:49Z

@MihuBot

EgorBo · 2025-01-23T12:55:58Z

@MihuBot

EgorBo · 2025-01-23T14:36:20Z

PTAL @jakobbotsch Diffs: MihuBot/runtime-utils#932 (SPMI diffs report missing contexts: https://dev.azure.com/dnceng-public/public/_build/results?buildId=926588&view=ms.vss-build-web.run-extensions-tab)

There are a few regressions where WB is lighter than no-WB (e.g. https://www.diffchecker.com/Sz7TI32G/)
And there are some regressions where previous VN based code could detect more opportunities (mostly, mixed with inlining). I managed to create a minimal repro:

[InlineArray(4)]internalstructArgumentData<T>{privateT_arg0;}[StructLayout(LayoutKind.Sequential)]internalrefstructTest{[MethodImpl(MethodImplOptions.NoInlining)]publicTest(objecta){_args[1]=a;}internalArgumentData<object?>_args;}

here we end up with:

 [000011] -ACXG------ * STOREIND ref [000009] --C-------- +--* RET_EXPR byref (for [000007])
[000010] ----------- \--* LCL_VAR ref V01 arg1

and we can't extract class info easily (stind.ref opcode doesn't contain any class token nor we can extract it from ops).

I might look into this and more cases separately (overall it's a regression only for previously merged PR)

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

Revert potential UB due to aliasing + more WB removals
3787478

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2025

dotnet-policy-serviceBot assigned EgorBo Jan 23, 2025

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#929
Open

jakobbotsch reviewed Jan 23, 2025
View reviewed changes

Address feedback
43cead8

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#931
Open

fix regressions
0505951

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#932
Open

EgorBo marked this pull request as ready for review January 23, 2025 14:36

EgorBo requested a review from jakobbotsch January 23, 2025 14:38

jakobbotsch approved these changes Jan 23, 2025
View reviewed changes

EgorBo merged commit 0f0753d into dotnet:mainJan 26, 2025

EgorBo deleted the revert-aliased-ub branch January 26, 2025 14:47

github-actionsBot locked and limited conversation to collaborators Feb 26, 2025

Revert potential UB due to aliasing + more WB removals
3787478

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2025

dotnet-policy-serviceBot assigned EgorBo Jan 23, 2025

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#929
Open

jakobbotsch reviewed Jan 23, 2025
View reviewed changes

Address feedback
43cead8

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#931
Open

fix regressions
0505951

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#932
Open

EgorBo marked this pull request as ready for review January 23, 2025 14:36

EgorBo requested a review from jakobbotsch January 23, 2025 14:38

jakobbotsch approved these changes Jan 23, 2025
View reviewed changes

EgorBo merged commit 0f0753d into dotnet:mainJan 26, 2025

EgorBo deleted the revert-aliased-ub branch January 26, 2025 14:47

github-actionsBot locked and limited conversation to collaborators Feb 26, 2025

Revert potential UB due to aliasing + more WB removals
3787478

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2025

dotnet-policy-serviceBot assigned EgorBo Jan 23, 2025

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#929
Open

jakobbotsch reviewed Jan 23, 2025
View reviewed changes

Address feedback
43cead8

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#931
Open

fix regressions
0505951

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#932
Open

EgorBo marked this pull request as ready for review January 23, 2025 14:36

EgorBo requested a review from jakobbotsch January 23, 2025 14:38

jakobbotsch approved these changes Jan 23, 2025
View reviewed changes

EgorBo merged commit 0f0753d into dotnet:mainJan 26, 2025

EgorBo deleted the revert-aliased-ub branch January 26, 2025 14:47

github-actionsBot locked and limited conversation to collaborators Feb 26, 2025

Revert potential UB due to aliasing + more WB removals
3787478

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2025

dotnet-policy-serviceBot assigned EgorBo Jan 23, 2025

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#929
Open

jakobbotsch reviewed Jan 23, 2025
View reviewed changes

Address feedback
43cead8

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#931
Open

fix regressions
0505951

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#932
Open

EgorBo marked this pull request as ready for review January 23, 2025 14:36

EgorBo requested a review from jakobbotsch January 23, 2025 14:38

jakobbotsch approved these changes Jan 23, 2025
View reviewed changes

EgorBo merged commit 0f0753d into dotnet:mainJan 26, 2025

EgorBo deleted the revert-aliased-ub branch January 26, 2025 14:47

github-actionsBot locked and limited conversation to collaborators Feb 26, 2025

Revert potential UB due to aliasing + more WB removals
3787478

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2025

dotnet-policy-serviceBot assigned EgorBo Jan 23, 2025

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#929
Open

jakobbotsch reviewed Jan 23, 2025
View reviewed changes

Address feedback
43cead8

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#931
Open

fix regressions
0505951

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#932
Open

EgorBo marked this pull request as ready for review January 23, 2025 14:36

EgorBo requested a review from jakobbotsch January 23, 2025 14:38

jakobbotsch approved these changes Jan 23, 2025
View reviewed changes

EgorBo merged commit 0f0753d into dotnet:mainJan 26, 2025

EgorBo deleted the revert-aliased-ub branch January 26, 2025 14:47

github-actionsBot locked and limited conversation to collaborators Feb 26, 2025

Revert potential UB due to aliasing + more WB removals
3787478

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2025

dotnet-policy-serviceBot assigned EgorBo Jan 23, 2025

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#929
Open

jakobbotsch reviewed Jan 23, 2025
View reviewed changes

Address feedback
43cead8

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#931
Open

fix regressions
0505951

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#932
Open

EgorBo marked this pull request as ready for review January 23, 2025 14:36

EgorBo requested a review from jakobbotsch January 23, 2025 14:38

jakobbotsch approved these changes Jan 23, 2025
View reviewed changes

EgorBo merged commit 0f0753d into dotnet:mainJan 26, 2025

EgorBo deleted the revert-aliased-ub branch January 26, 2025 14:47

github-actionsBot locked and limited conversation to collaborators Feb 26, 2025

Revert potential UB due to aliasing + more WB removals
3787478

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2025

dotnet-policy-serviceBot assigned EgorBo Jan 23, 2025

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#929
Open

jakobbotsch reviewed Jan 23, 2025
View reviewed changes

Address feedback
43cead8

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#931
Open

fix regressions
0505951

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#932
Open

EgorBo marked this pull request as ready for review January 23, 2025 14:36

EgorBo requested a review from jakobbotsch January 23, 2025 14:38

jakobbotsch approved these changes Jan 23, 2025
View reviewed changes

EgorBo merged commit 0f0753d into dotnet:mainJan 26, 2025

EgorBo deleted the revert-aliased-ub branch January 26, 2025 14:47

github-actionsBot locked and limited conversation to collaborators Feb 26, 2025

Revert potential UB due to aliasing + more WB removals
3787478

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2025

dotnet-policy-serviceBot assigned EgorBo Jan 23, 2025

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#929
Open

jakobbotsch reviewed Jan 23, 2025
View reviewed changes

Address feedback
43cead8

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#931
Open

fix regressions
0505951

MihuBot mentioned this pull request Jan 23, 2025
[JitDiff X64] [EgorBo] Revert potential UB due to aliasing + more WB removals MihuBot/runtime-utils#932
Open

EgorBo marked this pull request as ready for review January 23, 2025 14:36

EgorBo requested a review from jakobbotsch January 23, 2025 14:38

jakobbotsch approved these changes Jan 23, 2025
View reviewed changes

EgorBo merged commit 0f0753d into dotnet:mainJan 26, 2025

EgorBo deleted the revert-aliased-ub branch January 26, 2025 14:47

github-actionsBot locked and limited conversation to collaborators Feb 26, 2025

Uh oh!

Conversation

EgorBo commented Jan 23, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EgorBo commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

EgorBo commented Jan 23, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EgorBo commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

EgorBo commented Jan 23, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025

Uh oh!

EgorBo commented Jan 23, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

EgorBo commented Jan 23, 2025•
edited
Loading

EgorBo commented Jan 23, 2025•
edited
Loading

EgorBo commented Jan 23, 2025•
edited
Loading

EgorBo commented Jan 23, 2025•
edited
Loading

EgorBo commented Jan 23, 2025•
edited
Loading

EgorBo commented Jan 23, 2025•
edited
Loading

EgorBo commented Jan 23, 2025•
edited
Loading