JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data by amanasifkhalid · Pull Request #111780 · dotnet/runtime

amanasifkhalid · 2025-01-24T05:19:39Z

Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

dotnet-policy-service · 2025-01-24T05:20:17Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

amanasifkhalid · 2025-01-24T05:23:00Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2025-01-24T05:23:13Z

Azure Pipelines successfully started running 2 pipeline(s).

amanasifkhalid · 2025-01-24T16:19:42Z

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs are nontrivial, since we're now maintaining flow changes into blocks from inlined methods.

AndyAyersMS · 2025-01-24T19:21:55Z

 {
- unprofiledBlocks++;
- continue;
+ if (checkProfileFlag && (block->bbPreds != nullptr))


Can you explain the exclusion for blocks with no preds?

For a few phases after fgAddInternal, merged return blocks are unreachable, and thus haven't had the BBF_PROF_WEIGHT flag propagated into them. I suppose I could've explicitly checked for that case here, or disabled the checks for those phases, though this should cover other cases where blocks have been created, but they don't have flow into them yet.
I guess we're losing some coverage by not catching method/region entry blocks that aren't flagged, though it seems very unlikely that these blocks would lack profile weights while their successors do have them(?)

Ah, ok... annoying but understandable that there are going to be some exclusions. We might be able to narrow the exclusions somewhat but I wouldn't bother.

amanasifkhalid · 2025-01-24T20:14:43Z

libraries-jitstress failures are #111777

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

amanasifkhalid · 2025-01-24T05:19:39Z

Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

dotnet-policy-service · 2025-01-24T05:20:17Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

amanasifkhalid · 2025-01-24T05:23:00Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2025-01-24T05:23:13Z

Azure Pipelines successfully started running 2 pipeline(s).

amanasifkhalid · 2025-01-24T16:19:42Z

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs are nontrivial, since we're now maintaining flow changes into blocks from inlined methods.

AndyAyersMS · 2025-01-24T19:21:55Z

 {
- unprofiledBlocks++;
- continue;
+ if (checkProfileFlag && (block->bbPreds != nullptr))


Can you explain the exclusion for blocks with no preds?

For a few phases after fgAddInternal, merged return blocks are unreachable, and thus haven't had the BBF_PROF_WEIGHT flag propagated into them. I suppose I could've explicitly checked for that case here, or disabled the checks for those phases, though this should cover other cases where blocks have been created, but they don't have flow into them yet.
I guess we're losing some coverage by not catching method/region entry blocks that aren't flagged, though it seems very unlikely that these blocks would lack profile weights while their successors do have them(?)

Ah, ok... annoying but understandable that there are going to be some exclusions. We might be able to narrow the exclusions somewhat but I wouldn't bother.

amanasifkhalid · 2025-01-24T20:14:43Z

libraries-jitstress failures are #111777

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

amanasifkhalid · 2025-01-24T05:19:39Z

Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

dotnet-policy-service · 2025-01-24T05:20:17Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

amanasifkhalid · 2025-01-24T05:23:00Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2025-01-24T05:23:13Z

Azure Pipelines successfully started running 2 pipeline(s).

amanasifkhalid · 2025-01-24T16:19:42Z

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs are nontrivial, since we're now maintaining flow changes into blocks from inlined methods.

AndyAyersMS · 2025-01-24T19:21:55Z

 {
- unprofiledBlocks++;
- continue;
+ if (checkProfileFlag && (block->bbPreds != nullptr))


Can you explain the exclusion for blocks with no preds?

For a few phases after fgAddInternal, merged return blocks are unreachable, and thus haven't had the BBF_PROF_WEIGHT flag propagated into them. I suppose I could've explicitly checked for that case here, or disabled the checks for those phases, though this should cover other cases where blocks have been created, but they don't have flow into them yet.
I guess we're losing some coverage by not catching method/region entry blocks that aren't flagged, though it seems very unlikely that these blocks would lack profile weights while their successors do have them(?)

Ah, ok... annoying but understandable that there are going to be some exclusions. We might be able to narrow the exclusions somewhat but I wouldn't bother.

amanasifkhalid · 2025-01-24T20:14:43Z

libraries-jitstress failures are #111777

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

amanasifkhalid · 2025-01-24T05:19:39Z

Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

dotnet-policy-service · 2025-01-24T05:20:17Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

amanasifkhalid · 2025-01-24T05:23:00Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2025-01-24T05:23:13Z

Azure Pipelines successfully started running 2 pipeline(s).

amanasifkhalid · 2025-01-24T16:19:42Z

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs are nontrivial, since we're now maintaining flow changes into blocks from inlined methods.

AndyAyersMS · 2025-01-24T19:21:55Z

 {
- unprofiledBlocks++;
- continue;
+ if (checkProfileFlag && (block->bbPreds != nullptr))


Can you explain the exclusion for blocks with no preds?

For a few phases after fgAddInternal, merged return blocks are unreachable, and thus haven't had the BBF_PROF_WEIGHT flag propagated into them. I suppose I could've explicitly checked for that case here, or disabled the checks for those phases, though this should cover other cases where blocks have been created, but they don't have flow into them yet.
I guess we're losing some coverage by not catching method/region entry blocks that aren't flagged, though it seems very unlikely that these blocks would lack profile weights while their successors do have them(?)

Ah, ok... annoying but understandable that there are going to be some exclusions. We might be able to narrow the exclusions somewhat but I wouldn't bother.

amanasifkhalid · 2025-01-24T20:14:43Z

libraries-jitstress failures are #111777

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

amanasifkhalid · 2025-01-24T05:19:39Z

Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

dotnet-policy-service · 2025-01-24T05:20:17Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

amanasifkhalid · 2025-01-24T05:23:00Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2025-01-24T05:23:13Z

Azure Pipelines successfully started running 2 pipeline(s).

amanasifkhalid · 2025-01-24T16:19:42Z

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs are nontrivial, since we're now maintaining flow changes into blocks from inlined methods.

AndyAyersMS · 2025-01-24T19:21:55Z

 {
- unprofiledBlocks++;
- continue;
+ if (checkProfileFlag && (block->bbPreds != nullptr))


Can you explain the exclusion for blocks with no preds?

For a few phases after fgAddInternal, merged return blocks are unreachable, and thus haven't had the BBF_PROF_WEIGHT flag propagated into them. I suppose I could've explicitly checked for that case here, or disabled the checks for those phases, though this should cover other cases where blocks have been created, but they don't have flow into them yet.
I guess we're losing some coverage by not catching method/region entry blocks that aren't flagged, though it seems very unlikely that these blocks would lack profile weights while their successors do have them(?)

Ah, ok... annoying but understandable that there are going to be some exclusions. We might be able to narrow the exclusions somewhat but I wouldn't bother.

amanasifkhalid · 2025-01-24T20:14:43Z

libraries-jitstress failures are #111777

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

amanasifkhalid · 2025-01-24T05:19:39Z

Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

dotnet-policy-service · 2025-01-24T05:20:17Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

amanasifkhalid · 2025-01-24T05:23:00Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2025-01-24T05:23:13Z

Azure Pipelines successfully started running 2 pipeline(s).

amanasifkhalid · 2025-01-24T16:19:42Z

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs are nontrivial, since we're now maintaining flow changes into blocks from inlined methods.

AndyAyersMS · 2025-01-24T19:21:55Z

 {
- unprofiledBlocks++;
- continue;
+ if (checkProfileFlag && (block->bbPreds != nullptr))


Can you explain the exclusion for blocks with no preds?

For a few phases after fgAddInternal, merged return blocks are unreachable, and thus haven't had the BBF_PROF_WEIGHT flag propagated into them. I suppose I could've explicitly checked for that case here, or disabled the checks for those phases, though this should cover other cases where blocks have been created, but they don't have flow into them yet.
I guess we're losing some coverage by not catching method/region entry blocks that aren't flagged, though it seems very unlikely that these blocks would lack profile weights while their successors do have them(?)

Ah, ok... annoying but understandable that there are going to be some exclusions. We might be able to narrow the exclusions somewhat but I wouldn't bother.

amanasifkhalid · 2025-01-24T20:14:43Z

libraries-jitstress failures are #111777

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

amanasifkhalid · 2025-01-24T05:19:39Z

Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

dotnet-policy-service · 2025-01-24T05:20:17Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

amanasifkhalid · 2025-01-24T05:23:00Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2025-01-24T05:23:13Z

Azure Pipelines successfully started running 2 pipeline(s).

amanasifkhalid · 2025-01-24T16:19:42Z

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs are nontrivial, since we're now maintaining flow changes into blocks from inlined methods.

AndyAyersMS · 2025-01-24T19:21:55Z

 {
- unprofiledBlocks++;
- continue;
+ if (checkProfileFlag && (block->bbPreds != nullptr))


Can you explain the exclusion for blocks with no preds?

For a few phases after fgAddInternal, merged return blocks are unreachable, and thus haven't had the BBF_PROF_WEIGHT flag propagated into them. I suppose I could've explicitly checked for that case here, or disabled the checks for those phases, though this should cover other cases where blocks have been created, but they don't have flow into them yet.
I guess we're losing some coverage by not catching method/region entry blocks that aren't flagged, though it seems very unlikely that these blocks would lack profile weights while their successors do have them(?)

Ah, ok... annoying but understandable that there are going to be some exclusions. We might be able to narrow the exclusions somewhat but I wouldn't bother.

amanasifkhalid · 2025-01-24T20:14:43Z

libraries-jitstress failures are #111777

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

amanasifkhalid · 2025-01-24T05:19:39Z

Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

dotnet-policy-service · 2025-01-24T05:20:17Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

amanasifkhalid · 2025-01-24T05:23:00Z

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

azure-pipelines · 2025-01-24T05:23:13Z

Azure Pipelines successfully started running 2 pipeline(s).

amanasifkhalid · 2025-01-24T16:19:42Z

cc @dotnet/jit-contrib, @AndyAyersMS PTAL. Diffs are nontrivial, since we're now maintaining flow changes into blocks from inlined methods.

AndyAyersMS · 2025-01-24T19:21:55Z

 {
- unprofiledBlocks++;
- continue;
+ if (checkProfileFlag && (block->bbPreds != nullptr))


Can you explain the exclusion for blocks with no preds?

For a few phases after fgAddInternal, merged return blocks are unreachable, and thus haven't had the BBF_PROF_WEIGHT flag propagated into them. I suppose I could've explicitly checked for that case here, or disabled the checks for those phases, though this should cover other cases where blocks have been created, but they don't have flow into them yet.
I guess we're losing some coverage by not catching method/region entry blocks that aren't flagged, though it seems very unlikely that these blocks would lack profile weights while their successors do have them(?)

Ah, ok... annoying but understandable that there are going to be some exclusions. We might be able to narrow the exclusions somewhat but I wouldn't bother.

amanasifkhalid · 2025-01-24T20:14:43Z

libraries-jitstress failures are #111777

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

Check BBF_PROF_WEIGHT flag is set
28a3268

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 24, 2025

dotnet-policy-serviceBot assigned amanasifkhalid Jan 24, 2025

AndyAyersMS reviewed Jan 24, 2025
View reviewed changes

AndyAyersMS approved these changes Jan 24, 2025
View reviewed changes

amanasifkhalid merged commit ccd8c3d into dotnet:mainJan 24, 2025

amanasifkhalid deleted the check-profile-flags branch January 24, 2025 20:15

LoopedBard3 mentioned this pull request Jan 28, 2025
[Perf] Windows/x64: 2 Regressions on 1/24/2025 9:18:01 PM +00:00 #111917
Closed

This was referenced Jan 30, 2025
[Perf] Linux/arm64: 8 Improvements on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49169
Closed
[Perf] Windows/arm64: 1 Improvement on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49165
Closed

github-actionsBot locked and limited conversation to collaborators Feb 24, 2025

Check BBF_PROF_WEIGHT flag is set
28a3268

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 24, 2025

dotnet-policy-serviceBot assigned amanasifkhalid Jan 24, 2025

AndyAyersMS reviewed Jan 24, 2025
View reviewed changes

AndyAyersMS approved these changes Jan 24, 2025
View reviewed changes

amanasifkhalid merged commit ccd8c3d into dotnet:mainJan 24, 2025

amanasifkhalid deleted the check-profile-flags branch January 24, 2025 20:15

LoopedBard3 mentioned this pull request Jan 28, 2025
[Perf] Windows/x64: 2 Regressions on 1/24/2025 9:18:01 PM +00:00 #111917
Closed

This was referenced Jan 30, 2025
[Perf] Linux/arm64: 8 Improvements on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49169
Closed
[Perf] Windows/arm64: 1 Improvement on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49165
Closed

github-actionsBot locked and limited conversation to collaborators Feb 24, 2025

Check BBF_PROF_WEIGHT flag is set
28a3268

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 24, 2025

dotnet-policy-serviceBot assigned amanasifkhalid Jan 24, 2025

AndyAyersMS reviewed Jan 24, 2025
View reviewed changes

AndyAyersMS approved these changes Jan 24, 2025
View reviewed changes

amanasifkhalid merged commit ccd8c3d into dotnet:mainJan 24, 2025

amanasifkhalid deleted the check-profile-flags branch January 24, 2025 20:15

LoopedBard3 mentioned this pull request Jan 28, 2025
[Perf] Windows/x64: 2 Regressions on 1/24/2025 9:18:01 PM +00:00 #111917
Closed

This was referenced Jan 30, 2025
[Perf] Linux/arm64: 8 Improvements on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49169
Closed
[Perf] Windows/arm64: 1 Improvement on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49165
Closed

github-actionsBot locked and limited conversation to collaborators Feb 24, 2025

Check BBF_PROF_WEIGHT flag is set
28a3268

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 24, 2025

dotnet-policy-serviceBot assigned amanasifkhalid Jan 24, 2025

AndyAyersMS reviewed Jan 24, 2025
View reviewed changes

AndyAyersMS approved these changes Jan 24, 2025
View reviewed changes

amanasifkhalid merged commit ccd8c3d into dotnet:mainJan 24, 2025

amanasifkhalid deleted the check-profile-flags branch January 24, 2025 20:15

LoopedBard3 mentioned this pull request Jan 28, 2025
[Perf] Windows/x64: 2 Regressions on 1/24/2025 9:18:01 PM +00:00 #111917
Closed

This was referenced Jan 30, 2025
[Perf] Linux/arm64: 8 Improvements on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49169
Closed
[Perf] Windows/arm64: 1 Improvement on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49165
Closed

github-actionsBot locked and limited conversation to collaborators Feb 24, 2025

Check BBF_PROF_WEIGHT flag is set
28a3268

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 24, 2025

dotnet-policy-serviceBot assigned amanasifkhalid Jan 24, 2025

AndyAyersMS reviewed Jan 24, 2025
View reviewed changes

AndyAyersMS approved these changes Jan 24, 2025
View reviewed changes

amanasifkhalid merged commit ccd8c3d into dotnet:mainJan 24, 2025

amanasifkhalid deleted the check-profile-flags branch January 24, 2025 20:15

LoopedBard3 mentioned this pull request Jan 28, 2025
[Perf] Windows/x64: 2 Regressions on 1/24/2025 9:18:01 PM +00:00 #111917
Closed

This was referenced Jan 30, 2025
[Perf] Linux/arm64: 8 Improvements on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49169
Closed
[Perf] Windows/arm64: 1 Improvement on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49165
Closed

github-actionsBot locked and limited conversation to collaborators Feb 24, 2025

Check BBF_PROF_WEIGHT flag is set
28a3268

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 24, 2025

dotnet-policy-serviceBot assigned amanasifkhalid Jan 24, 2025

AndyAyersMS reviewed Jan 24, 2025
View reviewed changes

AndyAyersMS approved these changes Jan 24, 2025
View reviewed changes

amanasifkhalid merged commit ccd8c3d into dotnet:mainJan 24, 2025

amanasifkhalid deleted the check-profile-flags branch January 24, 2025 20:15

LoopedBard3 mentioned this pull request Jan 28, 2025
[Perf] Windows/x64: 2 Regressions on 1/24/2025 9:18:01 PM +00:00 #111917
Closed

This was referenced Jan 30, 2025
[Perf] Linux/arm64: 8 Improvements on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49169
Closed
[Perf] Windows/arm64: 1 Improvement on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49165
Closed

github-actionsBot locked and limited conversation to collaborators Feb 24, 2025

Check BBF_PROF_WEIGHT flag is set
28a3268

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 24, 2025

dotnet-policy-serviceBot assigned amanasifkhalid Jan 24, 2025

AndyAyersMS reviewed Jan 24, 2025
View reviewed changes

AndyAyersMS approved these changes Jan 24, 2025
View reviewed changes

amanasifkhalid merged commit ccd8c3d into dotnet:mainJan 24, 2025

amanasifkhalid deleted the check-profile-flags branch January 24, 2025 20:15

LoopedBard3 mentioned this pull request Jan 28, 2025
[Perf] Windows/x64: 2 Regressions on 1/24/2025 9:18:01 PM +00:00 #111917
Closed

This was referenced Jan 30, 2025
[Perf] Linux/arm64: 8 Improvements on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49169
Closed
[Perf] Windows/arm64: 1 Improvement on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49165
Closed

github-actionsBot locked and limited conversation to collaborators Feb 24, 2025

Check BBF_PROF_WEIGHT flag is set
28a3268

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 24, 2025

dotnet-policy-serviceBot assigned amanasifkhalid Jan 24, 2025

AndyAyersMS reviewed Jan 24, 2025
View reviewed changes

AndyAyersMS approved these changes Jan 24, 2025
View reviewed changes

amanasifkhalid merged commit ccd8c3d into dotnet:mainJan 24, 2025

amanasifkhalid deleted the check-profile-flags branch January 24, 2025 20:15

LoopedBard3 mentioned this pull request Jan 28, 2025
[Perf] Windows/x64: 2 Regressions on 1/24/2025 9:18:01 PM +00:00 #111917
Closed

This was referenced Jan 30, 2025
[Perf] Linux/arm64: 8 Improvements on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49169
Closed
[Perf] Windows/arm64: 1 Improvement on 1/24/2025 8:24:52 PM +00:00 dotnet/perf-autofiling-issues#49165
Closed

github-actionsBot locked and limited conversation to collaborators Feb 24, 2025

Uh oh!

Conversation

amanasifkhalid commented Jan 24, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 24, 2025

Uh oh!

amanasifkhalid commented Jan 24, 2025

Uh oh!

azure-pipelinesBot commented Jan 24, 2025

Uh oh!

amanasifkhalid commented Jan 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

amanasifkhalid commented Jan 24, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 24, 2025

Uh oh!

amanasifkhalid commented Jan 24, 2025

Uh oh!

azure-pipelinesBot commented Jan 24, 2025

Uh oh!

amanasifkhalid commented Jan 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

amanasifkhalid commented Jan 24, 2025

Uh oh!

dotnet-policy-serviceBot commented Jan 24, 2025

Uh oh!

amanasifkhalid commented Jan 24, 2025

Uh oh!

azure-pipelinesBot commented Jan 24, 2025

Uh oh!

amanasifkhalid commented Jan 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amanasifkhalid commented Jan 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects